Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Revert "Ignore some kind of SSL errors when login to Grooveshark" 

This reverts commit 77b30bce5a.
This commit is contained in:
David Sansome 2014-05-03 16:23:56 +10:00
parent 77b30bce5a
commit 5592bcf145
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/internet/groovesharkservice.cpp
View File

@ -1668,29 +1668,9 @@ QNetworkReply* GroovesharkService::CreateRequest(const QString& method_name,
void GroovesharkService::RequestSslErrors(const QList<QSslError>& errors) {
QNetworkReply* reply = qobject_cast<QNetworkReply*>(sender());
bool ignore_ssl_errors = false;
for (const QSslError& error : errors) {
emit StreamError("SSL error occurred in Grooveshark request for " +
reply->url().toString() + ": " + error.errorString());
if (error.error() == QSslError::UnableToGetLocalIssuerCertificate) {
// We face this error on some installations (Linux Mint 15, Windows 8),
// probably because a root certificate is missing. However, I was unable
// to find which one was missing, and adding the full chain of
// certificate didn't help. As it means the root certificate wasn't
// found, but the certificate itself looks OK and the connection is
// secure anyway, I believe it's probably fine to ignore this particular
// error. Let's emit StreamError anyway, to not hide the error to the user
// completely.
// I might have used QNetworkReply::ignoreSslErrors(QList<QSslError>)
// instead, but it doesn't work as expected (see QTBUG-16770).
ignore_ssl_errors = true;
}
}
if (ignore_ssl_errors) {
qLog(Info) << "Ignoring SSL errors for this Grooveshark request";
reply->ignoreSslErrors();
}
}