Code review comments from r2370.

src/core/albumcoverloader.cpp

@@ -44,7 +44,7 @@ AlbumCoverLoader::AlbumCoverLoader(QObject* parent)
 }
 
 QString AlbumCoverLoader::ImageCacheDir() {
-  return Utilities::GetConfigPath(Utilities::ALBUM_COVERS);
+  return Utilities::GetConfigPath(Utilities::Path_AlbumCovers);
 }
 
 void AlbumCoverLoader::Clear() {

src/core/database.cpp

@@ -334,7 +334,7 @@ Database::Database(QObject* parent, const QString& database_name)
   }
 
   directory_ = QDir::toNativeSeparators(
-      Utilities::GetConfigPath(Utilities::ROOT));
+      Utilities::GetConfigPath(Utilities::Path_Root));
 
   attached_databases_["jamendo"] = AttachedDatabase(
         directory_ + "/jamendo.db", ":/schema/jamendo.sql");

src/core/mac_startup.mm

@@ -232,7 +232,9 @@ bool MigrateLegacyConfigFiles() {
   if (!QFile::exists(old_config_dir)) {
     return false;
   }
-  QString new_config_dir = Utilities::GetConfigPath(Utilities::ROOT);
+  QString new_config_dir = Utilities::GetConfigPath(Utilities::Path_Root);
+  // Create ~/Library/Application Support which should already exist anyway.
+  QDir::root().mkpath(GetApplicationSupportPath());
 
   qDebug() << "Move from:" << old_config_dir
            << "to:" << new_config_dir;

src/core/utilities.cpp

@@ -201,7 +201,7 @@ QString ColorToRgba(const QColor& c) {
 
 QString GetConfigPath(ConfigPath config) {
   switch (config) {
-    case ROOT: {
+    case Path_Root: {
       #ifdef Q_OS_DARWIN
         return mac::GetApplicationSupportPath() + "/" + QCoreApplication::organizationName();
       #else
@@ -210,14 +210,14 @@ QString GetConfigPath(ConfigPath config) {
     }
     break;
 
-    case ALBUM_COVERS:
+    case Path_AlbumCovers:
-      return GetConfigPath(ROOT) + "/albumcovers";
+      return GetConfigPath(Path_Root) + "/albumcovers";
 
-    case NETWORK_CACHE:
+    case Path_NetworkCache:
-      return GetConfigPath(ROOT) + "/networkcache";
+      return GetConfigPath(Path_Root) + "/networkcache";
 
-    case GSTREAMER_REGISTRY:
+    case Path_GstreamerRegistry:
-      return GetConfigPath(ROOT) +
+      return GetConfigPath(Path_Root) +
           QString("/gst-registry-%1-bin").arg(QCoreApplication::applicationVersion());
 
     default:

src/core/utilities.h

@@ -43,10 +43,10 @@ namespace Utilities {
 
 
   enum ConfigPath {
-    ROOT,
+    Path_Root,
-    ALBUM_COVERS,
+    Path_AlbumCovers,
-    NETWORK_CACHE,
+    Path_NetworkCache,
-    GSTREAMER_REGISTRY,
+    Path_GstreamerRegistry,
   };
   QString GetConfigPath(ConfigPath config);
 }

src/engines/gstengine.cpp

@@ -121,7 +121,7 @@ bool GstEngine::Init() {
 #endif
 
 #if defined(Q_OS_WIN32) || defined(Q_OS_DARWIN)
-  registry_filename = Utilities::GetConfigPath(Utilities::GSTREAMER_REGISTRY);
+  registry_filename = Utilities::GetConfigPath(Utilities::Path_GstreamerRegistry);
 #endif
 
   if (!scanner_path.isEmpty())

src/main.cpp

@@ -112,14 +112,15 @@ int main(int argc, char *argv[]) {
   if (mac::MigrateLegacyConfigFiles()) {
     QSqlDatabase db = QSqlDatabase::addDatabase("QSQLITE");
     db.setDatabaseName(Utilities::GetConfigPath(
-        Utilities::ROOT) + "/" + Database::kDatabaseFilename);
+        Utilities::Path_Root) + "/" + Database::kDatabaseFilename);
     db.open();
     QSqlQuery query(
         "UPDATE songs SET art_manual = replace("
         "art_manual, '.config', 'Library/Application Support') "
-        "WHERE art_manual LIKE '%.config%';", db);
+        "WHERE art_manual LIKE '%.config%'", db);
     query.exec();
     db.close();
+    QSqlDatabase::removeDatabase(db.connectionName());
   }
 #endif