Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Save the last used tab in the edit tag dialog in QSettings so it's shared between instances. Fixes issue 2260

This commit is contained in:
David Sansome 2011-11-27 20:36:54 +00:00
parent 8334484c1e
commit 0edb8abc7a
3 changed files with 34 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/translations/translations.pot
View File

@ -593,7 +593,7 @@ msgstr ""
msgid "An error occurred loading the iTunes database"
msgstr ""
#: ui/edittagdialog.cpp:610
#: ui/edittagdialog.cpp:611
#, qt-format
msgid "An error occurred writing metadata to '%1'"
msgstr ""
@ -637,7 +637,7 @@ msgstr ""
msgid "Are you sure you want to delete this playlist?"
msgstr ""
#: ui/edittagdialog.cpp:702
#: ui/edittagdialog.cpp:717
msgid "Are you sure you want to reset this song's statistics?"
msgstr ""
@ -1098,24 +1098,24 @@ msgstr ""
msgid "Cover Manager"
msgstr ""
#: ui/edittagdialog.cpp:404
#: ui/edittagdialog.cpp:405
msgid "Cover art from embedded image"
msgstr ""
#: ui/edittagdialog.cpp:406
#: ui/edittagdialog.cpp:407
#, qt-format
msgid "Cover art loaded automatically from %1"
msgstr ""
#: ui/edittagdialog.cpp:399
#: ui/edittagdialog.cpp:400
msgid "Cover art manually unset"
msgstr ""
#: ui/edittagdialog.cpp:408
#: ui/edittagdialog.cpp:409
msgid "Cover art not set"
msgstr ""
#: ui/edittagdialog.cpp:402
#: ui/edittagdialog.cpp:403
#, qt-format
msgid "Cover art set from %1"
msgstr ""
@ -1593,7 +1593,7 @@ msgid "Equivalent to --log-levels *:3"
msgstr ""
#: internet/magnatunedownloaddialog.cpp:225 library/libraryview.cpp:453
#: ui/edittagdialog.cpp:717 ui/mainwindow.cpp:1802 ui/mainwindow.cpp:1907
#: ui/edittagdialog.cpp:732 ui/mainwindow.cpp:1802 ui/mainwindow.cpp:1907
#: ui/mainwindow.cpp:2126
msgid "Error"
msgstr ""
@ -2370,7 +2370,7 @@ msgstr ""
msgid "Loading stream"
msgstr ""
#: playlist/songloaderinserter.cpp:79 ui/edittagdialog.cpp:209
#: playlist/songloaderinserter.cpp:79 ui/edittagdialog.cpp:210
msgid "Loading tracks"
msgstr ""
@ -2630,7 +2630,7 @@ msgstr ""
msgid "Network Proxy"
msgstr ""
#: playlist/playlistdelegates.cpp:296 ui/edittagdialog.cpp:443
#: playlist/playlistdelegates.cpp:296 ui/edittagdialog.cpp:444
msgid "Never"
msgstr ""
@ -2663,7 +2663,7 @@ msgstr ""
msgid "Newest tracks"
msgstr ""
#: ui/edittagdialog.cpp:157 ui/trackselectiondialog.cpp:47
#: ui/edittagdialog.cpp:158 ui/trackselectiondialog.cpp:47
msgid "Next"
msgstr ""
@ -3061,7 +3061,7 @@ msgstr ""
msgid "Preview"
msgstr ""
#: ui/edittagdialog.cpp:156 ui/trackselectiondialog.cpp:46
#: ui/edittagdialog.cpp:157 ui/trackselectiondialog.cpp:46
msgid "Previous"
msgstr ""
@ -3289,7 +3289,7 @@ msgstr ""
msgid "Reset"
msgstr ""
#: ui/edittagdialog.cpp:701 ../bin/src/ui_edittagdialog.h:635
#: ui/edittagdialog.cpp:716 ../bin/src/ui_edittagdialog.h:635
msgid "Reset play counts"
msgstr ""
@ -3361,7 +3361,7 @@ msgstr ""
msgid "Save this stream in the Internet tab"
msgstr ""
#: ui/edittagdialog.cpp:617 ui/trackselectiondialog.cpp:249
#: ui/edittagdialog.cpp:618 ui/trackselectiondialog.cpp:249
msgid "Saving tracks"
msgstr ""
@ -4502,7 +4502,7 @@ msgstr ""
msgid "Your Magnatune credentials were incorrect"
msgstr ""
#: ui/edittagdialog.cpp:717 ui/mainwindow.cpp:2126
#: ui/edittagdialog.cpp:732 ui/mainwindow.cpp:2126
msgid ""
"Your gstreamer installation is missing the 'ofa' plugin. This is required "
"for automatic tag fetching. Try installing the 'gstreamer-plugins-bad' "
@ -4568,7 +4568,7 @@ msgstr ""
msgid "biggest first"
msgstr ""
#: playlist/playlistview.cpp:161 ui/edittagdialog.cpp:419
#: playlist/playlistview.cpp:161 ui/edittagdialog.cpp:420
msgid "bpm"
msgstr ""
@ -4611,7 +4611,7 @@ msgstr ""
msgid "in the last"
msgstr ""
#: playlist/playlistview.cpp:163 ui/edittagdialog.cpp:421
#: playlist/playlistview.cpp:163 ui/edittagdialog.cpp:422
#: internet/spotifysettingspage.cpp:60 internet/spotifysettingspage.cpp:61
#: internet/spotifysettingspage.cpp:62
msgid "kbps"

15
src/ui/edittagdialog.cpp
View File

@ -43,6 +43,7 @@
#include <QtDebug>
const char* EditTagDialog::kHintText = QT_TR_NOOP("(different across multiple songs)");
const char* EditTagDialog::kSettingsGroup = "EditTagDialog";
EditTagDialog::EditTagDialog(CoverProviders* cover_providers, QWidget* parent)
: QDialog(parent),
@ -675,9 +676,23 @@ void EditTagDialog::showEvent(QShowEvent* e) {
// Set the dialog's height to the smallest possible
resize(width(), sizeHint().height());
// Restore the tab that was current last time.
QSettings s;
s.beginGroup(kSettingsGroup);
ui_->tab_widget->setCurrentIndex(s.value("current_tab").toInt());
QDialog::showEvent(e);
}
void EditTagDialog::hideEvent(QHideEvent* e) {
// Save the current tab
QSettings s;
s.beginGroup(kSettingsGroup);
s.setValue("current_tab", ui_->tab_widget->currentIndex());
QDialog::hideEvent(e);
}
void EditTagDialog::SongRated(float rating) {
const QModelIndexList sel = ui_->song_list->selectionModel()->selectedIndexes();
if (sel.isEmpty())

2
src/ui/edittagdialog.h
View File

@ -48,6 +48,7 @@ public:
~EditTagDialog();
static const char* kHintText;
static const char* kSettingsGroup;
void SetSongs(const SongList& songs, const PlaylistItemList& items = PlaylistItemList());
void SetTagCompleter(LibraryBackend* backend);
@ -62,6 +63,7 @@ signals:
protected:
bool eventFilter(QObject* o, QEvent* e);
void showEvent(QShowEvent*);
void hideEvent(QHideEvent*);
private slots:
void SetSongsFinished();