Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
mirror of https://github.com/clementine-player/Clementine synced 2025-01-31 11:35:24 +01:00
Code Issues Releases Wiki Activity

Enable warnings for non virtual destructors.

Browse Source
This commit is contained in:
John Maguire 2010-02-23 12:26:29 +00:00
parent 93771c8238
commit 09eabcc90e
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backgroundthread.h
View File

@ -10,6 +10,7 @@ class BackgroundThreadBase : public QThread {
Q_OBJECT Q_OBJECT
public: public:
BackgroundThreadBase(QObject* parent = 0) : QThread(parent) {} BackgroundThreadBase(QObject* parent = 0) : QThread(parent) {}
virtual ~BackgroundThreadBase() {}
signals: signals:
void Initialised(); void Initialised();
}; };
@ -18,7 +19,7 @@ template <typename T>
class BackgroundThread : public BackgroundThreadBase { class BackgroundThread : public BackgroundThreadBase {
public: public:
BackgroundThread(QObject* parent = 0); BackgroundThread(QObject* parent = 0);
~BackgroundThread(); virtual ~BackgroundThread();
boost::shared_ptr<T> Worker() const { return worker_; } boost::shared_ptr<T> Worker() const { return worker_; }

3
src/src.pro
View File

@ -137,6 +137,9 @@ win32|fedora-win32-cross {
# Last.fm # Last.fm
LIBS += -llastfm LIBS += -llastfm
# Enable a bunch of warnings
QMAKE_CXXFLAGS += -Wall -Werror=non-virtual-dtor -Woverloaded-virtual
# Other platform specific libraries # Other platform specific libraries
!win32:!fedora-win32-cross { !win32:!fedora-win32-cross {
mac { mac {