Commit Graph

148 Commits

Author SHA1 Message Date
Brent Simmons fb51185c05 Remove references to isFeedProvider. 2023-06-25 16:15:21 -07:00
Brent Simmons 06910b1e58 Avoid force-unwrapping, which was causing a crash. Add an `assertionFailure` so we can catch this issue in the act — we need to know why an item would not be a Node. Fix https://github.com/Ranchero-Software/NetNewsWire/issues/3824 2023-01-22 14:57:56 -08:00
Maurice Parker f9af3c786b Merge branch 'ios-candidate' 2021-05-25 20:12:50 -05:00
Brent Simmons 9d2c8f000f Create and use IconImageCache. It centralizes and de-dupes logic for getting feed/article images, and it caches the results, which helps performance. 2021-05-08 12:42:44 -07:00
Stuart Breckenridge 5af2643479
standardised naming 2021-04-19 11:21:00 +08:00
Stuart Breckenridge d4130e7c65
Corrects naming convention
[iOS]
Twitter: Notify about new tweets
Reddit: Notify about new posts
Default: Notify about new articles
+ Fixes alignment issues in the inspector view

[macOS]
Twitter: Show notifications for new tweets
Reddit: Show notifications for new posts
Default: Show notifications for new articles
2021-04-19 11:10:57 +08:00
Stuart Breckenridge 4e517a6db4
Disable Reader View
This commit:
- adds a `isFeedProvider: Bool` property to `WebFeed`
- if `isFeedProvider` is `true`, the article extractor is disabled on the inspector, hidden from the context menu, and the toolbar button is disabled. Additionally, if `isFeedProvider` is `true`, `isArticleExtractorAlwaysOn` returns `false` and cannot be set to `true`.
2021-04-09 07:47:14 +08:00
Maurice Parker ab5421f533 Merge branch 'mac-release' into main 2021-03-27 17:21:49 -05:00
Maurice Parker 52f11ff538 Add validateFeed parameter to createWebFeed 2021-03-15 18:01:12 -05:00
Maurice Parker f1e4d70481 Simplify the folder copy logic 2021-03-15 17:47:53 -05:00
Maurice Parker d57cb7b21f Delete obsolete code 2021-03-15 17:35:23 -05:00
Maurice Parker 7e4e7091e2 Delete obsolete code 2021-03-15 17:33:12 -05:00
Maurice Parker bf76cb810d Change to always copy between accounts. Fixes #2871 2021-03-11 19:43:05 -06:00
Maurice Parker 74298e7cde Add hidden GruberFeedDoubleClickMarkAsRead preference 2021-02-26 17:38:26 -06:00
Maurice Parker 1f159a5bff Change drag-n-drop behavior to default to copy when dragging between accounts 2021-02-22 18:50:29 -06:00
Maurice Parker afd9a47abd Change so that we only show one error dialog when folder moves/copies can't find one or more feeds. 2021-02-22 17:50:30 -06:00
Maurice Parker 931b1f9afd Show Folder as it is created to give better visual feedback that a folder copy was successful. Fixes #2815 2021-02-22 17:14:41 -06:00
Maurice Parker 731d0d0d88 Show Folder as it is created to give better visual feedback that a folder copy was successful. Fixes #2815 2021-02-16 14:24:21 -06:00
Stuart Breckenridge 1e578828e9
: class chnaged to : AnyObject for protocols 2021-02-06 07:06:45 +08:00
Stuart Breckenridge e88327be78
You can’t toggle an optional Bool 2021-02-02 13:25:06 +08:00
Stuart Breckenridge aa0a5d2269
Checks for notification permissions
If notifications are authorised, the toggle will work.

Otherwise, an alert is shown giving the user required information to enable notifications.
2021-02-02 11:54:47 +08:00
Stuart Breckenridge 62ed7492eb
Adds checkmarks
Also adds notification to keep Inspector in sync.
2021-02-02 10:26:34 +08:00
Stuart Breckenridge 6b1ad170ca
Adds sidebar toggles for notifications/reader 2021-02-02 08:16:45 +08:00
Maurice Parker 73ba42fa1a Use the correct font for the preferred sidebar icon size. Fixes #2761 2021-01-24 10:34:27 -06:00
Maurice Parker f8ba630cf1 Delete dead code 2021-01-22 17:04:16 -06:00
Maurice Parker ef18600acc Separate background suppression from symbol processing. Fixes #2646 & Fixes #2635 2020-12-06 14:25:22 -06:00
Maurice Parker a0aad21385 Rebuild Sidebar outline view to try to fix Catalina problems 2020-11-20 15:02:23 -06:00
Maurice Parker f7574dc633 Tweak the sidebar image sizes so that they match the system apps as it looks like the HIG has the wrong values in it for sidebar image sizes 2020-11-15 15:18:33 -06:00
Daniel Jalkut 1ced4448ea Support a new secret user default JalkutRespectFolderExpansionOnNextUnread, and revise the "next unread" strategy so that whether the search for a next unread wraps around to the top or not is parameterized. 2020-11-01 17:33:48 -05:00
Maurice Parker 2395c0c7df Correct validation so that we can still move feeds in Reader API accounts 2020-10-31 17:37:25 -05:00
Maurice Parker 5fdbd4b9d0 Fixed misleading variable name 2020-10-31 17:31:48 -05:00
Maurice Parker cbb481c3f7 Don't allow a feed to be in more than one folder for Reader API accounts 2020-10-31 17:26:43 -05:00
Maurice Parker d735ae91dc Add a confirmation alert for the delete context menu so that it matches other delete functionality. 2020-10-23 16:54:20 -05:00
Maurice Parker 46743a0f49 Simplified the delete titles. 2020-09-28 20:28:53 -05:00
Maurice Parker aaff359609 Provide verification dialog for deletes. Issue #1789 2020-09-28 19:50:31 -05:00
Maurice Parker a04c60caea Fix icon color changing bug. 2020-09-02 13:38:02 -05:00
Maurice Parker b0e7ae0324 Merge branch 'mac-candidate' into main 2020-08-19 21:03:55 -05:00
Maurice Parker 72bd722def Remove sidebar filter button. Issue #2346 2020-08-17 17:50:50 -05:00
Maurice Parker 73b120a91c Change any glyphs in the sidebar to white when selected to make them visible regardless of use control color selection 2020-08-10 13:53:21 -05:00
Maurice Parker c652486663 Change all 10.16 version checks to be 11.0 2020-08-10 11:43:18 -05:00
Maurice Parker c5ec93e8b5 Respect Sidebar size preferences from General preferences Issue #2321 2020-08-08 17:07:21 -05:00
Maurice Parker 314d425c49 Use high resolution Feed icons in the Sidebar #2320 2020-08-07 19:44:12 -05:00
Nate Weaver 1f9dfb80e2 Changes for IDNA support 2020-07-29 15:42:11 -05:00
Maurice Parker 4af8e0ab1c Select next item in Sidebar on delete. Issue #2114 2020-07-10 16:49:10 -05:00
Stuart Breckenridge a57f98e4e7 NetNewsWire-Mac AppDefaults is now a singleton 2020-07-02 11:17:38 +08:00
Rizwan Mohamed Ibrahim d671029828
refactor open in app browser for mac and iOS 2020-05-29 19:26:20 +05:30
Nate Weaver 1e1fc06e7b Clean up shift-key checking and add it to more places 2020-05-20 19:59:21 -05:00
Maurice Parker b6a0057439 Fix bug where Unread feed could get filtered even while selected. 2020-05-02 16:44:24 -05:00
Maurice Parker 0ff0c87932 Add the new twitter add dialog 2020-04-21 21:25:45 -05:00
Maurice Parker 40ea5243c6 Removed notification we no longer needed to use to refresh the Feeds and Sidebar. 2020-04-01 20:31:32 -05:00