Commit Graph

4664 Commits

Author SHA1 Message Date
Flowinho
ee86b1a148 Apply background if feed-icon is bright 2020-03-13 11:54:31 +01:00
Flowinho
d282181269 Add isBright function to Shared Logic 2020-03-13 11:43:17 +01:00
Flowinho
0a3713e078 Align feedname and date correctly if there is no title or summary 2020-03-12 22:57:30 +01:00
Flowinho
da64f65c7b Fixes close button icon distortion
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.

- Set content-mode of the buttons imageview to scaleAspectFit.
2020-03-12 21:54:50 +01:00
Flowinho
feacda1c3b HOTFIX silly me 2020-03-12 21:33:02 +01:00
Flowinho
91247b7f16 Adding dynamic width algorithm to the titleLabel
This commit adds multiple functionalities at once:

- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).

The title label now resizes itself depending on the devices it’s displazed on.

- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.

The numbers are derived from my personal preference when implementing it.
2020-03-12 21:23:57 +01:00
Flowinho
97c79202fc Added missing constraints to the UISwitch elements 2020-03-12 17:56:43 +01:00
Maurice Parker
22b9e7b54b Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883 2020-03-11 19:45:45 -05:00
Maurice Parker
27b1443def Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881 2020-03-11 18:17:09 -06:00
Maurice Parker
76d5f4a073 Remove flush and restore of web view queues. Issue #1882 2020-03-11 17:02:16 -06:00
Maurice Parker
38981d01bd Don't remove items from Feeds list when batch update is performed. Issue #1879 2020-03-11 15:19:55 -06:00
Maurice Parker
9007ed4b06 Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834, #1856, and #1845 2020-03-11 14:47:00 -06:00
Maurice Parker
326322ead6
Merge pull request #1876 from flowinho/ios-candidate
iOS: Account Login Field should switch first responder on return #1870
2020-03-11 11:23:48 -06:00
Flowinho
b178fe93af Call action on return if password was added
This is an obvious change.
2020-03-11 14:02:06 +01:00
Flowinho
66fae15f64 Remove redundant code to lessen LOC
- Less code - less bugs.
- Also resign the first responder when the user presses the action button
2020-03-11 13:43:02 +01:00
Flowinho
386efd632b Changing UIContentType from username to email adress
Add responder switch to streamline login flow

This change achieves two things:

- When the user presses Return and the email field is selected, the cursor now switches to the password field (as expected by the user).
- It enables iOS to pick up login and password field and enables password autofill.
2020-03-11 13:43:02 +01:00
Brent Simmons
dc99d5b071 Bump version to 39. 2020-03-04 13:27:29 -08:00
Maurice Parker
7d8feba24b Remove file coordinator usage from account files. Issue #1821 2020-03-03 11:39:04 -08:00
Maurice Parker
3a0f57e4da Fixed toggle color. Issue #1838 2020-02-29 09:09:53 -08:00
Maurice Parker
cd5e491f00 Fix issue where full screen wouldn't come back after being engaged and moving to the timeline. (Regression) 2020-02-26 16:02:36 -08:00
Maurice Parker
9e3f061fcb Dispatch the page controller setting since it is unreliable. Issue #1756 & Issue #1808 2020-02-25 18:06:02 -08:00
Maurice Parker
5a5abb0b87 Ensure that the dom is fully loaded on *all* web views before being made available to process JavaScript. Issue #1756 & Issue #1808 2020-02-25 15:10:51 -08:00
Maurice Parker
a4bbf65944 Coalesce unread count backing store rebuilds to prevent feeds list flickering while syncing and the feeds filter is engaged. (Regression) 2020-02-25 10:42:56 -08:00
Maurice Parker
d222a9f617 Change to not force unwrap the descriptor. Issue #1818 2020-02-24 08:42:19 -08:00
Maurice Parker
23b8af4634 Don't end the operation until the deselection animation has completed. (Regression) 2020-02-24 08:07:14 -08:00
Maurice Parker
afadadff69 Restore timeline selection when coming back into foreground. (Regression) 2020-02-23 17:12:02 -08:00
Maurice Parker
48e856fc04 Serialize access to the UITableView for scrolling and diffable datasource updates. Issue #1806 2020-02-23 10:57:20 -08:00
Brent Simmons
fd0363aad2 Turn double space into single space after sentence in Settings. 2020-02-18 23:14:27 -08:00
Brent Simmons
b604fdaa86 Bump version to 38. 2020-02-18 23:07:49 -08:00
Maurice Parker
3e93877362 Add instructions for full screen and fix some dynamic type problems. Issue #1799 2020-02-18 17:30:25 -08:00
Maurice Parker
28c2598cf6 Exempt the current article from the timeline read filter. Issue #1798 2020-02-18 14:14:18 -08:00
Maurice Parker
0e72811429 Implement mark as unread window for accounts that need it. Issue #1407 2020-02-18 13:49:29 -08:00
Maurice Parker
8acd6a039a Change event used to stop web view activity (video and image zooming) so that it doesn't interfere with the image zooming transition. 2020-02-18 11:08:38 -08:00
Maurice Parker
e3b32847f9 Stop image zooming on swipes and video playback on button presses. Issue #1801 2020-02-18 09:49:54 -08:00
Maurice Parker
f79eaf7c19 Avoid redundant shadow table rebuilds when auto-expanding containers. 2020-02-18 09:30:58 -08:00
Maurice Parker
f1de105a65 Updated to latest RSCore 2020-02-18 09:20:38 -08:00
Brent Simmons
e22489ce40
Merge pull request #1795 from Wevah/ios-candidate
Fix sites being added to the no-favicons cache if the homepage fails to load
2020-02-17 17:59:37 -08:00
Maurice Parker
03c1ed2625 Make handling of programmatic feed selection when filtered or collapsed more consistent. Issues #1788 and #1792 2020-02-17 17:40:40 -08:00
Nate Weaver
aad1fc4a0c Call the completion handler with nil if faviconURLs is nil
Fixes #1791.
2020-02-15 08:53:56 -06:00
Nate Weaver
b3f736f899 Add a clarification comment 2020-02-15 08:22:59 -06:00
Nate Weaver
ee48f4baba Remove redundant nil check for homePageURL 2020-02-15 08:22:51 -06:00
Maurice Parker
6c5f0cc8b6 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-13 17:36:25 -08:00
Maurice Parker
58b8a9adb0 Render article on to be recycled web view and delay new web view showing to 0.3. Issue #1780 2020-02-13 17:35:34 -08:00
Maurice Parker
d01e9cef42 Remove unintended web view load when changing the article. 2020-02-13 16:08:44 -08:00
Brent Simmons
4c92e3f8ac Bump version to 37. 2020-02-12 21:52:54 -08:00
Maurice Parker
2ae021960b Move account files to the documents directory and out of the shared container. Issue #1784 2020-02-12 16:21:48 -08:00
Maurice Parker
31b72221f8 Rollback delay that was causing blank articles to be shown. Issue #1780 2020-02-09 11:57:07 -08:00
Brent Simmons
eb770f4494 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-08 17:22:03 -08:00
Brent Simmons
cac67f8ac4 Use percent-encoding — via URLComponents — on the articleID in the nnwImageIcon URL scheme. 2020-02-08 17:21:55 -08:00
Maurice Parker
eed12e5347 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-08 16:56:06 -08:00