Commit Graph

1385 Commits

Author SHA1 Message Date
Maurice Parker 27b1443def Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881 2020-03-11 18:17:09 -06:00
Maurice Parker 76d5f4a073 Remove flush and restore of web view queues. Issue #1882 2020-03-11 17:02:16 -06:00
Maurice Parker 38981d01bd Don't remove items from Feeds list when batch update is performed. Issue #1879 2020-03-11 15:19:55 -06:00
Maurice Parker 9007ed4b06 Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834, #1856, and #1845 2020-03-11 14:47:00 -06:00
Flowinho b178fe93af Call action on return if password was added
This is an obvious change.
2020-03-11 14:02:06 +01:00
Flowinho 66fae15f64 Remove redundant code to lessen LOC
- Less code - less bugs.
- Also resign the first responder when the user presses the action button
2020-03-11 13:43:02 +01:00
Flowinho 386efd632b Changing UIContentType from username to email adress
Add responder switch to streamline login flow

This change achieves two things:

- When the user presses Return and the email field is selected, the cursor now switches to the password field (as expected by the user).
- It enables iOS to pick up login and password field and enables password autofill.
2020-03-11 13:43:02 +01:00
Michele Volpato ee0f982e93 Remove unneeded whitespaces 2020-03-02 22:33:59 +01:00
Michele Volpato 115405f1f0 Fix progress bar width, add contraints to progress label 2020-03-02 22:25:57 +01:00
Maurice Parker 3a0f57e4da Fixed toggle color. Issue #1838 2020-02-29 09:09:53 -08:00
Maurice Parker cd5e491f00 Fix issue where full screen wouldn't come back after being engaged and moving to the timeline. (Regression) 2020-02-26 16:02:36 -08:00
Maurice Parker 9e3f061fcb Dispatch the page controller setting since it is unreliable. Issue #1756 & Issue #1808 2020-02-25 18:06:02 -08:00
Maurice Parker 5a5abb0b87 Ensure that the dom is fully loaded on *all* web views before being made available to process JavaScript. Issue #1756 & Issue #1808 2020-02-25 15:10:51 -08:00
Maurice Parker a4bbf65944 Coalesce unread count backing store rebuilds to prevent feeds list flickering while syncing and the feeds filter is engaged. (Regression) 2020-02-25 10:42:56 -08:00
Maurice Parker d222a9f617 Change to not force unwrap the descriptor. Issue #1818 2020-02-24 08:42:19 -08:00
Maurice Parker 23b8af4634 Don't end the operation until the deselection animation has completed. (Regression) 2020-02-24 08:07:14 -08:00
Maurice Parker afadadff69 Restore timeline selection when coming back into foreground. (Regression) 2020-02-23 17:12:02 -08:00
Maurice Parker 48e856fc04 Serialize access to the UITableView for scrolling and diffable datasource updates. Issue #1806 2020-02-23 10:57:20 -08:00
Brent Simmons fd0363aad2 Turn double space into single space after sentence in Settings. 2020-02-18 23:14:27 -08:00
Maurice Parker 3e93877362 Add instructions for full screen and fix some dynamic type problems. Issue #1799 2020-02-18 17:30:25 -08:00
Maurice Parker 28c2598cf6 Exempt the current article from the timeline read filter. Issue #1798 2020-02-18 14:14:18 -08:00
Maurice Parker 0e72811429 Implement mark as unread window for accounts that need it. Issue #1407 2020-02-18 13:49:29 -08:00
Maurice Parker 8acd6a039a Change event used to stop web view activity (video and image zooming) so that it doesn't interfere with the image zooming transition. 2020-02-18 11:08:38 -08:00
Maurice Parker e3b32847f9 Stop image zooming on swipes and video playback on button presses. Issue #1801 2020-02-18 09:49:54 -08:00
Maurice Parker f79eaf7c19 Avoid redundant shadow table rebuilds when auto-expanding containers. 2020-02-18 09:30:58 -08:00
Maurice Parker 03c1ed2625 Make handling of programmatic feed selection when filtered or collapsed more consistent. Issues #1788 and #1792 2020-02-17 17:40:40 -08:00
Maurice Parker 58b8a9adb0 Render article on to be recycled web view and delay new web view showing to 0.3. Issue #1780 2020-02-13 17:35:34 -08:00
Maurice Parker d01e9cef42 Remove unintended web view load when changing the article. 2020-02-13 16:08:44 -08:00
Maurice Parker 2ae021960b Move account files to the documents directory and out of the shared container. Issue #1784 2020-02-12 16:21:48 -08:00
Maurice Parker 31b72221f8 Rollback delay that was causing blank articles to be shown. Issue #1780 2020-02-09 11:57:07 -08:00
Brent Simmons eb770f4494 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-08 17:22:03 -08:00
Brent Simmons cac67f8ac4 Use percent-encoding — via URLComponents — on the articleID in the nnwImageIcon URL scheme. 2020-02-08 17:21:55 -08:00
Maurice Parker eed12e5347 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-08 16:56:06 -08:00
Maurice Parker bdd79aead5 Delay swapping out the web view until the new web view has had a chance to render. Issue #1780 2020-02-08 16:55:16 -08:00
Brent Simmons fe6fbd31a8 Edit the about NetNewsWire text. Add credit for Wevah; add thanks to Feedbin for Reader view hosting. 2020-02-08 16:14:45 -08:00
Maurice Parker e5a9205747 Always reload the web view when the showing state changes. Issue #1775 2020-02-06 11:41:06 -08:00
Maurice Parker 268c20da56 Set all the web view delegates to nil when recycling to prevent unintended behaviors. Issue #1777 2020-02-06 10:36:39 -08:00
Mihael Cholakov 936596f5d0 Shifting sections when one should be hidden 2020-02-06 15:27:49 +02:00
Brent Simmons d40eaed1f5 Begin moving the MainThreadOperationQueue from Account to ArticlesDatabase. 2020-02-05 21:23:23 -08:00
Maurice Parker d1f1ca22b6 Add a hack to prevent horizontal scrolling on iPad. Issue #1714 2020-02-05 13:46:59 -08:00
Maurice Parker dfd6be5fa6 Flush are rebuild web view queue when suspending and restoring the app. Issue #1563 2020-02-04 16:00:26 -08:00
Maurice Parker 8ed9958631 Change full article setting to enable or disable the feature. Issue #1773 2020-02-04 11:24:06 -08:00
Maurice Parker 76bad13ae1 Rebuild the backing stores to except spotlight search result restoration. Issue #1759 2020-02-04 11:00:55 -08:00
Maurice Parker e47e2d4ea0 Fetch any potential new articles and merge them when returning to the foreground. Issue #1761 & #1754 2020-02-03 14:05:22 -08:00
Maurice Parker 336c980243
Merge pull request #1769 from danmorrison/ios-candidate
Fix Feed Select Folder Table View Cell horizontal alignment
2020-02-03 10:11:00 -08:00
Nate Weaver ba6315fa07 Set lastImageCacheFlushDate on launch in CacheCleaner instead of registerDefaults()
So it's actually persisted to disk.
2020-02-02 17:55:51 -06:00
Dan Morrison da501cb39b Fix horizontal alignment #1768 2020-02-03 09:43:05 +11:00
Brent Simmons 782dfd688e
Merge pull request #1767 from hartlco/1766-Go-to-feed-visible-when-you-are-already-inside-the-feed
Don’t show “Go to feed” action if already inside feed
2020-02-02 12:51:21 -08:00
Martin Hartl 83241cc329 Don’t show “Go to feed” action if already inside feed 2020-02-02 21:44:54 +01:00
Brent Simmons 4fe2a3134f Suspend the databases sooner when suspending the application. 2020-02-02 12:11:39 -08:00
Maurice Parker 596575c0e8 Delay making the initial web view available to give it some time to load the DOM. Issue #1756 2020-02-01 16:41:10 -08:00
Maurice Parker fcd7b88a62 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-01 16:38:26 -08:00
Brent Simmons 5d1ec3bff2
Merge pull request #1763 from Wevah/vertical-scroll-fix
Don't block vertical pan gestures
2020-02-01 15:21:40 -08:00
Brent Simmons b50fabe325 Fix a crash that could happen when laying out the progress view while it’s not in the view hierarchy. Fix #1764. 2020-02-01 12:19:39 -08:00
Nate Weaver b86341f44c Don't block vertical pan gestures 2020-02-01 01:12:54 -06:00
Maurice Parker 8cb28b63b8 Always swap out the web view to prevent white flashing between articles and make loading faster. 2020-01-31 21:07:08 -07:00
Maurice Parker a0f429448f Call completions immediately if the previous WebViewController was deallocated because the iPad was rotated. Issue #1757 2020-01-30 18:48:51 -07:00
Maurice Parker df3c78b1c6 Change next/prev feed searches so that they skip collapsed sections. Issue#1755 2020-01-30 18:37:22 -07:00
Maurice Parker 63e15d78c2 Fix max size phone landscape layout problems. Issue #1743 2020-01-30 17:39:21 -07:00
Maurice Parker f9dea33375 Remove force unwraps of url and container. Issue #1721 2020-01-30 13:59:15 -07:00
Maurice Parker 13a1ef0605 Don't animate the disclosure icon until it has been added to the view hierarchy. Issue #1717 2020-01-30 13:44:31 -07:00
Maurice Parker 6454330c8b Add the subviews to the contentVIew (per the documentation). Issue #1717 2020-01-30 13:27:17 -07:00
Maurice Parker ab8deab726 Correct object ownership to remove retain cycle 2020-01-30 12:53:27 -07:00
Nate Weaver e6c2c32456 Standardize on tabs 2020-01-30 06:19:54 -06:00
Nate Weaver 447cc44b8e Put <title> and <base> in the <head> instead of <body>
This also means renderHTML() is no longer needed.
2020-01-30 06:15:14 -06:00
Maurice Parker f9589faa59 Keep queued WKWebViews in a hidden view until they are needed. Issue #1563 2020-01-29 17:39:40 -07:00
Maurice Parker fdde879910 Rest the currentFeedIndexPath if it has become invalidated by a shadow table rebuild. Issue #1741 2020-01-29 17:06:35 -07:00
Maurice Parker c293bc3a12 Animate timeline article selection and scrolling when done via article swiping. Issue #1732 2020-01-29 16:31:50 -07:00
Maurice Parker 967410e0f5 Don't rebuild the shadow table during launch for unread counts. Issue #1733 2020-01-29 12:19:28 -07:00
Maurice Parker 6b23cadc41 Empty the timeline when ending the search to make sure diffable datasources don't keep some search cells around. Issue #1736 2020-01-29 11:41:05 -07:00
Maurice Parker f96bb9c3e0 Store more article view controller state when destroying and recreating them. Issue #1729 2020-01-29 11:30:52 -07:00
Maurice Parker 03fbdbbe66 Exempt folders from the read filter if they have a child selected. Issue #1735 2020-01-29 11:18:17 -07:00
Maurice Parker b292ea97fc Dismiss the search bar if next unread takes us out of the search timeline. Issue #1722 2020-01-28 17:16:49 -07:00
Maurice Parker 76aa603874 Change to no longer filter currently selected Feed. Issue #1728 2020-01-28 16:51:50 -07:00
Maurice Parker ef79005d67 Change it so that we have the unread indicator and star hidden by default. Issue #1724 2020-01-27 22:26:49 -07:00
Maurice Parker 415fb3ab56 Fix it so that we aren't scrolling and selecting using the same animation. 2020-01-27 22:10:18 -07:00
Maurice Parker 6ac6136612 Make animations individually selectable and no longer animate navigation selections. Issue #1439 2020-01-27 21:57:52 -07:00
Maurice Parker dd5633b5ae Change to use the correct URL when reloading an image. 2020-01-27 16:27:13 -07:00
Maurice Parker 3a99e6430f Make the article icon code specify the desired article so that it can't pull the wrong one by mistake. Issue #1707 2020-01-27 12:58:32 -07:00
Maurice Parker 470f2159e8 Remove dead code left from when WebViewController was split from ArticleViewController. 2020-01-27 11:50:28 -07:00
Maurice Parker 243ebac665
Merge pull request #1719 from hartlco/1709-wrong-vibrant-tap-down-state-text-colour-for-account-type-buttons
Fix vibrant colors on highlight inside AddAccountViewController and the timeline layout cell
2020-01-27 10:35:08 -08:00
Maurice Parker 99fbd2d1a1 Remove extraneous code that was causing the unread counts to sometimes not be displayed. Issue #1711 2020-01-27 11:28:59 -07:00
Martin Hartl b8c1389bc6 Use VibrantBasicTableViewCell for Timeline layout cell to change label color on highlight/selection 2020-01-27 08:37:02 +01:00
Martin Hartl 7e9277f7d8 Use SettingsAccountTableViewCells inside AddAccountViewController for vibrant colors 2020-01-27 06:57:05 +01:00
Maurice Parker 72e886b709 Make extractor buttons higher animation while animating. Issue #1705 2020-01-26 22:32:18 -07:00
Maurice Parker 25daea8a9f Create separate color for block quote bar. Issue #1718 2020-01-26 21:44:53 -07:00
Maurice Parker bb05d9111e Fix to use the correct count for currently selected row. Issue #1711 2020-01-26 21:34:50 -07:00
Maurice Parker f2ac6ff1df Add functionality to clear the timeline and article views if their respective items get collapsed or filtered. Issue #1708 2020-01-26 21:18:43 -07:00
Maurice Parker 97d6c69431 Change to always reload the page when rendering an article. Issue #1713 2020-01-26 20:29:58 -07:00
Maurice Parker 4a63b28c73 Change how next and previous articles are selected so that animation timings can't impact them. Issue #1707 2020-01-26 14:21:04 -07:00
Maurice Parker bc5a8c3705 Reset scroll position when article is reset. Issue #1716 2020-01-26 13:01:03 -07:00
Maurice Parker fdde6d0583 Make sure that the smart feed section is expanded before selecting the all unread feed. Issue #1673 2020-01-25 16:13:33 -07:00
Maurice Parker b62f80e0ea Removed unnecessary reloads that were crashing. Issue #1672 2020-01-25 15:51:34 -07:00
Maurice Parker 785775801a Don't force cast scrollY as it might not always be set. Issue #1685 2020-01-25 15:36:43 -07:00
Maurice Parker aa94fbeacf Merge articles instead of replacing them for add remove feed and account functions. Issue #1692 2020-01-23 18:07:20 -07:00
Nate Weaver e88643f9b9 Make tables obey Dynamic Type 2020-01-22 05:26:12 -06:00
Maurice Parker f5c2fc4813 Pass all UTI types associated with OPML to the document picker for OPML imports. Issue #1684 2020-01-21 12:58:05 -07:00
Maurice Parker 050434023e Fade out unread and star indicators when possible. Issue #1683 2020-01-21 11:41:03 -07:00
Maurice Parker 1f58161eeb Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-01-21 11:05:58 -07:00
Maurice Parker deab8f8c6c Change to stop recycling the article view controller when switching panel modes on the iPad. Issue #1570 2020-01-21 11:05:47 -07:00
Nate Weaver 3635176d58 --table-border-color -> --table-cell-border-color; add Mac table styles 2020-01-20 21:59:40 -06:00
Nate Weaver 02297ed94a Add table styles 2020-01-20 21:59:40 -06:00
Maurice Parker ed355ad614 Update to allow all text types for importing OPML and make the error message more friendly. Issue #1443 2020-01-20 14:57:07 -07:00
Maurice Parker 61c854b031 Fix animation layer stripping. Issue #1668 2020-01-20 13:16:03 -07:00
Maurice Parker fe75fb1aa4 Prevent swipe gestures on header cells from triggering the cell below. Issue #1661 2020-01-20 12:42:25 -07:00
Maurice Parker 5b2728aa10
Merge pull request #1667 from hartlco/1647-video-keeps-playing-after-swiping-to-another-article
Stop media playback when article will disappear
2020-01-20 10:56:14 -08:00
Maurice Parker c2431cb48b Add wordpress emoji style. Issue #1666 2020-01-20 11:53:06 -07:00
Martin Hartl 3370b834b0 Stop media playback when article will disappear 2020-01-20 19:46:23 +01:00
Maurice Parker 502f83ba2d Set the scroll edge appearance to have the system background. Issue #1665 2020-01-20 11:43:26 -07:00
Maurice Parker e183345f98 Stop suppressing the Confirm Mark as Read setting for iPads. Issue #1660 2020-01-19 23:12:02 -07:00
Maurice Parker 84844e6cef Fix Feed deselection. Issue #1657 2020-01-19 18:36:23 -07:00
Maurice Parker f15ade5ebb Make the article datetime always a link to the article permalink. Issue #1655 2020-01-19 17:28:06 -07:00
Maurice Parker 8df8dfdb75 Update the Feeds list when a Feed's unread count gets above zero and the read filter is on. Issue #1550 2020-01-19 16:44:13 -07:00
Maurice Parker 7e35bd1ec4 Remove unused parameter. It was obsoleted, but not removed. 2020-01-19 15:36:19 -07:00
Maurice Parker b1653845c2 Remove media selector from block quotes so that the new style is always used. 2020-01-19 13:23:45 -07:00
Maurice Parker 09c8ca9898 Remove unnecessary cell reload that was causing crashes. Issue #1535 2020-01-19 12:16:59 -07:00
Maurice Parker 88f565e03f Use the DOM Y position to restore the scroll offset. This mostly fixes Issue #1494. 2020-01-19 11:48:26 -07:00
Maurice Parker 110c7ae2e8
Merge pull request #1653 from hartlco/1238-iOS-Timeline-back-swipe-animation-error
Apply UINavigationBarAppearance appearance to scroll edge
2020-01-19 10:34:56 -08:00
Martin Hartl 5a6e0fd387 Apply UINavigationBarAppearance appearance to scroll edge 2020-01-19 19:22:36 +01:00
Maurice Parker 8e92cee13d Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-01-18 18:24:29 -07:00
Maurice Parker 93f2c249e7 Change feed cell background color so that it can't be corrupted. Issue #1649 2020-01-18 18:24:18 -07:00
Brent Simmons b150eaaff5 Update copyright year to 2020. 2020-01-18 11:53:22 -08:00
Maurice Parker f0d8a9038d Reload the web view every 10 renderings to clean it up. Issue #1487 2020-01-18 11:59:24 -07:00
Phil Dokas d3ecb68708 Positions the footnote popover on top of other content 2020-01-17 13:41:12 -08:00
Maurice Parker 2e583ae7b2 Force the progress view label to update with content size changes. Issue #1645 2020-01-17 14:33:06 -07:00
Maurice Parker a4896958c3
Merge pull request #1643 from Wevah/ios-candidate
Update to latest RSCore
2020-01-17 12:07:42 -08:00
Maurice Parker 34984551c6 Fully reload the page when the content size changes. Issue #1642 2020-01-17 12:53:50 -07:00
Nate Weaver b35215d03b Update for pending RSCore String updates 2020-01-17 13:45:38 -06:00
Maurice Parker 3c1668c178 Make Feedbin/Twitter video usable. Issue #718 2020-01-17 12:17:38 -07:00
Maurice Parker df1b483996 Add Feedbin specific separator. Issue #1640 2020-01-17 10:56:59 -07:00
Maurice Parker 2cdec8c4bf Add a leading border to block quotes so that they can more easily be distinguished. Issue #1639 2020-01-17 10:53:22 -07:00
Maurice Parker f9e529bd3b Fix multiwindow auto layout errors. Issue #1636 2020-01-16 21:29:10 -07:00
Maurice Parker 9a4ed6b198 Dismiss the keyboard on drag. Issue #1634 2020-01-16 20:30:53 -07:00
Maurice Parker 2584462bc1 Fix scrolling code so that it takes into consideration the content is under the bars now. Issue #1633 2020-01-16 19:40:13 -07:00
Maurice Parker 046162b303 Update the SceneCoordinator to use the same lookup method to determine if the node should be getting its unread count from the SceneCoordinator. 2020-01-16 15:24:48 -07:00
Maurice Parker 333da704aa Fix regression that made customize timeline unselectable. 2020-01-16 14:44:30 -07:00
Maurice Parker 4f36ec3b11 Add Update Credetials button to the error dialog when a Feedbin credentials error happens. Issue #1441 2020-01-16 13:50:30 -07:00
Maurice Parker f7017aaed5 Enable update credentials even when the account info hasn't changed on updates. Issue #1441 2020-01-16 12:04:40 -07:00
Brent Simmons 57af7526da Revise Feedly tests to use MainThreadOperationQueue; get them building again. They don’t pass, but at least they build. 2020-01-15 22:10:06 -08:00
Maurice Parker 4eedd96507 Fix regression that prevented Safari from opening from Activity dialog. 2020-01-15 18:23:09 -07:00
Maurice Parker bd29a030e5 Make sure that the imageWasShown message always gets posted, even if the web view got reloaded. Issue #1586 2020-01-15 18:09:47 -07:00
Maurice Parker d68eccc55e Exit search if Go To Feed is selected. Issue #1557 2020-01-15 17:53:12 -07:00
Maurice Parker 3e604e0b34 Load the feed article if the extracted article fails to parse. Issue #1542 2020-01-15 17:34:02 -07:00
Maurice Parker c384362a78 Set extractor button state on viewDidLoad. Issue #1627 2020-01-15 17:28:37 -07:00
Kiel Gillard 0d0b6b8fa6 Gives iOS a chance to open universal links. #1625 2020-01-16 09:56:51 +11:00
Maurice Parker fadbd9d289
Merge pull request #1608 from myurieff/open-homepage-on-tap
Open homepage on tap
2020-01-14 14:22:33 -07:00
Mihael Cholakov 4b9f896a49 Fix UIView.transition view to be the icon 2020-01-14 17:49:43 +02:00
Mihael Cholakov 8df0067813 Fix icon highlighted color 2020-01-13 10:13:02 +02:00
Mihael Cholakov 9368d1033d Implement VibrantBasicTableViewCell 2020-01-12 23:53:08 +02:00
Mihael Cholakov 77b470a720 Safari is presented as pageSheet 2020-01-12 23:29:32 +02:00