FreshRSS/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire.git synced 2025-02-02 03:56:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't animate the disclosure icon until it has been added to the view hierarchy. Issue #1717

Browse Source
This commit is contained in:
Maurice Parker 2020-01-30 13:44:31 -07:00
parent 6454330c8b
commit 13a1ef0605
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
iOS/MasterFeed/Cell/MasterFeedTableViewSectionHeader.swift
View File

@ -42,7 +42,6 @@ class MasterFeedTableViewSectionHeader: UITableViewHeaderFooterView {
set {
if titleView.text != newValue {
titleView.text = newValue
setNeedsDisplay()
setNeedsLayout()
}
}
@ -50,7 +49,7 @@ class MasterFeedTableViewSectionHeader: UITableViewHeaderFooterView {
var disclosureExpanded = false {
didSet {
updateExpandedState()
updateExpandedState(animate: true)
updateUnreadCountView()
}
}
@ -116,19 +115,22 @@ private extension MasterFeedTableViewSectionHeader {
func commonInit() {
addSubviewAtInit(unreadCountView)
addSubviewAtInit(titleView)
updateExpandedState()
addSubviewAtInit(disclosureView)
updateExpandedState(animate: false)
addBackgroundView()
addSubviewAtInit(topSeparatorView)
addSubviewAtInit(bottomSeparatorView)
}
func updateExpandedState() {
func updateExpandedState(animate: Bool) {
if !isLastSection && self.disclosureExpanded {
self.bottomSeparatorView.isHidden = false
}
let duration = animate ? 0.3 : 0.0
UIView.animate(
withDuration: 0.3,
withDuration: duration,
animations: {
if self.disclosureExpanded {
self.disclosureView.transform = CGAffineTransform(rotationAngle: 1.570796)