7d8e49a2ee
Merge branch 'ios-release'
2020-05-18 03:05:59 -05:00
b575d648dc
Merge pull request #2063 from bdougsand/find-in-article-ios
...
Adds "Find in Article" activity to the share sheet
2020-05-18 02:41:28 -05:00
2297d218c0
Uses selector syntax.
2020-05-18 09:23:42 +08:00
6224dfad03
Notification Permission Requests
...
Fixes #2057
• On app launch, the app checks if notification permissions are granted and registers with APNS if that is the case. It will not request permissions as part of the app launch.
• When a user requests to be notified of new articles, the authorizationStatus is checked:
- if `notDetermined` or `provisional`, an authorization request is made, and if successful, the Notify of New Articles status is updated (otherwise it is reverted)
- if `denied`, an alert is thrown asking the user to enable in settings (and the change to notify of new articles is reverted)
- if `authorized` the update is made.
`WebFeedInspectorViewController` also monitors for the app entering the foreground so that it can get the latest notification auth settings.
2020-05-18 08:39:22 +08:00
d8dced6347
Adds a key command (ESC) to the article search bar
2020-05-15 21:41:14 -04:00
b058f27064
Fixes bugs in article search
...
Placement of the article search bar is now always done with constraints.
Previously, I'd used inputAccessoryView when the keyboard appeared. That
approach, although ostensibly permitted, causes a hierarchy inconsistency error
when the device orientation changes.
2020-05-15 21:41:14 -04:00
62d04e8881
Adds stored inputAccessoryView to ArticleSearchBar
...
It should have been obvious that inputAccessoryView traverses the responder
chain
2020-05-15 21:41:14 -04:00
46ce824b98
Adds guard against empty search strings to Find in Article
2020-05-15 21:41:14 -04:00
96671df667
Adds keyboard shortcut for "Find in Article" (iOS)
2020-05-15 21:41:14 -04:00
2631f4f3f0
Alters search highlights so they don't intercept pointer events
2020-05-15 21:41:14 -04:00
edb7c50cb3
Improves incremental search for "Find in Article"
...
Article search now maintains its position in the document, if possible.
2020-05-15 21:41:14 -04:00
98e0434077
Alters Find in Article to escape regex characters by default
2020-05-15 21:40:22 -04:00
c2b749a74c
Rebuild backing stores immediately when deselecting a Feed. Issue #2079
2020-05-15 17:06:49 -05:00
4e22489d97
Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release
2020-05-15 10:45:22 -05:00
8ff2776d88
Make sure we have only one web view in the view hierarchy after navigation. Issue #2075
2020-05-15 10:45:05 -05:00
225c98a70e
Merge pull request #2073 from rizwankce/open-in-safari-shortcut
...
Keyboard shortcuts for "Open in App Browser"
2020-05-15 04:38:26 -05:00
c9ebb6bd75
adds "Open In App Browser" shortcut
2020-05-15 12:39:33 +05:30
04458adee5
adds "Mark All Read" shortcut for feeds list
2020-05-14 18:13:41 +05:30
f7f7f4dddb
adds keyboard shortcuts for open in Safari
2020-05-14 17:58:38 +05:30
8500324eb2
Merge pull request #2041 from stuartbreckenridge/mail-fix-ios
...
mailto links now open on iOS
2020-05-14 07:26:26 -05:00
8fe746fabf
Merge pull request #2072 from rizwankce/fix/share-extension-activation-rule
...
Share extension activation rule for text
2020-05-14 07:17:54 -05:00
7deac7f3c3
Merge pull request #2071 from stuartbreckenridge/issue-2018
...
Key commands work with action sheets
2020-05-14 07:14:57 -05:00
bfef02e18f
adds text activation rule for share extension
2020-05-14 17:17:16 +05:30
a9e8cec90e
Key commands work with action sheets
2020-05-14 17:10:55 +08:00
8f8bd229c5
Merge pull request #2068 from rizwankce/feature/keyboard-shortcuts
...
Keyboard shortcuts
2020-05-13 11:43:14 -05:00
32c8c038ee
move toggle side bar to RootSplitViewController
2020-05-13 21:57:02 +05:30
a9aefd252e
adds keyboard shortcuts
...
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
2020-05-13 17:29:59 +05:30
f153643273
Removes return statements that are not needed.
2020-05-13 13:03:51 +08:00
58575331dd
Fixes #2018
...
This commit adds a new `MarkAsReadAlertControllerSourceType` protocol to which `CGRect`, `UIView`, and `UIBarButtonItem` conform to.
The `MarkAsReadAlertController` now presents an action sheet for mark as read, mark above as read, and mark below as read. The above is used for the `popoverPresentationController`’s `barButtonItem`, `sourceRect`, or `sourceView` as needed.
2020-05-13 12:33:51 +08:00
775a69a295
Add iOS Reddit URL builder
2020-05-12 11:17:47 -05:00
737f4bfdf5
Adds "Find in Article" activity to the share sheet
...
addresses #1750
2020-05-11 17:08:44 -04:00
ccb813f6ec
Allow autoplay on iOS
2020-05-10 12:21:35 -05:00
fda9be2e41
Update the progress bar when it comes into view so that it is always current
2020-05-10 10:00:04 -05:00
50e6e8e190
Merge pull request #2050 from jbennett/2049-add-folder-management-behavior
...
Adds an account behavior to disable folders
2020-05-08 15:36:16 -05:00
715804fe64
Merge branch 'ios-release'
2020-05-07 11:34:02 -05:00
46a96a7d50
Serialize access to the web view provider. Issue #2043
2020-05-07 11:32:11 -05:00
a37bfd5d74
Adds an account behavior to disable folders
...
Some sync services (Feed Wrangler) don't support folders. This behavior removes the account from the UI when adding new folders.
2020-05-07 10:03:04 -04:00
9429f36095
Don't image zoom any previews that are just links out
2020-05-06 21:56:01 -05:00
2d8cbb8017
Merge branch 'ios-release'
2020-05-06 18:39:55 -05:00
211e44fff5
Remove flash when changing out the web view upon returning to the foreground
2020-05-06 17:35:38 -05:00
be4691abd0
Use different assets for Snoo when in light vs dark mode
2020-05-06 15:32:05 -05:00
14d8e9af30
Merge branch 'ios-release'
2020-05-06 15:12:25 -05:00
d4cffa28f2
Rollback disclosure button reference hold since it does nothing to stop the crash
2020-05-06 14:58:47 -05:00
502ff3e019
Don't multiply by the device pixel ratio if that will put us over the canvas limit
2020-05-06 14:55:34 -05:00
5f60b84b8b
Reset all the web views when coming back to the foreground incase one of them is unavailable now
2020-05-06 14:53:09 -05:00
38f992d01d
Degrade zoom image quality rather than failing
2020-05-06 11:43:50 -05:00
f58ac4d160
Wraps Alert strings in `NSLocalizedString`
...
Also removes `tel` scheme handling.
2020-05-04 13:25:02 +08:00
78f72264fd
Add oauth2 signon to iOS
2020-05-03 16:19:55 -05:00
e825a5d516
Adds handling of `tel` url schemes
2020-05-03 22:37:01 +08:00
f901436211
mailto links now open on iOS
...
fixes #2036
Extends `URL` with an email address `var` for `mailto` schemes and adds a decisionHandler for `mailto` schemes on `WebViewController`. If the device cannot send mail, an alert is displayed.
2020-05-03 21:33:57 +08:00
e681fd6402
Stub out Reddit Feed Provider / Extension Point
2020-05-02 19:38:57 -05:00
41a17dfb06
Restrict build button on iOS so that it only appears if Twitter is enabled
2020-05-02 17:21:01 -05:00
85f7adaa0a
Use MainThreadOperation to prevent article status updates from interleaving
2020-05-02 10:02:58 -05:00
6bdcd941ae
Fix typo
2020-05-02 09:01:53 -05:00
a522ec67b3
Merge branch 'master' of https://github.com/Ranchero-Software/NetNewsWire
2020-05-01 17:43:33 -05:00
6d60053012
Merge branch 'ios-release'
2020-05-01 16:35:21 -05:00
e2267d14ee
Hold a reference to the pointer interaction to try to get it to stop crashing. Issue #2034
2020-05-01 16:34:19 -05:00
d5a4f1625a
Take device pixel ratio into consideration when drawing the image to zoom. Issue #2032
2020-05-01 16:24:29 -05:00
5ac69a411e
Remove the color parameter on iOS too
2020-05-01 02:02:44 -05:00
070981553d
Make attributed titles work on iOS
2020-05-01 01:42:44 -05:00
898681dfe6
Take device resolution into consideration when drawing image. Issue #2032
2020-04-30 15:34:17 -05:00
14e1dbe58e
Merge branch 'ios-release'
2020-04-30 14:29:01 -05:00
d30987ca0a
Use main thread operation to only allow one remote notification at a time to run.
2020-04-29 15:46:29 -05:00
d1c3d43018
Don't animate progress bar when initially added to the superview
2020-04-29 14:29:21 -05:00
a48cbfe1ca
Add code to show the Feed Inspector when the feed icon in the article view is pressed. Issue #1931
2020-04-28 21:26:57 -05:00
5e4ebb7298
Disallow the feed icon from the image zooming.
2020-04-28 21:03:21 -05:00
c1bb75f21e
Deleted dead code
2020-04-28 20:42:31 -05:00
37bbee9fcc
Remove calls to dismiss delegate function on cancel. Issue #2010
2020-04-28 17:58:06 -05:00
e77abf42c3
Revert "Removes AddAccountDismissDelegate"
2020-04-28 17:53:24 -05:00
31f3487d7a
Reset focus when returning to the app from another app or the safari view controller. Issue #1963
2020-04-28 17:16:34 -05:00
31b04f626a
Fix spelling of hashtag. Thanks Stephen!
2020-04-25 15:12:35 -05:00
f0988d1b68
Add #hashtag to placeholder text
2020-04-25 14:31:07 -05:00
86fb98c17b
Revert "WIP: Title tags"
2020-04-24 20:24:24 -05:00
6aff83481f
Make attributed titles work on iOS
2020-04-24 16:20:41 -05:00
ee92cf69d2
Merge branch 'extension-point'
2020-04-24 13:34:13 -05:00
6f29b21ddc
Merge pull request #2013 from rizwankce/fix/missing-add-account-title
...
Add title for AddAccountViewController
2020-04-24 10:30:31 -05:00
54fc60aa51
Add title for AddAccountViewController
...
view controller title via storyboard
2020-04-24 20:56:29 +05:30
a46609b564
Merge pull request #2014 from rizwankce/fix/add-account-cell-high-lighting
...
Deselect the cell row when selected for add account view controller
2020-04-24 09:11:28 -05:00
43f175d71a
Removes AddAccountDismissDelegate
...
Delegate which was responsible to dismiss AddAccountViewController
whenever presented view controller dismissed is not needed. So removing
it simply will go to previous screen from where user comes.
2020-04-24 18:49:49 +05:30
c7e3162c22
Deselect the cell row when selected for add account view controller
...
To avoid the highlighting even after the row is selected
2020-04-24 18:39:18 +05:30
37ae46ea4c
Merge more styles and fix styling of tables with explicit thead/tbody/tfoot
...
Also use :matches() to simplify some rules.
# Conflicts:
# Mac/MainWindow/Detail/styleSheet.css
# iOS/Resources/styleSheet.css
2020-04-23 23:21:22 -05:00
e741e8e1b4
Make detail entry more user friendly
2020-04-23 11:50:29 -05:00
c451cb38d9
Add Twitter detail entry scene
2020-04-23 10:43:09 -05:00
e1fc8d15d6
Update storyboard for dynamic type.
2020-04-23 10:01:26 -05:00
059b24c57b
Add Twitter select account for URL builder
2020-04-23 09:50:19 -05:00
e566d1493c
Fix disclosure indicator
2020-04-23 09:10:40 -05:00
4ff273c3b5
Add single Home Timeline and Mentions URL builder.
2020-04-23 09:08:33 -05:00
7d2eba537b
Change callback URL scheme to final scheme
2020-04-23 07:58:00 -05:00
1b48b09369
Fix hammer button compression bug
2020-04-23 06:55:57 -05:00
4461cf83cb
Add select URL Builder dialog
2020-04-23 04:44:26 -05:00
e11cf2ccf5
Rename to use common name for table view cell
2020-04-23 04:00:51 -05:00
62ca536717
Merge branch 'master' into extension-point
2020-04-22 22:06:16 -05:00
147d5c301c
Merge branch 'ios-release'
2020-04-22 22:04:45 -05:00
947c4f04d7
Implement fix that prevents wiggling on both the timeline and the article views.
2020-04-22 22:03:15 -05:00
a5583fc655
Validate that the selected row hasn't been removed when trying to select or scroll to it. Issue #1976
2020-04-22 18:18:20 -05:00
5d5093d26d
Merge branch 'master' into extension-point
2020-04-21 20:25:50 -05:00
f1357c0a23
Merge branch 'ios-release'
2020-04-21 20:25:14 -05:00
82e7d4eaf0
Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release
2020-04-21 20:24:01 -05:00
2454b807bb
Always update the status sync timer when returning to the foreground. Issue #2005
2020-04-21 20:23:46 -05:00
108da4ccf4
Fix buttons a11y label for close and share button for image vc
...
Image View Controller buttons both close and share don't have correct
a11y label. This will add the localised label
2020-04-21 22:14:58 +05:30
575288b78e
Merge branch 'master' into extension-point
2020-04-21 02:10:31 -05:00
7268dcdd77
Merge branch 'ios-release'
2020-04-21 02:06:19 -05:00
f7bdf9d47c
Correct text resizing issues in color palette settings. Issue #2000
2020-04-21 01:57:19 -05:00
7afcf681fe
Stablize swipe back gesture for timeline. Issue #2002
2020-04-21 01:52:39 -05:00
d0d29fd7da
Merge branch 'master' into extension-point
2020-04-19 19:01:11 -05:00
2a6d9994ea
Move shared CSS into its own file
2020-04-19 18:38:33 -05:00
eeb7b518a8
Change how showIcons is determined to take into consideration empty bylines
2020-04-19 17:29:11 -05:00
b80270f65b
Fix iOS timeline layout issue with truncated bylines
2020-04-19 17:28:00 -05:00
ac41c7af69
Added timestamp to retweets
2020-04-18 16:27:19 -05:00
ad95cef6bb
Add iOS twitter stylings
2020-04-18 15:17:56 -05:00
1778a270d6
Show byline in timeline for single feed timelines when available.
2020-04-18 07:53:56 -05:00
9b39165018
Merge branch 'master' into extension-point
2020-04-16 16:37:18 -05:00
afdfe5fe71
Merge branch 'ios-release'
2020-04-16 16:36:53 -05:00
a4c672bb46
Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release
2020-04-16 16:27:04 -05:00
928e93c074
Remove web view recycling as this seems to contribute to the blank article problem on iPadOS
2020-04-16 16:26:53 -05:00
f9a11198f0
Remove Omni from credits and about text.
2020-04-16 13:24:20 -07:00
d4b5d7bde4
Add FeedProviderManager
2020-04-16 15:06:56 -05:00
d168658e05
Add Extension Point maintenance to the iOS app.
2020-04-16 08:25:40 -05:00
1321f0b9ff
Loop through through rows using the count of rows in that section, rather than the count of rows in the initial indexPath’s section. Fix #1987 .
2020-04-12 18:23:20 -07:00
6d9eda442f
Remove userDeleted support. The read-items filter seems to fill the need to hide things. We’re simplifying the backend by removing this unused feature.
2020-04-12 17:12:36 -07:00
46f614e960
Merge branch 'ios-release'
2020-04-12 11:50:11 -05:00
7064d5d8f5
Fix regression where navigating back and paging back from an article happened at the same time.
2020-04-12 11:48:14 -05:00
e6c5d2f199
Merge branch 'ios-release'
2020-04-11 15:59:37 -05:00
7c266d65ee
Force the frame to center when displaying. Issue #1983
2020-04-11 15:58:48 -05:00
02f62bbb61
Fix image cropping. Issue #1967
2020-04-11 15:11:12 -05:00
6a9620e4de
Add NewsBlur and CloudKit to addable account types on production builds.
2020-04-06 15:37:26 -05:00
6ad4eeb280
Merge branch 'ios-release'
2020-04-06 08:47:56 -05:00
f0ec7c5e19
Fix problem where back swiping wouldn't work anymore for full screen. Issue #1970
2020-04-06 08:47:01 -05:00
bcfd75ff68
Replace the `firstElementPassingTest` function come from RSCore with the native function `first(where:)`.
2020-04-06 02:06:24 +08:00
40ea5243c6
Removed notification we no longer needed to use to refresh the Feeds and Sidebar.
2020-04-01 20:31:32 -05:00
ea78b5683d
Fix background notification processing of CloudKit changes.
2020-04-01 20:21:14 -05:00
def48546a3
Change how initial refresh is triggered.
2020-04-01 16:45:29 -05:00
4941d60c1a
Put add accounts list into alphabetical order
2020-04-01 07:50:11 -05:00
b664ae2609
Merge pull request #1959 from quanganhdo/mac-newsblur
...
Add NewsBlur support to Mac version
2020-03-30 17:37:08 -05:00
c3506e9329
Add NewsBlur to Preferences
2020-03-30 17:45:47 -04:00
41acb716bd
Remove activity donation for next unread. Issue #1957
2020-03-30 15:42:42 -05:00
d9e5350804
Hide credentials section for iCloud.
2020-03-30 03:00:52 -05:00
187121298e
Added support for CloudKit push notifications (subscriptions).
2020-03-30 02:48:25 -05:00
4f425c9c86
Implement web feed sync between devices.
2020-03-29 17:12:34 -05:00
ecc20ad9e3
Enabled adding a CloudKit account on iOS.
2020-03-28 17:51:14 -05:00
532db0b640
Merge branch 'ios-release'
2020-03-28 16:51:50 -05:00
649972f57f
Created the Developer build which has some functionality disabled for those without access to the API keys needed.
2020-03-28 16:51:41 -05:00
715671edad
Rebuild the Feeds list when coming back to it from the Timeline while the root split is collapsed to filter read Feeds.
2020-03-28 01:43:54 -05:00
6d085fdacf
Inline videos and enable player controls for both Mac and iOS. Issue #1952
2020-03-28 00:56:29 -05:00
bd1c73c1d3
Automatically remove Feed items if they should be filtered. Issue #1949
2020-03-27 18:24:57 -05:00
a13f10441f
Change pointer interaction to encompass the complete button.
2020-03-26 11:20:13 -05:00
53b00c5414
Don't show add account option for CloudKit when the entitlement isn't present.
2020-03-25 16:09:01 -05:00
6c06c7791c
Add interaction to buttons that were missing it. Issue #1945
2020-03-25 08:55:02 -05:00
450ddbd364
Refactored new pointer interaction code to be more simple.
2020-03-24 18:27:54 -05:00
bd75df7294
Add pointer interaction for timeline header button. Issue #1943
2020-03-24 16:42:46 -05:00
25882f69c8
Merge branch 'ios-release'
2020-03-24 16:00:53 -05:00
d615a0a894
Fix bug where clean up shortcut wouldn't clear articles if wrong setting was off.
2020-03-24 16:00:01 -05:00
d0680bcc73
Merge branch 'ios-release'
2020-03-24 12:21:32 -05:00
2d56971c45
Added missing dev files
2020-03-23 07:26:44 -05:00
8105756ccb
Add some work in progress for CloudKit syncing
2020-03-22 16:35:03 -05:00
85cbd204b3
Fixed clean up keyboard shortcut
2020-03-22 10:23:31 -05:00
97226f543b
Assign keyboard shortcuts to filters and change clean up shortcut. Issue #1842
2020-03-22 10:18:07 -05:00
b7fe991b7b
Retrieve session id for later requests
2020-03-22 00:47:27 -04:00
034aabbfff
Add login/logout support
2020-03-22 00:47:26 -04:00
8f5f856e49
Add NewsBlur account prototype
2020-03-22 00:47:26 -04:00
960af2a8df
Parameterize the container so that each developer has their own
2020-03-21 20:53:21 -05:00
07cc89541c
Add iCloud.com.ranchero.NetNewsWire entitlement to Mac and iOS targets.
2020-03-21 17:43:33 -07:00
9f516caa35
Don't use borders on nested tables. Issue #1936
2020-03-21 17:19:03 -05:00
9315a00d19
Add CloudKit container entitlements.
2020-03-21 02:34:34 -05:00
e7436925ad
Don't remove filtered feeds on article downloads.
2020-03-20 10:34:18 -05:00
316e4e62b2
Removed separator insets from layout code as they were no longer needed.
2020-03-20 06:58:11 -05:00
8a75defee9
Set row height when table is empty and set to automatic when articles are present. Issue #1919
2020-03-18 16:06:05 -05:00
1d26bc8c70
Revert "Set proper cell height for empty article array"
2020-03-18 15:55:33 -05:00
770206df60
Merge branch 'ios-release'
2020-03-17 17:19:31 -05:00
36841602a5
Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923
2020-03-17 17:18:24 -05:00
37cf7fae1d
Fix regression that prevented Always Show Reader View from working.
2020-03-16 07:58:51 -05:00
07042b8a2a
Implemented Clean Up keyboard shortcut. Issue #1915
2020-03-15 18:15:52 -05:00
47dc34db5d
Fix Typo
...
This contains work related to issue #1910
2020-03-15 22:44:12 +01:00
2ade0140bc
Set proper cell height for empty article array
...
Contains work related to #1800
This one took me a while to figure out since they amount of articles is tied to the coordinator.
- Fixed violation of single responsibility principle inside “resetEstimatedRowHeight()” by removing the applicance of tableViewRowHeight and instead return the correctly calculated rowHeight.
- Removed prototype strings from inside the function to a static struct to be able to switch parameters for this function more easy (might be useful later / in testing). Function looks cleaner.
Greetings from southern germany!
2020-03-15 22:31:54 +01:00
acaf3fac9f
Add user agent to plist. Issue #1913
2020-03-15 11:48:07 -05:00
a620a20588
Add the option to select the user interface color palette. Issue #1900
2020-03-15 04:25:25 -05:00
5b5eaf6bb7
Merge branch 'ios-release'
2020-03-14 17:13:25 -05:00
07dc4f1f10
Don't start the article extractor if we only want to store the article. Issue #1494
2020-03-14 06:31:14 -05:00
e6af6ece42
Add top and bottom margins to figure elements
2020-03-13 22:01:07 -05:00
9a3fe5caa5
Add a max-width to body
2020-03-13 21:36:16 -05:00
66e7e425aa
Remove obsolete code that could be causing the feed unread counts to not update. Issue #1806
2020-03-13 17:06:53 -05:00
833c336f2f
Only show the timeline next read button when the root split view controller is collapsed. Issue #1822
2020-03-13 16:03:42 -05:00
49257970af
Removed testing code. Issue #1810
2020-03-13 15:35:33 -05:00
2240058fe8
Merge pull request #1850 from mvolpato/bugfix-progress-indicator-max-width
...
Bugfix progress indicator max width
2020-03-13 15:31:30 -05:00
7922efab1e
Merge pull request #1899 from flowinho/ios-release
...
Hide articleExtractor and actionBarButtonItem
2020-03-13 15:13:33 -05:00
ce428d2cc6
Hide articleExtractor and actionBarButtonItem
2020-03-13 20:21:18 +01:00
52be6e5743
Darken light mode icon color so that it contrasts better against pure white icons. Issue #1731
2020-03-13 10:17:00 -05:00
d0cf04bd4f
Merge pull request #1892 from flowinho/ios-release
...
Add background to pure white icons
2020-03-13 10:04:56 -05:00
130691db34
Revert to old logic
2020-03-13 14:21:38 +01:00
ee86b1a148
Apply background if feed-icon is bright
2020-03-13 11:54:31 +01:00
77fd3020cc
Correct font used to specify font size. Issue #1878
2020-03-12 19:01:10 -05:00
76dd3abff2
Properly style footnotes that have been absoluted
2020-03-12 18:32:42 -05:00
dfdf19e17f
Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release
2020-03-12 18:07:49 -05:00
61a2e95d2b
Manually specify the font size to work around a WKWebView resizing bug. Issue #1878
2020-03-12 18:07:40 -05:00
c19bf93586
Merge pull request #1890 from flowinho/ios-release
...
Align feedname and date correctly if there is no title or summary
2020-03-12 17:03:58 -05:00
0a3713e078
Align feedname and date correctly if there is no title or summary
2020-03-12 22:57:30 +01:00
47e42fab0a
Removed old debugging statement.
2020-03-12 16:01:13 -05:00
da64f65c7b
Fixes close button icon distortion
...
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.
- Set content-mode of the buttons imageview to scaleAspectFit.
2020-03-12 21:54:50 +01:00
feacda1c3b
HOTFIX silly me
2020-03-12 21:33:02 +01:00
91247b7f16
Adding dynamic width algorithm to the titleLabel
...
This commit adds multiple functionalities at once:
- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).
The title label now resizes itself depending on the devices it’s displazed on.
- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.
The numbers are derived from my personal preference when implementing it.
2020-03-12 21:23:57 +01:00
97c79202fc
Added missing constraints to the UISwitch elements
2020-03-12 17:56:43 +01:00
22b9e7b54b
Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883
2020-03-11 19:45:45 -05:00
27b1443def
Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881
2020-03-11 18:17:09 -06:00
76d5f4a073
Remove flush and restore of web view queues. Issue #1882
2020-03-11 17:02:16 -06:00
38981d01bd
Don't remove items from Feeds list when batch update is performed. Issue #1879
2020-03-11 15:19:55 -06:00
9007ed4b06
Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834 , #1856 , and #1845
2020-03-11 14:47:00 -06:00
b178fe93af
Call action on return if password was added
...
This is an obvious change.
2020-03-11 14:02:06 +01:00
66fae15f64
Remove redundant code to lessen LOC
...
- Less code - less bugs.
- Also resign the first responder when the user presses the action button
2020-03-11 13:43:02 +01:00
386efd632b
Changing UIContentType from username to email adress
...
Add responder switch to streamline login flow
This change achieves two things:
- When the user presses Return and the email field is selected, the cursor now switches to the password field (as expected by the user).
- It enables iOS to pick up login and password field and enables password autofill.
2020-03-11 13:43:02 +01:00
ee0f982e93
Remove unneeded whitespaces
2020-03-02 22:33:59 +01:00
115405f1f0
Fix progress bar width, add contraints to progress label
2020-03-02 22:25:57 +01:00
94c6ca428f
Merge branch 'mac-release'
2020-03-01 16:32:31 -08:00
3a0f57e4da
Fixed toggle color. Issue #1838
2020-02-29 09:09:53 -08:00
cd5e491f00
Fix issue where full screen wouldn't come back after being engaged and moving to the timeline. (Regression)
2020-02-26 16:02:36 -08:00
9e3f061fcb
Dispatch the page controller setting since it is unreliable. Issue #1756 & Issue #1808
2020-02-25 18:06:02 -08:00
5a5abb0b87
Ensure that the dom is fully loaded on *all* web views before being made available to process JavaScript. Issue #1756 & Issue #1808
2020-02-25 15:10:51 -08:00
a4bbf65944
Coalesce unread count backing store rebuilds to prevent feeds list flickering while syncing and the feeds filter is engaged. (Regression)
2020-02-25 10:42:56 -08:00
d222a9f617
Change to not force unwrap the descriptor. Issue #1818
2020-02-24 08:42:19 -08:00
23b8af4634
Don't end the operation until the deselection animation has completed. (Regression)
2020-02-24 08:07:14 -08:00
afadadff69
Restore timeline selection when coming back into foreground. (Regression)
2020-02-23 17:12:02 -08:00
48e856fc04
Serialize access to the UITableView for scrolling and diffable datasource updates. Issue #1806
2020-02-23 10:57:20 -08:00
ad7dde8564
Merge branch 'ios-candidate'
2020-02-21 17:02:14 -08:00
fd0363aad2
Turn double space into single space after sentence in Settings.
2020-02-18 23:14:27 -08:00
3e93877362
Add instructions for full screen and fix some dynamic type problems. Issue #1799
2020-02-18 17:30:25 -08:00
28c2598cf6
Exempt the current article from the timeline read filter. Issue #1798
2020-02-18 14:14:18 -08:00
0e72811429
Implement mark as unread window for accounts that need it. Issue #1407
2020-02-18 13:49:29 -08:00
8acd6a039a
Change event used to stop web view activity (video and image zooming) so that it doesn't interfere with the image zooming transition.
2020-02-18 11:08:38 -08:00
e3b32847f9
Stop image zooming on swipes and video playback on button presses. Issue #1801
2020-02-18 09:49:54 -08:00
f79eaf7c19
Avoid redundant shadow table rebuilds when auto-expanding containers.
2020-02-18 09:30:58 -08:00
03c1ed2625
Make handling of programmatic feed selection when filtered or collapsed more consistent. Issues #1788 and #1792
2020-02-17 17:40:40 -08:00
58b8a9adb0
Render article on to be recycled web view and delay new web view showing to 0.3. Issue #1780
2020-02-13 17:35:34 -08:00
d01e9cef42
Remove unintended web view load when changing the article.
2020-02-13 16:08:44 -08:00
2ae021960b
Move account files to the documents directory and out of the shared container. Issue #1784
2020-02-12 16:21:48 -08:00
31b72221f8
Rollback delay that was causing blank articles to be shown. Issue #1780
2020-02-09 11:57:07 -08:00
eb770f4494
Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate
2020-02-08 17:22:03 -08:00
cac67f8ac4
Use percent-encoding — via URLComponents — on the articleID in the nnwImageIcon URL scheme.
2020-02-08 17:21:55 -08:00
eed12e5347
Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate
2020-02-08 16:56:06 -08:00
bdd79aead5
Delay swapping out the web view until the new web view has had a chance to render. Issue #1780
2020-02-08 16:55:16 -08:00
fe6fbd31a8
Edit the about NetNewsWire text. Add credit for Wevah; add thanks to Feedbin for Reader view hosting.
2020-02-08 16:14:45 -08:00
e5a9205747
Always reload the web view when the showing state changes. Issue #1775
2020-02-06 11:41:06 -08:00
268c20da56
Set all the web view delegates to nil when recycling to prevent unintended behaviors. Issue #1777
2020-02-06 10:36:39 -08:00
936596f5d0
Shifting sections when one should be hidden
2020-02-06 15:27:49 +02:00
d40eaed1f5
Begin moving the MainThreadOperationQueue from Account to ArticlesDatabase.
2020-02-05 21:23:23 -08:00
d1f1ca22b6
Add a hack to prevent horizontal scrolling on iPad. Issue #1714
2020-02-05 13:46:59 -08:00
dfd6be5fa6
Flush are rebuild web view queue when suspending and restoring the app. Issue #1563
2020-02-04 16:00:26 -08:00
8ed9958631
Change full article setting to enable or disable the feature. Issue #1773
2020-02-04 11:24:06 -08:00
76bad13ae1
Rebuild the backing stores to except spotlight search result restoration. Issue #1759
2020-02-04 11:00:55 -08:00
e47e2d4ea0
Fetch any potential new articles and merge them when returning to the foreground. Issue #1761 & #1754
2020-02-03 14:05:22 -08:00
336c980243
Merge pull request #1769 from danmorrison/ios-candidate
...
Fix Feed Select Folder Table View Cell horizontal alignment
2020-02-03 10:11:00 -08:00
ba6315fa07
Set lastImageCacheFlushDate on launch in CacheCleaner instead of registerDefaults()
...
So it's actually persisted to disk.
2020-02-02 17:55:51 -06:00
da501cb39b
Fix horizontal alignment #1768
2020-02-03 09:43:05 +11:00
782dfd688e
Merge pull request #1767 from hartlco/1766-Go-to-feed-visible-when-you-are-already-inside-the-feed
...
Don’t show “Go to feed” action if already inside feed
2020-02-02 12:51:21 -08:00
83241cc329
Don’t show “Go to feed” action if already inside feed
2020-02-02 21:44:54 +01:00
4fe2a3134f
Suspend the databases sooner when suspending the application.
2020-02-02 12:11:39 -08:00
596575c0e8
Delay making the initial web view available to give it some time to load the DOM. Issue #1756
2020-02-01 16:41:10 -08:00
fcd7b88a62
Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate
2020-02-01 16:38:26 -08:00
5d1ec3bff2
Merge pull request #1763 from Wevah/vertical-scroll-fix
...
Don't block vertical pan gestures
2020-02-01 15:21:40 -08:00
b50fabe325
Fix a crash that could happen when laying out the progress view while it’s not in the view hierarchy. Fix #1764 .
2020-02-01 12:19:39 -08:00
b86341f44c
Don't block vertical pan gestures
2020-02-01 01:12:54 -06:00
8cb28b63b8
Always swap out the web view to prevent white flashing between articles and make loading faster.
2020-01-31 21:07:08 -07:00
a0f429448f
Call completions immediately if the previous WebViewController was deallocated because the iPad was rotated. Issue #1757
2020-01-30 18:48:51 -07:00
df3c78b1c6
Change next/prev feed searches so that they skip collapsed sections. Issue#1755
2020-01-30 18:37:22 -07:00
63e15d78c2
Fix max size phone landscape layout problems. Issue #1743
2020-01-30 17:39:21 -07:00
f9dea33375
Remove force unwraps of url and container. Issue #1721
2020-01-30 13:59:15 -07:00
13a1ef0605
Don't animate the disclosure icon until it has been added to the view hierarchy. Issue #1717
2020-01-30 13:44:31 -07:00
6454330c8b
Add the subviews to the contentVIew (per the documentation). Issue #1717
2020-01-30 13:27:17 -07:00
ab8deab726
Correct object ownership to remove retain cycle
2020-01-30 12:53:27 -07:00
e6c2c32456
Standardize on tabs
2020-01-30 06:19:54 -06:00
447cc44b8e
Put <title> and <base> in the <head> instead of <body>
...
This also means renderHTML() is no longer needed.
2020-01-30 06:15:14 -06:00
f9589faa59
Keep queued WKWebViews in a hidden view until they are needed. Issue #1563
2020-01-29 17:39:40 -07:00
fdde879910
Rest the currentFeedIndexPath if it has become invalidated by a shadow table rebuild. Issue #1741
2020-01-29 17:06:35 -07:00
c293bc3a12
Animate timeline article selection and scrolling when done via article swiping. Issue #1732
2020-01-29 16:31:50 -07:00
967410e0f5
Don't rebuild the shadow table during launch for unread counts. Issue #1733
2020-01-29 12:19:28 -07:00
6b23cadc41
Empty the timeline when ending the search to make sure diffable datasources don't keep some search cells around. Issue #1736
2020-01-29 11:41:05 -07:00
f96bb9c3e0
Store more article view controller state when destroying and recreating them. Issue #1729
2020-01-29 11:30:52 -07:00
03fbdbbe66
Exempt folders from the read filter if they have a child selected. Issue #1735
2020-01-29 11:18:17 -07:00
b292ea97fc
Dismiss the search bar if next unread takes us out of the search timeline. Issue #1722
2020-01-28 17:16:49 -07:00
76aa603874
Change to no longer filter currently selected Feed. Issue #1728
2020-01-28 16:51:50 -07:00
ef79005d67
Change it so that we have the unread indicator and star hidden by default. Issue #1724
2020-01-27 22:26:49 -07:00
415fb3ab56
Fix it so that we aren't scrolling and selecting using the same animation.
2020-01-27 22:10:18 -07:00
6ac6136612
Make animations individually selectable and no longer animate navigation selections. Issue #1439
2020-01-27 21:57:52 -07:00
dd5633b5ae
Change to use the correct URL when reloading an image.
2020-01-27 16:27:13 -07:00
3a99e6430f
Make the article icon code specify the desired article so that it can't pull the wrong one by mistake. Issue #1707
2020-01-27 12:58:32 -07:00
470f2159e8
Remove dead code left from when WebViewController was split from ArticleViewController.
2020-01-27 11:50:28 -07:00
243ebac665
Merge pull request #1719 from hartlco/1709-wrong-vibrant-tap-down-state-text-colour-for-account-type-buttons
...
Fix vibrant colors on highlight inside AddAccountViewController and the timeline layout cell
2020-01-27 10:35:08 -08:00
99fbd2d1a1
Remove extraneous code that was causing the unread counts to sometimes not be displayed. Issue #1711
2020-01-27 11:28:59 -07:00
b8c1389bc6
Use VibrantBasicTableViewCell for Timeline layout cell to change label color on highlight/selection
2020-01-27 08:37:02 +01:00
7e9277f7d8
Use SettingsAccountTableViewCells inside AddAccountViewController for vibrant colors
2020-01-27 06:57:05 +01:00
72e886b709
Make extractor buttons higher animation while animating. Issue #1705
2020-01-26 22:32:18 -07:00
25daea8a9f
Create separate color for block quote bar. Issue #1718
2020-01-26 21:44:53 -07:00
bb05d9111e
Fix to use the correct count for currently selected row. Issue #1711
2020-01-26 21:34:50 -07:00
f2ac6ff1df
Add functionality to clear the timeline and article views if their respective items get collapsed or filtered. Issue #1708
2020-01-26 21:18:43 -07:00
97d6c69431
Change to always reload the page when rendering an article. Issue #1713
2020-01-26 20:29:58 -07:00
4a63b28c73
Change how next and previous articles are selected so that animation timings can't impact them. Issue #1707
2020-01-26 14:21:04 -07:00
bc5a8c3705
Reset scroll position when article is reset. Issue #1716
2020-01-26 13:01:03 -07:00
fdde6d0583
Make sure that the smart feed section is expanded before selecting the all unread feed. Issue #1673
2020-01-25 16:13:33 -07:00
b62f80e0ea
Removed unnecessary reloads that were crashing. Issue #1672
2020-01-25 15:51:34 -07:00
785775801a
Don't force cast scrollY as it might not always be set. Issue #1685
2020-01-25 15:36:43 -07:00
aa94fbeacf
Merge articles instead of replacing them for add remove feed and account functions. Issue #1692
2020-01-23 18:07:20 -07:00
e88643f9b9
Make tables obey Dynamic Type
2020-01-22 05:26:12 -06:00
f5c2fc4813
Pass all UTI types associated with OPML to the document picker for OPML imports. Issue #1684
2020-01-21 12:58:05 -07:00
050434023e
Fade out unread and star indicators when possible. Issue #1683
2020-01-21 11:41:03 -07:00
1f58161eeb
Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate
2020-01-21 11:05:58 -07:00
deab8f8c6c
Change to stop recycling the article view controller when switching panel modes on the iPad. Issue #1570
2020-01-21 11:05:47 -07:00
3635176d58
--table-border-color -> --table-cell-border-color; add Mac table styles
2020-01-20 21:59:40 -06:00
02297ed94a
Add table styles
2020-01-20 21:59:40 -06:00
ed355ad614
Update to allow all text types for importing OPML and make the error message more friendly. Issue #1443
2020-01-20 14:57:07 -07:00
61c854b031
Fix animation layer stripping. Issue #1668
2020-01-20 13:16:03 -07:00
fe75fb1aa4
Prevent swipe gestures on header cells from triggering the cell below. Issue #1661
2020-01-20 12:42:25 -07:00
5b2728aa10
Merge pull request #1667 from hartlco/1647-video-keeps-playing-after-swiping-to-another-article
...
Stop media playback when article will disappear
2020-01-20 10:56:14 -08:00
c2431cb48b
Add wordpress emoji style. Issue #1666
2020-01-20 11:53:06 -07:00
3370b834b0
Stop media playback when article will disappear
2020-01-20 19:46:23 +01:00
502f83ba2d
Set the scroll edge appearance to have the system background. Issue #1665
2020-01-20 11:43:26 -07:00
e183345f98
Stop suppressing the Confirm Mark as Read setting for iPads. Issue #1660
2020-01-19 23:12:02 -07:00
84844e6cef
Fix Feed deselection. Issue #1657
2020-01-19 18:36:23 -07:00
f15ade5ebb
Make the article datetime always a link to the article permalink. Issue #1655
2020-01-19 17:28:06 -07:00
8df8dfdb75
Update the Feeds list when a Feed's unread count gets above zero and the read filter is on. Issue #1550
2020-01-19 16:44:13 -07:00
7e35bd1ec4
Remove unused parameter. It was obsoleted, but not removed.
2020-01-19 15:36:19 -07:00
b1653845c2
Remove media selector from block quotes so that the new style is always used.
2020-01-19 13:23:45 -07:00
09c8ca9898
Remove unnecessary cell reload that was causing crashes. Issue #1535
2020-01-19 12:16:59 -07:00
88f565e03f
Use the DOM Y position to restore the scroll offset. This mostly fixes Issue #1494 .
2020-01-19 11:48:26 -07:00
110c7ae2e8
Merge pull request #1653 from hartlco/1238-iOS-Timeline-back-swipe-animation-error
...
Apply UINavigationBarAppearance appearance to scroll edge
2020-01-19 10:34:56 -08:00
5a6e0fd387
Apply UINavigationBarAppearance appearance to scroll edge
2020-01-19 19:22:36 +01:00
8e92cee13d
Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate
2020-01-18 18:24:29 -07:00
93f2c249e7
Change feed cell background color so that it can't be corrupted. Issue #1649
2020-01-18 18:24:18 -07:00
b150eaaff5
Update copyright year to 2020.
2020-01-18 11:53:22 -08:00
f0d8a9038d
Reload the web view every 10 renderings to clean it up. Issue #1487
2020-01-18 11:59:24 -07:00
d3ecb68708
Positions the footnote popover on top of other content
2020-01-17 13:41:12 -08:00
2e583ae7b2
Force the progress view label to update with content size changes. Issue #1645
2020-01-17 14:33:06 -07:00
a4896958c3
Merge pull request #1643 from Wevah/ios-candidate
...
Update to latest RSCore
2020-01-17 12:07:42 -08:00
34984551c6
Fully reload the page when the content size changes. Issue #1642
2020-01-17 12:53:50 -07:00
b35215d03b
Update for pending RSCore String updates
2020-01-17 13:45:38 -06:00
3c1668c178
Make Feedbin/Twitter video usable. Issue #718
2020-01-17 12:17:38 -07:00
df1b483996
Add Feedbin specific separator. Issue #1640
2020-01-17 10:56:59 -07:00
2cdec8c4bf
Add a leading border to block quotes so that they can more easily be distinguished. Issue #1639
2020-01-17 10:53:22 -07:00
f9e529bd3b
Fix multiwindow auto layout errors. Issue #1636
2020-01-16 21:29:10 -07:00
9a4ed6b198
Dismiss the keyboard on drag. Issue #1634
2020-01-16 20:30:53 -07:00
2584462bc1
Fix scrolling code so that it takes into consideration the content is under the bars now. Issue #1633
2020-01-16 19:40:13 -07:00
046162b303
Update the SceneCoordinator to use the same lookup method to determine if the node should be getting its unread count from the SceneCoordinator.
2020-01-16 15:24:48 -07:00
333da704aa
Fix regression that made customize timeline unselectable.
2020-01-16 14:44:30 -07:00
4f36ec3b11
Add Update Credetials button to the error dialog when a Feedbin credentials error happens. Issue #1441
2020-01-16 13:50:30 -07:00
f7017aaed5
Enable update credentials even when the account info hasn't changed on updates. Issue #1441
2020-01-16 12:04:40 -07:00
57af7526da
Revise Feedly tests to use MainThreadOperationQueue; get them building again. They don’t pass, but at least they build.
2020-01-15 22:10:06 -08:00
4eedd96507
Fix regression that prevented Safari from opening from Activity dialog.
2020-01-15 18:23:09 -07:00
bd29a030e5
Make sure that the imageWasShown message always gets posted, even if the web view got reloaded. Issue #1586
2020-01-15 18:09:47 -07:00
d68eccc55e
Exit search if Go To Feed is selected. Issue #1557
2020-01-15 17:53:12 -07:00
3e604e0b34
Load the feed article if the extracted article fails to parse. Issue #1542
2020-01-15 17:34:02 -07:00
c384362a78
Set extractor button state on viewDidLoad. Issue #1627
2020-01-15 17:28:37 -07:00
0d0b6b8fa6
Gives iOS a chance to open universal links. #1625
2020-01-16 09:56:51 +11:00
fadbd9d289
Merge pull request #1608 from myurieff/open-homepage-on-tap
...
Open homepage on tap
2020-01-14 14:22:33 -07:00
Maurice Parker
Stuart Breckenridge
Brian Sanders
Rizwan Mohamed Ibrahim
Jonathan Bennett
Nate Weaver
Brent Simmons
zgjie
Anh Do
Flowinho
Flowinho
Michele Volpato
Mihael Cholakov
Dan Morrison
Martin Hartl
Phil Dokas
Kiel Gillard