FreshRSS/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire.git synced 2024-12-12 17:36:19 +01:00
Code Issues Packages Projects Releases Wiki Activity
4,279 Commits 12 Branches 0 Tags 59 MiB
c0f76d0dbb
Commit Graph

4279 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Maurice Parker
c0f76d0dbb Change Mark All as Read icon. Issue #1526 2020-01-06 18:07:04 -07:00
Maurice Parker
7824939c30 Make OPML generate in a consistent order when the Web Feed name is the same. Issue #1545 2020-01-06 13:58:51 -07:00
Brent Simmons
f84abb81e2
Merge pull request #1538 from kielgillard/feedly-operation-string-keypaths 
Use string-based key paths instead of Swift key paths…
 2020-01-05 17:09:14 -08:00
Kiel Gillard
6922b6ddec Use string-based key paths instead of Swift key paths for FeedlyOperation. #1481 2020-01-06 08:59:08 +11:00
Brent Simmons
4184202806
Merge pull request #1533 from hartlco/1517-sharing-article-to-omnifocus-leaves-new-item-title-blank 
Share string with subject and URL instead of plain URL for Omnifocus and Things
 2020-01-05 12:54:03 -08:00
Martin Hartl
12731c2e39 Share string with subject and URL instead of plain URL for Omnifocus and Things 2020-01-05 07:36:30 +01:00
Brent Simmons
a405951f6d
Merge pull request #1529 from hartlco/1485-Add-mark-above-as-read-keyboard-shortcut 
Add keyboard shortcut for “Mark Above as Read” #1485
 2020-01-04 15:41:09 -08:00
Martin Hartl
d96a2b4097 Add keyboard shortcut for “Mark Above as Read” 2020-01-04 09:42:29 +01:00
Maurice Parker
5cd163e1e4 Add refresh indicator to the Timeline. Issue #15 2020-01-03 14:23:37 -07:00
Maurice Parker
5a7863d447 Rollback pull to refresh on the timeline and modified pull to refresh control. Issue #1520 2020-01-03 08:42:43 -07:00
Maurice Parker
b7f3612686
Merge pull request #1522 from hartlco/1485-Add-mark-below-mark-above-as-read 
Replace “Mark Older as Read” actions with “Mark Above/Below as Read” actions #1485
 2020-01-03 08:27:17 -07:00
Martin Hartl
5ee491ebee Replace “Mark Older as Read” actions with “Mark Above/Below as Read” actions 2020-01-03 09:00:25 +01:00
Maurice Parker
e26a00ddfe Enable pull to refresh on timeline and change refresh indicator to better show when it is successfully pulled. Issue #1520 2020-01-02 21:08:21 -07:00
Maurice Parker
c3fbf88fbb Add check so that we don't update article statuses for articles that we have pending statuses to send. Issue #1515 2020-01-02 18:21:18 -07:00
Brent Simmons
e773c11571
Merge pull request #1509 from timothyekl/account-test-api-updates 
Update Account tests for new async API
 2020-01-02 16:12:17 -08:00
Tim Ekl
44e920b18b Don't explicitly name error variables 
Following the resolution of #1512, start using the implicit `error`
variable inside `catch` blocks instead of explicitly declaring `e`
everywhere.
 2020-01-02 13:31:06 -08:00
Maurice Parker
c2d1f1c85a
Merge pull request #1514 from hartlco/1503-delete-should-be-at-the-bottom-of-the-context-menu 
Switch order of context menu items to show delete at the bottom #1503
 2020-01-02 11:02:37 -07:00
Martin Hartl
7b0261b401 Switch order of context menu items to show delete at the bottom 2020-01-02 08:16:29 +01:00
Brent Simmons
3d09345ea3 Update to latest RSParser, which fixes a crashing bug. 2020-01-01 22:25:40 -08:00
Brent Simmons
a5a3d9309b
Merge pull request #1511 from kielgillard/feedly-operation-fixup 
Indicate FeedlyOperation is asychronous.
 2020-01-01 15:19:01 -08:00
Kiel Gillard
2ee50054dc Indicate FeedlyOperations are asynchronous. 2020-01-02 10:00:09 +11:00
Kiel Gillard
f455bcec16 Models the feed website url of feedly articles as an optional since it seems the Feedly API will not always provide one. Issue #1449. 2020-01-02 09:34:24 +11:00
Tim Ekl
5ac18b14a7 Add missing expectations to send statuses tests 
f82be27666 flipped around calls to `selectPendingCount(_:)` so that it
respected the new async nature of the method; however, it neglected to
add enough XCTestExpectations to keep the test methods running through
the callbacks. Add those here.
 2020-01-01 13:39:17 -08:00
Brent Simmons
b9d68d4ac0 Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate 2019-12-31 18:59:04 -08:00
Brent Simmons
cea34c9e49 Update RSCore. 2019-12-31 18:58:57 -08:00
Brent Simmons
df13d108aa Update to latest RSCore. 2019-12-31 18:46:13 -08:00
Brent Simmons
fedfb24220
Merge pull request #1506 from Wevah/ios-blockquote-tweaks 
iPhone 8 Plus viewport is actually 414px wide
 2019-12-31 18:37:58 -08:00
Nate Weaver
53b2ebab78 iPhone 8 Plus viewport is actually 414px wide 2019-12-31 20:30:37 -06:00
Brent Simmons
c2a7f8501e
Merge pull request #1505 from Wevah/ios-blockquote-tweaks 
Don't shrink margins for wider viewports (e.g., landscape)
 2019-12-31 18:11:37 -08:00
Nate Weaver
b5467bb81c Don't shrink margins for wider viewports (e.g., landscape) 2019-12-31 20:08:40 -06:00
Brent Simmons
dcb6f06792
Merge pull request #1504 from Wevah/ios-blockquote-tweaks 
Tweak blockquote margins for small viewports
 2019-12-31 17:56:14 -08:00
Nate Weaver
95db828986 Tweak blockquote margins for small viewports 2019-12-31 19:47:09 -06:00
Tim Ekl
e4c84bc501 Add two missing expectation fulfillments 
It looks like two tests in FeedlySetStarredArticlesOperationTests
created but never referenced XCTestExpectation instances. Based on the
other nearby tests, add a call to `fulfill()` inside the associated
completion block after the rest of our test assertions are done.
 2019-12-31 19:41:32 -06:00
Tim Ekl
6c10774c4a Fix build errors stemming from FeedlyTestSupport 
There was one call to a throwing function inside
`checkArticles(in:correspondToStreamItemsIn:)` which was not
appropriately marked with `try`. Add that keyword, and then bubble out
the chain of errors through additional layers of helpers to the
enclosing test:

* This `checkArticles` variant was called by two others
* …one of which was used in `testAddNewFeedSuccess()`
* …another of which was used in various `verify` sync helpers
* …which were referenced from `testSyncing()`, a test case method

None of these involved any particular async hoops to jump through, and
since the top-level callers were all test functions, we can count on
XCTest to handle any errors thrown — no additional `catch` or handling
on our part is necessary.
 2019-12-31 19:36:42 -06:00
Tim Ekl
711aca3d1b Fix build errors in Feedly test support 
Two more cases of completion blocks taking Results, requiring a
do/catch/Result.get() to unwrap.

This commit deliberately leaves one build error for a more comprehensive
fix, since it occurs in a helper function that will have broader
fallout.
 2019-12-31 19:29:44 -06:00
Tim Ekl
152b1f2b8a Fix errors in Feedly sync unread operations tests 
Yet more completion blocks with Results; apply the usual
do/catch/Result.get() dance.
 2019-12-31 19:27:47 -06:00
Tim Ekl
13b227a461 Fix errors in Feedly set starred operations tests 
More of the same: completion blocks which take Results need
do/catch/Result.get().
 2019-12-31 19:24:36 -06:00
Tim Ekl
f12e8b4a4a Fix errors in starred articles operations tests 
Pull the same do/catch/Result.get() trick as previously for completion
blocks which now take Results. `try` a few throwing calls.
 2019-12-31 19:11:37 -06:00
Tim Ekl
6a4f3fb11e Fix build errors in sync stream operations tests 
Prefix two throwing calls with `try`. Label the enclosing test functions
with `throws` so the XCTest machinery helps us with error reporting.
 2019-12-31 19:08:29 -06:00
Maurice Parker
c2d298b836 Add the image title text to zoomed images. Issue #1468 2019-12-31 18:06:27 -07:00
Tim Ekl
6583688e38 Fix errors in Feedly unread operations tests 
Most fetch completion blocks took a parameter that was expected to be
some result data type, but is now a Result. Rename these parameters;
wrap their existing bodies in do/catch blocks; and recreate the original
underlying variable using the result of `Result.get()`.

Prepend a few synchronous calls that started throwing with `try` along
the way.
 2019-12-31 19:06:10 -06:00
Maurice Parker
0d915333e6 Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate 2019-12-31 17:06:32 -07:00
Maurice Parker
f0a5309786 Fix bug that prevented first article from being selected on iPad. 2019-12-31 17:06:13 -07:00
Maurice Parker
af76e44c0f Changed ArticleViewController to utilize UIPageViewController to provide gesture based navigation. 2019-12-31 16:55:39 -07:00
Brent Simmons
6d3cd0cc19 Update to build 24. 2019-12-31 15:40:31 -08:00
Brent Simmons
520ef3858a Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate 2019-12-31 15:40:10 -08:00
Brent Simmons
51faf77e59 Update isExecuting and isFinished in a way that should make NSOperationQueue happy. Hopefully this fixes a mystery crash bug. 2019-12-31 15:40:05 -08:00
Maurice Parker
0a29535412
Merge pull request #1496 from Wevah/table-overflow-wrapper 
Table overflow wrapper
 2019-12-31 16:24:43 -07:00
Tim Ekl
ae1651fad1 Fix errors in Feedly update-feeds operation tests 
Mark some throwing calls with `try`; mark the enclosing test functions
with `throws`, letting the XCTest framework handle error reporting for
us.
 2019-12-31 15:55:59 -06:00
Tim Ekl
f82be27666 Resolve errors in Feedly statuses operation tests 
Add `error` parameters to completion blocks which now pass them. Assert
these errors are always nil in the existing tests.

Flip calls to `selectPendingCount()` so they are async, with a
completion block that asserts about the results instead of asserting
about the return value. Since the closure takes a Result, unwrap it in a
do/catch block at each site; `XCTAssertNoThrow` doesn't help us bubble a
value out from `Result.get()`, and I'd rather not use `try!` here. There
might be a stylistic discussion to be had about this unwrapping, though.
 2019-12-31 15:52:54 -06:00