Commit Graph

1549 Commits

Author SHA1 Message Date
Daniel Jalkut aea529ae56 Work around case #550 by imposing the NSQuitAlwaysKeepsWindows default as true in NetNewsWire, despite what the user may have selected in the system-wide "Close windows when quitting" setting in General tab of System Preferences. 2019-02-15 17:40:05 -05:00
Brent Simmons a8924bf337
Merge pull request #549 from danielpunkass/state-restoration-improvements
Switch to standard state restoration mechanism
2019-02-15 10:40:41 -08:00
Daniel Jalkut c54d2f94cc Fix #547 by implementing state restoration in the sidebar and timeline view controllers. 2019-02-15 13:38:07 -05:00
Daniel Jalkut cd695848f0 Change split view state restoration from user defaults to standard window restoration mechanism. I don't think you need to include the manual window frame autosave name stuff either because I think it's automatically handled by AppKit's default state restoration. 2019-02-15 11:16:38 -05:00
Brent Simmons 193c34b9c2
Merge pull request #548 from danielpunkass/dark-mode-code-styles
Differentiate the color for code and pre blocks.
2019-02-15 07:50:49 -08:00
Daniel Jalkut 80cfc9c0fe Differentiate the color for code and pre blocks. 2019-02-15 09:34:12 -05:00
Brent Simmons d56b51a15a Update RSCore and RSWeb. 2019-02-12 18:12:25 -08:00
Brent Simmons 2dfec50261 Create and use DetailWebViewControllerDelegate. 2019-02-12 18:12:12 -08:00
Brent Simmons 15d682e0ff
Merge pull request #545 from danielpunkass/fix-public-attrs
Quiet warnings/errors from Xcode 10.2 about redundant public attribut…
2019-02-12 12:13:19 -08:00
Daniel Jalkut ddb0ee21b6 Quiet warnings/errors from Xcode 10.2 about redundant public attributes on methods implemented inside public extensions. 2019-02-12 10:05:51 -05:00
Brent Simmons 7566490e56 Update RSCore. 2019-02-11 22:43:50 -08:00
Brent Simmons 9b92fcfc2c Make baseURL a private extension computed var for Article. 2019-02-11 22:43:04 -08:00
Brent Simmons 350ab27371 Start DetailWebViewController. This is part of working on the search feature. We’ll need two separate web views — one for search results, one for normal use. 2019-02-11 22:36:31 -08:00
Brent Simmons 4a8634c0e8 Import AppKit instead of Cocoa in the hopes of not getting the Swift Core Data library added (since we’re not using Core Data). 2019-02-11 22:35:42 -08:00
Brent Simmons 8de4ff4ee3 Rationalize the ArticleRenderer API. 2019-02-10 22:06:03 -08:00
Brent Simmons 9d9afea52a Simplify articles and article variables. 2019-02-10 21:46:53 -08:00
Brent Simmons 1498823c20 Simplify communication with DetailStatusBarView. 2019-02-10 21:39:11 -08:00
Brent Simmons a74e0762e7 Simplify the view hierarchy for the detail view — remove one unneeded view. 2019-02-10 20:51:28 -08:00
Brent Simmons c23bdc74cb Delete some commented-out code. 2019-02-10 17:47:17 -08:00
Brent Simmons 5dbf194875 Delete some commented-out text. 2019-02-10 17:16:23 -08:00
Brent Simmons 7f4634b790 Get rid of TimelineContextualMenuDelegate. 2019-02-10 16:47:46 -08:00
Brent Simmons 68af34e397 Remove some commented-out code. 2019-02-10 16:36:56 -08:00
Brent Simmons 26ae039b91 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-02-10 12:27:32 -08:00
Brent Simmons 583ca1ac01 Move the sidebar contextual menu handling into SidebarViewController. 2019-02-10 12:27:22 -08:00
Brent Simmons 8bcd310e2c
Merge pull request #540 from rex4539/typos
Fix typos
2019-02-10 12:19:00 -08:00
Dimitris Apostolou e475be27c1
Fix typos 2019-02-10 11:02:22 +02:00
Brent Simmons b910bdbf49 Remove some unused code. 2019-02-09 22:41:21 -08:00
Brent Simmons 39d07aec2e Remove MainWindowSplitView, which was unused. 2019-02-09 22:28:33 -08:00
Brent Simmons 8cb3658a78 Remove some old instances of fileprivate. 2019-02-09 22:22:12 -08:00
Brent Simmons 2d79253be5 Remove some unused code. 2019-02-09 22:19:25 -08:00
Brent Simmons c40efd2c89 Remove some unused code. 2019-02-09 22:09:38 -08:00
Brent Simmons b22a965777 Update version and appcast for 5.0d15. 2019-02-09 21:29:56 -08:00
Brent Simmons df768da253 Stop using the builtin textField and imageView in the sidebar cell — this fixes the drag image issue. Fix #532. 2019-02-09 18:54:16 -08:00
Brent Simmons 1c2759dd2b Skip reloading HTML in the detail view when the article is set and it’s the same article that was already set. 2019-02-09 12:15:05 -08:00
Brent Simmons 064ef20c19 Update appcast for 5.0d14. 2019-02-08 22:11:24 -08:00
Brent Simmons 59c879312a Bump version to 5.0d14. 2019-02-08 21:57:33 -08:00
Brent Simmons 8a5428c1cf Discard future dates. Fix #538. 2019-02-08 21:54:45 -08:00
Brent Simmons 1466f7e919 Fix bug getting unread count for the Today smart feed — it would skip articles with no pubDate, but that did arrive today (and thus should be considered as part of Today). 2019-02-08 21:05:55 -08:00
Brent Simmons 7f82f9d607 Fix a bug where articles with changed dates wouldn’t update in the database. Make the code a bit more clear, too. 2019-02-08 20:41:46 -08:00
Brent Simmons 4d3bceda93 Skip reloadData in TimelineViewController when the articles array represents the same articles as the previous array. Just reload visible cells in that case. 2019-02-08 19:53:41 -08:00
Brent Simmons 58012a97f3 Remove unused code. 2019-02-07 22:45:19 -08:00
Brent Simmons 0e31e526e4 Remove unused code from TimelineTableView. 2019-02-07 22:27:26 -08:00
Brent Simmons 7184f8c439 Remove unused code from TimelineTableRowView. 2019-02-07 22:24:41 -08:00
Brent Simmons 2ece915ac3 Do less work in timeline table cell views, which should make scrolling imperceptibly faster. 2019-02-07 22:01:31 -08:00
Brent Simmons 6f41b2a728 Queue saving to disk, in Account, even during refresh. 2019-02-07 21:29:05 -08:00
Brent Simmons 6fba06425c Allow for a drop-on index when dragging a single local feed. 2019-02-07 21:27:24 -08:00
Brent Simmons 04270aaad7 Make the rows in the sidebar a little taller, to provide some breathing room. Fix #534. 2019-02-07 21:07:40 -08:00
Brent Simmons 6c421015cc Update appcast for 5.0d13. 2019-02-06 22:09:24 -08:00
Brent Simmons eb3c69f4d0 Don’t write "Untitled" to Subscriptions.opml when a feed lacks a name or editedName — “Untitled” is a localizable, display-only string, not something to store in OPML. Fix #527. 2019-02-06 21:18:22 -08:00
Brent Simmons aadf4ec09f Don’t set feed.editedName when importing OPML in Account. 2019-02-06 21:17:17 -08:00