Commit Graph

584 Commits

Author SHA1 Message Date
Maurice Parker 09652bff81 Remove Mark Read on Scroll code 2021-12-29 14:44:40 -08:00
Maurice Parker 06eae25797
Merge pull request #3329 from everhardt/feat-1844-scroll-mark-as-read
Add mark as read on scroll
2021-11-04 12:04:53 -05:00
Maurice Parker c26f09ad1c Fix bug that prevented us from returning to the original text size 2021-11-01 21:24:56 -05:00
everhardt 96ffa3aa22 Do not mark as read without user interaction 2021-10-30 18:57:04 +02:00
everhardt 5364b4f384 Mark bottom items in feed as read after 2 seconds on Mac
In case markArticlesAsReadOnScroll is set
2021-10-30 10:58:12 +02:00
everhardt 3b6a3cf4e7 Do not mark articles as read on scroll when they were manually toggled 2021-10-30 10:37:10 +02:00
everhardt 8bce42df56 Change scrollPositionQueue in Mac TimelineViewController to private 2021-10-27 22:21:42 +02:00
everhardt 3db1b60b65 Add Mac setting for mark as read on scroll 2021-10-27 22:03:38 +02:00
everhardt 7b8bed9ac2 Add mark as read on scroll functionality
Does not yet include a setting
2021-10-27 20:52:26 +02:00
Maurice Parker 6e54598547 Fix type that caused a compile error 2021-09-30 09:43:32 -05:00
Duncan Babbage f6552e110d Replace raw with repaired links. Fixes #3103 2021-09-30 16:52:00 +13:00
Duncan Babbage cc855f3832 link and URL vars for Article. Storage as rawLink
link and externalLink fall back to providing the raw stored value if URLs cannot be created even with repair.
2021-09-30 16:51:59 +13:00
Maurice Parker 4a3934fd28 Add ellipsis to Add context menu 2021-09-23 11:57:47 -05:00
Maurice Parker b43d8b6b28 Change reload so that the text size style can be used in more places. 2021-09-17 15:59:43 -05:00
Maurice Parker de956f9473 Change to use JavaScript to detect scroll events as it will also capture scrollbar events 2021-09-13 21:03:27 -05:00
Maurice Parker 2c801a388c Restore the article scroll position when restarting NetNewsWire 2021-09-13 20:42:58 -05:00
Maurice Parker 87700325cf Changed to use preferredURL incase we run into any malformed links 2021-09-12 21:34:47 -05:00
Maurice Parker fa4b2531f8
Merge pull request #3102 from robmathers/copy-url-menu-options
Add Copy Article URL & Copy External URL Menu Items. Fixes #1285.
2021-09-12 21:17:50 -05:00
Maurice Parker abd66ea1bb Maintain scroll position when changing themes 2021-09-11 20:53:57 -05:00
Maurice C Parker c031aa5cbe Add popup button for selecting article themes on Catalina 2021-09-09 05:47:49 -05:00
Maurice Parker 39c9cc440c Add optional article theme toolbar item 2021-09-08 19:58:40 -05:00
Maurice Parker 596202fc33 Reload the article if the theme changes 2021-09-08 15:55:42 -05:00
Maurice Parker b568f03edc Unify the stylesheets into a single one to make building themes easier 2021-09-08 04:58:26 -05:00
Maurice Parker 512e83d786 Refactor Styles to now be Themes 2021-09-07 16:58:06 -05:00
Daniel Jalkut 2e652351ec Implement the WKUIDelegate method that is reached when JavaScript in a web view invokes window.open(). This ensures that attempts to open links from code, such as from the YouTube embedded video player, work as expected. Fixes #3088. 2021-07-27 17:34:48 -04:00
Maurice Parker f9af3c786b Merge branch 'ios-candidate' 2021-05-25 20:12:50 -05:00
Brent Simmons 9d2c8f000f Create and use IconImageCache. It centralizes and de-dupes logic for getting feed/article images, and it caches the results, which helps performance. 2021-05-08 12:42:44 -07:00
Rob Mathers 8707a71313 Add Copy Article URL & Copy External URL Menu Items
The Mac items display in the edit and contextual menus, and in the iOS contextual menu for an article.
2021-05-01 16:47:39 -04:00
Chris Campbell 364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
Chris Campbell bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
Duncan Babbage 9092d075a0 Handle links with unencoded spaces. Fixes #3069 2021-04-28 22:49:32 +12:00
Stuart Breckenridge 5af2643479
standardised naming 2021-04-19 11:21:00 +08:00
Stuart Breckenridge d4130e7c65
Corrects naming convention
[iOS]
Twitter: Notify about new tweets
Reddit: Notify about new posts
Default: Notify about new articles
+ Fixes alignment issues in the inspector view

[macOS]
Twitter: Show notifications for new tweets
Reddit: Show notifications for new posts
Default: Show notifications for new articles
2021-04-19 11:10:57 +08:00
Maurice Parker 77dd2e5e22 Merge branch 'mac-release' into main 2021-04-15 14:31:52 -05:00
Maurice Parker 3955151daf Make sure mark as read completes before searching for the next unread. Fixes #2952 2021-04-15 14:29:49 -05:00
Stuart Breckenridge 4e517a6db4
Disable Reader View
This commit:
- adds a `isFeedProvider: Bool` property to `WebFeed`
- if `isFeedProvider` is `true`, the article extractor is disabled on the inspector, hidden from the context menu, and the toolbar button is disabled. Additionally, if `isFeedProvider` is `true`, `isArticleExtractorAlwaysOn` returns `false` and cannot be set to `true`.
2021-04-09 07:47:14 +08:00
Maurice Parker b1a0b649a5
Merge pull request #2972 from j-f1/read-unread
Update swipe actions on macOS to match iOS
2021-04-07 03:47:27 -05:00
Jed Fox 3609b6f977
Add labels to swipe actions to match iOS 2021-04-06 17:34:05 -04:00
Maurice Parker ea6cece955 Merge branch 'mac-release' into main 2021-04-03 09:30:42 -05:00
Maurice Parker 1ab727a128 Make symbol images images scale correctly. Fixes #2957 2021-04-01 11:12:48 -05:00
Jed Fox 4750e9b93a
Add dir=auto to page.html 2021-03-29 17:20:09 -04:00
Maurice Parker 95234706e1 Fix issue where next unread wasn't wrapping around. Fixes #2942 2021-03-29 14:33:08 -05:00
Maurice Parker fb9114538c Modified the Timeline so that it can handle duplicate articleIDs 2021-03-28 06:30:49 -05:00
Maurice Parker ab5421f533 Merge branch 'mac-release' into main 2021-03-27 17:21:49 -05:00
Maurice Parker 42e6e1397d Signal that the mouse exited the link when an article gets reloaded. Fixes #2877 2021-03-15 20:14:30 -05:00
Maurice Parker 78b9444274 Remove extra unused parameter in delegate signature 2021-03-15 20:10:42 -05:00
Maurice Parker 52f11ff538 Add validateFeed parameter to createWebFeed 2021-03-15 18:01:12 -05:00
Maurice Parker f1e4d70481 Simplify the folder copy logic 2021-03-15 17:47:53 -05:00
Maurice Parker d57cb7b21f Delete obsolete code 2021-03-15 17:35:23 -05:00
Maurice Parker 7e4e7091e2 Delete obsolete code 2021-03-15 17:33:12 -05:00