129 Commits

Author SHA1 Message Date
Brent Simmons
aa807249b9 Make ArticleExtractor reference SecretKey instead of passing in secrets. Remove unused imports of Secrets. 2024-07-07 15:48:56 -07:00
Brent Simmons
445306ef2a Get rid of SecretsProvider protocol. Stop passing secretsProvider around — just use SecretKey.whatever static properties. 2024-07-07 15:38:45 -07:00
Brent Simmons
90311f0e70 Make Secrets Sendable. Rename Id to ID. 2024-07-07 12:14:14 -07:00
Brent Simmons
e990b7aab1 Get the app delegate the old-fashioned way. 2024-06-30 18:06:49 -07:00
Brent Simmons
308a91cf4f Go back to CoalescingQueue because it was simpler to use than PostponingBlock. 2024-06-12 20:55:13 -07:00
Brent Simmons
7dc0d6cb23 Use queueMakeToolbarValidate. 2024-06-12 19:48:48 -07:00
Brent Simmons
57ac2d6b02 Use weak self in postponingBlock. 2024-06-12 17:55:24 -07:00
Brent Simmons
a91fd53100 Reorder arguments to PostponingBlock.init. 2024-06-12 17:48:51 -07:00
Brent Simmons
fba8c52b67 Convert several methods to async await. 2024-05-05 17:08:30 -07:00
Brent Simmons
300ffbb711 Create ArticleExtractor module. 2024-04-07 15:05:38 -07:00
Brent Simmons
6e8eecb6a9 Make ArticleExtractor MainActor; make it forget about SecretsProvider and the Secrets module. 2024-04-01 22:40:27 -07:00
Brent Simmons
f5c930a024 Mark MainWindowController as final. 2024-03-24 21:08:59 -07:00
Brent Simmons
2461e937bf Replace RSCore with several local modules. Update code as needed. 2024-03-20 20:49:15 -07:00
Brent Simmons
d0760f3d12 Continue fixing concurrency warnings. 2024-03-19 23:05:30 -07:00
Brent Simmons
78047fcaf7 Get rid of SecretsManager. It wasn’t thread-safe, and it existed only for tests (and it wasn’t thread-safe for tests either). Pass SecretsProvider parameter where it’s needed. 2024-03-10 22:22:41 -07:00
Ethan Wong
711eeddecc Do not make the sidebar first responder when it’s collapsed. 2024-02-27 22:16:38 -08:00
Brent Simmons
4c866b7230 Rename WebFeed and webFeed to Feed and feed. 2024-02-25 23:12:21 -08:00
Brent Simmons
b705433270 Rename WebFeed to Feed. 2024-02-25 21:41:18 -08:00
Brent Simmons
aca541dcc9 Remove no-longer-needed #available(macOS 11.0, *) checks. 2023-12-13 19:59:31 -08:00
Brent Simmons
7078e6fd55 Remove OAuthSwift and its dependencies. 2023-06-26 09:57:22 -07:00
Brent Simmons
fb51185c05 Remove references to isFeedProvider. 2023-06-25 16:15:21 -07:00
Brent Simmons
49549484af Rename New Web Feed to New Feed. 2023-06-25 15:30:57 -07:00
Brent Simmons
d232cf43c7 Remove showAddRedditFeedWindow function and all references to it. 2023-06-25 15:26:37 -07:00
Maurice Parker
6c1e1ea1c6 Remove Twitter integration. Fixes #3842 2023-02-03 19:00:13 -08:00
Dimitris Apostolou
94ae4d348c
Fix typos 2022-01-05 00:25:20 +02:00
Duncan Babbage
f6552e110d Replace raw with repaired links. Fixes #3103 2021-09-30 16:52:00 +13:00
Duncan Babbage
cc855f3832 link and URL vars for Article. Storage as rawLink
link and externalLink fall back to providing the raw stored value if URLs cannot be created even with repair.
2021-09-30 16:51:59 +13:00
Maurice Parker
4a3934fd28 Add ellipsis to Add context menu 2021-09-23 11:57:47 -05:00
Maurice Parker
2c801a388c Restore the article scroll position when restarting NetNewsWire 2021-09-13 20:42:58 -05:00
Maurice Parker
87700325cf Changed to use preferredURL incase we run into any malformed links 2021-09-12 21:34:47 -05:00
Maurice Parker
fa4b2531f8
Merge pull request #3102 from robmathers/copy-url-menu-options
Add Copy Article URL & Copy External URL Menu Items. Fixes #1285.
2021-09-12 21:17:50 -05:00
Maurice C Parker
c031aa5cbe Add popup button for selecting article themes on Catalina 2021-09-09 05:47:49 -05:00
Maurice Parker
39c9cc440c Add optional article theme toolbar item 2021-09-08 19:58:40 -05:00
Rob Mathers
8707a71313 Add Copy Article URL & Copy External URL Menu Items
The Mac items display in the edit and contextual menus, and in the iOS contextual menu for an article.
2021-05-01 16:47:39 -04:00
Maurice Parker
77dd2e5e22 Merge branch 'mac-release' into main 2021-04-15 14:31:52 -05:00
Maurice Parker
3955151daf Make sure mark as read completes before searching for the next unread. Fixes #2952 2021-04-15 14:29:49 -05:00
Stuart Breckenridge
4e517a6db4
Disable Reader View
This commit:
- adds a `isFeedProvider: Bool` property to `WebFeed`
- if `isFeedProvider` is `true`, the article extractor is disabled on the inspector, hidden from the context menu, and the toolbar button is disabled. Additionally, if `isFeedProvider` is `true`, `isArticleExtractorAlwaysOn` returns `false` and cannot be set to `true`.
2021-04-09 07:47:14 +08:00
Maurice Parker
95234706e1 Fix issue where next unread wasn't wrapping around. Fixes #2942 2021-03-29 14:33:08 -05:00
Maurice Parker
25ee970562 Remove async call since the Big Sur bug that it was working around appears to be fixed. Fixes #2791 2021-02-22 12:17:43 -06:00
Maurice Parker
04736ded79 Update the title bar when searching 2020-11-19 16:21:51 -06:00
Maurice Parker
97bbb9d9d9 Put unread articles button in the toolbar. Issue #2581 2020-11-19 12:10:42 -06:00
Maurice Parker
117f6ccf6f Reorder code to match new toolbar order 2020-11-19 11:31:58 -06:00
Maurice Parker
88c33283bf Move search bar to the right side of the toolbar and put icons in the same order as they are on iOS. Fixes #2583 2020-11-19 11:29:56 -06:00
Maurice Parker
8b7d7798ff Flip the order of mark all as read and search toolbar items 2020-11-09 15:26:14 -06:00
Maurice Parker
d397f1627c Scale button images down so that PDF button images look correct when the small size icons are selected. 2020-11-09 13:02:46 -06:00
Daniel Jalkut
1ced4448ea Support a new secret user default JalkutRespectFolderExpansionOnNextUnread, and revise the "next unread" strategy so that whether the search for a next unread wraps around to the top or not is parameterized. 2020-11-01 17:33:48 -05:00
Maurice Parker
4284ea26c8 Merge branch 'mac-release' into main 2020-10-18 16:37:00 -05:00
Maurice Parker
2772b5e36d Make current window key and front if we are opening Safari in the background. Issue #2427 2020-09-23 18:30:34 -05:00
Maurice Parker
e575aeca3c Restore functionality to mark older as read using keyboard shortcut. Issue #2451 2020-09-22 19:42:14 -05:00
Maurice Parker
7c7b128380 Fix subtitle for scenario where multiple are selected. 2020-09-02 13:00:09 -05:00