Commit Graph

4697 Commits

Author SHA1 Message Date
Maurice Parker 9533999778
Merge pull request #1906 from Ranchero-Software/revert-1905-post-body-fix
Revert "Make sure POST body is properly URL-encoded"
2020-03-14 02:49:50 -05:00
Maurice Parker 8384725b01
Revert "Make sure POST body is properly URL-encoded" 2020-03-14 02:48:37 -05:00
Maurice Parker d01fa0428a
Merge pull request #1905 from Wevah/post-body-fix
Make sure POST body is properly URL-encoded
2020-03-14 02:47:52 -05:00
Nate Weaver aed6858043 Simplify .utf8 2020-03-13 22:16:24 -05:00
Nate Weaver 3af70f5c7c Make sure POST body is properly URL-encoded 2020-03-13 22:12:36 -05:00
Maurice Parker 66e7e425aa Remove obsolete code that could be causing the feed unread counts to not update. Issue #1806 2020-03-13 17:06:53 -05:00
Maurice Parker 833c336f2f Only show the timeline next read button when the root split view controller is collapsed. Issue #1822 2020-03-13 16:03:42 -05:00
Maurice Parker 49257970af Removed testing code. Issue #1810 2020-03-13 15:35:33 -05:00
Maurice Parker 2240058fe8
Merge pull request #1850 from mvolpato/bugfix-progress-indicator-max-width
Bugfix progress indicator max width
2020-03-13 15:31:30 -05:00
Maurice Parker 7922efab1e
Merge pull request #1899 from flowinho/ios-release
Hide articleExtractor and actionBarButtonItem
2020-03-13 15:13:33 -05:00
Flowinho ce428d2cc6 Hide articleExtractor and actionBarButtonItem 2020-03-13 20:21:18 +01:00
Maurice Parker cc0fd50ea2 Make podcast URL's have a lower priority than other URL's. Issue #1897 2020-03-13 12:57:43 -05:00
Maurice Parker fe31ca8076 Normalize the URL if it was found in the HTML metadata. Issue #1896 2020-03-13 12:15:35 -05:00
Maurice Parker 73e7fb40ed Fixed macOS compile error for new brightness code detection. 2020-03-13 10:51:49 -05:00
Maurice Parker e0f8f7c5eb Increase brightness threshold to reduce false positives. Issue #1731 2020-03-13 10:45:02 -05:00
Maurice Parker 52be6e5743 Darken light mode icon color so that it contrasts better against pure white icons. Issue #1731 2020-03-13 10:17:00 -05:00
Maurice Parker d0cf04bd4f
Merge pull request #1892 from flowinho/ios-release
Add background to pure white icons
2020-03-13 10:04:56 -05:00
Flowinho 130691db34 Revert to old logic 2020-03-13 14:21:38 +01:00
Flowinho ee86b1a148 Apply background if feed-icon is bright 2020-03-13 11:54:31 +01:00
Flowinho d282181269 Add isBright function to Shared Logic 2020-03-13 11:43:17 +01:00
Maurice Parker 77fd3020cc Correct font used to specify font size. Issue #1878 2020-03-12 19:01:10 -05:00
Maurice Parker 7f20079e4d
Merge pull request #1826 from Wevah/footnote-fixes
Footnote fixes
2020-03-12 18:35:27 -05:00
Nate Weaver 781dd2ff73 Fix null error in wrapTables() 2020-03-12 18:32:42 -05:00
Nate Weaver 5bbda2a68e "footnotes" -> ".footnotes"; use idFromHash() 2020-03-12 18:32:42 -05:00
Nate Weaver 76dd3abff2 Properly style footnotes that have been absoluted 2020-03-12 18:32:42 -05:00
Nate Weaver 509ef01213 URL-decode the ID to make it work with non-ASCII characters
Fixes #1812.
2020-03-12 18:32:42 -05:00
Maurice Parker dfdf19e17f Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-03-12 18:07:49 -05:00
Maurice Parker 61a2e95d2b Manually specify the font size to work around a WKWebView resizing bug. Issue #1878 2020-03-12 18:07:40 -05:00
Maurice Parker c19bf93586
Merge pull request #1890 from flowinho/ios-release
Align feedname and date correctly if there is no title or summary
2020-03-12 17:03:58 -05:00
Flowinho 0a3713e078 Align feedname and date correctly if there is no title or summary 2020-03-12 22:57:30 +01:00
Maurice Parker 47e42fab0a Removed old debugging statement. 2020-03-12 16:01:13 -05:00
Maurice Parker 5783ff48fc
Merge pull request #1889 from flowinho/ios-release
Fixes close button icon distortion
2020-03-12 16:00:22 -05:00
Flowinho da64f65c7b Fixes close button icon distortion
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.

- Set content-mode of the buttons imageview to scaleAspectFit.
2020-03-12 21:54:50 +01:00
Maurice Parker 9cab5ca46c
Merge pull request #1888 from flowinho/ios-release
Adding dynamic width algorithm to the titleLabel
2020-03-12 15:34:01 -05:00
Flowinho feacda1c3b HOTFIX silly me 2020-03-12 21:33:02 +01:00
Flowinho 91247b7f16 Adding dynamic width algorithm to the titleLabel
This commit adds multiple functionalities at once:

- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).

The title label now resizes itself depending on the devices it’s displazed on.

- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.

The numbers are derived from my personal preference when implementing it.
2020-03-12 21:23:57 +01:00
Maurice Parker 429a48dd2a
Merge pull request #1884 from flowinho/ios-release
Added missing constraints to the UISwitch elements
2020-03-12 12:13:06 -05:00
Flowinho 97c79202fc Added missing constraints to the UISwitch elements 2020-03-12 17:56:43 +01:00
Maurice Parker 22b9e7b54b Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883 2020-03-11 19:45:45 -05:00
Maurice Parker 27b1443def Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881 2020-03-11 18:17:09 -06:00
Maurice Parker 76d5f4a073 Remove flush and restore of web view queues. Issue #1882 2020-03-11 17:02:16 -06:00
Maurice Parker 38981d01bd Don't remove items from Feeds list when batch update is performed. Issue #1879 2020-03-11 15:19:55 -06:00
Maurice Parker 9007ed4b06 Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834, #1856, and #1845 2020-03-11 14:47:00 -06:00
Maurice Parker 326322ead6
Merge pull request #1876 from flowinho/ios-candidate
iOS: Account Login Field should switch first responder on return #1870
2020-03-11 11:23:48 -06:00
Flowinho b178fe93af Call action on return if password was added
This is an obvious change.
2020-03-11 14:02:06 +01:00
Flowinho 66fae15f64 Remove redundant code to lessen LOC
- Less code - less bugs.
- Also resign the first responder when the user presses the action button
2020-03-11 13:43:02 +01:00
Flowinho 386efd632b Changing UIContentType from username to email adress
Add responder switch to streamline login flow

This change achieves two things:

- When the user presses Return and the email field is selected, the cursor now switches to the password field (as expected by the user).
- It enables iOS to pick up login and password field and enables password autofill.
2020-03-11 13:43:02 +01:00
Brent Simmons dc99d5b071 Bump version to 39. 2020-03-04 13:27:29 -08:00
Maurice Parker 7d8feba24b Remove file coordinator usage from account files. Issue #1821 2020-03-03 11:39:04 -08:00
Michele Volpato ee0f982e93 Remove unneeded whitespaces 2020-03-02 22:33:59 +01:00