Commit Graph

604 Commits

Author SHA1 Message Date
Maurice Parker 1ac4ec6e3c Fork MainWindow.storyboard so that we stop Catalina and Big Sur from stepping all over each other. 2020-12-06 15:21:30 -06:00
Maurice Parker ef18600acc Separate background suppression from symbol processing. Fixes #2646 & Fixes #2635 2020-12-06 14:25:22 -06:00
Brent Simmons 863ba726ad Don’t draw separators by default. (Yes, I changed my mine.) 2020-12-05 16:26:18 -08:00
Maurice Parker a0aad21385 Rebuild Sidebar outline view to try to fix Catalina problems 2020-11-20 15:02:23 -06:00
Maurice Parker e32c38f327 Fix clipping on popup menu. Fixes #2588 2020-11-19 17:27:11 -06:00
Maurice Parker 33cd254dad Fix bug where emulated separator continually was added to the row 2020-11-19 16:25:06 -06:00
Maurice Parker 04736ded79 Update the title bar when searching 2020-11-19 16:21:51 -06:00
Maurice Parker bc7692f4ba Change the separator to a custom separator color because the system color for dark mode was just too much. 2020-11-19 13:53:51 -06:00
Maurice Parker 006586ada6 Correctly align separator with contents of cell. Issue #2592 2020-11-19 13:44:08 -06:00
Maurice Parker 97bbb9d9d9 Put unread articles button in the toolbar. Issue #2581 2020-11-19 12:10:42 -06:00
Maurice Parker 117f6ccf6f Reorder code to match new toolbar order 2020-11-19 11:31:58 -06:00
Maurice Parker 88c33283bf Move search bar to the right side of the toolbar and put icons in the same order as they are on iOS. Fixes #2583 2020-11-19 11:29:56 -06:00
Maurice Parker c2d0dac62c Hide the Timeline sort and filter on Big Sur. Fixes #2582 2020-11-19 11:16:07 -06:00
Maurice Parker 8fd3cd2cde Rework cell background selection and separators to remove separator drawing artifacts and use the inset table style. Fixes #2579, #2580 and #2584 2020-11-18 22:02:54 -06:00
Maurice Parker eb5e85cbcf Set table view to style plain to avoid Big Sur's big margins. Fixes #2584 2020-11-18 20:49:32 -06:00
Maurice Parker f7574dc633 Tweak the sidebar image sizes so that they match the system apps as it looks like the HIG has the wrong values in it for sidebar image sizes 2020-11-15 15:18:33 -06:00
Maurice Parker 65510b1901 Merge branch 'mac-release' into main 2020-11-13 07:15:26 -06:00
Maurice Parker 8b7d7798ff Flip the order of mark all as read and search toolbar items 2020-11-09 15:26:14 -06:00
Maurice Parker d397f1627c Scale button images down so that PDF button images look correct when the small size icons are selected. 2020-11-09 13:02:46 -06:00
Brent Simmons e297a53eb2 Fix out-of-index crash by guarding against a 0-length string. 2020-11-06 17:03:20 -08:00
Maurice Parker e8238c03f2 Don't enable the Add button unless all conditions for an Add have been met. Fixes #2555 2020-11-05 10:34:26 -06:00
Maurice Parker c558731de8 Reduce size of article left and right padding 2020-11-04 12:30:29 -06:00
Maurice Parker 948998382d Make article view text adjustable via the app preferences. Fixes #42 2020-11-03 17:08:56 -06:00
Maurice Parker 0338a3bda4 Remove deprecation warning 2020-11-02 19:43:29 -06:00
Maurice Parker caeebfc89e Extend Article with PasteboardWriterOwner so that timeline copying works as it was intended to. Issue #963 2020-11-02 19:33:56 -06:00
Maurice Parker 5900b748be Filter the NetNewsWire share menu item from the NetNewsWire share menu 2020-11-02 16:27:13 -06:00
Daniel Jalkut 1ced4448ea Support a new secret user default JalkutRespectFolderExpansionOnNextUnread, and revise the "next unread" strategy so that whether the search for a next unread wraps around to the top or not is parameterized. 2020-11-01 17:33:48 -05:00
Maurice Parker 2395c0c7df Correct validation so that we can still move feeds in Reader API accounts 2020-10-31 17:37:25 -05:00
Maurice Parker 5fdbd4b9d0 Fixed misleading variable name 2020-10-31 17:31:48 -05:00
Maurice Parker cbb481c3f7 Don't allow a feed to be in more than one folder for Reader API accounts 2020-10-31 17:26:43 -05:00
Maurice Parker 3aad0b5075 Remove no longer needed system events. Fixes #2537 2020-10-30 09:44:24 -05:00
Maurice Parker c75dc8b54d Make sure that the error is displayed after the progress window is ended by doing an DispatchQueue.main.async on the error display. 2020-10-25 15:17:02 -05:00
Maurice Parker 0a01a9f501 Display "(No Text)" if there isn't a title or summary for the timeline. Fixes #2391 2020-10-23 19:18:35 -05:00
Maurice Parker d735ae91dc Add a confirmation alert for the delete context menu so that it matches other delete functionality. 2020-10-23 16:54:20 -05:00
Maurice Parker 065236ada3 Fix row background color. Issue #2503 2020-10-18 18:28:19 -05:00
Maurice Parker 34a2860c97 Fix row background color. Issue #2503 2020-10-18 18:27:36 -05:00
Maurice Parker 40d5625bd6 Use the correct error asset. 2020-10-18 17:04:30 -05:00
Maurice Parker 4284ea26c8 Merge branch 'mac-release' into main 2020-10-18 16:37:00 -05:00
Maurice Parker dc35037740 Remove CSS rule that was interfering with Newsfoot styling 2020-09-29 07:35:05 -05:00
Maurice Parker 46743a0f49 Simplified the delete titles. 2020-09-28 20:28:53 -05:00
Maurice Parker aaff359609 Provide verification dialog for deletes. Issue #1789 2020-09-28 19:50:31 -05:00
Maurice Parker 2772b5e36d Make current window key and front if we are opening Safari in the background. Issue #2427 2020-09-23 18:30:34 -05:00
Maurice Parker e575aeca3c Restore functionality to mark older as read using keyboard shortcut. Issue #2451 2020-09-22 19:42:14 -05:00
Maurice Parker fe39863858 Add width constraint to extractor button so that it doesn't move around on the most recent Big Sur beta's 2020-09-18 18:04:46 -05:00
Maurice Parker 3fed4774e3 Make the All Unread feed eligible for the Clean Up command. Issue #2417 2020-09-13 16:35:51 -05:00
Maurice Parker c580877a86 Change to utilize ArticleFetchers instead of Feeds so that the single article fetcher stops getting filtered out. Issue #2416 2020-09-12 18:09:42 -05:00
Maurice Parker feba4a7bc6 Change to respect individual feed filters when multiple feeds are selected. Issue #2399 2020-09-08 17:14:49 -05:00
Maurice Parker a04c60caea Fix icon color changing bug. 2020-09-02 13:38:02 -05:00
Maurice Parker 7c7b128380 Fix subtitle for scenario where multiple are selected. 2020-09-02 13:00:09 -05:00
Nate Weaver 34685328e0 Changes for IDNA support 2020-09-01 16:41:01 -05:00
Maurice C Parker 72dc09a257 Position the image assets on pixel boundaries. Issue #2350 2020-08-25 17:34:13 -05:00
Brent Simmons 8350586dc3 Use regular font weight for body text in the timeline. 2020-08-23 21:24:52 -07:00
Brent Simmons cb5142cba2 Make the feed name bold in timeline cells. 2020-08-23 19:18:02 -07:00
Maurice C Parker d99f12346d Manually draw background and selection so that it encompasses the whole row. Issue #2363 2020-08-21 16:02:09 -05:00
Maurice Parker b051a4c990 Make animation loop smoother. Issue #2377 2020-08-21 15:32:56 -05:00
Maurice Parker 1e7a185134 Use rgba instead of rgb for lightmode 2020-08-20 21:13:18 -05:00
Maurice Parker c1b108f541 Merge branch 'mac-candidate' into main 2020-08-20 21:03:55 -05:00
Maurice Parker 6893c8ebc8 Use the lighter shade of NNW blue for darkmode article view (like iOS) 2020-08-20 21:02:28 -05:00
Maurice Parker 6eae89cf4c Merge branch 'mac-candidate' into main 2020-08-20 20:45:15 -05:00
Maurice Parker 2b35eacc30 Improve new window pane sizes. Issue #2344 2020-08-20 20:00:31 -05:00
Maurice Parker b0e7ae0324 Merge branch 'mac-candidate' into main 2020-08-19 21:03:55 -05:00
Maurice Parker d3cebfaccb Turn the star color to white if the article is selected. Issue #2364 2020-08-19 20:00:34 -05:00
Maurice Parker f7fb859ea9 Make article source gray. Issue #2368 2020-08-19 12:48:20 -05:00
Maurice Parker bbd2dfad45 Change article accent color to be NNW blue. Issue #2367 2020-08-19 12:31:03 -05:00
Maurice Parker 1f047cdb10 Make the timeline date bold. Issue #2365 2020-08-19 11:56:14 -05:00
Maurice Parker ef99496002 Make summary text a lighter shade of gray. Issue #2366 2020-08-19 11:51:44 -05:00
Maurice Parker 25ec13972c Change margin padding back to 64px. Issue #2360 2020-08-18 17:20:44 -05:00
Maurice Parker b0de353d02 Make clean up availability take read count into consideration. Issue #2352 2020-08-18 15:04:30 -05:00
Maurice Parker 348e8734e7 Make timeline sort menu more closely match Mail's. Issues #2348, #2347, #2349 2020-08-18 12:01:36 -05:00
Maurice Parker 72bd722def Remove sidebar filter button. Issue #2346 2020-08-17 17:50:50 -05:00
Maurice Parker 24295639ae Set the total unread count in the subtitle when nothing is selected 2020-08-14 14:35:36 -05:00
Maurice Parker 9a91648acc Remove sidebar toggle from the default set 2020-08-11 21:36:15 -05:00
Maurice Parker 38d01eb151 Add Sidebar toggle 2020-08-11 21:03:19 -05:00
Maurice Parker f8cf5676e9 Don't allow Twitter or Reddit feeds to be added to accounts that can't handle them 2020-08-11 20:19:17 -05:00
Maurice Parker 3188a80d25 Remove CSS rule that was interfering with Newsfoot styling 2020-08-11 10:32:54 -05:00
Maurice Parker cb2eefa56a Implement new article extractor button for Big Sur 2020-08-10 17:34:12 -05:00
Maurice Parker 4ce974daca Rename ArticleExtractorButton to make room for the new ArticleExtractorButton 2020-08-10 15:47:40 -05:00
Maurice Parker 73b120a91c Change any glyphs in the sidebar to white when selected to make them visible regardless of use control color selection 2020-08-10 13:53:21 -05:00
Maurice Parker c652486663 Change all 10.16 version checks to be 11.0 2020-08-10 11:43:18 -05:00
Maurice Parker 1c9b0feaaf Move tooltip to the toolbar item instead of the button 2020-08-10 09:53:06 -05:00
Maurice Parker 7619f4470b Add article toolbar items 2020-08-10 09:45:48 -05:00
Maurice Parker 38dd0257bb Add search and mark all as read toolbar items 2020-08-10 09:28:45 -05:00
Maurice Parker fe671f079d Change to use programmatic toolbar building 2020-08-10 03:58:19 -05:00
Maurice Parker c4599cbcc4 Comment out Toolbar Search Item so that the storyboard can be opened on Catalina 2020-08-09 20:27:47 -05:00
Maurice Parker 58498ef33e Use the SF star for the timeline on Big Sur 2020-08-09 20:05:38 -05:00
Maurice Parker 8ee33c34b3 Hook up new search toolbar item 2020-08-09 16:40:44 -05:00
Maurice Parker 656d327692 Programmatically define the default set of toolbar items 2020-08-09 15:36:32 -05:00
Maurice Parker 258c89bf12 Add new sidebar item menu to toolbar 2020-08-09 11:46:53 -05:00
Maurice Parker f676de1ce1 Change toolbar separators to start with a lower case character to match modern Swift conventions 2020-08-09 10:47:56 -05:00
Maurice Parker afe8d23365 Add separator for timeline and make buttons stateful 2020-08-09 06:02:48 -05:00
Maurice Parker 57d988da95 Fix titles on Big Sur 2020-08-08 21:28:43 -05:00
Maurice Parker 1fba0ed247 Don't show a background on symbol images 2020-08-08 17:27:32 -05:00
Maurice Parker c5ec93e8b5 Respect Sidebar size preferences from General preferences Issue #2321 2020-08-08 17:07:21 -05:00
Maurice Parker 314d425c49 Use high resolution Feed icons in the Sidebar #2320 2020-08-07 19:44:12 -05:00
Maurice Parker a7a17e3937 Merge branch 'mac-candidate' into main 2020-08-06 17:06:49 -05:00
Maurice Parker 7baebfeb6a Don't notify the delegate of a selected article change if they haven't actually changed 2020-08-06 17:05:53 -05:00
Maurice Parker 844ef03a65 Reenable Extensions for the 5.5 release 2020-08-02 14:10:02 -05:00
Maurice Parker 87fc73c5de Merge branch 'mac-candidate' into main 2020-08-02 14:05:46 -05:00
Maurice Parker fd56a19edf Hard code enable the MarsEdit and Micro.blog extension points so that they work like 5.0.x 2020-08-02 14:03:51 -05:00
Nate Weaver 1f9dfb80e2 Changes for IDNA support 2020-07-29 15:42:11 -05:00
Maurice Parker 32d6d2f3c1 Convert RSCore into an SPM package 2020-07-29 05:11:57 -05:00
Maurice Parker 4af8e0ab1c Select next item in Sidebar on delete. Issue #2114 2020-07-10 16:49:10 -05:00
Maurice Parker 95a8f6d72d Merge branch 'swiftui' 2020-07-10 15:28:14 -05:00
Nate Weaver 5acce87995 Mac: Make shift-space scroll up even when the detail view doesn't have focus
Issue #969.
2020-07-10 13:57:34 -05:00
Stuart Breckenridge a57f98e4e7 NetNewsWire-Mac AppDefaults is now a singleton 2020-07-02 11:17:38 +08:00
Maurice Parker 9a82d2e233
Merge pull request #2121 from rizwankce/fix/in-app-browser-shortcut
fix open in app browser for mac and iOS
2020-05-29 10:13:07 -05:00
Rizwan Mohamed Ibrahim d671029828
refactor open in app browser for mac and iOS 2020-05-29 19:26:20 +05:30
Rizwan Mohamed Ibrahim eb7ac0f076
fix open in app browser for mac and iOS 2020-05-29 15:44:32 +05:30
Nate Weaver 41d96be8b4 Revert toolbar item updating 2020-05-25 21:25:52 -05:00
Nate Weaver 1ab17b2574 Add a preference for the browser to use to open articles
- Selectable in General Preferences
- Toolbar item now updates to show the browser's icon
2020-05-25 21:24:49 -05:00
Nate Weaver 0c2d057860 Add defaultBrowserID user default and make the appropriate toolbar item use that browser's icon 2020-05-25 21:19:50 -05:00
Nate Weaver b8220d3a9c Show the current default browser in the "Open in Browser" toolbar item 2020-05-25 21:19:29 -05:00
Brent Simmons 64eec7ad6b
Merge pull request #2100 from Wevah/open-in-background-inversion
Make shift key invert the "open in background" preference
2020-05-23 16:06:47 -07:00
Martin Nash 3e48be050e Updated function name to openInBrowserUsingOppositeOfSettings 2020-05-21 22:28:30 -07:00
Martin Nash 834be9edff 2099 | Keyboard shortcut to open in browser in background/foreground contrary to user preference.
- Add openInBrowserAlternate() function
- Add shit-modified entries to to GlobalKeyboardShortcuts.plist to trigger new function
2020-05-20 22:15:00 -07:00
Nate Weaver 5cd8dc9d5d Also let the Command key invert the background pref in web views 2020-05-20 20:08:13 -05:00
Nate Weaver 1e1fc06e7b Clean up shift-key checking and add it to more places 2020-05-20 19:59:21 -05:00
Nate Weaver 24338b135e Don't do shift-key detection in Browser 2020-05-20 19:54:25 -05:00
Nate Weaver e79cafc82e Make shift key invert the "open in background" preference
- Also add an appropriate menu item.
2020-05-20 19:41:23 -05:00
Maurice Parker a6b58beac7 Hide the account field for Popular and All reddit types 2020-05-12 14:14:39 -05:00
Maurice Parker fdfd91e53e Change Popular Reddit description 2020-05-12 10:17:58 -05:00
Maurice Parker 8434e7fa1f Add sort option to Add Reddit Feed dialog 2020-05-10 16:19:38 -05:00
Maurice Parker 06e91aa8b7 Add the Add Reddit Feed dialog 2020-05-10 11:44:30 -05:00
Maurice Parker 7ab4ca4291 Delete dead code 2020-05-10 11:04:45 -05:00
Maurice Parker faab33ab2e Save and toggle full screen state. Issue #2053 2020-05-09 14:14:46 -05:00
Jonathan Bennett a37bfd5d74 Adds an account behavior to disable folders
Some sync services (Feed Wrangler) don't support folders. This behavior removes the account from the UI when adding new folders.
2020-05-07 10:03:04 -04:00
Maurice Parker b6a0057439 Fix bug where Unread feed could get filtered even while selected. 2020-05-02 16:44:24 -05:00
Maurice Parker 6ba862244a Add placeholder text for Twitter search 2020-05-02 16:31:42 -05:00
Maurice Parker 3bc4b9e4b2 Hide filter button when searching 2020-05-02 13:25:48 -05:00
Nate Weaver 37f1ebc025 Remove the color parameter as it's no longer needed 2020-05-01 01:45:12 -05:00
Nate Weaver c555646fb2 Add attributed title support in the timeline 2020-05-01 01:42:43 -05:00
Maurice Parker 86fb98c17b
Revert "WIP: Title tags" 2020-04-24 20:24:24 -05:00
Nate Weaver b437ddab5c Move NSAttributedString+NetNewsWire into Shared/Extensions 2020-04-24 18:25:56 -05:00
Nate Weaver fde4f53f42 Documentation comments 2020-04-24 16:20:41 -05:00
Nate Weaver 154e78b0c0 Add a comment about why these constants differ between OSs 2020-04-24 16:20:41 -05:00
Nate Weaver 26415f0c62 Assign multiple attributes in one go rather than one at a time 2020-04-24 16:20:41 -05:00
Nate Weaver df4ea1479a Tweak comment 2020-04-24 16:20:41 -05:00
Nate Weaver d3e6606cf5 Use a constant for clarity 2020-04-24 16:20:41 -05:00
Nate Weaver 6aff83481f Make attributed titles work on iOS 2020-04-24 16:20:41 -05:00
Nate Weaver dc787620c5 Use API that works on both macOS and iOS 2020-04-24 16:20:41 -05:00
Nate Weaver ba73e3289a Remove redundant call to updateTextFieldText() 2020-04-24 16:20:41 -05:00
Nate Weaver d84ed6068f Add a convenience initializer for attributed strings from an html string 2020-04-24 16:20:41 -05:00
Nate Weaver 2a00b4a4a9 Keep monospace fonts monospaced; use a variable for the current symbolic traits 2020-04-24 16:20:41 -05:00
Nate Weaver 39255a8422 Initialize baseWeight outside the enumeration 2020-04-24 16:20:41 -05:00
Nate Weaver a6411c7afa Check for semibold base font before changing bold text to heavy 2020-04-24 16:20:41 -05:00
Nate Weaver 57a6561733 Use superscript/subscript font feature 2020-04-24 16:20:41 -05:00
Nate Weaver 3d509a94d4 Add attributed title support in the timeline 2020-04-24 16:20:40 -05:00
Maurice Parker ee92cf69d2 Merge branch 'extension-point' 2020-04-24 13:34:13 -05:00
Nate Weaver 37ae46ea4c Merge more styles and fix styling of tables with explicit thead/tbody/tfoot
Also use :matches() to simplify some rules.

# Conflicts:
#	Mac/MainWindow/Detail/styleSheet.css
#	iOS/Resources/styleSheet.css
2020-04-23 23:21:22 -05:00
Maurice Parker 211a9c329f Make screen name entry tolerant of @ usage. 2020-04-23 11:42:00 -05:00