Commit Graph

57 Commits

Author SHA1 Message Date
Maurice Parker
58b24f3349 Rename callback: to completion: 2019-12-14 18:01:34 -07:00
Maurice Parker
56d43f8f2d Do a full reload of the article when rearranging the UI to accommodate for split screen color changes. 2019-11-20 18:16:54 -06:00
Maurice Parker
188c1f8d8e Reload article image on image load notifications. 2019-11-18 19:44:31 -06:00
Maurice Parker
701070f2dd Make Article icons/avatars match Timeline icons/avatars. Issue #1273 2019-11-12 09:22:23 -06:00
Daniel Jalkut
2903e4507b Remove references to WebKit preferences that are not pertinent in 10.15. 2019-10-26 14:23:44 -04:00
Brent Simmons
74b1d56cbf Merge branch 'mac-release' 2019-10-18 17:38:22 -07:00
Brent Simmons
a11e900a93 Get the y scroll position in the detail view using window.pageYOffset instead of document.body.scrollTop. It appears the latter may be broken — at any rate, it just returns 0 on Catalina. (On Mojave, use the same method as before, so as not to risk a regression.) 2019-10-18 17:37:56 -07:00
Maurice Parker
51373885b4 Change javascript event handlers to use event.target.matches instead of walking the dom to install event handlers 2019-10-15 09:04:21 -05:00
Maurice Parker
a1f26898c8 Split Mac and iOS specific javascript into individual files. 2019-10-13 15:47:11 -05:00
Phil Dokas
31c1dc40e3 Fix leading for super and subscript in the article view 2019-10-08 22:15:49 -07:00
Maurice Parker
f7e235a1fb Remove padding from code blocks that was causing weird indentation 2019-10-07 11:05:22 -05:00
Maurice Parker
3d343eb91d Prevent pre tags from wrapping. Issue #1089 2019-10-03 18:27:48 -05:00
Andrew Brehaut
f25c0e0b57 Original implementation was only aware of multimarkdown style footnote markup.
This commit includes support for DaringFireball style footnotes
2019-09-26 20:20:53 +12:00
Andrew Brehaut
0d99136961 544 Simple darkmode style for popovers 2019-09-23 20:38:46 +12:00
Andrew Brehaut
4c54d2c4ff 544 adds and positions the arrow on the popover bubble
An arrow element is now inserted into the dom to orient the bubble to the fnref
element that opened it. This is offset in the opposite direction to the bubble
if the bubble overhangs one side or the other.

Additionally, if both sides overhang then no positioning takes place. This
is the first step towards supporting more narrow windows and mobile clients.
2019-09-23 20:25:00 +12:00
Andrew Brehaut
af5d510c80 #544 Better handling of the footnote reverse links
* Uses a stylesheet to hide the reverse link in the popover rather than monkeying around with the dom in JS
* Javascript event handler catches clicks on the reverse buttons in the footnote list at the bottom of the page
  and scrolls the document back to the source, rather than opening the document in a browser window.
2019-09-23 19:56:58 +12:00
Andrew Brehaut
5fea81971b #554 newsfoot.js and css are included in the page
These changes are the bare minimum required to get footnotes to appear and function on the article page.
 * The newsfoot.js script now wraps everything in an IIFE to prevent bleed to other scripts
 * Stylesheets are included in the main stylesheet, with the colors extracted out into separate selectors

Currently missing the arrow pointing to the footnote link, and no consideration exists for mobile presentation
beyond a max-width: 100vh on the footnote popover.
2019-09-22 14:06:51 +12:00
Maurice Parker
9d54a1de74 Enable always on Reader View for feeds 2019-09-21 15:03:42 -05:00
Maurice Parker
b49aeca577 Moved page.html location information to ArticleRenderer 2019-09-21 12:36:35 -05:00
Maurice Parker
0c00150849 Externalize javascript code into separate main.js file 2019-09-21 04:34:11 -05:00
Maurice Parker
ba45144c2a Merge branch 'mac-release' 2019-09-21 03:57:41 -05:00
Maurice Parker
3decd23c45 Convert iOS to use Javascript rendering 2019-09-20 20:33:28 -05:00
Maurice Parker
710abf30c7 Make stylesheet external to page.html 2019-09-20 19:28:13 -05:00
Ben Ubois
cdf643c2a6 Make iFrames responsive. 2019-09-20 17:21:01 -07:00
Maurice Parker
9c6d47eaa1 Merge branch 'pr/1033' 2019-09-20 17:51:27 -05:00
Maurice Parker
d3a5bdf6d3 Merge branch 'mac-release' 2019-09-19 11:59:01 -05:00
Nate Weaver
4a0bbeacc2 Disable Web Inspector for App Store builds
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
Ben Ubois
0b6683d073 Render with evaluateJavaScript.
Replaced loadHTMLString based rendering for improved performance.
2019-09-18 22:03:23 -07:00
Maurice Parker
8cd6f107e5 Add basic Article Content extraction 2019-09-18 18:15:55 -05:00
Maurice Parker
786a4e48c4 Merge branch 'mac-release' 2019-09-17 15:01:01 -05:00
Nate Weaver
0c89bc43c1 Use a bridging header for the Web Inspector API instead of KVC 2019-09-17 06:55:55 -05:00
Nate Weaver
4f405009f5 Use a selector instead of a block for the notification observation 2019-09-17 05:04:05 -05:00
Nate Weaver
e39fa31bf7 Add a menu item to the Debug menu to enable the Web Inspector
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
2019-09-17 05:04:05 -05:00
Maurice Parker
444771dfae Merge branch 'mac-release' 2019-09-16 18:16:13 -05:00
Maurice Parker
1d7cbe5596 Fix super wide div's. Issue #1010 2019-09-16 18:12:56 -05:00
Maurice Parker
57542592cb Correct which view should become the first responder. Issue #1014 2019-09-11 17:47:02 -05:00
Brent Simmons
3b501e9f4e Merge branch 'mac-release' 2019-09-10 20:28:42 -07:00
Maurice Parker
8dda681409 Add accessibility labels to Sidebar, Timeline, and Article. Issue #934 2019-09-10 11:09:17 -05:00
Brent Simmons
0d25f2331a Merge branch 'mac-release' 2019-09-06 19:28:31 -07:00
Brent Simmons
58c2fad2fd Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976. 2019-09-06 19:28:06 -07:00
Maurice Parker
00b2756526 Merge branch 'mac-release' 2019-09-05 13:15:04 -05:00
Brian Warren
ce3ec10c95 Enforcing automatic height for images in the template 2019-09-05 10:59:16 -07:00
Maurice Parker
da8250ac5a Merge branch 'mac-release' 2019-09-04 17:42:30 -05:00
Maurice Parker
7a8d23958b Restrict iframe width to be at most 100% 2019-09-04 17:41:58 -05:00
Maurice Parker
dabb78cde4 Merge branch 'mac-release' 2019-09-04 17:20:37 -05:00
Thomas Pritchard
d3ad4b52a3 Set a sensible line height for figure captions 2019-09-04 19:58:29 +01:00
Thomas Pritchard
5976923f23 Add figures to Mac detail stylesheet 2019-09-04 19:58:29 +01:00
Maurice Parker
fa5840811a Change the view that gets made the first responder so that keyboard shortcuts work again 2019-09-04 03:12:50 -05:00
Maurice Parker
722d486018 Move keyboard config files to Shared location in repo as they will now be used in the iOS app as well as the Mac app 2019-09-04 03:11:55 -05:00
Jim Correia
e7e77d362c Fix for bug #901 — first web view load flashes white in dark mode
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.

Instead, use a modification of the original solution used for iOS:

    - wrap the web view in a box with an appropriate background color
    - hide the web view at creation
    - show the web view after* the first load

This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.

[*] Showing the view immediately after the first load still causes the flash
    to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
    but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00