f9af3c786b
Merge branch 'ios-candidate'
2021-05-25 20:12:50 -05:00
9d2c8f000f
Create and use IconImageCache. It centralizes and de-dupes logic for getting feed/article images, and it caches the results, which helps performance.
2021-05-08 12:42:44 -07:00
8707a71313
Add Copy Article URL & Copy External URL Menu Items
...
The Mac items display in the edit and contextual menus, and in the iOS contextual menu for an article.
2021-05-01 16:47:39 -04:00
364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
...
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
...
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
9092d075a0
Handle links with unencoded spaces. Fixes #3069
2021-04-28 22:49:32 +12:00
5af2643479
standardised naming
2021-04-19 11:21:00 +08:00
d4130e7c65
Corrects naming convention
...
[iOS]
Twitter: Notify about new tweets
Reddit: Notify about new posts
Default: Notify about new articles
+ Fixes alignment issues in the inspector view
[macOS]
Twitter: Show notifications for new tweets
Reddit: Show notifications for new posts
Default: Show notifications for new articles
2021-04-19 11:10:57 +08:00
77dd2e5e22
Merge branch 'mac-release' into main
2021-04-15 14:31:52 -05:00
3955151daf
Make sure mark as read completes before searching for the next unread. Fixes #2952
2021-04-15 14:29:49 -05:00
4e517a6db4
Disable Reader View
...
This commit:
- adds a `isFeedProvider: Bool` property to `WebFeed`
- if `isFeedProvider` is `true`, the article extractor is disabled on the inspector, hidden from the context menu, and the toolbar button is disabled. Additionally, if `isFeedProvider` is `true`, `isArticleExtractorAlwaysOn` returns `false` and cannot be set to `true`.
2021-04-09 07:47:14 +08:00
b1a0b649a5
Merge pull request #2972 from j-f1/read-unread
...
Update swipe actions on macOS to match iOS
2021-04-07 03:47:27 -05:00
3609b6f977
Add labels to swipe actions to match iOS
2021-04-06 17:34:05 -04:00
ea6cece955
Merge branch 'mac-release' into main
2021-04-03 09:30:42 -05:00
1ab727a128
Make symbol images images scale correctly. Fixes #2957
2021-04-01 11:12:48 -05:00
4750e9b93a
Add dir=auto to page.html
2021-03-29 17:20:09 -04:00
95234706e1
Fix issue where next unread wasn't wrapping around. Fixes #2942
2021-03-29 14:33:08 -05:00
fb9114538c
Modified the Timeline so that it can handle duplicate articleIDs
2021-03-28 06:30:49 -05:00
ab5421f533
Merge branch 'mac-release' into main
2021-03-27 17:21:49 -05:00
42e6e1397d
Signal that the mouse exited the link when an article gets reloaded. Fixes #2877
2021-03-15 20:14:30 -05:00
78b9444274
Remove extra unused parameter in delegate signature
2021-03-15 20:10:42 -05:00
52f11ff538
Add validateFeed parameter to createWebFeed
2021-03-15 18:01:12 -05:00
f1e4d70481
Simplify the folder copy logic
2021-03-15 17:47:53 -05:00
d57cb7b21f
Delete obsolete code
2021-03-15 17:35:23 -05:00
7e4e7091e2
Delete obsolete code
2021-03-15 17:33:12 -05:00
bf76cb810d
Change to always copy between accounts. Fixes #2871
2021-03-11 19:43:05 -06:00
e2f21c15c2
formatting
2021-03-08 14:12:32 +08:00
f630cb16db
comments
2021-03-08 10:30:58 +08:00
a59df3e6fc
Moves frame tweaking to end of liveResize
2021-03-08 10:28:51 +08:00
27b9326d07
fixes #2823
2021-03-08 10:06:30 +08:00
2e12f5a078
removes code comment
2021-03-07 21:34:52 +08:00
86981a0c5b
#2597
...
Fixes #2597 : Toggles a small window height change to get webview to behave on macOS 11.
2021-03-07 16:47:39 +08:00
7a653db1dd
typo
2021-03-07 15:51:43 +08:00
8dc6e4e332
Contraint Changes
...
• Fixes #2850
• #2634: resizing vertically downards (expanding) is smooth
2021-03-07 14:21:30 +08:00
d0e3ec6d1c
Fix variable name
2021-03-06 16:25:44 -06:00
a7abde04ab
Fix variable name
2021-03-06 16:25:10 -06:00
2ca06eeae7
Remove containing box for web view. Fixes #2848
2021-03-05 12:45:15 -06:00
035759947a
Fix #2833 : Titlebar is overlapped by toolbar in fullscreen
...
Fix issue where detail web view would be overlapped by the toolbar in full screen by setting web view constraints to use the `safeAreaLayoutGuide` in macOS 11+.
2021-02-27 19:02:13 -06:00
593569175c
Fix #2833 : Titlebar is overlapped by toolbar in fullscreen
...
Fix issue where detail web view would be overlapped by the toolbar in full screen by setting web view constraints to use the `safeAreaLayoutGuide` in macOS 11+.
2021-02-27 16:32:57 -08:00
74298e7cde
Add hidden GruberFeedDoubleClickMarkAsRead preference
2021-02-26 17:38:26 -06:00
1f159a5bff
Change drag-n-drop behavior to default to copy when dragging between accounts
2021-02-22 18:50:29 -06:00
afd9a47abd
Change so that we only show one error dialog when folder moves/copies can't find one or more feeds.
2021-02-22 17:50:30 -06:00
931b1f9afd
Show Folder as it is created to give better visual feedback that a folder copy was successful. Fixes #2815
2021-02-22 17:14:41 -06:00
25ee970562
Remove async call since the Big Sur bug that it was working around appears to be fixed. Fixes #2791
2021-02-22 12:17:43 -06:00
731d0d0d88
Show Folder as it is created to give better visual feedback that a folder copy was successful. Fixes #2815
2021-02-16 14:24:21 -06:00
ca294c7528
Remove async call since the Big Sur bug that it was working around appears to be fixed. Fixes #2791
2021-02-15 17:49:28 -06:00
1e578828e9
: class chnaged to : AnyObject for protocols
2021-02-06 07:06:45 +08:00
e88327be78
You can’t toggle an optional Bool
2021-02-02 13:25:06 +08:00
aa0a5d2269
Checks for notification permissions
...
If notifications are authorised, the toggle will work.
Otherwise, an alert is shown giving the user required information to enable notifications.
2021-02-02 11:54:47 +08:00
62ed7492eb
Adds checkmarks
...
Also adds notification to keep Inspector in sync.
2021-02-02 10:26:34 +08:00
6b1ad170ca
Adds sidebar toggles for notifications/reader
2021-02-02 08:16:45 +08:00
73ba42fa1a
Use the correct font for the preferred sidebar icon size. Fixes #2761
2021-01-24 10:34:27 -06:00
f8ba630cf1
Delete dead code
2021-01-22 17:04:16 -06:00
43a01c5501
Change to use standard Apple colors for darkmode. Fixes #2660
2020-12-11 15:29:31 -06:00
6ef29e3927
Update the text size using JavaScript so that the web page doesn't reload. Fixes #2641
2020-12-08 19:00:56 -06:00
1ac4ec6e3c
Fork MainWindow.storyboard so that we stop Catalina and Big Sur from stepping all over each other.
2020-12-06 15:21:30 -06:00
ef18600acc
Separate background suppression from symbol processing. Fixes #2646 & Fixes #2635
2020-12-06 14:25:22 -06:00
863ba726ad
Don’t draw separators by default. (Yes, I changed my mine.)
2020-12-05 16:26:18 -08:00
a0aad21385
Rebuild Sidebar outline view to try to fix Catalina problems
2020-11-20 15:02:23 -06:00
e32c38f327
Fix clipping on popup menu. Fixes #2588
2020-11-19 17:27:11 -06:00
33cd254dad
Fix bug where emulated separator continually was added to the row
2020-11-19 16:25:06 -06:00
04736ded79
Update the title bar when searching
2020-11-19 16:21:51 -06:00
bc7692f4ba
Change the separator to a custom separator color because the system color for dark mode was just too much.
2020-11-19 13:53:51 -06:00
006586ada6
Correctly align separator with contents of cell. Issue #2592
2020-11-19 13:44:08 -06:00
97bbb9d9d9
Put unread articles button in the toolbar. Issue #2581
2020-11-19 12:10:42 -06:00
117f6ccf6f
Reorder code to match new toolbar order
2020-11-19 11:31:58 -06:00
88c33283bf
Move search bar to the right side of the toolbar and put icons in the same order as they are on iOS. Fixes #2583
2020-11-19 11:29:56 -06:00
c2d0dac62c
Hide the Timeline sort and filter on Big Sur. Fixes #2582
2020-11-19 11:16:07 -06:00
8fd3cd2cde
Rework cell background selection and separators to remove separator drawing artifacts and use the inset table style. Fixes #2579 , #2580 and #2584
2020-11-18 22:02:54 -06:00
eb5e85cbcf
Set table view to style plain to avoid Big Sur's big margins. Fixes #2584
2020-11-18 20:49:32 -06:00
f7574dc633
Tweak the sidebar image sizes so that they match the system apps as it looks like the HIG has the wrong values in it for sidebar image sizes
2020-11-15 15:18:33 -06:00
65510b1901
Merge branch 'mac-release' into main
2020-11-13 07:15:26 -06:00
8b7d7798ff
Flip the order of mark all as read and search toolbar items
2020-11-09 15:26:14 -06:00
d397f1627c
Scale button images down so that PDF button images look correct when the small size icons are selected.
2020-11-09 13:02:46 -06:00
e297a53eb2
Fix out-of-index crash by guarding against a 0-length string.
2020-11-06 17:03:20 -08:00
e8238c03f2
Don't enable the Add button unless all conditions for an Add have been met. Fixes #2555
2020-11-05 10:34:26 -06:00
c558731de8
Reduce size of article left and right padding
2020-11-04 12:30:29 -06:00
948998382d
Make article view text adjustable via the app preferences. Fixes #42
2020-11-03 17:08:56 -06:00
0338a3bda4
Remove deprecation warning
2020-11-02 19:43:29 -06:00
caeebfc89e
Extend Article with PasteboardWriterOwner so that timeline copying works as it was intended to. Issue #963
2020-11-02 19:33:56 -06:00
5900b748be
Filter the NetNewsWire share menu item from the NetNewsWire share menu
2020-11-02 16:27:13 -06:00
1ced4448ea
Support a new secret user default JalkutRespectFolderExpansionOnNextUnread, and revise the "next unread" strategy so that whether the search for a next unread wraps around to the top or not is parameterized.
2020-11-01 17:33:48 -05:00
2395c0c7df
Correct validation so that we can still move feeds in Reader API accounts
2020-10-31 17:37:25 -05:00
5fdbd4b9d0
Fixed misleading variable name
2020-10-31 17:31:48 -05:00
cbb481c3f7
Don't allow a feed to be in more than one folder for Reader API accounts
2020-10-31 17:26:43 -05:00
3aad0b5075
Remove no longer needed system events. Fixes #2537
2020-10-30 09:44:24 -05:00
c75dc8b54d
Make sure that the error is displayed after the progress window is ended by doing an DispatchQueue.main.async on the error display.
2020-10-25 15:17:02 -05:00
0a01a9f501
Display "(No Text)" if there isn't a title or summary for the timeline. Fixes #2391
2020-10-23 19:18:35 -05:00
d735ae91dc
Add a confirmation alert for the delete context menu so that it matches other delete functionality.
2020-10-23 16:54:20 -05:00
065236ada3
Fix row background color. Issue #2503
2020-10-18 18:28:19 -05:00
34a2860c97
Fix row background color. Issue #2503
2020-10-18 18:27:36 -05:00
40d5625bd6
Use the correct error asset.
2020-10-18 17:04:30 -05:00
4284ea26c8
Merge branch 'mac-release' into main
2020-10-18 16:37:00 -05:00
dc35037740
Remove CSS rule that was interfering with Newsfoot styling
2020-09-29 07:35:05 -05:00
46743a0f49
Simplified the delete titles.
2020-09-28 20:28:53 -05:00
aaff359609
Provide verification dialog for deletes. Issue #1789
2020-09-28 19:50:31 -05:00
2772b5e36d
Make current window key and front if we are opening Safari in the background. Issue #2427
2020-09-23 18:30:34 -05:00
e575aeca3c
Restore functionality to mark older as read using keyboard shortcut. Issue #2451
2020-09-22 19:42:14 -05:00
fe39863858
Add width constraint to extractor button so that it doesn't move around on the most recent Big Sur beta's
2020-09-18 18:04:46 -05:00
3fed4774e3
Make the All Unread feed eligible for the Clean Up command. Issue #2417
2020-09-13 16:35:51 -05:00
Maurice Parker
Brent Simmons
Rob Mathers
Chris Campbell
Duncan Babbage
Stuart Breckenridge
Jed Fox
Stuart Breckenridge
Collin Donnell
Daniel Jalkut