Commit Graph

2373 Commits

Author SHA1 Message Date
Brent Simmons 7ad0b6b604 Always update the unread count in the timeline after doing a sync fetch after representedObjects changes. Reload visible cells whenever showFeedNames changes. Fix #923. 2019-09-10 20:28:16 -07:00
Maurice Parker 8dda681409 Add accessibility labels to Sidebar, Timeline, and Article. Issue #934 2019-09-10 11:09:17 -05:00
Brent Simmons 41c82eca15 Rename existingFeed(with:) to existingFeed(withFeedID:) to make it more clear. Make account.idToFeedDictionary private — callers should use existingFeed(withFeedID:). 2019-09-08 21:44:05 -07:00
Brent Simmons f5f306f60f Add comments to feed.iconURL and feed.faviconURL, explaining that these are set only if that info was part of the feed (which is a JSON-Feed-only feature). 2019-09-08 21:17:57 -07:00
Maurice Parker 0961753357
Merge pull request #998 from hisaac/mac-release
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 13:02:58 -05:00
Isaac Halvorson 8b635fc04c Add command arrow key shortcuts to sidebar shortcuts plist 2019-09-08 12:54:26 -05:00
Maurice Parker 7ca2226669 Move credentials classes to the Account framework in NetNewsWire 2019-09-08 04:28:43 -05:00
Brent Simmons 53370ff0d3 Bump version to 5.0.1d2. 2019-09-07 20:45:10 -07:00
Brent Simmons c05e55af41 Update to latest RSCore. 2019-09-07 18:31:07 -07:00
Brent Simmons 5b15285e8e Make sure that article.preferredLink doesn’t return an empty string. 2019-09-07 18:27:48 -07:00
Brent Simmons 60f13c32a4 Update to latest RSParser. 2019-09-06 20:00:06 -07:00
Brent Simmons 6dce9eb0ec Update to latest RSParser. 2019-09-06 19:50:02 -07:00
Brent Simmons 58c2fad2fd Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976. 2019-09-06 19:28:06 -07:00
Brent Simmons d49b212bc2 Delete unused EvergreenLarge.png. 2019-09-06 19:11:41 -07:00
Maurice Parker 0e7d971e65 Queue a reload of all visible cells anytime a favicon is downloaded. Issue #995 2019-09-06 16:52:31 -05:00
Brent Simmons 809c2fdfc5
Merge pull request #993 from danielpunkass/fix-extension-versioning-backport
mac-release targeted version of the fix for #989
2019-09-06 12:45:52 -07:00
Daniel Jalkut d79bbefeb8 mac-release targeted version of the fix for #989 2019-09-06 15:40:59 -04:00
Maurice Parker 7a242b2c15
Merge pull request #988 from danielpunkass/app-movement-monitor
Instantiate an RSAppMovementMonitor to track user movement of the app…
2019-09-06 08:33:40 -05:00
Daniel Jalkut 8e01e8e45a Instantiate an RSAppMovementMonitor to track user movement of the application while running. Fixes #897. 2019-09-06 09:13:09 -04:00
Maurice Parker dc64fa2bda
Merge pull request #980 from good/mac-release
Enforces auto-height for images to fix improper resizing
2019-09-05 13:11:15 -05:00
Brian Warren ce3ec10c95 Enforcing automatic height for images in the template 2019-09-05 10:59:16 -07:00
Brent Simmons f0d080b0be Remove blank line from near top of About window credits. 2019-09-04 21:04:21 -07:00
Brent Simmons 5ad307411d Bump version to 5.0.1d1 2019-09-04 21:00:59 -07:00
Maurice Parker 7a8d23958b Restrict iframe width to be at most 100% 2019-09-04 17:41:58 -05:00
Maurice Parker 25466a8aef
Merge pull request #964 from tpritc/mac-release
Fix for bug #959 — Detail stylesheet doesn't account for figures
2019-09-04 14:13:31 -05:00
Thomas Pritchard 091b43a9fb Apply figure styles to iOS as well 2019-09-04 19:58:30 +01:00
Thomas Pritchard d3ad4b52a3 Set a sensible line height for figure captions 2019-09-04 19:58:29 +01:00
Thomas Pritchard 5976923f23 Add figures to Mac detail stylesheet 2019-09-04 19:58:29 +01:00
Brent Simmons 0ba8f3b4e1 Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898. 2019-09-03 22:58:17 -07:00
Brent Simmons cbaad4bdeb Add checkbox to Preferences > General for turning off the unread count in the Dock. 2019-09-03 22:17:31 -07:00
Brent Simmons 7b0ff737f5 Update RSParser to latest. 2019-09-03 21:51:32 -07:00
Brent Simmons 5efbe6a4f0 Add NNW website link to top of About window text. 2019-09-03 21:24:17 -07:00
Brent Simmons 8d97c185e9 Update RSParser to latest. 2019-09-03 21:17:27 -07:00
Brent Simmons 563b4a8320
Merge pull request #945 from correia/correia-separators
Add optional separators in the timeline view.
2019-09-02 10:44:53 -07:00
Jim Correia c8920ca5a6 Added optional separators in the timeline view.
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
2019-09-02 09:13:21 -07:00
Maurice Parker 8560ce33f4 Merge branch 'mac-release' of https://github.com/brentsimmons/NetNewsWire into mac-release 2019-09-01 10:49:46 -05:00
Maurice Parker e31dec7c44 Call completion handler when there are no feeds associated with the folder being removed. Issue #938 2019-09-01 10:49:35 -05:00
Brent Simmons 1b26b1ece5
Merge pull request #932 from correia/bug-901
Fix for bug #901 — first web view load flashes white in dark mode
2019-08-31 22:27:31 -07:00
Jim Correia e7e77d362c Fix for bug #901 — first web view load flashes white in dark mode
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.

Instead, use a modification of the original solution used for iOS:

    - wrap the web view in a box with an appropriate background color
    - hide the web view at creation
    - show the web view after* the first load

This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.

[*] Showing the view immediately after the first load still causes the flash
    to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
    but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
Maurice Parker fabea36a91
Merge pull request #930 from correia/bug-921
Only enable "Open in Browser" when a single article is selected.
2019-08-31 18:29:07 -05:00
Jim Correia cdfdc06142 Only enable "Open in Browser" when a single article is selected.
Fixes bug #921.
2019-08-31 16:02:21 -07:00
Maurice Parker c1216bf7bb Merge branch 'mac-release' of https://github.com/brentsimmons/NetNewsWire into mac-release 2019-08-30 10:40:25 -05:00
Maurice Parker a69be4117a Retrieve statuses before articles during sync process and default starred articles to read if there isn't an unread status Issue #868 2019-08-30 10:39:52 -05:00
Brent Simmons 29efae42fd Update Apple events privacy statement to refer to article instead of news item. 2019-08-28 21:40:56 -07:00
Brent Simmons d468961d81 Update version and build number. 2019-08-28 21:40:21 -07:00
Brent Simmons a7c373b445 Update to latest RSCore. 2019-08-28 21:37:55 -07:00
Brent Simmons 1c2d5a677a Update to latest RSParser, which includes fix for detecting RDF feeds that lack an XML header. 2019-08-28 21:24:35 -07:00
Maurice Parker 3279a25581 Cache home page to feed icon relationship 2019-08-26 19:40:30 -05:00
Maurice Parker 1a3e2784ae Optimize table cell reloading when feed images are made available 2019-08-26 12:54:23 -05:00
Brent Simmons c3aebe7868 Bump version and build. 2019-08-23 21:59:44 -07:00