Commit Graph

4226 Commits

Author SHA1 Message Date
Nate Weaver
792fcddaf6 Update comment 2019-12-30 17:35:47 -06:00
Nate Weaver
58ef7600fb Avoid copying the table and use querySelector()
(Since there's only one .articleBody.)
2019-12-30 17:24:34 -06:00
Nate Weaver
7a61a6a5b4 Specify div explicitly 2019-12-30 17:24:34 -06:00
Nate Weaver
0800c77002 Remove now-unneeded style rule 2019-12-30 17:17:35 -06:00
Nate Weaver
c2d3e9213d Strip spans from pre elements inside table cells
Works around a clipping issue.
2019-12-30 17:17:35 -06:00
Nate Weaver
bb0fffcec2 Move wrapTables() to just after wrapFrames() 2019-12-30 17:17:35 -06:00
Nate Weaver
cbbb46a776 Wrap tables in an overflow-x: auto; div 2019-12-30 17:17:35 -06:00
Maurice Parker
8a85b18d09
Merge pull request #1495 from kielgillard/ios-candidate
Models the feed identifier of feedly articles as an optional…
2019-12-30 14:55:30 -07:00
Kiel Gillard
3b47edfba7 Models the feed identifier of feedly articles as an optional since it seems the Feedly API will not always provide one (despite the API documentation).
Additional, more elegantly handle the failure to parse an article when Feedly does not provide a matching feed.
2019-12-31 08:47:27 +11:00
Maurice Parker
c692d46cc8
Merge pull request #1493 from hartlco/1486-feedslist-contextmenu-mark-all-as-read
Include Mark All as Read in Feeds list context menu #1486
2019-12-30 13:37:38 -07:00
Martin Hartl
5cbfe3b071 Include Mark All as Read in Feeds list context menu 2019-12-30 21:16:50 +01:00
Brent Simmons
388886a355 Base our active articles window on dateArrived instead of datePublished. This reverses a recent change that led to some bugs. 2019-12-28 22:20:13 -08:00
Brent Simmons
ac519c5c90 Add new and updated articles to the in-memory cache when saving articles. 2019-12-28 21:19:02 -08:00
Brent Simmons
26bb2b8eaf Remove references to Article.bannerImageURL. We can bring it back if/when we start using it. 2019-12-28 20:53:36 -08:00
Maurice Parker
a1b23edc8b Delete obsolete code 2019-12-28 16:06:37 -07:00
Maurice Parker
5c4d8aeba7 Verify that the parent node to be expanded is a Folder before trying to expand it. 2019-12-28 10:58:15 -07:00
Maurice Parker
0fbd376078 Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate 2019-12-28 10:23:43 -07:00
Maurice Parker
36521a1783 Don't crash if there isn't a folder or feed available. 2019-12-28 10:23:09 -07:00
Brent Simmons
aeaeac61fc Get rid of DatabaseArticle entirely. Cache Article objects. This will make fetches faster *and* save memory. 2019-12-27 22:47:02 -08:00
Maurice Parker
4b361300f4 Fix the OPML export when there is only one exportable account. Issue #1457 2019-12-26 12:35:39 -07:00
Maurice Parker
1043b42472 Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate 2019-12-26 12:22:10 -07:00
Maurice Parker
00ed368683 Change the full screen tap zone to be the center of the navigation bar instead of the whole navigation bar. Issue #1450. 2019-12-26 12:21:56 -07:00
Maurice Parker
be2b7e6eef
Merge pull request #1465 from Wevah/ios-feed-sizing-fix
Make initial scale 100% and don't let WebKit increase text size
2019-12-26 11:24:49 -07:00
Nate Weaver
758fb1a1c0 Make initial scale 100% and don't let WebKit increase text size
Issue #1459.
2019-12-24 20:15:53 -06:00
Maurice Parker
84d1ccadfd Clear the saved middle position when emptying the timeline. Issue #1464 2019-12-24 17:55:56 -07:00
Maurice Parker
61370dd04d Fix so that we don't try to scroll before the datasource has been fully applied to the table. Issue #1463 2019-12-24 17:34:47 -07:00
Maurice Parker
5eac0dc0b4
Merge pull request #1455 from Austinate/bugfix/add_folder_account_name_sync_issue
iOS, Add Folder: Make sure Account Name field is in sync with selecte…
2019-12-24 16:02:28 -07:00
austinate
f43e7880f7 iOS, Add Folder: Make sure Account Name field is in sync with selected account in picker 2019-12-23 17:20:52 +02:00
Brent Simmons
df642c128a Bump version to 23. 2019-12-21 16:22:09 -08:00
Brent Simmons
a5272e0b49 Bump build to 22. 2019-12-20 21:18:31 -08:00
Brent Simmons
17ba716bb4 Update to latest RSParser. 2019-12-20 21:16:10 -08:00
Maurice Parker
8fb92e119a Auto expand accounts that may have been suspended as collapsed when disclosing a feed. Issue #1440 2019-12-19 09:38:53 -07:00
Brent Simmons
3a33c38d5c Use an inner function in FeedbinAccountDelegate.refreshMissingArticles. I like this pattern because 1) it keeps the switch statement and its cases near each other, and 2) it puts all the actual processing in a single function, which makes it easier to see where processing happens. 2019-12-17 21:24:17 -08:00
Brent Simmons
db564d9cf9 Remove all references to fetchArticleIDsForStatusesWithoutArticles. Use fetchArticleIDsForStatusesWithoutArticlesNewerThanCutoffDate instead. 2019-12-17 21:15:20 -08:00
Brent Simmons
6d499c8848 Bump version to 21. Lucky 21. 2019-12-17 19:19:32 -08:00
Maurice Parker
236f581d95 Update Feedbin to use fetchArticleIDsForStatusesWithoutArticlesNewerThanCutoffDate for missing articles. 2019-12-17 17:43:08 -07:00
Maurice Parker
2148bb29dc
Merge pull request #1438 from kielgillard/feedly-account-update-error
Check the account update error when updating a Feedly account…
2019-12-17 17:12:17 -07:00
Kiel Gillard
40dacd6522 Update set starred articles operation to honour database errors. 2019-12-18 09:45:30 +11:00
Kiel Gillard
5a9b138a9d Update set unraed articles operation to honour database errors. 2019-12-18 09:42:08 +11:00
Kiel Gillard
7ddcb2fc8e Add optional completions to avoid race conditions involving these marked statuses. 2019-12-18 09:41:45 +11:00
Kiel Gillard
6fb0e2e0d0 Honour the error case when ingesting read and star statuses 2019-12-18 09:32:58 +11:00
Kiel Gillard
bd307cbb6c Give the FeedlySyncStarredArticlesOperation a delegate so that if the database becomes suspended, the remainder of the sync operation cancels. 2019-12-18 09:26:57 +11:00
Kiel Gillard
311f5b2e81 Check the account update error when update a Feedly account and finish with an error, indicating to its delegate that remaining operations should cancel. 2019-12-18 09:19:00 +11:00
Maurice Parker
73d6d5f5d5 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-12-17 14:29:53 -07:00
Brent Simmons
948d366a4e Created fetchArticleIDsForStatusesWithoutArticlesNewerThanCutoffDate — this gets articleIDs of articles we care about. They’re not deleted. They’re either (starred) or (unread and newer than cutoffDate). Also: it’s async. Use this instead of fetchArticleIDsForStatusesWithoutArticles, which is deprecated. 2019-12-17 13:28:48 -08:00
Maurice Parker
b637a6f01b Process the article downloads in smaller transaction groups to make possible to interrupt. Issue #1437. 2019-12-17 14:28:04 -07:00
Maurice Parker
7192a6893e Change Feedbin to always check the error from Account.update. 2019-12-17 13:25:01 -07:00
Maurice Parker
d17a0699d6 Update to latest RSDatabase 2019-12-17 11:01:19 -07:00
Brent Simmons
567a971a1c Remove no-longer-used fetchStatuses functions. 2019-12-16 23:09:46 -08:00
Brent Simmons
704ccb2927 Remove no-longer-used ensureStatuses functions. 2019-12-16 23:06:21 -08:00