FreshRSS/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire.git synced 2024-12-22 23:58:36 +01:00
Code Issues Packages Projects Releases Wiki Activity
8,374 Commits 14 Branches 0 Tags 64 MiB
750e287ff9
Commit Graph

230 Commits

Author SHA1 Message Date
Maurice Parker
e6c5d2f199 Merge branch 'ios-release' 2020-04-11 15:59:37 -05:00
Maurice Parker
7c266d65ee Force the frame to center when displaying. Issue #1983 2020-04-11 15:58:48 -05:00
zgjie
bcfd75ff68 Replace the firstElementPassingTest function come from RSCore with the native function first(where:). 2020-04-06 02:06:24 +08:00
Maurice Parker
649972f57f Created the Developer build which has some functionality disabled for those without access to the API keys needed. 2020-03-28 16:51:41 -05:00
Maurice Parker
36841602a5 Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923 2020-03-17 17:18:24 -05:00
Maurice Parker
37cf7fae1d Fix regression that prevented Always Show Reader View from working. 2020-03-16 07:58:51 -05:00
Maurice Parker
07dc4f1f10 Don't start the article extractor if we only want to store the article. Issue #1494 2020-03-14 06:31:14 -05:00
Maurice Parker
7922efab1e
Merge pull request #1899 from flowinho/ios-release 
Hide articleExtractor and actionBarButtonItem
 2020-03-13 15:13:33 -05:00
Flowinho
ce428d2cc6 Hide articleExtractor and actionBarButtonItem 2020-03-13 20:21:18 +01:00
Maurice Parker
47e42fab0a Removed old debugging statement. 2020-03-12 16:01:13 -05:00
Flowinho
da64f65c7b Fixes close button icon distortion 
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.

- Set content-mode of the buttons imageview to scaleAspectFit.
 2020-03-12 21:54:50 +01:00
Flowinho
feacda1c3b HOTFIX silly me 2020-03-12 21:33:02 +01:00
Flowinho
91247b7f16 Adding dynamic width algorithm to the titleLabel 
This commit adds multiple functionalities at once:

- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).

The title label now resizes itself depending on the devices it’s displazed on.

- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.

The numbers are derived from my personal preference when implementing it.
 2020-03-12 21:23:57 +01:00
Maurice Parker
22b9e7b54b Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883 2020-03-11 19:45:45 -05:00
Maurice Parker
27b1443def Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881 2020-03-11 18:17:09 -06:00
Maurice Parker
76d5f4a073 Remove flush and restore of web view queues. Issue #1882 2020-03-11 17:02:16 -06:00
Maurice Parker
cd5e491f00 Fix issue where full screen wouldn't come back after being engaged and moving to the timeline. (Regression) 2020-02-26 16:02:36 -08:00
Maurice Parker
9e3f061fcb Dispatch the page controller setting since it is unreliable. Issue #1756 & Issue #1808 2020-02-25 18:06:02 -08:00
Maurice Parker
5a5abb0b87 Ensure that the dom is fully loaded on *all* web views before being made available to process JavaScript. Issue #1756 & Issue #1808 2020-02-25 15:10:51 -08:00
Maurice Parker
0e72811429 Implement mark as unread window for accounts that need it. Issue #1407 2020-02-18 13:49:29 -08:00
Maurice Parker
8acd6a039a Change event used to stop web view activity (video and image zooming) so that it doesn't interfere with the image zooming transition. 2020-02-18 11:08:38 -08:00
Maurice Parker
e3b32847f9 Stop image zooming on swipes and video playback on button presses. Issue #1801 2020-02-18 09:49:54 -08:00
Maurice Parker
58b8a9adb0 Render article on to be recycled web view and delay new web view showing to 0.3. Issue #1780 2020-02-13 17:35:34 -08:00
Maurice Parker
d01e9cef42 Remove unintended web view load when changing the article. 2020-02-13 16:08:44 -08:00
Maurice Parker
2ae021960b Move account files to the documents directory and out of the shared container. Issue #1784 2020-02-12 16:21:48 -08:00
Maurice Parker
31b72221f8 Rollback delay that was causing blank articles to be shown. Issue #1780 2020-02-09 11:57:07 -08:00
Brent Simmons
eb770f4494 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-08 17:22:03 -08:00
Brent Simmons
cac67f8ac4 Use percent-encoding — via URLComponents — on the articleID in the nnwImageIcon URL scheme. 2020-02-08 17:21:55 -08:00
Maurice Parker
bdd79aead5 Delay swapping out the web view until the new web view has had a chance to render. Issue #1780 2020-02-08 16:55:16 -08:00
Maurice Parker
e5a9205747 Always reload the web view when the showing state changes. Issue #1775 2020-02-06 11:41:06 -08:00
Maurice Parker
268c20da56 Set all the web view delegates to nil when recycling to prevent unintended behaviors. Issue #1777 2020-02-06 10:36:39 -08:00
Maurice Parker
d1f1ca22b6 Add a hack to prevent horizontal scrolling on iPad. Issue #1714 2020-02-05 13:46:59 -08:00
Maurice Parker
dfd6be5fa6 Flush are rebuild web view queue when suspending and restoring the app. Issue #1563 2020-02-04 16:00:26 -08:00
Maurice Parker
8ed9958631 Change full article setting to enable or disable the feature. Issue #1773 2020-02-04 11:24:06 -08:00
Maurice Parker
596575c0e8 Delay making the initial web view available to give it some time to load the DOM. Issue #1756 2020-02-01 16:41:10 -08:00
Maurice Parker
8cb28b63b8 Always swap out the web view to prevent white flashing between articles and make loading faster. 2020-01-31 21:07:08 -07:00
Maurice Parker
a0f429448f Call completions immediately if the previous WebViewController was deallocated because the iPad was rotated. Issue #1757 2020-01-30 18:48:51 -07:00
Maurice Parker
ab8deab726 Correct object ownership to remove retain cycle 2020-01-30 12:53:27 -07:00
Nate Weaver
447cc44b8e Put <title> and <base> in the <head> instead of <body> 
This also means renderHTML() is no longer needed.
 2020-01-30 06:15:14 -06:00
Maurice Parker
f9589faa59 Keep queued WKWebViews in a hidden view until they are needed. Issue #1563 2020-01-29 17:39:40 -07:00
Maurice Parker
c293bc3a12 Animate timeline article selection and scrolling when done via article swiping. Issue #1732 2020-01-29 16:31:50 -07:00
Maurice Parker
f96bb9c3e0 Store more article view controller state when destroying and recreating them. Issue #1729 2020-01-29 11:30:52 -07:00
Maurice Parker
dd5633b5ae Change to use the correct URL when reloading an image. 2020-01-27 16:27:13 -07:00
Maurice Parker
3a99e6430f Make the article icon code specify the desired article so that it can't pull the wrong one by mistake. Issue #1707 2020-01-27 12:58:32 -07:00
Maurice Parker
470f2159e8 Remove dead code left from when WebViewController was split from ArticleViewController. 2020-01-27 11:50:28 -07:00
Maurice Parker
97d6c69431 Change to always reload the page when rendering an article. Issue #1713 2020-01-26 20:29:58 -07:00
Maurice Parker
4a63b28c73 Change how next and previous articles are selected so that animation timings can't impact them. Issue #1707 2020-01-26 14:21:04 -07:00
Maurice Parker
bc5a8c3705 Reset scroll position when article is reset. Issue #1716 2020-01-26 13:01:03 -07:00
Maurice Parker
785775801a Don't force cast scrollY as it might not always be set. Issue #1685 2020-01-25 15:36:43 -07:00
Maurice Parker
deab8f8c6c Change to stop recycling the article view controller when switching panel modes on the iPad. Issue #1570 2020-01-21 11:05:47 -07:00
Maurice Parker
61c854b031 Fix animation layer stripping. Issue #1668 2020-01-20 13:16:03 -07:00
Martin Hartl
3370b834b0 Stop media playback when article will disappear 2020-01-20 19:46:23 +01:00
Maurice Parker
7e35bd1ec4 Remove unused parameter. It was obsoleted, but not removed. 2020-01-19 15:36:19 -07:00
Maurice Parker
88f565e03f Use the DOM Y position to restore the scroll offset. This mostly fixes Issue #1494. 2020-01-19 11:48:26 -07:00
Maurice Parker
f0d8a9038d Reload the web view every 10 renderings to clean it up. Issue #1487 2020-01-18 11:59:24 -07:00
Maurice Parker
34984551c6 Fully reload the page when the content size changes. Issue #1642 2020-01-17 12:53:50 -07:00
Maurice Parker
f9e529bd3b Fix multiwindow auto layout errors. Issue #1636 2020-01-16 21:29:10 -07:00
Maurice Parker
2584462bc1 Fix scrolling code so that it takes into consideration the content is under the bars now. Issue #1633 2020-01-16 19:40:13 -07:00
Maurice Parker
4eedd96507 Fix regression that prevented Safari from opening from Activity dialog. 2020-01-15 18:23:09 -07:00
Maurice Parker
3e604e0b34 Load the feed article if the extracted article fails to parse. Issue #1542 2020-01-15 17:34:02 -07:00
Maurice Parker
c384362a78 Set extractor button state on viewDidLoad. Issue #1627 2020-01-15 17:28:37 -07:00
Kiel Gillard
0d0b6b8fa6 Gives iOS a chance to open universal links. #1625 2020-01-16 09:56:51 +11:00
Martin Hartl
c739d77817 Provide dedicated TitleActivityItemSource when sharing to Omnifocus and Things 2020-01-11 09:12:41 +01:00
Maurice Parker
f1e01bd43f Automatically show the nav and toolbars when separating controllers. Issue #1593 2020-01-09 21:22:29 -07:00
Maurice Parker
1b1b3e796e Shoehorn the controller into the little area allowed for context previews in landscape. Issue #1569 2020-01-09 21:11:13 -07:00
Maurice Parker
9fedf68b3f Add action to Share button to open in Safari. Issue #1573 2020-01-09 18:27:52 -07:00
Maurice Parker
3115abc72e Enhance accessibility for toggle toolbar buttons. Issue #1581 2020-01-09 14:38:25 -07:00
Maurice Parker
96c781f468 Change so that we don't crash if the article extractor completes and its delegate is deallocated. Issue #1566 2020-01-08 11:22:11 -07:00
Maurice Parker
15569e62b2 Prevent crash when the web view load hasn't set up the tap zone constraints. Issue #1564 2020-01-08 10:54:41 -07:00
Maurice Parker
c2d298b836 Add the image title text to zoomed images. Issue #1468 2019-12-31 18:06:27 -07:00
Maurice Parker
f0a5309786 Fix bug that prevented first article from being selected on iPad. 2019-12-31 17:06:13 -07:00
Maurice Parker
af76e44c0f Changed ArticleViewController to utilize UIPageViewController to provide gesture based navigation. 2019-12-31 16:55:39 -07:00
Maurice Parker
00ed368683 Change the full screen tap zone to be the center of the navigation bar instead of the whole navigation bar. Issue #1450. 2019-12-26 12:21:56 -07:00
Brent Simmons
15184aa3f1 Finish changes mandated by DatabaseQueue changes. 2019-12-16 22:45:59 -08:00
Maurice Parker
6f2e6a7d9a Add mask back in so that the zoom image doesn't overlay the bars when zooming back. 2019-12-10 17:54:14 -07:00
Maurice Parker
9b3793968f Change image zoom animation to take safe area into consideration when determining image origin. Issue #1425 2019-12-09 14:29:17 -07:00
Maurice Parker
2ea8253e25 Make navigation and toolbars transparent. Issue #1413 2019-12-07 11:53:53 -07:00
Maurice Parker
87a82eb290 Remove attempt to remove the context menu interaction. 2019-11-29 18:16:27 -06:00
Maurice Parker
d62ff04c64 Fix next unread menu option when in fullscreen. 2019-11-29 13:26:14 -06:00
Maurice Parker
549bf3197c Show article extractor target state in context menu. 2019-11-25 20:36:15 -06:00
Maurice Parker
323b160b7f Add context menu for Fullscreen mode actions. Issue #1344 2019-11-25 19:43:43 -06:00
Maurice Parker
cd493730b1 Hide bars when returning to the foreground so that they don't come back. 2019-11-24 14:49:44 -06:00
Maurice Parker
69aeacd98d Add fullscreen article setting/functionality. Issue #1343 2019-11-24 14:18:58 -06:00
Maurice Parker
2c7ec88087 Removed dead code. 2019-11-24 13:41:32 -06:00
Maurice Parker
5c4cd072ce Make next unread button work with new async feed functionality. 2019-11-24 13:37:56 -06:00
Maurice Parker
06d3c35206 Rollback POC code that shouldn't have gotten added 2019-11-24 10:01:47 -06:00
Maurice Parker
88707517e8 Make sliders should be quantized. Issue #1342 2019-11-24 09:41:50 -06:00
Maurice Parker
7033879704 Animate safe area inset changes. Issue #1341 2019-11-24 03:42:38 -06:00
Maurice Parker
e26f20449c Adjusted so that tap zones only appear for fullscreen. Issue #1331 2019-11-23 11:07:40 -06:00
Maurice Parker
56d43f8f2d Do a full reload of the article when rearranging the UI to accommodate for split screen color changes. 2019-11-20 18:16:54 -06:00
Maurice Parker
198dec68b1 Reload Article images when their availablity notification arrives. Issue #1317 2019-11-18 19:33:31 -06:00
Maurice Parker
fc235a029e Remove toolbar autohiding and add optional fullscreen mode. 2019-11-18 19:12:24 -06:00
Maurice Parker
52652d1670 Auto hide toolbar on scroll. 2019-11-17 20:20:50 -06:00
Maurice Parker
701070f2dd Make Article icons/avatars match Timeline icons/avatars. Issue #1273 2019-11-12 09:22:23 -06:00
Maurice Parker
a232c5c040 Remove restore title hack that should have been removed when Reader was moved away from the title. Issue #1271 2019-11-07 15:03:54 -06:00
Maurice Parker
94d60fbf34 Remove unnecessary dispatch 2019-11-07 15:00:43 -06:00
Maurice Parker
ac2506fd64 Don't cache icon views used by the web view. 2019-11-07 14:58:58 -06:00
Maurice Parker
4f294c4d20 Make Article icons/avatars match Timeline icons/avatars Issue #1274 2019-11-07 14:29:16 -06:00
Maurice Parker
fc577d3266 Exchange share and reader button positions. 2019-11-06 08:08:08 -06:00
Maurice Parker
4f1e1ef0c2 Move Reader button to Safari button position on Article View. Issue #1260 2019-11-06 08:00:20 -06:00
Maurice Parker
47293cc073 Make zoomed images use the full width. Issue #1229 2019-11-01 16:11:14 -05:00
Maurice Parker
fe7f6bb8df Make image zoom fetch requests cancellable. Issue #1178 2019-10-30 11:06:55 -05:00
Maurice Parker
9de38b00b9 Reset scrollview zoom level when reloading html. Issue #1216 2019-10-30 04:52:49 -05:00
Maurice Parker
6a281c7672 Replace Mark All as Read with progress indicator. Issues #1157 and #1165 2019-10-25 13:34:59 -05:00
Maurice Parker
3a314d2db7 Add activity indicator for image fetches. 2019-10-19 16:25:06 -05:00
Maurice Parker
76d7c0256a Fix full screen image background color for dark mode 2019-10-16 20:53:49 -05:00
Maurice Parker
eca5f8259a Enhance full image view support to work with 3 panel mode and split window views 2019-10-16 20:20:36 -05:00
Maurice Parker
6c562f93b5 Add a masking subview so that the image appears to slide under the nav and toolbars 2019-10-16 19:32:33 -05:00
Maurice Parker
cb6490222f Change image zoom animation to be a solid picture zooming in and out 2019-10-16 16:40:49 -05:00
Maurice Parker
3ddd14d856 Change zoom out animation to make the view controller appear faster 2019-10-16 11:55:08 -05:00
Maurice Parker
1ebb0e60c3 Simplify transition handoff 2019-10-16 11:34:18 -05:00
Maurice Parker
0182fb7296 Use a wrapper class to prevent a circular reference between the web view and the article controller 2019-10-16 11:31:20 -05:00
Maurice Parker
42bccc2fea Remove obsolete code 2019-10-15 20:13:08 -05:00
Maurice Parker
11e9f468d6 Refinement of the full screen image view animation. 2019-10-15 19:52:00 -05:00
Maurice Parker
425b3b09a1 Animate the transition to full screen image view 2019-10-15 18:08:13 -05:00
Maurice Parker
4759cedd35 Use Javascript to fetch to the image for the ImageViewController 2019-10-13 19:41:34 -05:00
Maurice Parker
bebf69ef74 Set bounds on share popover 2019-10-12 16:54:24 -05:00
Maurice Parker
60fb58ecaa Add share button to full screen image view. 2019-10-12 15:27:38 -05:00
Maurice Parker
3ee0506b4a Add fullscreen image previewing and zooming 2019-10-12 14:45:44 -05:00
Maurice Parker
608da70e8e Launch Safari when web preview is tapped. Issue #1090 2019-10-01 11:09:46 -05:00
Maurice Parker
4e6e61842a Make sure the web view has been initialized before deallocating it. 2019-10-01 03:51:05 -05:00
Maurice Parker
17c33b75e9 Make the reader view button have a larger hitbox 2019-09-27 17:32:13 -05:00
Maurice Parker
da4715c6d1 Fix disappearing reader view button 2019-09-27 17:23:38 -05:00
Maurice Parker
65356424d9 Change reader button to be a system button 2019-09-27 14:09:28 -05:00
Maurice Parker
67e6408da0 Make reader button bigger so that it can be tapped easier 2019-09-27 13:07:33 -05:00
Maurice Parker
79e7653619 Change disabled color of reader view button to match other bar button items when disabled 2019-09-27 12:12:12 -05:00
Maurice Parker
9da949114f Move location of Reader View button 2019-09-27 11:20:26 -05:00
Maurice Parker
98befac78c Animate reader view button 2019-09-24 16:34:11 -05:00
Maurice Parker
026c7cfd6d Initial article extractor implementation for iOS 2019-09-24 06:46:53 -05:00
Maurice Parker
394618a687 Rename DetailViewController to ArticleViewController to fix name collision 2019-09-24 04:29:15 -05:00