Ethan Wong
7402594d7c
Prevent RSCore from being embedded into ShareExtention and cleanup 'Delete Frameworks' code.
2021-05-24 13:08:25 +08:00
Ethan Wong
2579b7975a
Make SyncDatabase explicitly depend on RSCore to resolve signing issue
2021-05-23 21:23:30 +08:00
Brent Simmons
7558120dc3
Update appcast for 6.0.3b1.
2021-05-20 20:08:02 -07:00
Maurice Parker
e56560a928
Remove the deep signing code flag.
2021-05-18 19:35:59 -05:00
Brent Simmons
f9f5f09c60
Merge pull request #3112 from heckj/unsafe_os_unfair_lock
...
fixing name of lock
2021-05-10 12:29:23 -07:00
Joe Heck
3409275a23
fixing name of lock
2021-05-10 11:55:24 -07:00
Brent Simmons
a6a641d1c5
Merge pull request #3111 from heckj/unsafe_os_unfair_lock
...
replacing os_unfair_lock with NSLock
2021-05-10 11:22:20 -07:00
Joe Heck
8df105aad4
replacing os_unfair_lock with NSLock
...
learned that os_unfair_lock with & was quite unsafe when used within
swift. Apparently in swift, &foo in Swift means "make a copy of foo and
pass it inout to a function, then overwrite its value with whatever
the function did to it when that function returns."
And if you're using it within a struct, it's apparently even more
dangerous. because the address of self can change from call to call
— self might not even have an address, it might be contained in
registers only.
Using NSlock will be a smidge less performant, but notably more safe.
2021-05-10 11:14:04 -07:00
Maurice Parker
2f32a4b928
Move deep signing flag to xcconfig files
2021-05-06 06:36:11 -05:00
Brent Simmons
fa0744ed2c
Merge pull request #3100 from greenbuffo/fix/2916
...
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
2021-05-01 11:16:50 -07:00
Chris Campbell
364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
...
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
Chris Campbell
bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
...
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
Brent Simmons
8e34187821
Merge pull request #3083 from babbage/docs/spm
...
Minor technotes updates
2021-04-27 18:00:15 -07:00
Duncan Babbage
336f3e7a17
Technotes: Swift Packages, AppDefaults not DB5
...
Revise additonal reference to Git submodules.
2021-04-27 16:50:05 +12:00
Brent Simmons
2fd7d8549e
Merge pull request #3078 from babbage/patch-1
...
Update Coding Guidelines
2021-04-25 20:04:00 -07:00
Duncan Babbage
e0d5dd69a2
Update Coding Guidelines
...
Minor edit, as discussed in NNW Slack.
2021-04-26 14:36:07 +12:00
Brent Simmons
3842e1c368
Merge pull request #3032 from stuartbreckenridge/fix/code-sign-xcode12_5
...
Adds —deep code sign flag for Xcode 12.5
2021-04-21 19:02:12 -07:00
Stuart Breckenridge
036dbf297c
Adds —deep code sign flag for Xcode 12.5
2021-04-22 09:43:07 +08:00
Brent Simmons
77cd189c75
Merge pull request #3021 from stuartbreckenridge/fix/3014
...
Naming convention for notification options
2021-04-21 18:02:11 -07:00
Stuart Breckenridge
cde7bf9589
restores storyboard to previous commit
2021-04-22 09:00:06 +08:00
Brent Simmons
6ed3b1227e
Merge pull request #3010 from uruha-komachin/main
...
Fixed missing argument `validateFeed:`
2021-04-21 17:05:20 -07:00
Brent Simmons
b52292d459
Update appcasts for 6.0.2.
2021-04-20 17:46:11 -07:00
Brent Simmons
df06abcb79
Remove no-longer-used appcast.
2021-04-20 17:39:41 -07:00
Stuart Breckenridge
5af2643479
standardised naming
2021-04-19 11:21:00 +08:00
Stuart Breckenridge
d4130e7c65
Corrects naming convention
...
[iOS]
Twitter: Notify about new tweets
Reddit: Notify about new posts
Default: Notify about new articles
+ Fixes alignment issues in the inspector view
[macOS]
Twitter: Show notifications for new tweets
Reddit: Show notifications for new posts
Default: Show notifications for new articles
2021-04-19 11:10:57 +08:00
Komachin
7a5581a2c7
Fixed missing argument validateFeed:
...
Based on the newest API, `public func createWebFeed(url: String, name: String?, container: Container, validateFeed: Bool, completion: @escaping (Result<WebFeed, Error>) -> Void)`, there should be a `validateFeed:` argument.
2021-04-17 10:38:40 +01:00
Brent Simmons
8e2de9237c
Update appcast for 6.0.2b1.
2021-04-15 19:50:59 -07:00
Maurice Parker
77dd2e5e22
Merge branch 'mac-release' into main
2021-04-15 14:31:52 -05:00
Maurice Parker
6a4c761ed8
Merge branch 'ios-candidate' into main
2021-04-15 14:30:32 -05:00
Maurice Parker
3955151daf
Make sure mark as read completes before searching for the next unread. Fixes #2952
2021-04-15 14:29:49 -05:00
Maurice Parker
92fd016b7a
Exclude Inoreader from article status syncs
2021-04-15 14:17:25 -05:00
Maurice Parker
8f0519ca47
Fix regression where marking all as unread wouldn't take you back to the sidebar
2021-04-15 14:17:06 -05:00
Maurice Parker
f2bbacc871
Add completion callbacks so that we can ensure that unreads have been marked before determining the next unread. Fixes #2993
2021-04-15 14:16:51 -05:00
Maurice Parker
8307a64b7b
Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate
2021-04-15 14:13:24 -05:00
Maurice Parker
091ef7aba2
Exclude Inoreader from article status syncs
2021-04-15 14:13:15 -05:00
Brent Simmons
ebc10b54c1
Bump build to 601.
2021-04-13 19:52:48 -07:00
Stuart Breckenridge
70cf3a303a
reworked gaurd statement
2021-04-13 07:55:22 -05:00
Stuart Breckenridge
1b3a070389
Fixes #2994
...
Removes force unwrapping and returns an empty string if the pubDate cannot be determined.
2021-04-13 07:55:05 -05:00
Maurice Parker
0ac3ba0bbb
Change force unwraps so that we just fail on the move instead of crashing
2021-04-13 07:38:41 -05:00
Brent Simmons
4355d7617a
Merge pull request #2996 from stuartbreckenridge/fix/2994
...
Fixes #2994
2021-04-12 21:18:49 -07:00
Stuart Breckenridge
7df2fa5b1e
reworked gaurd statement
2021-04-13 12:17:31 +08:00
Stuart Breckenridge
307b24af1b
Fixes #2994
...
Removes force unwrapping and returns an empty string if the pubDate cannot be determined.
2021-04-13 12:00:50 +08:00
Maurice Parker
d418835086
Merge branch 'ios-candidate' into main
2021-04-12 21:09:56 -05:00
Maurice Parker
c47480614c
Fix regression where marking all as unread wouldn't take you back to the sidebar
2021-04-12 21:09:34 -05:00
Maurice Parker
f0ab588c0f
Update to latest Account API.
2021-04-12 19:46:59 -05:00
Maurice Parker
c25c8c0739
Merge branch 'ios-candidate' into main
2021-04-12 19:43:37 -05:00
Maurice Parker
991297165b
Add completion callbacks so that we can ensure that unreads have been marked before determining the next unread. Fixes #2993
2021-04-12 19:42:05 -05:00
Maurice Parker
c95daa208f
Add completion callbacks so that we can ensure that unreads have been marked before determining the next unread. Fixes #2993
2021-04-12 19:41:01 -05:00
Maurice Parker
11e2a3eca8
Change so that sync accounts have a Remove button instead of a Delete button. Fixes #2991
2021-04-12 13:48:54 -05:00
Maurice Parker
3a1b3f96bb
Change so that sync accounts have a Remove button instead of a Delete button. Fixes #2991
2021-04-12 13:48:03 -05:00
