Commit Graph

2393 Commits

Author SHA1 Message Date
Brent Simmons 66d9333999 Make minor code formatting changes so that TimelineViewController matches our current thinking. Also delete some commented-out and unused code. 2019-09-16 22:27:17 -07:00
Brent Simmons f7c9cc1dbd Remove no-longer needed machinery for updating the timeline on dark-mode/light-mode appearance changes. 2019-09-16 22:09:58 -07:00
Brent Simmons a05fd61085 Merge branch 'imagecache' into mac-release 2019-09-16 20:07:31 -07:00
Brent Simmons 2d22f061a5 Remove no-longer-needed functions for compositing the avatar on a background. 2019-09-16 20:07:07 -07:00
Brent Simmons a225d52ba3 Use the new TimelineAvatarView instead of an NSImageView in TimelineTableCellView. 2019-09-16 20:01:30 -07:00
Brent Simmons 506b621e5d Draw the avatar background in TimelineAvatarView only if the icon is too short vertically. 2019-09-16 20:00:32 -07:00
Brent Simmons 2f9f4e263c Restore color for light avatar background. 2019-09-16 19:59:33 -07:00
Maurice Parker 1d7cbe5596 Fix super wide div's. Issue #1010 2019-09-16 18:12:56 -05:00
Maurice Parker 0458fd3838 Delete avatar and favicon image caches every three days 2019-09-16 16:26:40 -05:00
Brent Simmons 8a2d1f5f6a Create TimelineAvatarView, which draws the background for images that need it. 2019-09-15 23:02:13 -07:00
Maurice Parker 7c3c78b796 Remove debug print statement 2019-09-15 04:08:10 -05:00
Maurice Parker dc67c9f03b Update to latest RSCore 2019-09-15 04:06:24 -05:00
Maurice Parker 20dda3727b Change to use the scaled avatar version of the favicon. 2019-09-15 04:05:11 -05:00
Maurice Parker b07bf73f78 Revert "Scale images, when needed, before generating inline HTML data in ArticleRenderer — this keeps us from getting huge amounts of data, which slows down rendering."
This reverts commit c3e26ea307.
2019-09-15 04:00:24 -05:00
Brent Simmons c3e26ea307 Scale images, when needed, before generating inline HTML data in ArticleRenderer — this keeps us from getting huge amounts of data, which slows down rendering. 2019-09-14 22:41:13 -07:00
Brent Simmons 6377cbc379 Bump version to 5.0.2. 2019-09-14 11:08:34 -07:00
Brent Simmons 73471bc6cd Update RSCore to get Daniel’s app movement monitor fix. 2019-09-14 10:46:05 -07:00
Brent Simmons 744d43ddd9 Bump version to 5.0. 2019-09-11 22:26:09 -07:00
Maurice Parker 57542592cb Correct which view should become the first responder. Issue #1014 2019-09-11 17:47:02 -05:00
Brent Simmons 1b7a46e505 Bump version to 5.0.1b1. 2019-09-10 20:32:15 -07:00
Brent Simmons 7ad0b6b604 Always update the unread count in the timeline after doing a sync fetch after representedObjects changes. Reload visible cells whenever showFeedNames changes. Fix #923. 2019-09-10 20:28:16 -07:00
Maurice Parker 8dda681409 Add accessibility labels to Sidebar, Timeline, and Article. Issue #934 2019-09-10 11:09:17 -05:00
Brent Simmons 41c82eca15 Rename existingFeed(with:) to existingFeed(withFeedID:) to make it more clear. Make account.idToFeedDictionary private — callers should use existingFeed(withFeedID:). 2019-09-08 21:44:05 -07:00
Brent Simmons f5f306f60f Add comments to feed.iconURL and feed.faviconURL, explaining that these are set only if that info was part of the feed (which is a JSON-Feed-only feature). 2019-09-08 21:17:57 -07:00
Maurice Parker 0961753357
Merge pull request #998 from hisaac/mac-release
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 13:02:58 -05:00
Isaac Halvorson 8b635fc04c Add command arrow key shortcuts to sidebar shortcuts plist 2019-09-08 12:54:26 -05:00
Maurice Parker 7ca2226669 Move credentials classes to the Account framework in NetNewsWire 2019-09-08 04:28:43 -05:00
Brent Simmons 53370ff0d3 Bump version to 5.0.1d2. 2019-09-07 20:45:10 -07:00
Brent Simmons c05e55af41 Update to latest RSCore. 2019-09-07 18:31:07 -07:00
Brent Simmons 5b15285e8e Make sure that article.preferredLink doesn’t return an empty string. 2019-09-07 18:27:48 -07:00
Brent Simmons 60f13c32a4 Update to latest RSParser. 2019-09-06 20:00:06 -07:00
Brent Simmons 6dce9eb0ec Update to latest RSParser. 2019-09-06 19:50:02 -07:00
Brent Simmons 58c2fad2fd Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976. 2019-09-06 19:28:06 -07:00
Brent Simmons d49b212bc2 Delete unused EvergreenLarge.png. 2019-09-06 19:11:41 -07:00
Maurice Parker 0e7d971e65 Queue a reload of all visible cells anytime a favicon is downloaded. Issue #995 2019-09-06 16:52:31 -05:00
Brent Simmons 809c2fdfc5
Merge pull request #993 from danielpunkass/fix-extension-versioning-backport
mac-release targeted version of the fix for #989
2019-09-06 12:45:52 -07:00
Daniel Jalkut d79bbefeb8 mac-release targeted version of the fix for #989 2019-09-06 15:40:59 -04:00
Maurice Parker 7a242b2c15
Merge pull request #988 from danielpunkass/app-movement-monitor
Instantiate an RSAppMovementMonitor to track user movement of the app…
2019-09-06 08:33:40 -05:00
Daniel Jalkut 8e01e8e45a Instantiate an RSAppMovementMonitor to track user movement of the application while running. Fixes #897. 2019-09-06 09:13:09 -04:00
Maurice Parker dc64fa2bda
Merge pull request #980 from good/mac-release
Enforces auto-height for images to fix improper resizing
2019-09-05 13:11:15 -05:00
Brian Warren ce3ec10c95 Enforcing automatic height for images in the template 2019-09-05 10:59:16 -07:00
Brent Simmons f0d080b0be Remove blank line from near top of About window credits. 2019-09-04 21:04:21 -07:00
Brent Simmons 5ad307411d Bump version to 5.0.1d1 2019-09-04 21:00:59 -07:00
Maurice Parker 7a8d23958b Restrict iframe width to be at most 100% 2019-09-04 17:41:58 -05:00
Maurice Parker 25466a8aef
Merge pull request #964 from tpritc/mac-release
Fix for bug #959 — Detail stylesheet doesn't account for figures
2019-09-04 14:13:31 -05:00
Thomas Pritchard 091b43a9fb Apply figure styles to iOS as well 2019-09-04 19:58:30 +01:00
Thomas Pritchard d3ad4b52a3 Set a sensible line height for figure captions 2019-09-04 19:58:29 +01:00
Thomas Pritchard 5976923f23 Add figures to Mac detail stylesheet 2019-09-04 19:58:29 +01:00
Brent Simmons 0ba8f3b4e1 Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898. 2019-09-03 22:58:17 -07:00
Brent Simmons cbaad4bdeb Add checkbox to Preferences > General for turning off the unread count in the Dock. 2019-09-03 22:17:31 -07:00