Commit Graph

305 Commits

Author SHA1 Message Date
Nate Weaver 447cc44b8e Put <title> and <base> in the <head> instead of <body>
This also means renderHTML() is no longer needed.
2020-01-30 06:15:14 -06:00
Maurice Parker c6beb3c9dd Don't try to convert to an absolute img url when the img url is already absolute. Issue #1726 2020-01-28 15:39:02 -07:00
Nate Weaver b9bba7b614 Update RSWeb 2020-01-27 23:02:01 -06:00
Maurice Parker dd5633b5ae Change to use the correct URL when reloading an image. 2020-01-27 16:27:13 -07:00
Maurice Parker 3a99e6430f Make the article icon code specify the desired article so that it can't pull the wrong one by mistake. Issue #1707 2020-01-27 12:58:32 -07:00
Maurice Parker 97d6c69431 Change to always reload the page when rendering an article. Issue #1713 2020-01-26 20:29:58 -07:00
Maurice Parker f15ade5ebb Make the article datetime always a link to the article permalink. Issue #1655 2020-01-19 17:28:06 -07:00
Maurice Parker 7e35bd1ec4 Remove unused parameter. It was obsoleted, but not removed. 2020-01-19 15:36:19 -07:00
Nate Weaver 7ee1f99962 Updates for Data+RSCore changes 2020-01-18 19:18:58 -06:00
Nate Weaver b35215d03b Update for pending RSCore String updates 2020-01-17 13:45:38 -06:00
Maurice Parker 539722d685 Change Feedbin Twitter images to use the canonical source instead of Feedbin image servers. 2020-01-17 11:41:04 -07:00
Maurice Parker 38ef0c2515 Convert src to use Feedbin proxy images when they are available. Issue #1632 2020-01-16 17:14:38 -07:00
Nate Weaver 6eac3781ba Update to latest RSCore
Update use of OMPLString().
2020-01-13 22:20:57 -06:00
Nate Weaver 58c90feccf Update to latest RSCore 2020-01-13 15:32:13 -06:00
Nate Weaver e94985e7f2 Update to latest RSCore 2020-01-12 18:26:41 -06:00
Maurice Parker a8951089c3 Change to work with only article id's. Issue #1595 2020-01-11 12:51:13 -07:00
Maurice Parker 911d4ed248 Change dark image detection to only consider non-clear pixels and not fail on images with no luminescence. Issue #1607 2020-01-11 12:25:31 -07:00
Nate Weaver ca429153ce Update to latest RSCore 2020-01-11 01:30:40 -06:00
Nate Weaver 0b404c294d Update to newest RSCore 2020-01-09 18:22:06 -06:00
Maurice Parker 92cfbc767b
Merge pull request #1553 from hartlco/1548-mark-above-below-as-read-should-not-appear-if-nothing-to-mark
Only show mark unread above/below actions if articles above/below contain unread items
2020-01-07 16:47:37 -07:00
Nate Weaver 645c3deba1 Use new MacroProcessor replacement 2020-01-07 16:06:41 -06:00
Martin Hartl 02ab44c3eb Only show mark unread above/below actions if articles above/below contained unread items 2020-01-07 22:48:15 +01:00
Maurice Parker 0a29535412
Merge pull request #1496 from Wevah/table-overflow-wrapper
Table overflow wrapper
2019-12-31 16:24:43 -07:00
Nate Weaver fcea33d61f Only strip out color, background, and font css properties
Prevents icon images from rendering super-huge.
2019-12-30 18:30:10 -06:00
Nate Weaver 792fcddaf6 Update comment 2019-12-30 17:35:47 -06:00
Nate Weaver 58ef7600fb Avoid copying the table and use querySelector()
(Since there's only one .articleBody.)
2019-12-30 17:24:34 -06:00
Nate Weaver 7a61a6a5b4 Specify div explicitly 2019-12-30 17:24:34 -06:00
Nate Weaver c2d3e9213d Strip spans from pre elements inside table cells
Works around a clipping issue.
2019-12-30 17:17:35 -06:00
Nate Weaver bb0fffcec2 Move wrapTables() to just after wrapFrames() 2019-12-30 17:17:35 -06:00
Nate Weaver cbbb46a776 Wrap tables in an overflow-x: auto; div 2019-12-30 17:17:35 -06:00
Maurice Parker a1b23edc8b Delete obsolete code 2019-12-28 16:06:37 -07:00
Brent Simmons 15184aa3f1 Finish changes mandated by DatabaseQueue changes. 2019-12-16 22:45:59 -08:00
Maurice Parker 58b24f3349 Rename callback: to completion: 2019-12-14 18:01:34 -07:00
Brent Simmons a1675f0640 Fix a build warning in the Mac version. 2019-12-07 22:23:55 -08:00
Nate Weaver 71bc1e5d8a Return the app icon earlier so we never hit the favicon cache 2019-12-07 16:09:32 -06:00
Nate Weaver bf4dd59d90 Use the app icon for the NNW feed 2019-12-07 15:45:33 -06:00
Maurice Parker f159371967 Change to make sure all queue's get cleared before suspending the database. Issue #1389 2019-12-02 14:14:35 -06:00
Maurice Parker aae5b1dc48 Remove filtering of Accounts and Smartfeeds. Issue #1377 & #1376 2019-12-01 17:54:34 -06:00
Maurice Parker d9f2e13732 Suspend and resume account resources when moving between the background and foreground. 2019-12-01 16:51:25 -06:00
Maurice Parker 3d582270ad Add filter exceptions so that the correct timeline is always selected regardless of filter state. Issue #1366 2019-11-28 12:40:33 -06:00
Maurice Parker 30f560be4d Convert Feedly and Mercury to use the new Secrets system. 2019-11-27 17:20:09 -06:00
Maurice Parker 748f4e64d3
Merge pull request #1364 from jbennett/manage-secrets
Generalize handling of secrets and keys
2019-11-27 16:54:24 -06:00
Nate Weaver 64af8840fe Mark appropriate caches as dirty 2019-11-27 15:45:14 -06:00
Nate Weaver f690bba775 Make sure self.postDidLoadFaviconNotification() is always called after a download attempt
Otherwise the rest of the favicon URLs won't be tried.
2019-11-27 15:40:35 -06:00
Maurice Parker ef2222ad94 Merge branch 'mac-release' 2019-11-27 14:08:52 -06:00
Nate Weaver 9de27febf0 Fix favicon loading for sites with multiple/invalid favicons
Load the next favicon if a favicon is invalid

Iterate through multiple favicons and use the first that actually loads

- Add a homePageURL property to SingleFaviconDownloader that notification observers can use.
- Only add a URL to the favicon cache when we're sure it's valid.

Post notification even if the icon failed to load

Update RSParser

Remove single-favicon helper methods

Only load the next favicon if the current load failed

Update RSParser

Make sure to try the default favicon.ico

RSParser test fix update

Update RSParser
2019-11-27 13:02:49 -06:00
Maurice Parker 81c4756f97 Persist article read filters across application launches. Issue #1349 2019-11-27 11:43:36 -06:00
Jonathan Bennett 544daf5756 handle missing secrets
Missing secrets will give a blank string instead of exploding.

Also, an example of a custom property
2019-11-27 11:30:27 -05:00
Jonathan Bennett d3dd7498e6 generate the secret property automatically 2019-11-27 11:20:43 -05:00
Maurice Parker ebd7f4904d Persist the Feeds Read filter across application launches. Issue #1349 2019-11-26 20:23:12 -06:00
Maurice Parker 9de3caf3a0 Make persistentIdentifier iOS only for now. 2019-11-26 17:00:13 -06:00
Maurice Parker 4a9e79cd1e Persist and restore container expanded state across application launches. Issue #1361 2019-11-26 16:33:11 -06:00
Jonathan Bennett 9d0034576d start extracting secrets 2019-11-26 08:58:16 -05:00
Maurice Parker 323b160b7f Add context menu for Fullscreen mode actions. Issue #1344 2019-11-25 19:43:43 -06:00
Maurice Parker 6a56936850 Moved expanded state away from Node so that it won't get lost on rebuilds. Issue #1346 2019-11-24 18:29:00 -06:00
Maurice Parker 9f60984ba2 Increase the number of characters available for the summary in the timeline. Issue #1333 2019-11-23 18:22:58 -06:00
Maurice Parker 6d18cfec7c Refactor SmartFeedController to find SmartFeeds by FeedIdentifier instead of the string identifier. 2019-11-23 12:30:18 -06:00
Maurice Parker 7667dbf60e Add hide read feeds menu option 2019-11-22 10:55:54 -06:00
Maurice Parker eea5d6f327 Change ReadFilter to ReadFilterType and differentiate the ReadFilter from the query filter. 2019-11-22 09:40:39 -06:00
Maurice Parker a5b4d570af Change ReadFilter case unavailable to alwaysRead 2019-11-22 09:32:27 -06:00
Maurice Parker 6d8fca01ea Filter async requests based on ReadFilter. 2019-11-21 19:54:35 -06:00
Maurice Parker e8826130a4 Add timeline filter button 2019-11-21 18:22:43 -06:00
Maurice Parker 64c1a615b0 Make sure top level nodes are always expanded. 2019-11-21 16:25:00 -06:00
Maurice Parker 89e9a7b80e Add filter button show/hide unread feeds. Issue #1311 2019-11-21 15:55:50 -06:00
Maurice Parker 56d43f8f2d Do a full reload of the article when rearranging the UI to accommodate for split screen color changes. 2019-11-20 18:16:54 -06:00
Maurice Parker 198dec68b1 Reload Article images when their availablity notification arrives. Issue #1317 2019-11-18 19:33:31 -06:00
Maurice Parker 397d8e8ffa Update picker for Share Extension to be hierarchical and use icons. Issue #1269 2019-11-16 19:44:01 -06:00
Maurice Parker 91a3e4fd73 Change Add Web Feed folder selection to be a separate controlling instead of the picker wheel. Issue #1270 2019-11-16 12:02:58 -06:00
Maurice Parker 5283d2efbe Implement Feed protocol. 2019-11-15 06:19:14 -06:00
Maurice Parker 06bd5b3a6f Renamed Feed and related classes/instances to WebFeed 2019-11-14 20:11:41 -06:00
Maurice Parker 15e62a0750 Update Mac app to work with latest ActivityManager. 2019-11-14 15:35:19 -06:00
Maurice Parker 0d66259650 Add ArticleFetcherType and change state restoration to use new type. 2019-11-14 15:06:32 -06:00
Maurice Parker c366a55cb5 Change to use Favicon generator. 2019-11-12 15:36:03 -06:00
Maurice Parker 701070f2dd Make Article icons/avatars match Timeline icons/avatars. Issue #1273 2019-11-12 09:22:23 -06:00
Maurice Parker 866988edcf Correct deep link comments. 2019-11-11 13:47:28 -06:00
Maurice Parker 8a69657b54 Convert all image locations to be absolute. Issues #954 & 1280 2019-11-09 17:37:25 -06:00
Maurice Parker 62d7fe34f1 Unify the cache deletion code between iOS and Mac now that the Mac uses the caches directory. 2019-11-08 12:20:21 -06:00
Maurice Parker 4f294c4d20 Make Article icons/avatars match Timeline icons/avatars Issue #1274 2019-11-07 14:29:16 -06:00
Maurice Parker 238289ec5d Ignore Feed Icon in special cases. Issue #1265 2019-11-06 17:59:27 -06:00
Maurice Parker b0f9d97650 Discard images that are too wide to be used as icons. Issue #1264 2019-11-06 17:36:05 -06:00
Maurice Parker 560f36621f Add IconImage to encapsulate our icon processing logic 2019-11-05 18:05:57 -06:00
Maurice Parker 68cb9258c5 Clean up deleted and inactive accounts from Smartfeeds. Issue #1205 2019-11-01 19:26:32 -05:00
Maurice Parker 0f5210d92f Change image processing queues to default quality of service 2019-10-31 14:39:35 -05:00
Maurice Parker 8eb99b01c3 Increase default icon brightness 2019-10-31 14:25:09 -05:00
Maurice Parker 8ba15c6234 Cache favicon to homepage mappings 2019-10-31 14:04:34 -05:00
Maurice Parker 5bcb5a982f Cache home pages with no icon between launches 2019-10-31 13:38:38 -05:00
Maurice Parker 1e7b71a482 Use correct queues for user interface elements 2019-10-31 12:22:37 -05:00
Maurice Parker 94f31b18bc Automatically show the add feed sheet if the user asks to continue in the app on a failed Siri Add Feed 2019-10-20 19:05:11 -05:00
Maurice Parker c18f5f7537 Change ActivityManager to use ArticleStringFormatter to remove embedded HTML escape stuff 2019-10-20 02:33:28 -05:00
Maurice Parker 00f100e3a3 Renamed TimelineStringFormatter to ArticleStringFormatter now that it is used for much more than the timelines 2019-10-20 02:28:00 -05:00
Maurice Parker ee3a767cf7 Add required user info keys to user activities. 2019-10-19 18:21:58 -05:00
Maurice Parker e54cb90295 Delete donated shortcuts. Issue #904 2019-10-18 13:01:28 -05:00
Brent Simmons 1d45796220 Merge mac-release. 2019-10-17 22:11:35 -07:00
Brent Simmons 56fab24cec Make importing NetNewsWire 3 subscriptions a one-step process — use an accessory view in the NSOpenPanel. Also: refactor to use immutable structs instead of classes; use static methods on structs; reduce API surface; don’t flatten sub-folders (let the OPML importer handle the flattening, which it already does). 2019-10-17 13:25:11 -07:00
Brent Simmons 618a22916d Merge branch 'mac-release' 2019-10-13 22:20:05 -07:00
Brent Simmons b1497c0626 Merge branch 'mac-release' 2019-10-13 22:08:34 -07:00
Maurice Parker a1f26898c8 Split Mac and iOS specific javascript into individual files. 2019-10-13 15:47:11 -05:00
Maurice Parker 3ee0506b4a Add fullscreen image previewing and zooming 2019-10-12 14:45:44 -05:00
Maurice Parker a2a4616a48 Remove article notification when an article is read 2019-10-04 11:20:57 -05:00
Maurice Parker f7fd003f3c Make article extractor report correct state on failed Mercury parses 2019-10-04 07:39:49 -05:00