Commit Graph

389 Commits

Author SHA1 Message Date
Maurice Parker bffcfdd67d Add share operator to sidebarItemsPublisher so that we don't duplicate rebuilds 2020-07-24 14:05:26 -05:00
Maurice Parker 3b648ac548 Remove removeDuplicates operator as it wasn't needed 2020-07-24 13:57:08 -05:00
Maurice Parker a25ed4da4a Changed delete context menu item to use combine code 2020-07-24 12:57:47 -05:00
Maurice Parker d70721491d Change mark all as read in account to use combine code 2020-07-24 11:52:46 -05:00
Maurice Parker b2c70e847c Change from using @Published as a PassthroughSubject to using real ones to avoid @Published quirks 2020-07-24 11:40:17 -05:00
Maurice Parker 75b9264d44 Rewrite Sidebar select next unread in Combine 2020-07-23 16:27:54 -05:00
Maurice Parker 36aba33c3d Animate sidebar item changes 2020-07-23 11:53:59 -05:00
Maurice Parker b3ca806d0b Stop disabling tab support on Multiplatform macOS. Issue #179 2020-07-23 11:29:48 -05:00
Maurice Parker 6ebd5ad5ed Make toolbar placement more explicit to fix problems that appeared in Xcode 12 Beta 3 2020-07-22 21:01:02 -05:00
Maurice Parker 71a6f03fd6 Scroll into view when a Timeline Item is selected if it isn't completely visible 2020-07-22 20:40:04 -05:00
Maurice Parker f9cd15970f Update for changes in Beta 3 of Xcode 12 2020-07-22 17:55:15 -05:00
Maurice Parker 48c721a468
Merge pull request #2293 from stuartbreckenridge/feature/sidebar-context-menus
Feature/sidebar context menus
2020-07-22 16:50:53 -05:00
Stuart Breckenridge 1bd0bfce37
Minor changes for #2287 2020-07-22 21:47:40 +08:00
Maurice Parker a90930c7f9 Correct image resize adjustment for scaling up images 2020-07-21 18:34:31 -05:00
Maurice Parker f7dec4cf23 Don't scale up icons anymore. It was causing a weird effect where in some visible views the source icon was larger than in other. 2020-07-21 18:25:54 -05:00
Maurice Parker cf8c6f5e8e Layout sidebar items differently on macOS and iOS due to rendering differences in the platforms 2020-07-21 17:40:51 -05:00
Maurice Parker 8d6d7b94cc Fix sidebar item alignment 2020-07-21 15:43:21 -05:00
Maurice Parker b4aef7c414 Make sidebar handle selection state when read filter is on 2020-07-21 14:16:46 -05:00
Maurice Parker a990e07351 Change to not debounce the filter button 2020-07-21 10:53:31 -05:00
Maurice Parker e8742306ad Replace coalescing queue and other items with Combine 2020-07-21 09:27:38 -05:00
Stuart Breckenridge 7639ea2780
Initial work on #2287 2020-07-21 16:05:31 +08:00
Maurice Parker e315687cc9 Supply a background for the icon if it is too short or hard to see. Issue #2220 2020-07-20 21:01:25 -05:00
Maurice Parker c0e9f28398 Do a synchronous fetch of the timeline data on macOS 2020-07-20 17:04:12 -05:00
Maurice Parker d71dc5813e Replace with nothing to reset the Timeline when fetching a new one 2020-07-20 16:44:56 -05:00
Maurice Parker e7a68f433d Optimized Timeline context menu so that it isn't constantly scanning for article location in array 2020-07-20 16:21:48 -05:00
Maurice Parker 4bf4c6d6c2 Restore Mark All As Read in Feed context menu after making it performant 2020-07-20 09:40:56 -05:00
Maurice Parker 3b8db28f3d Deleted code that is dead because of recent navigation changes 2020-07-20 01:36:19 -05:00
Maurice Parker ef6a74b8bd Push the byline and published date to the bottom of the Timeline cell 2020-07-19 21:13:24 -05:00
Maurice Parker 9c0da054fd Don't silently fail if there is no undo manager, just go ahead and mark the records 2020-07-19 21:06:38 -05:00
Maurice Parker 6853535b96 Remove macOS navigate code that was messing up performance 2020-07-19 20:34:20 -05:00
Maurice Parker 797b8cd428 Delete dead code 2020-07-19 20:26:54 -05:00
Maurice Parker 77dc455ce9 Disable Mark All as Read in Feed context menu item as it was just crushing Timeline performance 2020-07-19 20:12:48 -05:00
Maurice Parker feb2d2c9ab Fix iOS compile error due to selection change 2020-07-19 19:46:33 -05:00
Maurice Parker 29386d74d6 Make selected indicator white 2020-07-19 18:20:05 -05:00
Maurice Parker 4446fa0ca9 Change mark all as read image to be a PNG, since SwiftUI on AppKit sucks at handling vector resources 2020-07-19 17:44:41 -05:00
Maurice Parker 88745755b6 Change how the Inspector renames web feeds and folders so that they will sync 2020-07-19 17:07:09 -05:00
Maurice Parker a521673ac6 Fix bug that prevented Mark All As Read button from enabling until a status change event occurred 2020-07-19 16:36:34 -05:00
Maurice Parker fe2b81b47b Put hack in to select next unread item. WIP 2020-07-19 15:50:01 -05:00
Maurice Parker 68a569ec0b Implement go to next unread 2020-07-19 15:24:59 -05:00
Maurice Parker de10e81e31 Stub out goToNextUnread for SceneModel 2020-07-19 13:28:22 -05:00
Maurice Parker 3cbb4da788 Add Sidebar go to next functionality 2020-07-19 13:23:08 -05:00
Maurice Parker 7f60c69454 Save and restore selection for the Timeline 2020-07-19 11:38:15 -05:00
Maurice Parker 1b5c9da2d7 Change status updates be combine code instead of selectors 2020-07-19 11:15:02 -05:00
Maurice Parker b25c8634ca Add missing subscription command 2020-07-18 23:13:57 -05:00
Maurice Parker a243601695 Fetch and merge articles for the timeline. Issue #2281 2020-07-18 23:09:39 -05:00
Maurice Parker c4ec9606f3 Delete empty lines 2020-07-18 21:38:00 -05:00
Maurice Parker 859d9fc972 Change to use the standard cancellables set 2020-07-18 21:33:24 -05:00
Maurice Parker 16555d829a Clear the timeline when there are no feeds selected. 2020-07-18 21:16:55 -05:00
Maurice Parker 8291230561 Fix the iPad which seems to like to set the selected value to nil after setting it to the correct selection 2020-07-18 21:02:38 -05:00
Maurice Parker 9240c8e8a9 Add space between section header and feed url, since macOS doesn't add it like it should 2020-07-18 20:22:41 -05:00
Maurice Parker 68f4ea88c9 Hide home url section if one isn't available 2020-07-18 20:18:57 -05:00
Maurice Parker 86a38edabd
Merge pull request #2283 from stuartbreckenridge/hotfix/inspector-tweaks
Inspector tweaks
2020-07-18 19:57:18 -05:00
Maurice Parker 8cbc18c45e Refactor TimelineModel to use Combine more fully 2020-07-18 19:56:30 -05:00
Stuart Breckenridge 03c60a2979
Adds default cancel keyboard shortcut 2020-07-19 08:25:26 +08:00
Stuart Breckenridge 526a98f326
Switches to AppAssets 2020-07-19 08:12:20 +08:00
Stuart Breckenridge 4d227e7e2c
Inspector tweaks
- [x] Account Inspector should have an Active toggle (see iOS)
 - [x] Feed Inspector Home Page should open the link in browser when tapped
- [x] Feed Inspector Home Page should have a browser icon (see iOS)
- [x] Feed Inspector Home Page URL should line wrap
- [x] Feed Inspector Feed URL should be copiable (currently this is a long press on iOS)
- [x] Feed Inspector Feed URL should line wrap
- [x] Inspector should use inset style on iOS
2020-07-19 07:57:25 +08:00
Maurice Parker 9732ca10f3 Made Sidebar Combine correct 2020-07-18 17:10:45 -05:00
Maurice Parker d36870028a Refactor Combine code to make it more readable 2020-07-18 16:53:30 -05:00
Maurice Parker 271f7433d4 Use a table to look up TimelineItem position instead of spinning through the TimelineItems 2020-07-18 16:36:20 -05:00
Maurice Parker 3899fe7fd9 Use the fetch filter option to speed up timeline rendering 2020-07-18 16:12:10 -05:00
Maurice Parker 6a33060473 Fix sidebar rename bug 2020-07-18 15:24:48 -05:00
Maurice Parker 876f978347 Standardize notification handling on Combine instead of selectors 2020-07-18 15:20:15 -05:00
Maurice Parker 5845925b3a
Merge pull request #2278 from stuartbreckenridge/feature/feed-inspector
Notifications/Reader View/InspectorModel
2020-07-18 10:57:22 -05:00
Stuart Breckenridge 5fb44a30ea
actually updates readerview value 2020-07-18 21:46:39 +08:00
Stuart Breckenridge 5a7c3111ce
Removes rename 2020-07-18 21:24:06 +08:00
Stuart Breckenridge 0e2b8fd514
Adds `InspectorModel`
`InspectorModel` covers previous management of notifications, reader view, and name changes.
2020-07-18 21:21:59 +08:00
Stuart Breckenridge dece406f56
Confirm changed to Done 2020-07-18 19:31:56 +08:00
Maurice Parker 1a46167355
Merge pull request #2277 from stuartbreckenridge/feature/feed-inspector
Update InspectorView.swift
2020-07-18 05:24:20 -05:00
Stuart Breckenridge f525081f6e
Update InspectorView.swift 2020-07-18 18:23:07 +08:00
Maurice Parker 69c92e795b
Merge pull request #2276 from stuartbreckenridge/feature/feed-inspector
Inspector Views
2020-07-18 05:00:15 -05:00
Maurice Parker e391b29353 Implement the Mark All as Read button 2020-07-18 04:58:46 -05:00
Maurice Parker 40e0a1b676 Launch with correct views instead of using placeholder text views 2020-07-18 04:35:44 -05:00
Stuart Breckenridge 8f8afb5dbb
Inspector View
Inspector Views for macOS and iOS
2020-07-18 17:34:04 +08:00
Maurice Parker be60b112d0 Remove computed properties from TimelineItem 2020-07-17 20:55:18 -05:00
Maurice Parker 2a4a13ed13 Implement mark all as read in feed context menu for timeline 2020-07-17 20:29:53 -05:00
Maurice Parker 644e9da1c0 Implement open in browser timeline context menu item. 2020-07-17 20:08:49 -05:00
Maurice Parker a102b9f63d Add marking starred and read context menu items to Timeline 2020-07-17 19:46:05 -05:00
Maurice Parker 538d886bf4 Correct about/below mark as read to take into account multiple select 2020-07-17 18:15:42 -05:00
Maurice Parker 11bd3dce22 Change sidebar context menu to use trailing closure syntax 2020-07-17 18:05:26 -05:00
Maurice Parker 067041195d Implement Mark Above and Mark Below context menu items. 2020-07-17 17:59:35 -05:00
Maurice Parker 37a84395fe Add in missing file 2020-07-17 17:34:11 -05:00
Maurice Parker 048da0bf79 Separate the sidebar context menu into a standalone different file 2020-07-17 17:27:08 -05:00
Maurice Parker 78fdf0a0d0 Enable open in browser toolbar button. 2020-07-17 17:08:08 -05:00
Maurice Parker 74b878fa6f Disable safari and share toolbar buttons when no articles are selected 2020-07-17 13:55:54 -05:00
Stuart Breckenridge 19d4afc467
On macOS, just change the colorScheme 2020-07-17 22:33:38 +08:00
Stuart Breckenridge b739f6dd61
Improves behaviour of dark/light changes on iOS 2020-07-17 22:18:10 +08:00
Maurice Parker 8f7b8160a1 Make Timeline text layout like current apps 2020-07-16 19:36:20 -05:00
Maurice Parker cdf8ad1277 Remove web provider queue flush on multiplatform 2020-07-16 13:44:19 -05:00
Maurice Parker 2b0f6f4e77 Deselect articles when switching selected feeds 2020-07-16 12:27:40 -05:00
Maurice Parker e5bf13edca Tweak API to stop web view controller rebuiding 2020-07-16 11:51:33 -05:00
Maurice Parker 364bcf9d4d Implement new ArticleView API for iOS 2020-07-16 11:42:07 -05:00
Maurice Parker 5f573fc985 Make article rendering stop flashing! 2020-07-16 11:14:05 -05:00
Maurice Parker 9836fb781c Rename variable to make its intent clear 2020-07-16 10:53:54 -05:00
Maurice Parker 92f6ee3f42 Coalesce refresh progress updates 2020-07-15 21:32:56 -05:00
Maurice Parker 46762bf297 Implement refresh progress bar for macOS 2020-07-15 21:24:22 -05:00
Maurice Parker 69fa598d99 Enable refresh button on macOS 2020-07-15 20:09:11 -05:00
Maurice Parker e34dbd48ee Move error handling to SceneNavigationView 2020-07-15 20:06:29 -05:00
Maurice Parker cf233f4825
Merge pull request #2259 from stuartbreckenridge/feature/mac-preferences
Mac Preferences
2020-07-15 19:16:19 -05:00
Maurice Parker 30d1f77405 Implement pull to refresh on iOS 2020-07-15 16:52:57 -05:00
Maurice Parker 2b84469fb4 Refactored refresh progress so that it doesn't crash on the mac anymore 2020-07-15 15:32:04 -05:00
Maurice Parker f32b0bfdc3 Change to use a view instead of a function for the navigation wrapper 2020-07-15 15:25:41 -05:00
Maurice Parker 367bd90ec9 Fix refresh progress compile error 2020-07-15 13:43:24 -05:00
Maurice Parker deee6c13f5 Remove progress indicator and next unread from timeline until we can properly show and hide them. 2020-07-15 13:00:38 -05:00
Maurice Parker c8077ad214 Separated refresh progress model from SceneModel again 2020-07-15 12:56:19 -05:00
Stuart Breckenridge 0904ff519f
moves preferredColorScheme to App level. 2020-07-15 11:16:16 +08:00
Maurice Parker 31068f90a0 Implement macOS share button 2020-07-14 17:10:53 -05:00
Maurice Parker e6bd17f8f9 Remove commented code 2020-07-14 13:53:23 -05:00
Stuart Breckenridge 4982211e27
WiP on Edit Accounts and ColorScheme 2020-07-14 14:57:55 +08:00
Maurice Parker dc023e681b Implement share/activity button on iOS 2020-07-13 20:18:39 -05:00
Maurice Parker da08219ca3 Add more button state and standardize button syntax 2020-07-13 17:24:40 -05:00
Maurice Parker 7643ddc173 Remove specific button state enums as they were overkill 2020-07-13 16:26:53 -05:00
Maurice Parker 4bb88363e7 Change to only resort when sort parameters change 2020-07-13 16:06:42 -05:00
Maurice Parker ffa579446e Only add section header padding for macOS 2020-07-13 12:00:59 -05:00
Maurice Parker b79a1aef0c Put in the padding that Apple left off of the section headers 2020-07-13 11:58:44 -05:00
Maurice Parker 543048b981 Add context menu divider to match existing macOS design 2020-07-13 11:43:27 -05:00
Maurice Parker c29960ddda Clean up navigation handling for the timeline 2020-07-13 11:37:21 -05:00
Maurice Parker 17e1247ff0 Add sort control for macOS 2020-07-12 19:43:25 -05:00
Maurice Parker 3a67f2cd8e Change navigation title for macOS so that it shows the Feed 2020-07-12 17:45:38 -05:00
Maurice Parker 809e6542e0 Fix bug in unfiltering a filtered timeline 2020-07-12 17:30:35 -05:00
Maurice Parker d7a4bddc72 Make timeline filter maintain it state for each timeline individually 2020-07-12 16:48:39 -05:00
Maurice Parker 2ebec7801c Fix read filter accessibility labels (help) 2020-07-12 15:03:43 -05:00
Maurice Parker 6c236fc0e3 Implement Timeline read filter 2020-07-12 14:43:52 -05:00
Maurice Parker 22e2c0b0e6 Add sidebar read filter 2020-07-12 10:52:42 -05:00
Maurice Parker 9f4a037c8f Rebuild sidebar items when the unread count changes 2020-07-12 09:54:39 -05:00
Stuart Breckenridge 31b93c5d13
small refactoring 2020-07-12 14:07:52 +08:00
Maurice Parker 2eb20c86af Refactor timeline code to be more clear 2020-07-11 20:11:01 -05:00
Maurice Parker 6891f76241 Fix smart feed feed lookup 2020-07-11 19:56:42 -05:00
Maurice Parker 7998b5450b Enabled toolbar buttons for read and star 2020-07-11 19:52:28 -05:00
Maurice Parker 92ac91d9d5 Delete dead code 2020-07-11 18:47:44 -05:00
Maurice Parker 184ef57576 Implement Timeline multiselect 2020-07-11 18:22:47 -05:00
Maurice Parker cf79d3f508 Merge branch 'master' of https://github.com/Ranchero-Software/NetNewsWire 2020-07-11 12:48:58 -05:00
Maurice Parker 360f7a07bf Implement Sidebar multiselect for macOS 2020-07-11 12:47:13 -05:00
Stuart Breckenridge 61c42171c7
2237
Fixes #2237 accent colours on web feeds.
2020-07-12 00:07:37 +08:00
Maurice Parker 20d989f1b8
Revert "Widget Work in Progress" 2020-07-11 09:48:34 -05:00
Maurice Parker 3eda1de825
Merge pull request #2249 from stuartbreckenridge/feature/widget
Widget Work in Progress
2020-07-11 09:36:50 -05:00
Stuart Breckenridge c3d4834879
Moves to monitoring changes in scene phase 2020-07-11 21:02:46 +08:00
Stuart Breckenridge 9991b3760e
Removes print statements and reorgs code 2020-07-11 20:22:21 +08:00
Stuart Breckenridge 1cc5f3cc30
Widget Updates
• Can now read data written by main app
• Has preview capability in widget gallery
• Still to solve using ORGANIZATION_IDENTIFIER
2020-07-11 17:01:09 +08:00
Maurice Parker 2f99cd01c1 Fix the width of the indicator so that it would stop reflowing the cell when changed to star 2020-07-10 10:13:18 -05:00
Stuart Breckenridge a45ba35b24
Initial widget work
• Latest data is saved out to JSON at various points.
• Technote on widget usage.
• Widget target added.
2020-07-10 23:10:12 +08:00
Maurice Parker bf8a52d710 Update the timeline with status changes 2020-07-09 20:10:52 -05:00
Maurice Parker 2d57945e98 Implement Read and Star button functionality 2020-07-09 18:44:51 -05:00
Maurice Parker 3e61c7044b Stub out mark as read and star functionality 2020-07-09 16:34:47 -05:00
Alex Faber 5b50e8cdd2 OPT: Cleanup Add Folder view on Mac, change SceneNavigationView to support multiple sheet types. 2020-07-09 21:09:50 +02:00
Maurice Parker aa4d191d1d Fixed Article Toolbar item placement on iPad 2020-07-09 09:57:39 -05:00
Maurice Parker 91f2479b96
Merge pull request #2234 from stuartbreckenridge/fix/2193
Fix 2193
2020-07-09 08:10:42 -05:00
Maurice Parker 897474a637 Fixed the font for macOS article view 2020-07-09 07:47:47 -05:00
Stuart Breckenridge 771fe21422
Tidy up 2020-07-09 17:36:17 +08:00
Stuart Breckenridge f4deab1361
Updates title to match current app 2020-07-09 17:04:04 +08:00
Stuart Breckenridge 9830a977a0 Add Web Feed Colours
Icons in the picker now use accent colour.
2020-07-09 16:58:04 +08:00