Commit Graph

525 Commits

Author SHA1 Message Date
Stuart Breckenridge
cd20632b5d
Adds sidebar toggle image to app assets 2020-08-10 08:36:31 +08:00
Stuart Breckenridge
dadff04da5
Removes padding. 2020-08-10 08:31:10 +08:00
Stuart Breckenridge
88ee63ba68
Adds #warning message for AppKit usage. 2020-08-10 08:28:17 +08:00
Stuart Breckenridge
94a9557ba6
Adds sidebar toggling from toolbar. 2020-08-10 08:01:16 +08:00
Stuart Breckenridge
cd8c32055b
Resolves crash when switching between panes 2020-08-05 20:06:44 +08:00
Stuart Breckenridge
1d0c47a1bd
Changes Preferences to use TabBar
This appears to crash when selecting a different pane.
2020-08-05 11:45:24 +08:00
Maurice Parker
4067e1edd7 Make the mark all as read raster image a template so that it renders in the correct color 2020-08-04 21:19:03 -05:00
Maurice Parker
7365b25fec Add SidebarCommands to main menu 2020-08-04 21:11:06 -05:00
Maurice Parker
269677121e Removed Commands from iOS build since they aren't supported there anymore 2020-08-04 18:19:48 -05:00
Maurice Parker
b724658528 Refactor how we do Secrets to work with the new Swift Package structure 2020-07-30 17:40:45 -05:00
Maurice Parker
ce04c82520 remove RSCoreResources import that shouldn't have been there 2020-07-30 07:47:43 -05:00
Maurice Parker
2fbee1eb03 Convert RSDatabase into swift packages 2020-07-29 19:48:54 -05:00
Maurice Parker
32d6d2f3c1 Convert RSCore into an SPM package 2020-07-29 05:11:57 -05:00
Maurice Parker
ff829c0e59 Stop skipping the Today feed when finding next unread and looping around 2020-07-27 21:21:11 -05:00
Maurice Parker
ecefe59a5e Skip the current folder for next unread 2020-07-27 21:01:32 -05:00
Maurice Parker
855907404e Use custom user agent for web views 2020-07-27 19:25:39 -05:00
Maurice Parker
b77e2164cd Revert using combine for toolbar buttons as it was inconsistent with context menus 2020-07-27 15:43:58 -05:00
Maurice Parker
c3ca910e20
Merge pull request #2305 from rizwankce/add-toolbar-button-menu
Add toolbar button menu
2020-07-27 11:50:24 -05:00
Maurice Parker
a48c894985 Make macOS timeline load synchronous and add an id to list that changes when the feed selection changes to reset the scroll 2020-07-27 10:36:37 -05:00
Maurice Parker
6b08b1e48b Revert "Switch to using LazyVStack for the Timeline"
This reverts commit 9878ca4b17.
2020-07-27 10:24:32 -05:00
Maurice Parker
9878ca4b17 Switch to using LazyVStack for the Timeline 2020-07-27 08:19:34 -05:00
Rizwan Mohamed Ibrahim
2528d1e9d7
Add Twitter and Reddit button actions 2020-07-27 13:43:07 +05:30
Rizwan Mohamed Ibrahim
2987c9742e
Remove action sheet var on sidebar toolbar model 2020-07-27 13:41:23 +05:30
Rizwan Mohamed Ibrahim
177c18d4ea
Adds Menu for "Add" tool bar button 2020-07-27 13:39:39 +05:30
Maurice Parker
dbe662b7db Implement Select Next Unread using Combine 2020-07-26 17:17:02 -05:00
Maurice Parker
4c1061cfba Fix bug that caused currently selected item to not be found on next unread 2020-07-26 16:00:00 -05:00
Maurice Parker
2efc0a17a9 Make Sidebar expansion state available to SidebarModel 2020-07-26 15:31:32 -05:00
Maurice Parker
539685586e Reenable Timeline context menus 2020-07-26 13:57:50 -05:00
Maurice Parker
9e1e55ac8d Delete commented code 2020-07-26 12:05:37 -05:00
Maurice Parker
c195d6f8f0 Delete old code 2020-07-26 12:04:53 -05:00
Maurice Parker
d1b015ce21 Add download events to timeline management 2020-07-26 12:00:57 -05:00
Maurice Parker
fbf0c60d55 Make fetch articles an async process 2020-07-26 11:05:18 -05:00
Maurice Parker
2217dc492f Moved title update to the correct func for subscription 2020-07-26 07:54:04 -05:00
Maurice Parker
bb1b7ad0b0 Clear selected articles when selected feeds changes 2020-07-26 07:37:17 -05:00
Maurice Parker
5a267485c3 Remove status fade animation since it was interfering with the selection scrolling 2020-07-26 07:29:37 -05:00
Maurice Parker
71acfb524d Move onReceive to container view for timeline 2020-07-26 07:18:05 -05:00
Maurice Parker
a3459bc57a Move onReceive to container where it belongs 2020-07-26 07:06:00 -05:00
Noelle Leigh
4dafe95478 Fix Multiplatform/iOS/Settings/SettingsModel.swift 2020-07-26 05:47:02 -04:00
Maurice Parker
028eccfaf9 Delete old and dead error handling code 2020-07-25 19:47:15 -05:00
Maurice Parker
4fe40f9ed6 Add replay so that iOS filters work 2020-07-25 19:44:50 -05:00
Maurice Parker
4d8e8dab47 Remove caveman debugging 2020-07-25 19:34:02 -05:00
Maurice Parker
59528f48b1 Reimplement Article Read Filter 2020-07-25 19:14:59 -05:00
Maurice Parker
8f346af250 Merge branch 'main' of https://github.com/Ranchero-Software/NetNewsWire into main 2020-07-25 18:53:54 -05:00
Stuart Breckenridge
b8e201e5d0
Fixes #2298 2020-07-26 07:36:24 +08:00
Maurice Parker
a1cbca8a0b Remove replays that were making things strange on macOS 2020-07-25 17:31:34 -05:00
Maurice Parker
d83ca618fb Reimplement open in browser toolbar button functionality 2020-07-25 16:56:38 -05:00
Maurice Parker
628f349448 Fix previous and next article API's 2020-07-25 16:33:40 -05:00
Maurice Parker
67eb319703 Make selected articles available to Share dialog 2020-07-25 16:28:23 -05:00
Maurice Parker
8b1aa3e88a Reimplement Mark All as Read toolbar item 2020-07-25 16:19:22 -05:00
Maurice Parker
d28a672378 Reimplement starred toolbar toggle 2020-07-25 16:12:12 -05:00
Maurice Parker
f793e1b02d Reimplement toggle read/unread for selected toolbar item. 2020-07-25 16:07:12 -05:00
Maurice Parker
479562b47f Disable animations on iOS for TimelineItem status changes 2020-07-25 14:12:17 -05:00
Maurice Parker
206683315a Update iOS to work with new TimelineItems struct 2020-07-25 14:02:10 -05:00
Maurice Parker
1de3c75d4f Add update timeline articles statuses back in 2020-07-25 13:53:46 -05:00
Maurice Parker
d3399e8632 Enable article lookups 2020-07-25 13:15:00 -05:00
Maurice Parker
5c8aaed54c Reenabled mac toolbar validation 2020-07-25 12:46:33 -05:00
Maurice Parker
dabf471db7 Subscribe to article selection changes in the Article View 2020-07-25 11:25:36 -05:00
Maurice Parker
fca35060d5 Add timeline item selection tracking 2020-07-25 10:56:21 -05:00
Maurice Parker
e88e4f65a5 Switch TimelineItems to use an OrderedDictionary 2020-07-25 10:31:22 -05:00
Maurice Parker
882ebbea3e Update iOS with latest TimelineModel refactoring 2020-07-25 06:20:21 -05:00
Maurice Parker
7d7a018fe1 Merge branch 'main' of https://github.com/Ranchero-Software/NetNewsWire into main 2020-07-25 05:01:23 -05:00
Maurice Parker
25bce5e258
Merge pull request #2297 from stuartbreckenridge/feature/sync-errors
Handles single and multiple sync failures
2020-07-25 05:00:48 -05:00
Stuart Breckenridge
673f0ce718
Handles single and multiple sync failures
If a single sync failure is encountered a sheet is presented which allows the user to update their credentials.

If multiple sync failures are encountered an alert is shown listing the accounts which encountered errors. On iOS, this alert can take the user into Settings, but there is no obvious way to programatically pesent macOS preferences.
2020-07-25 16:40:04 +08:00
Maurice Parker
953c22f605 Begin refactor of Timeline to use Combine fully 2020-07-24 21:05:30 -05:00
Maurice Parker
c5d040fa97 Change select next unread subject to be void instead of Bool 2020-07-24 18:30:54 -05:00
Maurice Parker
bffcfdd67d Add share operator to sidebarItemsPublisher so that we don't duplicate rebuilds 2020-07-24 14:05:26 -05:00
Maurice Parker
3b648ac548 Remove removeDuplicates operator as it wasn't needed 2020-07-24 13:57:08 -05:00
Maurice Parker
a25ed4da4a Changed delete context menu item to use combine code 2020-07-24 12:57:47 -05:00
Maurice Parker
d70721491d Change mark all as read in account to use combine code 2020-07-24 11:52:46 -05:00
Maurice Parker
b2c70e847c Change from using @Published as a PassthroughSubject to using real ones to avoid @Published quirks 2020-07-24 11:40:17 -05:00
Rizwan Mohamed Ibrahim
cb409728aa
Add subscriptions import/export navigation link with list
- refactors export/import action sheet to be a new screen with list options
2020-07-24 20:50:43 +05:30
Maurice Parker
75b9264d44 Rewrite Sidebar select next unread in Combine 2020-07-23 16:27:54 -05:00
Maurice Parker
36aba33c3d Animate sidebar item changes 2020-07-23 11:53:59 -05:00
Maurice Parker
b3ca806d0b Stop disabling tab support on Multiplatform macOS. Issue #179 2020-07-23 11:29:48 -05:00
Maurice Parker
6ebd5ad5ed Make toolbar placement more explicit to fix problems that appeared in Xcode 12 Beta 3 2020-07-22 21:01:02 -05:00
Maurice Parker
71a6f03fd6 Scroll into view when a Timeline Item is selected if it isn't completely visible 2020-07-22 20:40:04 -05:00
Maurice Parker
f9cd15970f Update for changes in Beta 3 of Xcode 12 2020-07-22 17:55:15 -05:00
Maurice Parker
48c721a468
Merge pull request #2293 from stuartbreckenridge/feature/sidebar-context-menus
Feature/sidebar context menus
2020-07-22 16:50:53 -05:00
Stuart Breckenridge
1bd0bfce37
Minor changes for #2287 2020-07-22 21:47:40 +08:00
Maurice Parker
a90930c7f9 Correct image resize adjustment for scaling up images 2020-07-21 18:34:31 -05:00
Maurice Parker
f7dec4cf23 Don't scale up icons anymore. It was causing a weird effect where in some visible views the source icon was larger than in other. 2020-07-21 18:25:54 -05:00
Maurice Parker
cf8c6f5e8e Layout sidebar items differently on macOS and iOS due to rendering differences in the platforms 2020-07-21 17:40:51 -05:00
Maurice Parker
8d6d7b94cc Fix sidebar item alignment 2020-07-21 15:43:21 -05:00
Maurice Parker
b4aef7c414 Make sidebar handle selection state when read filter is on 2020-07-21 14:16:46 -05:00
Maurice Parker
9f5e78fb86
Merge pull request #2291 from rizwankce/settings-account-credentials-view
Add fresh RSS account with credentials account view
2020-07-21 12:56:29 -05:00
Rizwan Mohamed Ibrahim
81a92738f9
Add fresh RSS account with credentials account view 2020-07-21 23:10:18 +05:30
Maurice Parker
a820a11186
Merge pull request #2290 from rizwankce/settings-account-credentials-view
Add credentials account view and model
2020-07-21 10:54:34 -05:00
Maurice Parker
a990e07351 Change to not debounce the filter button 2020-07-21 10:53:31 -05:00
Rizwan Mohamed Ibrahim
86c9100e70
Add credentials account view and model
- refactors feedbin account view and model
- groups feedbin, feedly, newsblur into credentials account
2020-07-21 20:43:43 +05:30
Maurice Parker
e8742306ad Replace coalescing queue and other items with Combine 2020-07-21 09:27:38 -05:00
Stuart Breckenridge
7639ea2780
Initial work on #2287 2020-07-21 16:05:31 +08:00
Maurice Parker
e315687cc9 Supply a background for the icon if it is too short or hard to see. Issue #2220 2020-07-20 21:01:25 -05:00
Maurice Parker
c0e9f28398 Do a synchronous fetch of the timeline data on macOS 2020-07-20 17:04:12 -05:00
Maurice Parker
d71dc5813e Replace with nothing to reset the Timeline when fetching a new one 2020-07-20 16:44:56 -05:00
Maurice Parker
e7a68f433d Optimized Timeline context menu so that it isn't constantly scanning for article location in array 2020-07-20 16:21:48 -05:00
Maurice Parker
4bf4c6d6c2 Restore Mark All As Read in Feed context menu after making it performant 2020-07-20 09:40:56 -05:00
Maurice Parker
3b8db28f3d Deleted code that is dead because of recent navigation changes 2020-07-20 01:36:19 -05:00
Maurice Parker
ef6a74b8bd Push the byline and published date to the bottom of the Timeline cell 2020-07-19 21:13:24 -05:00
Maurice Parker
9c0da054fd Don't silently fail if there is no undo manager, just go ahead and mark the records 2020-07-19 21:06:38 -05:00
Maurice Parker
6853535b96 Remove macOS navigate code that was messing up performance 2020-07-19 20:34:20 -05:00
Maurice Parker
797b8cd428 Delete dead code 2020-07-19 20:26:54 -05:00
Maurice Parker
77dc455ce9 Disable Mark All as Read in Feed context menu item as it was just crushing Timeline performance 2020-07-19 20:12:48 -05:00
Maurice Parker
feb2d2c9ab Fix iOS compile error due to selection change 2020-07-19 19:46:33 -05:00
Maurice Parker
29386d74d6 Make selected indicator white 2020-07-19 18:20:05 -05:00
Maurice Parker
4446fa0ca9 Change mark all as read image to be a PNG, since SwiftUI on AppKit sucks at handling vector resources 2020-07-19 17:44:41 -05:00
Maurice Parker
88745755b6 Change how the Inspector renames web feeds and folders so that they will sync 2020-07-19 17:07:09 -05:00
Maurice Parker
a521673ac6 Fix bug that prevented Mark All As Read button from enabling until a status change event occurred 2020-07-19 16:36:34 -05:00
Maurice Parker
fe2b81b47b Put hack in to select next unread item. WIP 2020-07-19 15:50:01 -05:00
Maurice Parker
68a569ec0b Implement go to next unread 2020-07-19 15:24:59 -05:00
Maurice Parker
de10e81e31 Stub out goToNextUnread for SceneModel 2020-07-19 13:28:22 -05:00
Maurice Parker
3cbb4da788 Add Sidebar go to next functionality 2020-07-19 13:23:08 -05:00
Maurice Parker
7f60c69454 Save and restore selection for the Timeline 2020-07-19 11:38:15 -05:00
Maurice Parker
1b5c9da2d7 Change status updates be combine code instead of selectors 2020-07-19 11:15:02 -05:00
Maurice Parker
b25c8634ca Add missing subscription command 2020-07-18 23:13:57 -05:00
Maurice Parker
a243601695 Fetch and merge articles for the timeline. Issue #2281 2020-07-18 23:09:39 -05:00
Maurice Parker
c4ec9606f3 Delete empty lines 2020-07-18 21:38:00 -05:00
Maurice Parker
859d9fc972 Change to use the standard cancellables set 2020-07-18 21:33:24 -05:00
Maurice Parker
16555d829a Clear the timeline when there are no feeds selected. 2020-07-18 21:16:55 -05:00
Maurice Parker
8291230561 Fix the iPad which seems to like to set the selected value to nil after setting it to the correct selection 2020-07-18 21:02:38 -05:00
Maurice Parker
9240c8e8a9 Add space between section header and feed url, since macOS doesn't add it like it should 2020-07-18 20:22:41 -05:00
Maurice Parker
68f4ea88c9 Hide home url section if one isn't available 2020-07-18 20:18:57 -05:00
Maurice Parker
86a38edabd
Merge pull request #2283 from stuartbreckenridge/hotfix/inspector-tweaks
Inspector tweaks
2020-07-18 19:57:18 -05:00
Maurice Parker
8cbc18c45e Refactor TimelineModel to use Combine more fully 2020-07-18 19:56:30 -05:00
Stuart Breckenridge
03c60a2979
Adds default cancel keyboard shortcut 2020-07-19 08:25:26 +08:00
Stuart Breckenridge
526a98f326
Switches to AppAssets 2020-07-19 08:12:20 +08:00
Stuart Breckenridge
4d227e7e2c
Inspector tweaks
- [x] Account Inspector should have an Active toggle (see iOS)
 - [x] Feed Inspector Home Page should open the link in browser when tapped
- [x] Feed Inspector Home Page should have a browser icon (see iOS)
- [x] Feed Inspector Home Page URL should line wrap
- [x] Feed Inspector Feed URL should be copiable (currently this is a long press on iOS)
- [x] Feed Inspector Feed URL should line wrap
- [x] Inspector should use inset style on iOS
2020-07-19 07:57:25 +08:00
Maurice Parker
9732ca10f3 Made Sidebar Combine correct 2020-07-18 17:10:45 -05:00
Maurice Parker
d36870028a Refactor Combine code to make it more readable 2020-07-18 16:53:30 -05:00
Maurice Parker
271f7433d4 Use a table to look up TimelineItem position instead of spinning through the TimelineItems 2020-07-18 16:36:20 -05:00
Maurice Parker
3899fe7fd9 Use the fetch filter option to speed up timeline rendering 2020-07-18 16:12:10 -05:00
Maurice Parker
6a33060473 Fix sidebar rename bug 2020-07-18 15:24:48 -05:00
Maurice Parker
876f978347 Standardize notification handling on Combine instead of selectors 2020-07-18 15:20:15 -05:00
Maurice Parker
5845925b3a
Merge pull request #2278 from stuartbreckenridge/feature/feed-inspector
Notifications/Reader View/InspectorModel
2020-07-18 10:57:22 -05:00
Stuart Breckenridge
5fb44a30ea
actually updates readerview value 2020-07-18 21:46:39 +08:00
Stuart Breckenridge
5a7c3111ce
Removes rename 2020-07-18 21:24:06 +08:00
Stuart Breckenridge
0e2b8fd514
Adds InspectorModel
`InspectorModel` covers previous management of notifications, reader view, and name changes.
2020-07-18 21:21:59 +08:00
Stuart Breckenridge
dece406f56
Confirm changed to Done 2020-07-18 19:31:56 +08:00
Maurice Parker
1a46167355
Merge pull request #2277 from stuartbreckenridge/feature/feed-inspector
Update InspectorView.swift
2020-07-18 05:24:20 -05:00
Stuart Breckenridge
f525081f6e
Update InspectorView.swift 2020-07-18 18:23:07 +08:00
Maurice Parker
69c92e795b
Merge pull request #2276 from stuartbreckenridge/feature/feed-inspector
Inspector Views
2020-07-18 05:00:15 -05:00
Maurice Parker
e391b29353 Implement the Mark All as Read button 2020-07-18 04:58:46 -05:00
Maurice Parker
40e0a1b676 Launch with correct views instead of using placeholder text views 2020-07-18 04:35:44 -05:00
Stuart Breckenridge
8f8afb5dbb
Inspector View
Inspector Views for macOS and iOS
2020-07-18 17:34:04 +08:00
Maurice Parker
be60b112d0 Remove computed properties from TimelineItem 2020-07-17 20:55:18 -05:00
Maurice Parker
2a4a13ed13 Implement mark all as read in feed context menu for timeline 2020-07-17 20:29:53 -05:00
Maurice Parker
644e9da1c0 Implement open in browser timeline context menu item. 2020-07-17 20:08:49 -05:00
Maurice Parker
a102b9f63d Add marking starred and read context menu items to Timeline 2020-07-17 19:46:05 -05:00
Maurice Parker
538d886bf4 Correct about/below mark as read to take into account multiple select 2020-07-17 18:15:42 -05:00
Maurice Parker
11bd3dce22 Change sidebar context menu to use trailing closure syntax 2020-07-17 18:05:26 -05:00
Maurice Parker
067041195d Implement Mark Above and Mark Below context menu items. 2020-07-17 17:59:35 -05:00