Commit Graph

5497 Commits

Author SHA1 Message Date
Martin Nash 3e48be050e Updated function name to openInBrowserUsingOppositeOfSettings 2020-05-21 22:28:30 -07:00
Martin Nash 834be9edff 2099 | Keyboard shortcut to open in browser in background/foreground contrary to user preference.
- Add openInBrowserAlternate() function
- Add shit-modified entries to to GlobalKeyboardShortcuts.plist to trigger new function
2020-05-20 22:15:00 -07:00
Maurice Parker 314df88e12
Merge pull request #2098 from Wevah/master
master: Strip inline max-width and max-height from elements
2020-05-20 17:53:42 -05:00
Nate Weaver 6723599ea0 Strip inline max-width and max-height from elements 2020-05-20 16:36:30 -05:00
Maurice Parker 7d8e49a2ee Merge branch 'ios-release' 2020-05-18 03:05:59 -05:00
Maurice Parker b575d648dc
Merge pull request #2063 from bdougsand/find-in-article-ios
Adds "Find in Article" activity to the share sheet
2020-05-18 02:41:28 -05:00
Maurice Parker 4b1c40f264
Merge pull request #2085 from stuartbreckenridge/2057
2057 - Notification permissions are only requested when the user asks to be Notified of New Articles
2020-05-18 02:03:47 -05:00
Stuart Breckenridge 2297d218c0
Uses selector syntax. 2020-05-18 09:23:42 +08:00
Stuart Breckenridge 6224dfad03
Notification Permission Requests
Fixes #2057

• On app launch, the app checks if notification permissions are granted and registers with APNS if that is the case. It will not request permissions as part of the app launch.

• When a user requests to be notified of new articles, the authorizationStatus is checked:
- if `notDetermined` or `provisional`, an authorization request is made, and if successful, the Notify of New Articles status is updated (otherwise it is reverted)
- if `denied`, an alert is thrown asking the user to enable in settings (and the change to notify of new articles is reverted)
- if `authorized` the update is made.

`WebFeedInspectorViewController` also monitors for the app entering the foreground so that it can get the latest notification auth settings.
2020-05-18 08:39:22 +08:00
Stuart Breckenridge e6e77c10f3
Merge pull request #3 from Ranchero-Software/ios-release
catchup
2020-05-16 18:11:21 +08:00
Brian Sanders d8dced6347 Adds a key command (ESC) to the article search bar 2020-05-15 21:41:14 -04:00
Brian Sanders b058f27064 Fixes bugs in article search
Placement of the article search bar is now always done with constraints.
Previously, I'd used inputAccessoryView when the keyboard appeared. That
approach, although ostensibly permitted, causes a hierarchy inconsistency error
when the device orientation changes.
2020-05-15 21:41:14 -04:00
Brian Sanders 62d04e8881 Adds stored inputAccessoryView to ArticleSearchBar
It should have been obvious that inputAccessoryView traverses the responder
chain
2020-05-15 21:41:14 -04:00
Brian Sanders 46ce824b98 Adds guard against empty search strings to Find in Article 2020-05-15 21:41:14 -04:00
Brian Sanders 96671df667 Adds keyboard shortcut for "Find in Article" (iOS) 2020-05-15 21:41:14 -04:00
Brian Sanders 2631f4f3f0 Alters search highlights so they don't intercept pointer events 2020-05-15 21:41:14 -04:00
Brian Sanders edb7c50cb3 Improves incremental search for "Find in Article"
Article search now maintains its position in the document, if possible.
2020-05-15 21:41:14 -04:00
Brian Sanders 98e0434077 Alters Find in Article to escape regex characters by default 2020-05-15 21:40:22 -04:00
Maurice Parker 1dbbd3bd32
Merge pull request #2081 from Wevah/master
Add "Open Application Support Folder" Debug menu item
2020-05-15 17:32:45 -05:00
Nate Weaver 68da48071a Add "Open Application Support Folder" Debug menu item 2020-05-15 17:29:24 -05:00
Maurice Parker c2b749a74c Rebuild backing stores immediately when deselecting a Feed. Issue #2079 2020-05-15 17:06:49 -05:00
Maurice Parker 4e22489d97 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-05-15 10:45:22 -05:00
Maurice Parker 8ff2776d88 Make sure we have only one web view in the view hierarchy after navigation. Issue #2075 2020-05-15 10:45:05 -05:00
Maurice Parker fd6736a897
Merge pull request #2077 from stuartbreckenridge/notifications
Notifications
2020-05-15 07:41:01 -05:00
Stuart Breckenridge fa51fa47b4
reorged the send notification code 2020-05-15 20:32:33 +08:00
Stuart Breckenridge 23ee6761ca
adds grouping and summaries to notifications 2020-05-15 19:53:44 +08:00
Maurice Parker 225c98a70e
Merge pull request #2073 from rizwankce/open-in-safari-shortcut
Keyboard shortcuts for "Open in App Browser"
2020-05-15 04:38:26 -05:00
Rizwan Mohamed Ibrahim c9ebb6bd75
adds "Open In App Browser" shortcut 2020-05-15 12:39:33 +05:30
Stuart Breckenridge b56d20d507
Merge pull request #2 from Ranchero-Software/ios-release
merge
2020-05-15 10:04:56 +08:00
Maurice Parker 49e51d489a
Merge pull request #2074 from rizwankce/fix/mark-all-read-shortcut-on-feed
"Mark All Read" shortcut for feeds list
2020-05-14 09:52:31 -05:00
Rizwan Mohamed Ibrahim 04458adee5
adds "Mark All Read" shortcut for feeds list 2020-05-14 18:13:41 +05:30
Rizwan Mohamed Ibrahim f7f7f4dddb
adds keyboard shortcuts for open in Safari 2020-05-14 17:58:38 +05:30
Maurice Parker 8500324eb2
Merge pull request #2041 from stuartbreckenridge/mail-fix-ios
mailto links now open on iOS
2020-05-14 07:26:26 -05:00
Maurice Parker 8fe746fabf
Merge pull request #2072 from rizwankce/fix/share-extension-activation-rule
Share extension activation rule for text
2020-05-14 07:17:54 -05:00
Maurice Parker 7deac7f3c3
Merge pull request #2071 from stuartbreckenridge/issue-2018
Key commands work with action sheets
2020-05-14 07:14:57 -05:00
Rizwan Mohamed Ibrahim bfef02e18f
adds text activation rule for share extension 2020-05-14 17:17:16 +05:30
Stuart Breckenridge a9e8cec90e
Key commands work with action sheets 2020-05-14 17:10:55 +08:00
Maurice Parker 8f8bd229c5
Merge pull request #2068 from rizwankce/feature/keyboard-shortcuts
Keyboard shortcuts
2020-05-13 11:43:14 -05:00
Rizwan Mohamed Ibrahim 32c8c038ee
move toggle side bar to RootSplitViewController 2020-05-13 21:57:02 +05:30
Maurice Parker 8523f3222f
Merge pull request #2066 from stuartbreckenridge/issue-2018
Mark As Read, Mark Below As Read, Mark Above as Read now present an action sheet
2020-05-13 10:05:19 -05:00
Rizwan Mohamed Ibrahim a9aefd252e
adds keyboard shortcuts
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
2020-05-13 17:29:59 +05:30
Stuart Breckenridge f153643273
Removes return statements that are not needed. 2020-05-13 13:03:51 +08:00
Stuart Breckenridge 58575331dd
Fixes #2018
This commit adds a new `MarkAsReadAlertControllerSourceType` protocol to which `CGRect`, `UIView`, and `UIBarButtonItem` conform to.

The `MarkAsReadAlertController` now presents an action sheet for mark as read, mark above as read, and mark below as read. The above is used for the `popoverPresentationController`’s `barButtonItem`, `sourceRect`, or `sourceView` as needed.
2020-05-13 12:33:51 +08:00
Stuart Breckenridge 1f7d40a537
Merge pull request #1 from Ranchero-Software/ios-release
Ios release
2020-05-13 07:30:28 +08:00
Maurice Parker a6b58beac7 Hide the account field for Popular and All reddit types 2020-05-12 14:14:39 -05:00
Maurice Parker 775a69a295 Add iOS Reddit URL builder 2020-05-12 11:17:47 -05:00
Maurice Parker fdfd91e53e Change Popular Reddit description 2020-05-12 10:17:58 -05:00
Maurice Parker 105fcd7033 Always show link for images 2020-05-12 07:17:32 -05:00
Maurice Parker cf91632d4a Remove anchor tag from images 2020-05-12 05:06:16 -05:00
Brian Sanders 737f4bfdf5 Adds "Find in Article" activity to the share sheet
addresses #1750
2020-05-11 17:08:44 -04:00