7259 Commits

Author SHA1 Message Date
Chris Campbell
364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
Chris Campbell
bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
Brent Simmons
8e34187821
Merge pull request #3083 from babbage/docs/spm
Minor technotes updates
2021-04-27 18:00:15 -07:00
Duncan Babbage
336f3e7a17 Technotes: Swift Packages, AppDefaults not DB5
Revise additonal reference to Git submodules.
2021-04-27 16:50:05 +12:00
Brent Simmons
2fd7d8549e
Merge pull request #3078 from babbage/patch-1
Update Coding Guidelines
2021-04-25 20:04:00 -07:00
Duncan Babbage
e0d5dd69a2
Update Coding Guidelines
Minor edit, as discussed in NNW Slack.
2021-04-26 14:36:07 +12:00
Brent Simmons
3842e1c368
Merge pull request #3032 from stuartbreckenridge/fix/code-sign-xcode12_5
Adds —deep code sign flag for Xcode 12.5
2021-04-21 19:02:12 -07:00
Stuart Breckenridge
036dbf297c
Adds —deep code sign flag for Xcode 12.5 2021-04-22 09:43:07 +08:00
Brent Simmons
77cd189c75
Merge pull request #3021 from stuartbreckenridge/fix/3014
Naming convention for notification options
2021-04-21 18:02:11 -07:00
Stuart Breckenridge
cde7bf9589
restores storyboard to previous commit 2021-04-22 09:00:06 +08:00
Brent Simmons
6ed3b1227e
Merge pull request #3010 from uruha-komachin/main
Fixed missing argument `validateFeed:`
2021-04-21 17:05:20 -07:00
Brent Simmons
b52292d459 Update appcasts for 6.0.2. 2021-04-20 17:46:11 -07:00
Brent Simmons
df06abcb79 Remove no-longer-used appcast. 2021-04-20 17:39:41 -07:00
Stuart Breckenridge
5af2643479
standardised naming 2021-04-19 11:21:00 +08:00
Stuart Breckenridge
d4130e7c65
Corrects naming convention
[iOS]
Twitter: Notify about new tweets
Reddit: Notify about new posts
Default: Notify about new articles
+ Fixes alignment issues in the inspector view

[macOS]
Twitter: Show notifications for new tweets
Reddit: Show notifications for new posts
Default: Show notifications for new articles
2021-04-19 11:10:57 +08:00
Komachin
7a5581a2c7
Fixed missing argument validateFeed:
Based on the newest API, `public func createWebFeed(url: String, name: String?, container: Container, validateFeed: Bool, completion: @escaping (Result<WebFeed, Error>) -> Void)`, there should be a `validateFeed:` argument.
2021-04-17 10:38:40 +01:00
Brent Simmons
8e2de9237c Update appcast for 6.0.2b1. 2021-04-15 19:50:59 -07:00
Maurice Parker
77dd2e5e22 Merge branch 'mac-release' into main 2021-04-15 14:31:52 -05:00
Maurice Parker
6a4c761ed8 Merge branch 'ios-candidate' into main 2021-04-15 14:30:32 -05:00
Maurice Parker
3955151daf Make sure mark as read completes before searching for the next unread. Fixes #2952 2021-04-15 14:29:49 -05:00
Maurice Parker
92fd016b7a Exclude Inoreader from article status syncs 2021-04-15 14:17:25 -05:00
Maurice Parker
8f0519ca47 Fix regression where marking all as unread wouldn't take you back to the sidebar 2021-04-15 14:17:06 -05:00
Maurice Parker
f2bbacc871 Add completion callbacks so that we can ensure that unreads have been marked before determining the next unread. Fixes #2993 2021-04-15 14:16:51 -05:00
Maurice Parker
8307a64b7b Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2021-04-15 14:13:24 -05:00
Maurice Parker
091ef7aba2 Exclude Inoreader from article status syncs 2021-04-15 14:13:15 -05:00
Brent Simmons
ebc10b54c1 Bump build to 601. 2021-04-13 19:52:48 -07:00
Stuart Breckenridge
70cf3a303a reworked gaurd statement 2021-04-13 07:55:22 -05:00
Stuart Breckenridge
1b3a070389 Fixes #2994
Removes force unwrapping and returns an empty string if the pubDate cannot be determined.
2021-04-13 07:55:05 -05:00
Maurice Parker
0ac3ba0bbb Change force unwraps so that we just fail on the move instead of crashing 2021-04-13 07:38:41 -05:00
Brent Simmons
4355d7617a
Merge pull request #2996 from stuartbreckenridge/fix/2994
Fixes #2994
2021-04-12 21:18:49 -07:00
Stuart Breckenridge
7df2fa5b1e
reworked gaurd statement 2021-04-13 12:17:31 +08:00
Stuart Breckenridge
307b24af1b
Fixes #2994
Removes force unwrapping and returns an empty string if the pubDate cannot be determined.
2021-04-13 12:00:50 +08:00
Maurice Parker
d418835086 Merge branch 'ios-candidate' into main 2021-04-12 21:09:56 -05:00
Maurice Parker
c47480614c Fix regression where marking all as unread wouldn't take you back to the sidebar 2021-04-12 21:09:34 -05:00
Maurice Parker
f0ab588c0f Update to latest Account API. 2021-04-12 19:46:59 -05:00
Maurice Parker
c25c8c0739 Merge branch 'ios-candidate' into main 2021-04-12 19:43:37 -05:00
Maurice Parker
991297165b Add completion callbacks so that we can ensure that unreads have been marked before determining the next unread. Fixes #2993 2021-04-12 19:42:05 -05:00
Maurice Parker
c95daa208f Add completion callbacks so that we can ensure that unreads have been marked before determining the next unread. Fixes #2993 2021-04-12 19:41:01 -05:00
Maurice Parker
11e2a3eca8 Change so that sync accounts have a Remove button instead of a Delete button. Fixes #2991 2021-04-12 13:48:54 -05:00
Maurice Parker
3a1b3f96bb Change so that sync accounts have a Remove button instead of a Delete button. Fixes #2991 2021-04-12 13:48:03 -05:00
Maurice Parker
69bd305184 Upgrade to the latest RSParser 2021-04-12 12:05:03 -05:00
Maurice Parker
ccaf47aa83
Merge pull request #2980 from stuartbreckenridge/contributions
Contributions
2021-04-11 09:10:05 -05:00
Maurice Parker
facfb6fb4b
Merge pull request #2977 from stuartbreckenridge/disable-reader-view
Disable reader view
2021-04-11 09:09:36 -05:00
Stuart Breckenridge
a498ff538e
Updated setup.sh instructions 2021-04-11 08:04:18 +08:00
Brent Simmons
4b9273be56 Add build phase to widgets extension to strip out frameworks. 2021-04-10 14:35:42 -07:00
Brent Simmons
a2334628cd Use .NetNewsWire.iOS.SpringboardWidgets as bundle ID for widgets extension. 2021-04-10 11:37:12 -07:00
Brent Simmons
030a09edcf Change bundle ID for widget extension to use plural widgets. 2021-04-10 11:26:09 -07:00
Brent Simmons
329788cea1 Bump version to 6.0, build 600. 2021-04-10 10:58:10 -07:00
Stuart Breckenridge
0fa30a9404
removes force unwrapping 2021-04-10 20:29:33 +08:00
Stuart Breckenridge
3c5af3159e
Adds setup script and updates readme. 2021-04-10 20:19:30 +08:00