Commit Graph

13 Commits

Author SHA1 Message Date
Ethan Wong
bfe63c4e19 Allow ImageViewController to be closed with the space key on physical keyoard for iOS. 2024-02-27 22:18:18 -08:00
Rizwan Mohamed Ibrahim
108da4ccf4
Fix buttons a11y label for close and share button for image vc
Image View Controller buttons both close and share don't have correct
a11y label. This will add the localised label
2020-04-21 22:14:58 +05:30
Maurice Parker
47e42fab0a Removed old debugging statement. 2020-03-12 16:01:13 -05:00
Flowinho
da64f65c7b Fixes close button icon distortion
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.

- Set content-mode of the buttons imageview to scaleAspectFit.
2020-03-12 21:54:50 +01:00
Flowinho
feacda1c3b HOTFIX silly me 2020-03-12 21:33:02 +01:00
Flowinho
91247b7f16 Adding dynamic width algorithm to the titleLabel
This commit adds multiple functionalities at once:

- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).

The title label now resizes itself depending on the devices it’s displazed on.

- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.

The numbers are derived from my personal preference when implementing it.
2020-03-12 21:23:57 +01:00
Maurice Parker
c2d298b836 Add the image title text to zoomed images. Issue #1468 2019-12-31 18:06:27 -07:00
Maurice Parker
eca5f8259a Enhance full image view support to work with 3 panel mode and split window views 2019-10-16 20:20:36 -05:00
Maurice Parker
425b3b09a1 Animate the transition to full screen image view 2019-10-15 18:08:13 -05:00
Maurice Parker
4759cedd35 Use Javascript to fetch to the image for the ImageViewController 2019-10-13 19:41:34 -05:00
Maurice Parker
bebf69ef74 Set bounds on share popover 2019-10-12 16:54:24 -05:00
Maurice Parker
60fb58ecaa Add share button to full screen image view. 2019-10-12 15:27:38 -05:00
Maurice Parker
3ee0506b4a Add fullscreen image previewing and zooming 2019-10-12 14:45:44 -05:00