Commit Graph

1703 Commits

Author SHA1 Message Date
Maurice Parker 2edd558139 Stop validation fall through for Reader API adds/edits 2020-10-27 14:45:21 -05:00
Maurice Parker 1035fd7b76 Make Reader API table cells unselectable 2020-10-27 14:44:47 -05:00
Maurice Parker b72948bc8e Update Extensions to match the new styling of the Accounts management functionality 2020-10-27 14:25:45 -05:00
Maurice Parker fa08dec5ff Add Inoreader to the list of services not available in the developer build 2020-10-27 14:03:53 -05:00
Stuart Breckenridge 83a3a0315b
Using Feedbin filled PDF 2020-10-27 22:06:23 +08:00
Stuart Breckenridge ef057d2f93
Removes fuzziness
Feed icons have been updated with any/dark appearance traits where possible instead of using tinting. Where possible, they’ve been converted to PDFs. iPhone/iPad icons now use PDFs based on SF Symbols.
2020-10-27 17:37:25 +08:00
Stuart Breckenridge 8661aae6b9
Tinting added to Settings and Inspector 2020-10-27 15:10:30 +08:00
Stuart Breckenridge ee88e83548
Tints added to iOS Account controllers 2020-10-27 12:25:15 +08:00
Stuart Breckenridge 5190bf0577
Restrict Accounts now part of cellForRow 2020-10-27 12:13:45 +08:00
Stuart Breckenridge 03611bc6ec
Add Accounts UI Refresh
• An extenison has been added to `AccountType` for iconColors (which have been added to the asset catalogs) and localised account names. SPM can handle resources so it might make sense to move to there.

• Add Account screen now has sections for local, icloud, web, and self-hosted, icons are now tinted and sized a bit smaller, and text is now `body` sized.
2020-10-27 11:42:28 +08:00
Maurice Parker 43382df4ec Make iOS match macOS for availability and order of offered accounts 2020-10-25 20:33:56 -05:00
Maurice Parker be7f0c5ddb
Merge pull request #2527 from stuartbreckenridge/additional-ios-account-types
Additional iOS account types
2020-10-25 20:11:16 -05:00
Stuart Breckenridge c25e42fc7e
additional iOS account types 2020-10-26 09:03:32 +08:00
Maurice Parker 807b2d3109 Don't delay hiding the progress bar unless we are animating it. 2020-10-25 12:46:25 -05:00
Maurice Parker b0fc1eccca Fix deprecation warnings for Xcode 12.2 2020-10-25 12:34:02 -05:00
Maurice Parker 6d9dcecd81 Prevent backgrounds from showing up when displaying symbol icons. Fixes #2523 2020-10-24 18:15:59 -05:00
Maurice Parker 6043cfc652 Add Inoreader, BazQux, and The Old Reader assets to iOS 2020-10-24 14:30:59 -05:00
Maurice Parker 09b5f53253 Add missing account type cases. 2020-10-24 14:23:48 -05:00
Maurice Parker 0a01a9f501 Display "(No Text)" if there isn't a title or summary for the timeline. Fixes #2391 2020-10-23 19:18:35 -05:00
Maurice Parker be35382f70 Update Feedbin icon to the new design. 2020-10-23 15:44:55 -05:00
Maurice Parker 8cffd206ec Change to use deselect instead of selecting a nil indexPath since deselect still animates correctly on iOS 14. 2020-10-22 19:48:09 -05:00
Maurice Parker 18726d061d Remove zero duration animations. 2020-10-22 18:56:33 -05:00
Maurice Parker 7030de089e Speed up context menus by checking unread count instead of fetching articles everytime. 2020-10-20 17:59:54 -05:00
Maurice Parker 8dbe5691e3 Update the user interface style on the main thread. 2020-10-20 13:45:28 -05:00
Maurice Parker 0b170b7ff5 Merge branch 'ios-release' into main 2020-10-18 19:59:11 -05:00
Maurice Parker 4284ea26c8 Merge branch 'mac-release' into main 2020-10-18 16:37:00 -05:00
Maurice Parker d1b8ac06af Ensure that the snapshot has items in it before testing section zero. 2020-10-17 20:06:53 -05:00
Maurice Parker 6cdb2cbfd0 Add exception handling for Reddit app when sharing since it doesn't pass the URL correctly to the share sheet. 2020-10-17 13:00:34 -05:00
Rizwan Mohamed Ibrahim e4ba77d1b9
Fix a11y for refresh progress view and adds traits 2020-10-07 19:50:12 +05:30
Maurice Parker 8ab762c860 FIx slider layering issue on iOS 14. Issue #2482 2020-10-05 17:28:03 -05:00
Maurice Parker dc35037740 Remove CSS rule that was interfering with Newsfoot styling 2020-09-29 07:35:05 -05:00
Maurice Parker ee7e32959f Add confirmation dialog for Feed/Folder deletes. Issue #1789 2020-09-28 20:21:07 -05:00
Maurice Parker afefac74fc Fix color of context menu preview title. 2020-09-28 17:16:03 -05:00
Maurice Parker 59d427d626 Don't allow duplicate Feedly or FeedWrangler accounts. Issue #2448 2020-09-24 18:02:12 -05:00
Maurice Parker bad21330f3 Revert to requesting notifications on application launch so that the badge can be configured. Issue #2447 2020-09-22 17:39:29 -05:00
Maurice Parker c580877a86 Change to utilize ArticleFetchers instead of Feeds so that the single article fetcher stops getting filtered out. Issue #2416 2020-09-12 18:09:42 -05:00
Maurice Parker feba4a7bc6 Change to respect individual feed filters when multiple feeds are selected. Issue #2399 2020-09-08 17:14:49 -05:00
Maurice Parker cf8dbb26f7 Resolve issue where we could have a web view deallocated before getting displayed. 2020-09-01 18:54:46 -05:00
Maurice Parker acaeb4164a Fix issue where web views that never readied themselves would clog up the queue. 2020-09-01 18:27:55 -05:00
Nate Weaver 34685328e0 Changes for IDNA support 2020-09-01 16:41:01 -05:00
Maurice Parker 4c221058d8 Don't insert the web view into the queue until the preload process has already started. 2020-08-26 18:08:43 -05:00
Maurice Parker c1b108f541 Merge branch 'mac-candidate' into main 2020-08-20 21:03:55 -05:00
Maurice Parker 6893c8ebc8 Use the lighter shade of NNW blue for darkmode article view (like iOS) 2020-08-20 21:02:28 -05:00
Maurice Parker a500166af0 Merge branch 'ios-release' into main 2020-08-15 11:03:29 -05:00
Stuart Breckenridge ddbf0fffb6
Fixes #2335
The `ReleaseNotes` struct has been replaced with an extension on URL. Release Notes can now be opened on all versions of NNW.
2020-08-15 15:01:00 +08:00
Maurice Parker eccfd5e15b Finish macOS Share Extension 2020-08-14 10:25:55 -05:00
Maurice Parker 54275225a7 Stub out Share Extension 2020-08-13 18:03:39 -05:00
Maurice Parker d6ed015514 Don't allow users to add Reddit or Twitter feeds if they don't have an extension configured. 2020-08-12 10:27:58 -05:00
Maurice Parker d05b450cc5 Use colorful smart feed icons on iOS 2020-08-11 20:41:20 -05:00
Maurice Parker c4ad7c71fd Don't allow Twitter or Reddit feeds to be added to accounts that can't handle them 2020-08-11 17:33:48 -05:00
Maurice Parker 0835e789e5 Add cancel button to Twitter Add Feed 2020-08-11 17:07:36 -05:00
Maurice Parker 0cb0bc357a Rename AddWebFeed controller classes to AddFeed since they are now used for other feed types 2020-08-11 17:04:11 -05:00
Maurice Parker 9f9b12b6b3 Add Twitter Feed functionality 2020-08-11 16:46:26 -05:00
Maurice Parker e7f42905dc Add Reddit Feed adding functionality 2020-08-11 16:27:42 -05:00
Maurice Parker 0ec250ec24 Rewrite Add Feed and Add Folder to be separate dialogs 2020-08-11 15:00:31 -05:00
Maurice Parker 3188a80d25 Remove CSS rule that was interfering with Newsfoot styling 2020-08-11 10:32:54 -05:00
Brent Simmons 462753e06b Update credits. 2020-08-10 22:16:45 -07:00
Maurice Parker e2de38647a Don't crash on early calls to update the toolbar 2020-08-09 20:13:37 -05:00
Maurice Parker 69fb9421a6 Fix tick mark placement which looked bad on iOS 14 2020-08-07 15:30:36 -05:00
Maurice Parker a63466f7b3 Add and remove buttons instead of hiding them since our hiding trick doesn't work on iOS 14 2020-08-07 15:20:20 -05:00
Maurice Parker 382078e8c6 Fix dynamic type warnings in new storyboards 2020-08-04 16:04:41 -05:00
Maurice Parker b724658528 Refactor how we do Secrets to work with the new Swift Package structure 2020-07-30 17:40:45 -05:00
Nate Weaver 1f9dfb80e2 Changes for IDNA support 2020-07-29 15:42:11 -05:00
Rizwan Mohamed Ibrahim 1c4b6b4c26
Fix a11y for title view of timeline view controller 2020-07-29 11:37:27 +05:30
Maurice Parker 18fd984246 Revert "Update to the maintenance branches of the submodules"
This reverts commit e672f6c5ac.
2020-07-28 18:13:35 -05:00
Maurice Parker e672f6c5ac Update to the maintenance branches of the submodules 2020-07-28 17:47:52 -05:00
Maurice Parker 66f8180006 Make sure we are changing the user interface style on the main thread 2020-07-27 19:35:41 -05:00
Noelle Leigh 7f60b3d330 fix iOS/Settings/SettingsViewController.swift 2020-07-26 06:37:40 -05:00
Noelle Leigh 908e8c3c63 fix iOS/Settings/SettingsViewController.swift 2020-07-26 05:46:27 -04:00
Maurice Parker 84389e2cf4 Move from using views for the queue to using an array and remove unneeded flush of queue 2020-07-16 13:56:07 -05:00
Rizwan Mohamed Ibrahim 64a4d9bbe5
Fix localised comments 2020-07-14 22:04:20 +05:30
Rizwan Mohamed Ibrahim 1a3bbf7dbf
Add a11y label for starred status on master timeline 2020-07-14 18:08:07 +05:30
Rizwan Mohamed Ibrahim 1427e1d8c6
Add a11y label for expanded/collapsed status for Master Feed 2020-07-14 18:07:29 +05:30
Stuart Breckenridge 7183b853bd
#2256
Fixes #2256
2020-07-13 14:24:57 +08:00
Nate Weaver 059ebd5e27 Use parentContainerID when computing hash also 2020-07-12 07:44:43 -05:00
Maurice Parker 95a8f6d72d Merge branch 'swiftui' 2020-07-10 15:28:14 -05:00
Nate Weaver 82f7f99827 iOS: Make shift-space scroll up even when the detail view doesn't have focus 2020-07-10 13:57:35 -05:00
Maurice Parker 99820c1c2f Fix class name 2020-07-08 17:25:10 -05:00
Maurice Parker 526fe71cf1 Merge branch 'master' into swiftui 2020-07-08 13:23:23 -05:00
Maurice Parker 4ba2ab4baa Complete the dequeue operation even if the web view navigation fails 2020-07-08 13:22:19 -05:00
Maurice Parker e1c8479515 Prevent Twitter embeds from cutting off. Issue #2166 2020-07-07 11:47:52 -05:00
Maurice Parker 2e94ae9e8e Add basic support for Article view on iOS 2020-07-06 21:14:05 -05:00
Maurice Parker dd9dca57de Update design to more closely match the existing iOS design and Big Sur look and feel 2020-07-03 19:19:40 -05:00
Maurice Parker 88d03586ae Register AppDefaults. Issue #2190 2020-07-03 01:24:35 -05:00
Maurice Parker d15dbe18ef Change AppDefaults to be final classes on macOS and iOS 2020-07-02 05:36:23 -05:00
Stuart Breckenridge f92b219cdc NetNewsWire-iOS AppDefaults is now a singleton 2020-07-02 10:47:45 +08:00
Rizwan Mohamed Ibrahim 687b454cd7
fix mark all as read context menu on Accounts 2020-07-01 12:30:39 +05:30
Maurice Parker 72ef643a5f Remove commented code 2020-06-29 04:29:39 -05:00
Maurice Parker 403b859c31 Verify that the section exists before accessing it so that we don't crash on the new SDK 2020-06-28 03:14:53 -05:00
Brent Simmons 4ed6ccd52b Fixed warning from Apple upload system — NSExtensionActivationSupportsText needed to be a boolean, not a string. 2020-06-27 18:15:26 -07:00
Maurice Parker 05f259da51 Merge branch 'ios-release' 2020-06-21 17:55:33 -05:00
Maurice Parker 95704c7f3e Prefix accessibility label with unread when item is unread. Issue #2142 2020-06-20 11:05:54 -05:00
Maurice Parker 21e79250db Merge branch 'ios-release' 2020-06-18 17:45:12 -05:00
Maurice Parker d453a94330 Make unread and star animations cancel on cell reuse. Issue #2054 2020-06-18 17:37:29 -05:00
Maurice Parker b3c0fac5d3 Save the previous feed instead of relying on the currentFeedIndexPath which may have been reset. Issue #2139 2020-06-18 16:16:30 -05:00
Maurice Parker 5356189654 Optimize unread count look up 2020-06-16 08:32:01 -05:00
Maurice Parker d69b313525 Optimize unread count lookup 2020-06-16 08:27:59 -05:00
Maurice Parker 36e39705e7 Merge branch 'ios-release' 2020-06-16 08:10:31 -05:00
Maurice Parker 7dd20560c3 Remove reset of web view controller when returning to foreground. 2020-06-16 08:09:28 -05:00
Maurice Parker 4075da2ee8 Fix removal of tap zones when removing old web views 2020-06-16 08:07:54 -05:00
Maurice Parker 50508446bb Use immutable object for diffable datasource on Feeds. Issues #1901, #2031, #2124 2020-06-15 18:03:20 -05:00
Maurice Parker 95f6f80583 Merge branch 'ios-release' 2020-06-15 17:40:06 -05:00
Maurice Parker 3b2fcb74fd
Merge pull request #2134 from Mackarous/master
Disable selection while applying snapshot
2020-06-15 17:23:23 -05:00
Andrew Mackarous 5cc2605add Fix issue #2132 2020-06-15 02:42:30 -04:00
Brian Sanders 6aa7b009f8 Tweaks the scroll behavior when space bar is pressed
The overlap is 2 lines of text at the standard system font size.
2020-06-13 19:17:17 -04:00
Rizwan Mohamed Ibrahim f2cd09aae3
refactor open in app browser with global shortcuts 2020-05-29 20:39:04 +05:30
Rizwan Mohamed Ibrahim d671029828
refactor open in app browser for mac and iOS 2020-05-29 19:26:20 +05:30
Maurice Parker 9253222f96 Rollback change that incorrectly was stopping web activity on wrong controllers 2020-05-27 11:30:30 -05:00
Maurice Parker 809379038f Stop image zooming and video playback on page swipe 2020-05-27 10:12:20 -05:00
Kiel Gillard 🤪 9d7ebf8dfa Command + I can be used to get info on a feed for a timeline or an article. Fixes #2104 2020-05-26 14:52:15 +10:00
Maurice Parker 3ce20e26ff
Merge pull request #2102 from stuartbreckenridge/issue-1932
Adds Title when sharing to Tweetbot and Buffer
2020-05-23 15:02:03 -05:00
Stuart Breckenridge 8b3e5d7cfd
Adds Title when sharing to Tweetbot and Buffer
Fixes #1932
2020-05-22 20:53:22 +08:00
Stuart Breckenridge 98c8ea6d9f
disables swipe back gesture on trackpads 2020-05-20 21:32:19 +08:00
Maurice Parker 7d8e49a2ee Merge branch 'ios-release' 2020-05-18 03:05:59 -05:00
Maurice Parker b575d648dc
Merge pull request #2063 from bdougsand/find-in-article-ios
Adds "Find in Article" activity to the share sheet
2020-05-18 02:41:28 -05:00
Stuart Breckenridge 2297d218c0
Uses selector syntax. 2020-05-18 09:23:42 +08:00
Stuart Breckenridge 6224dfad03
Notification Permission Requests
Fixes #2057

• On app launch, the app checks if notification permissions are granted and registers with APNS if that is the case. It will not request permissions as part of the app launch.

• When a user requests to be notified of new articles, the authorizationStatus is checked:
- if `notDetermined` or `provisional`, an authorization request is made, and if successful, the Notify of New Articles status is updated (otherwise it is reverted)
- if `denied`, an alert is thrown asking the user to enable in settings (and the change to notify of new articles is reverted)
- if `authorized` the update is made.

`WebFeedInspectorViewController` also monitors for the app entering the foreground so that it can get the latest notification auth settings.
2020-05-18 08:39:22 +08:00
Brian Sanders d8dced6347 Adds a key command (ESC) to the article search bar 2020-05-15 21:41:14 -04:00
Brian Sanders b058f27064 Fixes bugs in article search
Placement of the article search bar is now always done with constraints.
Previously, I'd used inputAccessoryView when the keyboard appeared. That
approach, although ostensibly permitted, causes a hierarchy inconsistency error
when the device orientation changes.
2020-05-15 21:41:14 -04:00
Brian Sanders 62d04e8881 Adds stored inputAccessoryView to ArticleSearchBar
It should have been obvious that inputAccessoryView traverses the responder
chain
2020-05-15 21:41:14 -04:00
Brian Sanders 46ce824b98 Adds guard against empty search strings to Find in Article 2020-05-15 21:41:14 -04:00
Brian Sanders 96671df667 Adds keyboard shortcut for "Find in Article" (iOS) 2020-05-15 21:41:14 -04:00
Brian Sanders 2631f4f3f0 Alters search highlights so they don't intercept pointer events 2020-05-15 21:41:14 -04:00
Brian Sanders edb7c50cb3 Improves incremental search for "Find in Article"
Article search now maintains its position in the document, if possible.
2020-05-15 21:41:14 -04:00
Brian Sanders 98e0434077 Alters Find in Article to escape regex characters by default 2020-05-15 21:40:22 -04:00
Maurice Parker c2b749a74c Rebuild backing stores immediately when deselecting a Feed. Issue #2079 2020-05-15 17:06:49 -05:00
Maurice Parker 4e22489d97 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-05-15 10:45:22 -05:00
Maurice Parker 8ff2776d88 Make sure we have only one web view in the view hierarchy after navigation. Issue #2075 2020-05-15 10:45:05 -05:00
Maurice Parker 225c98a70e
Merge pull request #2073 from rizwankce/open-in-safari-shortcut
Keyboard shortcuts for "Open in App Browser"
2020-05-15 04:38:26 -05:00
Rizwan Mohamed Ibrahim c9ebb6bd75
adds "Open In App Browser" shortcut 2020-05-15 12:39:33 +05:30
Rizwan Mohamed Ibrahim 04458adee5
adds "Mark All Read" shortcut for feeds list 2020-05-14 18:13:41 +05:30
Rizwan Mohamed Ibrahim f7f7f4dddb
adds keyboard shortcuts for open in Safari 2020-05-14 17:58:38 +05:30
Maurice Parker 8500324eb2
Merge pull request #2041 from stuartbreckenridge/mail-fix-ios
mailto links now open on iOS
2020-05-14 07:26:26 -05:00
Maurice Parker 8fe746fabf
Merge pull request #2072 from rizwankce/fix/share-extension-activation-rule
Share extension activation rule for text
2020-05-14 07:17:54 -05:00
Maurice Parker 7deac7f3c3
Merge pull request #2071 from stuartbreckenridge/issue-2018
Key commands work with action sheets
2020-05-14 07:14:57 -05:00
Rizwan Mohamed Ibrahim bfef02e18f
adds text activation rule for share extension 2020-05-14 17:17:16 +05:30
Stuart Breckenridge a9e8cec90e
Key commands work with action sheets 2020-05-14 17:10:55 +08:00
Maurice Parker 8f8bd229c5
Merge pull request #2068 from rizwankce/feature/keyboard-shortcuts
Keyboard shortcuts
2020-05-13 11:43:14 -05:00
Rizwan Mohamed Ibrahim 32c8c038ee
move toggle side bar to RootSplitViewController 2020-05-13 21:57:02 +05:30
Rizwan Mohamed Ibrahim a9aefd252e
adds keyboard shortcuts
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
2020-05-13 17:29:59 +05:30
Stuart Breckenridge f153643273
Removes return statements that are not needed. 2020-05-13 13:03:51 +08:00
Stuart Breckenridge 58575331dd
Fixes #2018
This commit adds a new `MarkAsReadAlertControllerSourceType` protocol to which `CGRect`, `UIView`, and `UIBarButtonItem` conform to.

The `MarkAsReadAlertController` now presents an action sheet for mark as read, mark above as read, and mark below as read. The above is used for the `popoverPresentationController`’s `barButtonItem`, `sourceRect`, or `sourceView` as needed.
2020-05-13 12:33:51 +08:00
Maurice Parker 775a69a295 Add iOS Reddit URL builder 2020-05-12 11:17:47 -05:00
Brian Sanders 737f4bfdf5 Adds "Find in Article" activity to the share sheet
addresses #1750
2020-05-11 17:08:44 -04:00
Maurice Parker ccb813f6ec Allow autoplay on iOS 2020-05-10 12:21:35 -05:00
Maurice Parker fda9be2e41 Update the progress bar when it comes into view so that it is always current 2020-05-10 10:00:04 -05:00
Maurice Parker 50e6e8e190
Merge pull request #2050 from jbennett/2049-add-folder-management-behavior
Adds an account behavior to disable folders
2020-05-08 15:36:16 -05:00
Maurice Parker 715804fe64 Merge branch 'ios-release' 2020-05-07 11:34:02 -05:00
Maurice Parker 46a96a7d50 Serialize access to the web view provider. Issue #2043 2020-05-07 11:32:11 -05:00
Jonathan Bennett a37bfd5d74 Adds an account behavior to disable folders
Some sync services (Feed Wrangler) don't support folders. This behavior removes the account from the UI when adding new folders.
2020-05-07 10:03:04 -04:00