Commit Graph

246 Commits

Author SHA1 Message Date
Daniel Jalkut
d79bbefeb8 mac-release targeted version of the fix for #989 2019-09-06 15:40:59 -04:00
Daniel Jalkut
8e01e8e45a Instantiate an RSAppMovementMonitor to track user movement of the application while running. Fixes #897. 2019-09-06 09:13:09 -04:00
Brian Warren
ce3ec10c95 Enforcing automatic height for images in the template 2019-09-05 10:59:16 -07:00
Brent Simmons
f0d080b0be Remove blank line from near top of About window credits. 2019-09-04 21:04:21 -07:00
Brent Simmons
5ad307411d Bump version to 5.0.1d1 2019-09-04 21:00:59 -07:00
Maurice Parker
7a8d23958b Restrict iframe width to be at most 100% 2019-09-04 17:41:58 -05:00
Thomas Pritchard
d3ad4b52a3 Set a sensible line height for figure captions 2019-09-04 19:58:29 +01:00
Thomas Pritchard
5976923f23 Add figures to Mac detail stylesheet 2019-09-04 19:58:29 +01:00
Brent Simmons
0ba8f3b4e1 Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898. 2019-09-03 22:58:17 -07:00
Brent Simmons
cbaad4bdeb Add checkbox to Preferences > General for turning off the unread count in the Dock. 2019-09-03 22:17:31 -07:00
Brent Simmons
5efbe6a4f0 Add NNW website link to top of About window text. 2019-09-03 21:24:17 -07:00
Jim Correia
c8920ca5a6 Added optional separators in the timeline view.
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
2019-09-02 09:13:21 -07:00
Jim Correia
e7e77d362c Fix for bug #901 — first web view load flashes white in dark mode
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.

Instead, use a modification of the original solution used for iOS:

    - wrap the web view in a box with an appropriate background color
    - hide the web view at creation
    - show the web view after* the first load

This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.

[*] Showing the view immediately after the first load still causes the flash
    to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
    but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
Jim Correia
cdfdc06142 Only enable "Open in Browser" when a single article is selected.
Fixes bug #921.
2019-08-31 16:02:21 -07:00
Brent Simmons
29efae42fd Update Apple events privacy statement to refer to article instead of news item. 2019-08-28 21:40:56 -07:00
Brent Simmons
d468961d81 Update version and build number. 2019-08-28 21:40:21 -07:00
Maurice Parker
3279a25581 Cache home page to feed icon relationship 2019-08-26 19:40:30 -05:00
Maurice Parker
1a3e2784ae Optimize table cell reloading when feed images are made available 2019-08-26 12:54:23 -05:00
Brent Simmons
c3aebe7868 Bump version and build. 2019-08-23 21:59:44 -07:00
Brent Simmons
739eb5183e Bump version and build numbers. 2019-08-23 18:31:04 -07:00
Brent Simmons
dd62a3325a Center the main window on first run. 2019-08-23 18:30:28 -07:00
Brent Simmons
4bead42b5a Center prefs window after switching to the proper view. 2019-08-23 18:30:14 -07:00
Brent Simmons
cc7321e936 Center the preferences window. Fix #769. 2019-08-23 16:22:06 -07:00
Brent Simmons
3447ebcec0 Reload data after a batch update. Fix #872. 2019-08-23 15:52:07 -07:00
Brent Simmons
e140d51e4b Bump version and build number. 2019-08-21 21:42:48 -07:00
Brent Simmons
849830f494 Refetch articles for smart feeds and folders, if selected, when a feed or folder is deleted. Fix #838. 2019-08-21 21:41:56 -07:00
Brent Simmons
f513741ddb Start work on filtering timeline so that articles from deleted feeds never show up. 2019-08-21 13:23:46 -07:00
Brent Simmons
e524d48c1d Add credit to Joe Heck in the About window for difficult infrastructure. 2019-08-19 14:38:18 -07:00
Brent Simmons
588dbb0ce5 Add prefs to Advanced prefs pane to 1) check for updates automatically, and 2) choose to download test or release builds. The default will be release builds only, since most people don’t want test builds. 2019-08-18 16:07:37 -07:00
Brent Simmons
5670989c29 Do initial layout of revised Advanced preferences (which now include updates preferences). 2019-08-17 16:58:39 -07:00
Brent Simmons
8d7e238386 Change default SUFeedURL to release builds appcast. Add FeedURLForTestBuilds to store the URL for test builds. 2019-08-17 11:04:54 -07:00
Brent Simmons
3aae7ad328 Now using manual build numbers, because I messed up and built from the wrong branch. I should be able to figure out how to get back to automated build numbers — but it can wait till after 5.0 ships. 2019-08-14 00:20:42 -07:00
Brent Simmons
f86c32b414 Bump version to b4. 2019-08-14 00:13:50 -07:00
Brent Simmons
8cb9aefeec Bump version to 5.0b3. 2019-08-13 21:24:15 -07:00
Brent Simmons
2bbd135c9e Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829. 2019-08-13 21:07:39 -07:00
Brent Simmons
fc0fc2055e Get the unread count from the timeline, instead of the database, only for the Today feed and only if it’s selected and it’s the only node selected. 2019-08-13 20:29:04 -07:00
Brent Simmons
cf1b3843ee Add a SmartFeedType to smart feeds so the sidebar can tell them apart. 2019-08-13 20:28:28 -07:00
Brent Simmons
62258683c8 Add Ryan’s word-wrap change to mac-candidate. 2019-08-13 20:07:42 -07:00
Brent Simmons
bfe3a15b9d Bump version to 5.0b2. Remove how-to-support thing from About box. 2019-08-12 09:53:47 -07:00
Brent Simmons
495662f888 Add, to About window, credit for Ryan Dotson for the Help Book. Also add a link to the How to Support NetNewsWire tech note. 2019-08-11 22:08:24 -07:00
Brent Simmons
bf3e26e827 Bump version to 5.0b1. 2019-08-11 21:58:27 -07:00
Brent Simmons
40369eaca0 Change the URL of the Help book to include a /mac/ directory, so we can have separate help books for Mac and iOS. 2019-08-10 14:26:51 -07:00
Brent Simmons
536ac205a0 Fix crash when making a feed via AppleScript and the feed already exists. 2019-08-03 11:04:52 -07:00
Brent Simmons
4b5dd7cd17 Fix some AppleScript terminology conflicts. Change account.type too account.accountType. Change local account to onmymac. 2019-08-02 14:03:04 -07:00
Brent Simmons
ccd1d4bdc1 Wire up the account name for scripting. 2019-08-02 12:44:24 -07:00
Brent Simmons
5d97e89e91 Replace the contents property with allFeeds — which returns all the feeds, including those inside folders. This is distinct from the feeds element, which returns just top-level feeds. 2019-08-01 22:51:03 -07:00
Brent Simmons
e800b13f01 The accounts property returns all accounts. 2019-08-01 21:52:12 -07:00
Brent Simmons
31e089fc1d Add an active property to the scripting definition for Account. 2019-07-29 19:56:22 -07:00
Brent Simmons
887f8e0b53 Check to see if the timeline already has the expected representedObjects when the sidebar selection (apparently) has changed. If so, then don’t set the representedObjects again, and don’t knock the user out of search mode if searching. 2019-07-28 16:00:43 -07:00
Brent Simmons
2441de960f Skip reloading the sidebar after the tree controller rebuilds when the rebuilt version is the same as the previous version. This saves some cycles, and it’s part of fixing #791. 2019-07-28 15:31:17 -07:00
Brent Simmons
44ec6a026d Get the unread count from the timeline for the currently selected node in the sidebar. This ensures that transients in the timeline are accounted for. (The database query for the unread count wouldn’t necessarily match.) 2019-07-27 22:53:27 -07:00
Brent Simmons
05faea53c4 Remove reference to NSCalendarDayChanged — it’s no longer necessary to update the Today feed unread count when the day changes. 2019-07-27 19:52:05 -07:00
Brent Simmons
8acab45cf9 Make formatting changes to SidebarViewController.swift so it conforms to current formatting thinking. 2019-07-27 19:49:33 -07:00
Brent Simmons
a41f7d8e68 Remove some unneeded drawing. This makes resizing the timeline faster. 2019-07-27 15:44:13 -07:00
Maurice Parker
8b0c8156df Remove refresh at midnight for Today smartfeed 2019-07-26 08:06:08 -05:00
Maurice Parker
4fc1998cf3 Make Account and AccountDelegate interfaces more consistent by requiring the container parameter on removeFeed. Resolves #802 2019-07-17 15:41:21 -05:00
Brent Simmons
b1606ce20f Add thanks to GitHub, Slack, and CircleCI to about box. 2019-07-09 21:45:01 -07:00
Brent Simmons
7a204ad6ed Run database fetches async, in the timeline, when appropriate — for instance, when All Unread is selected and new articles come in. 2019-07-05 20:06:31 -07:00
Brent Simmons
6f16a2715e Skip downloading featured images, since we’re not displaying them anywhere. 2019-06-17 21:47:17 -07:00
Brent Simmons
6cf6df059f Update version to 5.0a4. 2019-06-15 17:20:43 -07:00
Maurice Parker
18b90ba93f Added How To Support NetNewsWire help menu item. Issue #753 2019-06-14 17:38:00 -05:00
Maurice Parker
ed6dd249c3 add missed file in last commit 2019-06-14 15:35:12 -05:00
Maurice Parker
40b9be6709 center smaller avatars on a solid color background image to make all avatars a consistent size 2019-06-14 15:33:13 -05:00
Maurice Parker
6527ac852c Correct usage of BatchUpdate so that UI remains responsive after error messages Issue #752 2019-06-13 14:50:41 -05:00
Nate Weaver
3e8e7113c0 Make read/starred read/write via AppleScript 2019-06-11 19:17:50 -05:00
Brent Simmons
3e0f70f43e Update version to 5.0a3. Update appcast. 2019-06-10 21:52:13 -07:00
Maurice Parker
e8199ed0a6 Change to not show alert dialog on automatic refreshes. Issue #729 2019-06-10 15:21:17 -05:00
Maurice Parker
93fbbd4cc3 Make sure that FeedFinder and InitialDownloader are running on the main thread. 2019-06-10 08:21:03 -05:00
Brent Simmons
45f6d8043a Add ellipsis where needed in import/export OPML sheets. Fix #731. 2019-06-09 20:18:10 -07:00
Brent Simmons
4a4fa6ed0e Fix crashing bug by not using an NSFont as a key in a Swift dictionary. Fix #734. 2019-06-09 16:03:08 -07:00
Brent Simmons
2d96544933 NetNewsWire 5.0a2. 2019-06-08 16:29:07 -07:00
Charles Parnot
4f02fe7401 Fix issue with 'Mark as Read' menu item in the Article menu.
There were 2 issues: the title of the menu item did not toggle between 'Mark As Read' and 'Mark As Unread', and it was not invalidated where there is no article selected. All the code was already in place in `MainWindowController` as part of the interface item validation, but the menu item was using the wrong selector: `markRead` instead of `toggleRead`. Just changing the action in the menu item was needed to get the validation and menu item update happening correctly.
2019-06-07 09:06:18 +02:00
Brent Simmons
364fc2760f Bump version to 5.0a1. That’s right — it’s alpha now. W00t! 2019-05-31 20:21:08 -07:00
Maurice Parker
3593d1c5d8 Update to the new icon 2019-05-31 13:52:15 -05:00
Maurice Parker
88b2775076 Make sure that an account doesn't try persist to the disk in the time that it is logically deleted and when it is actually deallocated 2019-05-31 08:05:26 -05:00
Maurice Parker
beacad1aeb Validate folder drop to make sure no folders with the same name are already in the target account 2019-05-30 17:57:06 -05:00
Maurice Parker
a8f090656d Handle when a feed in a folder being copied/moved already is subscribed in target account 2019-05-30 14:44:13 -05:00
Maurice Parker
30c21bb125 Enable folders to be dropped in a move or copy between accounts 2019-05-30 14:36:21 -05:00
Maurice Parker
1352dda8aa Modify Feedbin feed deletes so that they emulate how the local account feed deletes work. 2019-05-30 10:12:34 -05:00
Maurice Parker
51284b5aa4 Rename deleteFeed to removeFeed to be more consistent with other API's 2019-05-29 21:04:44 -05:00
Maurice Parker
527e677934 Rename deleteFolder to removeFolder to make the API more consistent 2019-05-29 20:53:00 -05:00
Maurice Parker
f4bc17c8f1 Refactor addFeed and removeFeed usages to be more consistent 2019-05-29 20:47:52 -05:00
Maurice Parker
5e3fcfd955 Correct how feeds were deleted so that only the feed in the correct container was deleted 2019-05-29 17:56:26 -05:00
Maurice Parker
bead6ae123 Remove now unnecessary call to account structureDidChange in drop 2019-05-29 17:14:50 -05:00
Maurice Parker
fa6b6a4769 Corrected move BatchUpdate usage to make move animation smoother 2019-05-29 17:08:41 -05:00
Maurice Parker
b1bd8d2d90 Enable folder dragging between accounts 2019-05-29 15:43:33 -05:00
Maurice Parker
8fc6e81ddf Update the Today timeline and unread count when the day changes. Issue #627 2019-05-29 10:24:30 -05:00
Maurice Parker
0648053417 Enforce tag specific drop validation (can't copy to the account level) 2019-05-28 17:42:19 -05:00
Maurice Parker
83652c40de Handle scenario where moved/copied feed already exists somewhere else in account 2019-05-28 16:46:16 -05:00
Maurice Parker
01d5a95241 Remove redundant private keyword usage 2019-05-28 16:31:03 -05:00
Maurice Parker
112702020b Enable same account copying. 2019-05-28 13:11:29 -05:00
Maurice Parker
78c19bda43 Remove restriction on only moving and copying between local accounts. 2019-05-28 11:09:47 -05:00
Maurice Parker
b3c4c8de59 Correct how feeds were copied and moved between accounts to eliminate shared objects. 2019-05-28 10:59:06 -05:00
Maurice Parker
493abbb609 Refactor create feed functionality to increase code reuse and encapsulation 2019-05-28 09:45:02 -05:00
Maurice Parker
c7b61f7d87 Enable copy between local accounts. 2019-05-27 18:01:24 -05:00
Maurice Parker
659c9e5271 Allow dragged feeds between local accounts only 2019-05-27 15:11:16 -05:00
Brent Simmons
bfe41438fc Make default exported OPML file name Subscriptions-[accountName].opml. Fix #683. 2019-05-26 22:17:19 -07:00
Brent Simmons
e5e9538318 Change column spacing in the grid view so that we use standard space between labels and content. 2019-05-26 22:12:09 -07:00
Brent Simmons
8322ea4f31 Tweak the explanotext for the Name field in Account > Preferences. 2019-05-26 22:01:50 -07:00
Brent Simmons
6cd8f42597 Add layout constraints for the table cells in Account > Preferences sidebar. 2019-05-26 21:59:41 -07:00