Brent Simmons
3ead2c63bc
Remove attachments from the app, since we’re not using attachments in any way. We could always add it back later.
2019-12-03 23:03:15 -08:00
Brent Simmons
f8376b807a
Restore two-step process for OPML exporting.
2019-10-24 21:12:58 -07:00
Brent Simmons
1c06eb27e8
Create separate private extension. Make misc. code formatting changes to match current thinking.
2019-10-23 22:33:21 -07:00
Brent Simmons
6f29497ec8
Move NSTextFieldDelegate conformance to separate extension.
...
Handle the optional nil case in controlTextDidChange.
2019-10-23 22:27:08 -07:00
Brent Simmons
c01b2c6269
Merge pull request #1145 from Wevah/add-folder-button-fix
...
Disable "Add Folder" button when the text field is empty
2019-10-23 22:22:12 -07:00
Brent Simmons
06b0e35739
Move Protocol declaration to top of ExportOPMLAccessoryViewController.swift. As critical API, it needs to be easy to spot.
...
Create separation extensions — one for protocol conformance, one for private methods — ExportOPMLController.
Make minor code formatting change: instead of { return } — which is hard to set a breakpoint on — move the return to its own line.
Remove an internal access qualifier, since internal is default and implied.
2019-10-23 22:00:14 -07:00
Nate Weaver
37e77a9596
Make delegate-less init() fail since a delegate is currently required
2019-10-22 12:14:38 -05:00
Nate Weaver
e7278017d9
Forgo notifications entirely, and use a delegate instead
2019-10-22 12:14:38 -05:00
Nate Weaver
a762052264
Don't use block-based notification observing
2019-10-22 12:14:38 -05:00
Nate Weaver
7e98869080
Use an accessory view instead of an intermediate sheet for OPML export
2019-10-22 12:14:38 -05:00
Nate Weaver
b5d7ce8e8c
Disable "Add Folder" button when the text field is empty
2019-10-19 12:31:47 -05:00
Brent Simmons
a11e900a93
Get the y scroll position in the detail view using window.pageYOffset instead of document.body.scrollTop. It appears the latter may be broken — at any rate, it just returns 0 on Catalina. (On Mojave, use the same method as before, so as not to risk a regression.)
2019-10-18 17:37:56 -07:00
Brent Simmons
56fab24cec
Make importing NetNewsWire 3 subscriptions a one-step process — use an accessory view in the NSOpenPanel. Also: refactor to use immutable structs instead of classes; use static methods on structs; reduce API surface; don’t flatten sub-folders (let the OPML importer handle the flattening, which it already does).
2019-10-17 13:25:11 -07:00
Maurice Parker
19145505c5
Add the ability to import NNW 3 Subscription plist files. Issue #1129
2019-10-14 20:45:58 -05:00
Brent Simmons
427c0da0d3
Fix build error in FetchRequestQueue.
2019-10-13 22:19:49 -07:00
Brent Simmons
31a2afb067
Fix crashing bug in FetchRequestQueue by making sure the completion is called not more than once from FetchRequestOperation. Fix #1133 .
2019-10-13 22:08:05 -07:00
Brent Simmons
099172d9d2
Empty the database articles cache when NetNewsWire moves to the background. This helps prevent the cache from growing forever.
2019-10-12 15:06:21 -07:00
Jim Correia
be89df884d
The Debug menu can now be enabled in release builds.
...
`defaults write com.ranchero.NetNewsWire-Evergreen ShowDebugMenu -bool YES`
Toggling the Web Inspector uses SPI, so it's always excluded from the Debug
menu when building for the Mac App Store.
2019-10-06 17:56:53 -07:00
Brent Simmons
098128fd0a
Use new Slack group URL with Help menu command. Fix #1087 .
2019-09-29 22:46:40 -07:00
Brent Simmons
27478b0f6f
Make r and u both just toggle read status. Update keyboard shortcuts HTML documentation to match.
2019-09-29 22:44:32 -07:00
Brent Simmons
b62a7afa10
Add keyboard shortcut for toggling starred status — s key. Fix #875 .
2019-09-29 22:34:31 -07:00
Maurice Parker
c4ee1edb69
Add externalID to Folder and persist it to OPML file. Issue #1060
2019-09-25 17:01:09 -05:00
Nate Weaver
0c99a5f523
Remove enableWebInspectorMenuItem outlet
...
Fixes a console warning about the removed property.
2019-09-22 15:19:23 -05:00
Ben Ubois
cdf643c2a6
Make iFrames responsive.
2019-09-20 17:21:01 -07:00
Nate Weaver
502f5656b8
Don't hide the Web Inspector menu item since the entire Debug menu is removed for release builds
2019-09-19 11:27:04 -05:00
Nate Weaver
180cc39904
Negate MAC_APP_STORE
...
Oops. (Was un-negated for testing.)
2019-09-19 11:19:25 -05:00
Nate Weaver
4a0bbeacc2
Disable Web Inspector for App Store builds
...
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
Nate Weaver
93f7972441
Add some spacing around a comment
2019-09-17 13:58:45 -05:00
Nate Weaver
1e840f3090
Move WebKit "inspector starts attached" user default to AppDefaults
2019-09-17 13:42:18 -05:00
Nate Weaver
4a2724bcc4
Fix comment capitalization
2019-09-17 13:27:11 -05:00
Nate Weaver
0c89bc43c1
Use a bridging header for the Web Inspector API instead of KVC
2019-09-17 06:55:55 -05:00
Nate Weaver
4f405009f5
Use a selector instead of a block for the notification observation
2019-09-17 05:04:05 -05:00
Nate Weaver
e39fa31bf7
Add a menu item to the Debug menu to enable the Web Inspector
...
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
2019-09-17 05:04:05 -05:00
Brent Simmons
66d9333999
Make minor code formatting changes so that TimelineViewController matches our current thinking. Also delete some commented-out and unused code.
2019-09-16 22:27:17 -07:00
Brent Simmons
f7c9cc1dbd
Remove no-longer needed machinery for updating the timeline on dark-mode/light-mode appearance changes.
2019-09-16 22:09:58 -07:00
Brent Simmons
a05fd61085
Merge branch 'imagecache' into mac-release
2019-09-16 20:07:31 -07:00
Brent Simmons
a225d52ba3
Use the new TimelineAvatarView instead of an NSImageView in TimelineTableCellView.
2019-09-16 20:01:30 -07:00
Brent Simmons
506b621e5d
Draw the avatar background in TimelineAvatarView only if the icon is too short vertically.
2019-09-16 20:00:32 -07:00
Brent Simmons
2f9f4e263c
Restore color for light avatar background.
2019-09-16 19:59:33 -07:00
Maurice Parker
1d7cbe5596
Fix super wide div's. Issue #1010
2019-09-16 18:12:56 -05:00
Maurice Parker
0458fd3838
Delete avatar and favicon image caches every three days
2019-09-16 16:26:40 -05:00
Brent Simmons
8a2d1f5f6a
Create TimelineAvatarView, which draws the background for images that need it.
2019-09-15 23:02:13 -07:00
Maurice Parker
57542592cb
Correct which view should become the first responder. Issue #1014
2019-09-11 17:47:02 -05:00
Brent Simmons
7ad0b6b604
Always update the unread count in the timeline after doing a sync fetch after representedObjects changes. Reload visible cells whenever showFeedNames changes. Fix #923 .
2019-09-10 20:28:16 -07:00
Maurice Parker
8dda681409
Add accessibility labels to Sidebar, Timeline, and Article. Issue #934
2019-09-10 11:09:17 -05:00
Maurice Parker
0961753357
Merge pull request #998 from hisaac/mac-release
...
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 13:02:58 -05:00
Isaac Halvorson
8b635fc04c
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 12:54:26 -05:00
Brent Simmons
58c2fad2fd
Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976 .
2019-09-06 19:28:06 -07:00
Brent Simmons
d49b212bc2
Delete unused EvergreenLarge.png.
2019-09-06 19:11:41 -07:00
Maurice Parker
0e7d971e65
Queue a reload of all visible cells anytime a favicon is downloaded. Issue #995
2019-09-06 16:52:31 -05:00
