Commit Graph

4128 Commits

Author SHA1 Message Date
Brent Simmons 1e1da9a541
Merge pull request #1202 from Wevah/code-style-updates
Update Protocols and Delegates section
2019-10-28 11:11:44 -07:00
Brent Simmons 729b768547
Update CodingGuidelines.md 2019-10-28 11:11:16 -07:00
Maurice Parker 6269dd3def Set delete highlight color to red. 2019-10-28 13:05:23 -05:00
Maurice Parker e032d7911f
Merge pull request #1211 from jbennett/feature/1185-add-highlight-background-to-vibrant-button
Delete account button should highlight red
2019-10-28 12:58:46 -05:00
Maurice Parker beab7bbbc8
Merge pull request #1212 from jbennett/feature/1194-align-feed-icon-w-first-line
Align feed icon with first line of label
2019-10-28 12:54:25 -05:00
Jonathan Bennett 7682825469 Align feed icon with first line of label
Image was aligned with top padding, takes into consideration the image and font size (line height).
2019-10-28 01:44:33 -04:00
Jonathan Bennett 6e973fb5ed Set highlight background colors for "Delete Account"
This matches the colors from the "Contacts" app
2019-10-28 00:53:09 -04:00
Jonathan Bennett 25411ead45 Add a highlight background color
Adds an IBInspectable background color for the hightlight state.
2019-10-28 00:51:13 -04:00
Brent Simmons 47ca7a8a30
Merge pull request #1201 from danielpunkass/fix-notarization
Fix Notarization NOTE: ADDS FILE DELETION to build phase
2019-10-27 15:51:48 -07:00
Nate Weaver 9c946758bf Update Protocols and Delegates section 2019-10-27 11:39:47 -05:00
Daniel Jalkut cc1da562b1 Add commands to the Sparkle build phase script to remove Autoupdater and Updater.app binaries. These are not needed by NetNewsWire since we use the XPC services to provide the same functionality. 2019-10-27 12:06:54 -04:00
Brent Simmons 596d3e1101 Make the unread count color in the Feeds list a little lighter. Set up the colors as an app asset. 2019-10-26 21:30:44 -07:00
Brent Simmons 0581d94935 Add a little padding, left and right, to the unread count view in the Feeds list. 2019-10-26 21:19:37 -07:00
Brent Simmons 14fbf612c1 Set up 5.1d1 testing things: new appcast URL, build # 3000. 2019-10-26 20:58:40 -07:00
Brent Simmons 4cb602f24a Merge mac-release. 2019-10-26 12:44:33 -07:00
Brent Simmons 759f89ec84
Merge pull request #1170 from Wevah/row-swipe-icons
Use glyphs from SF Symbols for table row swipe actions
2019-10-26 12:25:22 -07:00
Brent Simmons f8c9f94ced
Merge pull request #1183 from danielpunkass/caches-directory
Use the NSCachesDirectory default location, which for sandboxed build…
2019-10-26 12:23:58 -07:00
Brent Simmons 06e3d60e37
Merge pull request #1182 from danielpunkass/deployment-target-update
Deployment target update + minor fix
2019-10-26 12:23:24 -07:00
Daniel Jalkut 030d86c1b7 Use the NSCachesDirectory default location, which for sandboxed builds will end up inside our sandbox container. 2019-10-26 14:42:11 -04:00
Daniel Jalkut 2903e4507b Remove references to WebKit preferences that are not pertinent in 10.15. 2019-10-26 14:23:44 -04:00
Daniel Jalkut 1fd55ab846 Remove an unused outlet for enableWebInspectorMenuItem 2019-10-26 14:21:00 -04:00
Daniel Jalkut 4c5b184976 Bump deployment target to 10.15 for Mac 2019-10-26 14:19:35 -04:00
Brent Simmons 6403808a87 Bump build number to 3. 2019-10-26 11:13:49 -07:00
Brent Simmons d1987c650e Roll back the timeline background color change. Remove the white accent view. 2019-10-26 11:09:34 -07:00
Maurice Parker 473053e813 Update the updated since label on every appearance 2019-10-25 17:07:40 -05:00
Maurice Parker 8304b174bf Change refresh label to use "Updated" instead of "Refreshed" 2019-10-25 16:27:10 -05:00
Maurice Parker e1a571fab3 Remove separator accent when switching to darkmode 2019-10-25 15:56:09 -05:00
Maurice Parker 21aaf71cbf Update timeline theme. Issue #1169 2019-10-25 15:52:32 -05:00
Maurice Parker cf7ea99cb6 Delete timeline unread count animation. Issue #1174 2019-10-25 15:03:13 -05:00
Maurice Parker 74c9290e6a Change disclosure image to be a filled triangle. Issue #1175 2019-10-25 14:57:01 -05:00
Maurice Parker bdd085345b Change refreshed label color to be more subtle 2019-10-25 13:39:59 -05:00
Maurice Parker 6a281c7672 Replace Mark All as Read with progress indicator. Issues #1157 and #1165 2019-10-25 13:34:59 -05:00
Maurice Parker fa24e8a863 Make sure suite name is initialized before using it 2019-10-25 12:56:28 -05:00
Brent Simmons 3354d5a569 Delete articles and statuses from feeds no longer subscribed-to. At startup. Fix #899. 2019-10-24 22:28:26 -07:00
Brent Simmons cd4135bf9a Remove old, comment-out update method in ArticlesTable. 2019-10-24 21:48:24 -07:00
Brent Simmons eec008ca5b Remove Info.plist from NetNewsWire Tests copy files phase, since it shouldn’t be there. 2019-10-24 21:41:20 -07:00
Brent Simmons f8376b807a Restore two-step process for OPML exporting. 2019-10-24 21:12:58 -07:00
Maurice Parker 3f81cd9b96 Make sure that the search bar doesn't appear on device rotation. Issue #1171 2019-10-24 12:46:53 -05:00
Maurice Parker bedf8a19e9 Pre-populate Feed Name on Feed Info. Issue #1163 2019-10-24 12:30:10 -05:00
Jonathan Bennett 739256ffa4 correct submodule 2019-10-24 12:19:51 -04:00
Jonathan Bennett 5437e136bc Merge branch 'master' into feature/feed-wrangler 2019-10-24 12:03:54 -04:00
Jonathan Bennett 48e47ec40b Allow adding of feeds 2019-10-24 11:48:12 -04:00
Brent Simmons 1c06eb27e8 Create separate private extension. Make misc. code formatting changes to match current thinking. 2019-10-23 22:33:21 -07:00
Brent Simmons 6f29497ec8 Move NSTextFieldDelegate conformance to separate extension.
Handle the optional nil case in controlTextDidChange.
2019-10-23 22:27:08 -07:00
Brent Simmons c01b2c6269
Merge pull request #1145 from Wevah/add-folder-button-fix
Disable "Add Folder" button when the text field is empty
2019-10-23 22:22:12 -07:00
Brent Simmons 06b0e35739 Move Protocol declaration to top of ExportOPMLAccessoryViewController.swift. As critical API, it needs to be easy to spot.
Create separation extensions — one for protocol conformance, one for private methods — ExportOPMLController.

Make minor code formatting change: instead of { return } — which is hard to set a breakpoint on — move the return to its own line.

Remove an internal access qualifier, since internal is default and implied.
2019-10-23 22:00:14 -07:00
Brent Simmons 00afc3f32e Merge master. 2019-10-23 21:33:01 -07:00
Brent Simmons 364351d0be Update beta appcast. 2019-10-23 21:31:27 -07:00
Brent Simmons a6915fe24e
Merge pull request #1148 from Wevah/opml-export-accessory-view
Use an accessory view instead of an intermediate sheet for OPML export
2019-10-23 21:29:35 -07:00
Maurice Parker f538b3304f Added account name to account inspector title 2019-10-23 20:29:22 -05:00