Commit Graph

269 Commits

Author SHA1 Message Date
Maurice Parker ced4ff239a Fix compile errors by updating to latest API for Article 2021-09-30 09:28:09 -05:00
Duncan Babbage f6552e110d Replace raw with repaired links. Fixes #3103 2021-09-30 16:52:00 +13:00
Duncan Babbage cc855f3832 link and URL vars for Article. Storage as rawLink
link and externalLink fall back to providing the raw stored value if URLs cannot be created even with repair.
2021-09-30 16:51:59 +13:00
Maurice Parker 87700325cf Changed to use preferredURL incase we run into any malformed links 2021-09-12 21:34:47 -05:00
Maurice Parker fa4b2531f8
Merge pull request #3102 from robmathers/copy-url-menu-options
Add Copy Article URL & Copy External URL Menu Items. Fixes #1285.
2021-09-12 21:17:50 -05:00
Maurice Parker 09647be51b Merge branch 'ios-release' 2021-09-06 20:31:24 -05:00
Stuart Breckenridge 178e737040 Converts to a browser preference to a `Bool`. 2021-08-26 10:27:23 +08:00
Stuart Breckenridge 3bc18e2891 Reduces Browsers to in-app and system default 2021-08-25 15:05:18 +08:00
Stuart Breckenridge 08a1120e00
Adds app default option
Adds app defaults option for controlling link opening preferences.

Adds browser logic and images.

Browser Manager Updates

- Handles deletion of current browser
- Fixes detection of installed browsers by moving URL Types to LSApplicationQuery
- Updates icons to glyphs
- Context menus update

tidy up

- removes browser specific options and offers in-app or default browser options (can be enabled via a bool)
- adds 1Password as an option
- removes custom wording on context menus

Fixes

- makes sure browser options are available on iPad
- uses VibrantCell
- Changes Settings title to "Open Links In"
2021-08-23 23:01:48 +08:00
Maurice Parker 3ea427bd2d Fix open in browser when the article is selected. Fixes #3215 2021-07-06 18:50:48 -05:00
Maurice Parker c2413cda37 Restore alpha of the indicators to 1 incase the animation completion handler doesn't get called. Fixes #3156 2021-06-23 03:24:23 -05:00
Maurice Parker 86ca397221 Ignore key commands when the web view has focus. Fixes #3179 2021-06-23 02:44:34 -05:00
Rob Mathers 8707a71313 Add Copy Article URL & Copy External URL Menu Items
The Mac items display in the edit and contextual menus, and in the iOS contextual menu for an article.
2021-05-01 16:47:39 -04:00
Duncan Babbage 9092d075a0 Handle links with unencoded spaces. Fixes #3069 2021-04-28 22:49:32 +12:00
Duncan Babbage 7e71814011 Rename accessibility action labels as per #3072 2021-04-26 08:19:31 +12:00
Maurice Parker b69f936cb1 Change the Mark All As Read confirmation back to an Alert. Fixes #2968 2021-04-03 11:02:15 -05:00
Maurice Parker 3c2c17df0d Fix threading issue 2021-03-25 16:28:15 -05:00
Stuart Breckenridge 0a10544905
Fixes context menu logic
Prevents both a menu and action being attached to the `markAllAsRead` button. This caused issues on iPad where the popover would show instead of the menu. When the user changes the preference the toolbar is now rebuilt.

This commit also fixes the widget building on M1 where SwiftGen is available.
2021-02-04 08:19:35 +08:00
Stuart Breckenridge 6eba67c158
Adds context menus to mark all as read 2021-02-01 08:12:20 +08:00
Maurice Parker 5927c77a04 Convert iOS smart feed icons back to symbol images so that they show up as white when selected. 2020-12-06 16:01:43 -06:00
Maurice Parker a80fc871c4 Add separators to iOS context menus 2020-11-13 05:23:04 -06:00
Maurice Parker 0a01a9f501 Display "(No Text)" if there isn't a title or summary for the timeline. Fixes #2391 2020-10-23 19:18:35 -05:00
Maurice Parker 18726d061d Remove zero duration animations. 2020-10-22 18:56:33 -05:00
Maurice Parker 0b170b7ff5 Merge branch 'ios-release' into main 2020-10-18 19:59:11 -05:00
Maurice Parker d1b8ac06af Ensure that the snapshot has items in it before testing section zero. 2020-10-17 20:06:53 -05:00
Maurice Parker a500166af0 Merge branch 'ios-release' into main 2020-08-15 11:03:29 -05:00
Maurice Parker e2de38647a Don't crash on early calls to update the toolbar 2020-08-09 20:13:37 -05:00
Maurice Parker a63466f7b3 Add and remove buttons instead of hiding them since our hiding trick doesn't work on iOS 14 2020-08-07 15:20:20 -05:00
Rizwan Mohamed Ibrahim 1c4b6b4c26
Fix a11y for title view of timeline view controller 2020-07-29 11:37:27 +05:30
Rizwan Mohamed Ibrahim 64a4d9bbe5
Fix localised comments 2020-07-14 22:04:20 +05:30
Rizwan Mohamed Ibrahim 1a3bbf7dbf
Add a11y label for starred status on master timeline 2020-07-14 18:08:07 +05:30
Stuart Breckenridge f92b219cdc NetNewsWire-iOS AppDefaults is now a singleton 2020-07-02 10:47:45 +08:00
Maurice Parker 403b859c31 Verify that the section exists before accessing it so that we don't crash on the new SDK 2020-06-28 03:14:53 -05:00
Maurice Parker 05f259da51 Merge branch 'ios-release' 2020-06-21 17:55:33 -05:00
Maurice Parker 95704c7f3e Prefix accessibility label with unread when item is unread. Issue #2142 2020-06-20 11:05:54 -05:00
Maurice Parker 21e79250db Merge branch 'ios-release' 2020-06-18 17:45:12 -05:00
Maurice Parker d453a94330 Make unread and star animations cancel on cell reuse. Issue #2054 2020-06-18 17:37:29 -05:00
Maurice Parker 95f6f80583 Merge branch 'ios-release' 2020-06-15 17:40:06 -05:00
Kiel Gillard 🤪 9d7ebf8dfa Command + I can be used to get info on a feed for a timeline or an article. Fixes #2104 2020-05-26 14:52:15 +10:00
Stuart Breckenridge 98c8ea6d9f
disables swipe back gesture on trackpads 2020-05-20 21:32:19 +08:00
Maurice Parker 7d8e49a2ee Merge branch 'ios-release' 2020-05-18 03:05:59 -05:00
Maurice Parker 7deac7f3c3
Merge pull request #2071 from stuartbreckenridge/issue-2018
Key commands work with action sheets
2020-05-14 07:14:57 -05:00
Stuart Breckenridge a9e8cec90e
Key commands work with action sheets 2020-05-14 17:10:55 +08:00
Maurice Parker 8f8bd229c5
Merge pull request #2068 from rizwankce/feature/keyboard-shortcuts
Keyboard shortcuts
2020-05-13 11:43:14 -05:00
Rizwan Mohamed Ibrahim 32c8c038ee
move toggle side bar to RootSplitViewController 2020-05-13 21:57:02 +05:30
Rizwan Mohamed Ibrahim a9aefd252e
adds keyboard shortcuts
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
2020-05-13 17:29:59 +05:30
Stuart Breckenridge f153643273
Removes return statements that are not needed. 2020-05-13 13:03:51 +08:00
Stuart Breckenridge 58575331dd
Fixes #2018
This commit adds a new `MarkAsReadAlertControllerSourceType` protocol to which `CGRect`, `UIView`, and `UIBarButtonItem` conform to.

The `MarkAsReadAlertController` now presents an action sheet for mark as read, mark above as read, and mark below as read. The above is used for the `popoverPresentationController`’s `barButtonItem`, `sourceRect`, or `sourceView` as needed.
2020-05-13 12:33:51 +08:00
Maurice Parker fda9be2e41 Update the progress bar when it comes into view so that it is always current 2020-05-10 10:00:04 -05:00
Nate Weaver 5ac69a411e Remove the color parameter on iOS too 2020-05-01 02:02:44 -05:00