Commit Graph

2777 Commits

Author SHA1 Message Date
Maurice Parker 189af8d816 Invalidate user activities when collapsed and returning to Feeds scene 2019-09-01 15:31:11 -05:00
Maurice Parker 1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker dfc3046bf0 Clear the timeline when the user begins searching 2019-09-01 14:49:56 -05:00
Maurice Parker a5298f0381 Refactor mark as read for articles to be in the SceneCoordinator instead of in the DetailViewController 2019-09-01 12:52:06 -05:00
Maurice Parker 858bdb7f21 Rename AppCoordinator to SceneCoordinator as that name better defines its purpose 2019-09-01 12:43:07 -05:00
Maurice Parker 56c81bba1f Delete code that was doing an unnecessary rebuild of the treeController. This will be done by the controllers receiving the batch update notification. 2019-09-01 10:57:08 -05:00
Maurice Parker 6cf1e4539d Merge branch 'mac-release' 2019-09-01 10:51:22 -05:00
Maurice Parker 8560ce33f4 Merge branch 'mac-release' of https://github.com/brentsimmons/NetNewsWire into mac-release 2019-09-01 10:49:46 -05:00
Maurice Parker e31dec7c44 Call completion handler when there are no feeds associated with the folder being removed. Issue #938 2019-09-01 10:49:35 -05:00
Maurice Parker 43fb7dff9f Fix bug that prevented new folders from appearing in the Feeds 2019-09-01 10:29:30 -05:00
Maurice Parker 397d75c6f6 Restore animation when adds and deletes happen to feed items 2019-09-01 10:11:03 -05:00
Brent Simmons 30e5f33a29 Remove note in README about NNW not yet shipping. 2019-08-31 22:38:49 -07:00
Brent Simmons 1b26b1ece5
Merge pull request #932 from correia/bug-901
Fix for bug #901 — first web view load flashes white in dark mode
2019-08-31 22:27:31 -07:00
Jim Correia e7e77d362c Fix for bug #901 — first web view load flashes white in dark mode
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.

Instead, use a modification of the original solution used for iOS:

    - wrap the web view in a box with an appropriate background color
    - hide the web view at creation
    - show the web view after* the first load

This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.

[*] Showing the view immediately after the first load still causes the flash
    to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
    but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
Maurice Parker 27883632d0 Fix bug that prevented reading article user activities from being restored 2019-08-31 20:23:14 -05:00
Maurice Parker 87030a5921 Implement stateRestorationActivity to save most relevant current user activity 2019-08-31 19:30:21 -05:00
Maurice Parker ecec048716 Merge branch 'mac-release' 2019-08-31 18:31:10 -05:00
Maurice Parker fabea36a91
Merge pull request #930 from correia/bug-921
Only enable "Open in Browser" when a single article is selected.
2019-08-31 18:29:07 -05:00
Jim Correia cdfdc06142 Only enable "Open in Browser" when a single article is selected.
Fixes bug #921.
2019-08-31 16:02:21 -07:00
Maurice Parker 407bd296db Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-08-31 17:37:49 -05:00
Maurice Parker 988ac1bbd8 Correct label color to specify correct platform 2019-08-31 17:37:42 -05:00
Maurice Parker 6caff148dd
Merge pull request #928 from correia/placeholder-content
Use noContentHTML rather than noSelectionHTML for prepared web views.
2019-08-31 17:20:52 -05:00
Jim Correia 5f11c42fc2 Use noContentHTML rather than noSelectionHTML for prepared web views.
Added a noContentHTML to ArticleRenderer. Use that for the initial content
for queued web views so that we don't see a temporary flash of "No
Selection" when pushing to an article that doesn't load instantly.
2019-08-31 15:03:03 -07:00
Maurice Parker c9858a0457 Show and hide scope bar based on editing state 2019-08-31 16:39:59 -05:00
Maurice Parker fe2e0155da Add scoped searching of articles 2019-08-31 15:53:47 -05:00
Maurice Parker ba36572497
Merge pull request #927 from correia/correia/webview-layout
Added missing constraints to the web container view in the Detail scene.
2019-08-31 15:27:52 -05:00
Maurice Parker 80a8559823
Merge pull request #926 from correia/correia/limit-webview-queue-size
Limit the size of the queue maintained by DetailViewControllerWebViewProvider.
2019-08-31 15:27:24 -05:00
Jim Correia 77cf92ec13 Added missing constraints to the web container view in the Detail scene. 2019-08-31 13:20:23 -07:00
Jim Correia 52ad2623a8 Limit the size of the queue maintained by DetailViewControllerWebViewProvider. 2019-08-31 13:16:46 -07:00
Maurice Parker 8335a5cb48
Merge pull request #924 from correia/correia/white-flash-on-load
Fix flash on white when loading detail view controller in dark mode
2019-08-31 15:02:20 -05:00
Jim Correia f7b53283d6 Maintain a queue of "prepared" web views for use in DetailWebViewController.
WKWebView has an awful behavior of a flash to white on first load when in
dark mode.

Keep a queue of WebViews where we've already done a trivial load so that by
the time we need them in the UI, they're past the flash-to-shite part of
their lifecycle.
2019-08-31 12:53:03 -07:00
Jim Correia a5b2c759ec Create the WKWebView instance at runtime.
Specify a container view in the storyboard and create+install the web view
at viewDidLoad time.

This lets us experiment with solutions for providing a web view that avoids
the flash-to-white problem.
2019-08-31 12:30:01 -07:00
Jim Correia e5782ca464 Removed the hide the webview workaround to expose the flash to white problem. 2019-08-31 11:27:59 -07:00
Maurice Parker 67b9721a10 Made article search go fast 2019-08-31 12:12:50 -05:00
Maurice Parker 8002839941 Remove disclosure chevron from launch storyboard 2019-08-31 11:51:14 -05:00
Maurice Parker d9ce01591f Implement full article search 2019-08-31 11:50:34 -05:00
Maurice Parker 061dfe931b Restrict access to rebuildShadowTable function 2019-08-31 11:38:03 -05:00
Maurice Parker 2cf6550226 Implemented launch storyboard. Issue #742 2019-08-30 17:39:39 -05:00
Maurice Parker 762710266d Reload all cells when a batch update completes because we might be out of sync even though we called apply on the datasource. This can happen when moving a feed into and out of a folder. 2019-08-30 16:19:06 -05:00
Maurice Parker ca0bdb3d35 Change to not animate on timeline fetcher changes 2019-08-30 14:42:33 -05:00
Maurice Parker 07ca61f7cf Convert the timeline to use diffable datasources 2019-08-30 14:17:05 -05:00
Maurice Parker 3baca1d7c0 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-08-30 11:47:16 -05:00
Maurice Parker 995fca5d6a Updated FreshRSS to pull statuses before articles and to work with the new sync status API's 2019-08-30 11:47:08 -05:00
Maurice Parker ea1f21797c Merge branch 'mac-release' 2019-08-30 11:28:16 -05:00
Maurice Parker c1216bf7bb Merge branch 'mac-release' of https://github.com/brentsimmons/NetNewsWire into mac-release 2019-08-30 10:40:25 -05:00
Maurice Parker a69be4117a Retrieve statuses before articles during sync process and default starred articles to read if there isn't an unread status Issue #868 2019-08-30 10:39:52 -05:00
Maurice Parker 372e6f4c6b
Merge pull request #912 from kielgillard/master
#914 - Explicity identify the addable account types.
2019-08-30 09:09:46 -05:00
Maurice Parker 3ab1412dc6 Preserve article selection when articles are downloaded (for iPad only) 2019-08-30 02:39:54 -05:00
Kiel Gillard f27b7029de Explicity identify the addable account types, allowing for a contingent list given factors such as macOS API availability. 2019-08-30 15:17:25 +10:00
Maurice Parker 86a302f787 Prevent selecting of items that may not show the current article selection as is done on the iPhone 2019-08-29 17:49:21 -05:00