Commit Graph

2193 Commits

Author SHA1 Message Date
Tom Grimwood-Taylor 0447694142 Fix feed selection when the max feed score is 0.
This occurs, for example, when searching for “macrumors.com” and adding
to the Feedbin account. All four feeds have a score of 0 since their
source is set as HTMLLink. This would also fix a case in which there are
two feeds: one with a negative score and one with a score of 0.

Since the method uses a Set the feed selected when there are multiple
feeds with an identical maximum score will be random.
2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor ac9057299a Remove edited name when remote feed name changes. 2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor f3505e4537 Fix posting name notifications when name changes. 2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor b4d7042a7b Ensure status changes are sent before refresh.
When the refresh button was manually clicked a full refresh would occur,
but locally changed statuses wouldn't be sent. This meant the statuses
of items in NetNewsWire would revert to their remote values until an
automatic status sync was triggered.
2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor 3c1b84dd73 Fix a Feedbin subscriptionID going out of sync.
If, for example, a user deleted a feed and recreated it on the server
without a sync in between, the subscription ID for the feed would update
on the server, but remain unchanged locally. If the user then wanted to
delete or rename the feed they'd get a 404 error.
2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor cd85e52fdd Fix updating local feed list when no remote feeds.
When there were no remote feeds the logic to remove local
feeds was skipped.
2019-06-03 17:09:17 +01:00
Brent Simmons c6a9078c68 Fix typo in appcast. 2019-05-31 21:07:21 -07:00
Brent Simmons c4296584d0 Update appcast for alpha one. 2019-05-31 21:06:34 -07:00
Brent Simmons 364fc2760f Bump version to 5.0a1. That’s right — it’s alpha now. W00t! 2019-05-31 20:21:08 -07:00
Maurice Parker 00ee775170 Made timeline layout tweaks to make indicator, avatar, and first line of text line up better. Issue #689 2019-05-31 17:58:39 -05:00
Maurice Parker 2d91e64148 Provide a better error message when encountering feed not found and already subscribed errors 2019-05-31 17:24:43 -05:00
Maurice Parker e348a1f9ed Remove layout caching that was causing seemly random layout issues. Issue #714 2019-05-31 16:59:02 -05:00
Maurice Parker 3593d1c5d8 Update to the new icon 2019-05-31 13:52:15 -05:00
Maurice Parker 8e0c857810 Update the extract page number function to make it more readable 2019-05-31 13:38:33 -05:00
Maurice Parker 88b2775076 Make sure that an account doesn't try persist to the disk in the time that it is logically deleted and when it is actually deallocated 2019-05-31 08:05:26 -05:00
Maurice Parker fec3c69f4a Remove Feedbin api workaround for unpropagated mode=extended parameter 2019-05-31 07:54:12 -05:00
Maurice Parker 10296a1b74 Clear the feed metadata on Feedbin feed delete 2019-05-31 07:47:05 -05:00
Maurice Parker d602f894f6 Fix link parsing bug that causes crash 2019-05-31 07:22:28 -05:00
Maurice Parker beacad1aeb Validate folder drop to make sure no folders with the same name are already in the target account 2019-05-30 17:57:06 -05:00
Maurice Parker e7c339fb09 Update iOS to work with the latest Account API 2019-05-30 17:41:56 -05:00
Maurice Parker 0ddb47aa32 Refactor feed finder to make it threadsafe 2019-05-30 17:35:08 -05:00
Maurice Parker a8f090656d Handle when a feed in a folder being copied/moved already is subscribed in target account 2019-05-30 14:44:13 -05:00
Maurice Parker 30c21bb125 Enable folders to be dropped in a move or copy between accounts 2019-05-30 14:36:21 -05:00
Maurice Parker 1352dda8aa Modify Feedbin feed deletes so that they emulate how the local account feed deletes work. 2019-05-30 10:12:34 -05:00
Maurice Parker 7bec55c90b Add missing completion call that was causing restored feeds to not show 2019-05-29 21:39:53 -05:00
Maurice Parker 51284b5aa4 Rename deleteFeed to removeFeed to be more consistent with other API's 2019-05-29 21:04:44 -05:00
Maurice Parker 527e677934 Rename deleteFolder to removeFolder to make the API more consistent 2019-05-29 20:53:00 -05:00
Maurice Parker f4bc17c8f1 Refactor addFeed and removeFeed usages to be more consistent 2019-05-29 20:47:52 -05:00
Maurice Parker 5e3fcfd955 Correct how feeds were deleted so that only the feed in the correct container was deleted 2019-05-29 17:56:26 -05:00
Maurice Parker bead6ae123 Remove now unnecessary call to account structureDidChange in drop 2019-05-29 17:14:50 -05:00
Maurice Parker fa6b6a4769 Corrected move BatchUpdate usage to make move animation smoother 2019-05-29 17:08:41 -05:00
Maurice Parker b1bd8d2d90 Enable folder dragging between accounts 2019-05-29 15:43:33 -05:00
Maurice Parker 039deadb72 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-05-29 10:24:55 -05:00
Maurice Parker 8fc6e81ddf Update the Today timeline and unread count when the day changes. Issue #627 2019-05-29 10:24:30 -05:00
Brent Simmons ce81b5d78c Update RSParser. 2019-05-28 21:56:29 -07:00
Maurice Parker 0648053417 Enforce tag specific drop validation (can't copy to the account level) 2019-05-28 17:42:19 -05:00
Maurice Parker 83652c40de Handle scenario where moved/copied feed already exists somewhere else in account 2019-05-28 16:46:16 -05:00
Maurice Parker 01d5a95241 Remove redundant private keyword usage 2019-05-28 16:31:03 -05:00
Maurice Parker cf016c5d7d Prevent Feedbin in account copy from putting a feed in both the root account and a folder at the same time. 2019-05-28 13:38:40 -05:00
Maurice Parker 112702020b Enable same account copying. 2019-05-28 13:11:29 -05:00
Maurice Parker 78c19bda43 Remove restriction on only moving and copying between local accounts. 2019-05-28 11:09:47 -05:00
Maurice Parker b3c4c8de59 Correct how feeds were copied and moved between accounts to eliminate shared objects. 2019-05-28 10:59:06 -05:00
Maurice Parker 493abbb609 Refactor create feed functionality to increase code reuse and encapsulation 2019-05-28 09:45:02 -05:00
Maurice Parker 6b93576f37
Merge pull request #715 from philviso/GH690_GH694_TimelineCellLayoutUpdates
Use 3 lines for timeline title + updated unread indicator layout
2019-05-28 05:24:20 -05:00
Phil Viso 6168f01822 Updated margins and sizing of unread indicator to match the mail app. Issue #690 2019-05-27 18:46:57 -05:00
Phil Viso 092b72d44c Updated timeline to default to 3 lines for the title. Issue #694 2019-05-27 18:46:53 -05:00
Maurice Parker c7b61f7d87 Enable copy between local accounts. 2019-05-27 18:01:24 -05:00
Maurice Parker 659c9e5271 Allow dragged feeds between local accounts only 2019-05-27 15:11:16 -05:00
Maurice Parker 324198066e
Merge pull request #677 from aaronraimist/building-instructions
Add basic building instructions
2019-05-27 12:04:04 -05:00
Maurice Parker 61f9a66d74 Change so that we fire off status update immediately if the number of pending status changes exceeds 100. Issue #658 2019-05-27 12:03:12 -05:00