Commit Graph

1301 Commits

Author SHA1 Message Date
Brent Simmons 1b236c425e Create Mac UI for JavaScript setting. 2023-11-25 20:50:45 -08:00
Brent Simmons 9d7dba085e Make JavaScript on by default — since it’s needed for videos and social media embeds etc. 2023-11-25 20:17:12 -08:00
Brent Simmons dfd778d038 Add `isJavascriptEnabled` setting, defaulting to false, and respect it in the web view. 2023-11-25 11:53:19 -08:00
Brent Simmons c05ef2344f Remove unused code and references to Twitter and Reddit. 2023-11-25 11:44:34 -08:00
Brent Simmons 279a99259e Use WKUserScript to inject scripts into the page. Use permalink as base URL. 2023-11-25 11:29:56 -08:00
Brent Simmons 7078e6fd55 Remove OAuthSwift and its dependencies. 2023-06-26 09:57:22 -07:00
Brent Simmons d31c9c1766 Remove unused imports of the Zip module. 2023-06-26 09:56:26 -07:00
Brent Simmons 1bef45e1af Remove ExtensionPoint code. 2023-06-25 16:48:37 -07:00
Brent Simmons 7f295797ee Remove last references to isFeedProvider. Fix a couple warnings. 2023-06-25 16:19:20 -07:00
Brent Simmons fb51185c05 Remove references to isFeedProvider. 2023-06-25 16:15:21 -07:00
Brent Simmons 85704acd9c Remove FeedProviderManager and Feed Provider and remove references to them. 2023-06-25 16:11:55 -07:00
Brent Simmons 6c1891f7fd Remove Reddit assets. 2023-06-25 15:45:09 -07:00
Brent Simmons d24c66d7eb Remove references to AddFeedWindowControllerType.redditFeed. 2023-06-25 15:31:20 -07:00
Brent Simmons 49549484af Rename New Web Feed to New Feed. 2023-06-25 15:30:57 -07:00
Brent Simmons d232cf43c7 Remove showAddRedditFeedWindow function and all references to it. 2023-06-25 15:26:37 -07:00
Brent Simmons aeafd60c36 Remove Extensions UI from Settings window. 2023-06-25 15:24:24 -07:00
Brent Simmons 4dd3d60c78 Create and use API to determine if there are any feeds that require the Reddit API. 2023-06-25 15:01:53 -07:00
Brent Simmons 8a9481b621 Remove New Reddit Feed menu command. Rename New Web Feed to just New Feed. 2023-06-25 14:46:17 -07:00
Brent Simmons b6e7c16c13 Remove add-Reddit-feed sheet and window controller. 2023-06-25 14:43:55 -07:00
Brent Simmons e6a25f374a Show Reddit deprecation alert if needed. 2023-06-18 15:53:37 -07:00
Brent Simmons 82cb561fc7 Update copyright for 2023. 2023-03-13 21:47:10 -07:00
Brent Simmons 0ba9a06b92 Update Twitter notice to not specify any dates. Bump version and build. 2023-03-13 21:44:32 -07:00
Brent Simmons fda56b4423 Update the Twitter removal warning to say “later in February” instead of “February 9,” since Twitter postponed the removal date to the 13th, and might do so again. 2023-02-09 21:51:58 -08:00
Brent Simmons 86966b29ec Update Safari extension icon — new icon by Louie Mantia. Update release notes and build. 2023-02-09 21:46:46 -08:00
Brent Simmons e7ae7887e3 Add and use anyLocalOriCloudAccountHasAtLeastOneTwitterFeed in AccountManager. Simplify date comparison code. 2023-02-05 20:17:31 -08:00
Stuart Breckenridge b83345a47f
Adds account type check for Twitter deprecation alert 2023-02-05 21:30:44 +08:00
Stuart Breckenridge da91548875
Shows Twitter deprecation alert on macOS 2023-02-05 09:40:41 +08:00
Maurice Parker 6c1e1ea1c6 Remove Twitter integration. Fixes #3842 2023-02-03 19:00:13 -08:00
Brent Simmons 06910b1e58 Avoid force-unwrapping, which was causing a crash. Add an `assertionFailure` so we can catch this issue in the act — we need to know why an item would not be a Node. Fix https://github.com/Ranchero-Software/NetNewsWire/issues/3824 2023-01-22 14:57:56 -08:00
Daniel Jalkut 85899d7b56 Revise layout of the Preferences window to ensure the labels are right-aligned. 2022-04-05 16:22:49 -04:00
Brent Simmons c24b6a0bc8 Add a line for Stuart in the Credits. (Went with “Contributing Developer,” and put it just below Maurice’s line. If anyone has a better idea for a title, let me know.) 2022-02-27 21:28:25 -08:00
Jed Fox 15fcb3eb31
Fix warning about clipped content 2022-02-12 16:13:11 -05:00
Jed Fox 10540dc67c
Fix height of label on Feedbin sign-in modal 2022-02-12 16:13:11 -05:00
Maurice Parker ea6e5b8434 Change to no longer copy app distributed themes to the Themes folder. Fixes #3447 2022-02-07 16:23:08 -08:00
Maurice Parker 0e641b4575 Correct label 2022-02-04 10:55:07 -08:00
Maurice Parker ea7a101ca5 Change to point to the 6.1 documentation 2022-01-23 13:21:45 -08:00
Brent Simmons b5f4221518 Jump through App Store provisioning profile hoops so that we can distribute the app again. Also: bump version to 6.1b2. 2022-01-17 17:44:51 -08:00
Brent Simmons 0e7ef5f82e Merge branch 'main' of https://github.com/Ranchero-Software/NetNewsWire 2022-01-09 20:55:34 -08:00
Brent Simmons ded927fcfe Update copyright dates to 2022. 2022-01-09 20:55:03 -08:00
Dimitris Apostolou 94ae4d348c
Fix typos 2022-01-05 00:25:20 +02:00
Maurice Parker 7a2ddd7f06 Add ITSAppUsesNonExemptEncryption key 2021-12-30 12:04:02 -08:00
Maurice Parker ab9802d8b5 Remove Hyperlegible theme 2021-12-30 11:55:44 -08:00
Maurice Parker 09652bff81 Remove Mark Read on Scroll code 2021-12-29 14:44:40 -08:00
Maurice Parker 7608bf2ae6 Disable the Mark as Read on Scroll preferences temporarily 2021-11-18 19:01:48 -06:00
Maurice Parker 06eae25797
Merge pull request #3329 from everhardt/feat-1844-scroll-mark-as-read
Add mark as read on scroll
2021-11-04 12:04:53 -05:00
Maurice Parker c26f09ad1c Fix bug that prevented us from returning to the original text size 2021-11-01 21:24:56 -05:00
Maurice Parker c16a231530 Added the Hyperlegible theme 2021-11-01 21:22:22 -05:00
everhardt 96ffa3aa22 Do not mark as read without user interaction 2021-10-30 18:57:04 +02:00
everhardt 5364b4f384 Mark bottom items in feed as read after 2 seconds on Mac
In case markArticlesAsReadOnScroll is set
2021-10-30 10:58:12 +02:00
everhardt 3b6a3cf4e7 Do not mark articles as read on scroll when they were manually toggled 2021-10-30 10:37:10 +02:00
everhardt 8bce42df56 Change scrollPositionQueue in Mac TimelineViewController to private 2021-10-27 22:21:42 +02:00
everhardt 3db1b60b65 Add Mac setting for mark as read on scroll 2021-10-27 22:03:38 +02:00
everhardt 7b8bed9ac2 Add mark as read on scroll functionality
Does not yet include a setting
2021-10-27 20:52:26 +02:00
Nate Weaver 604aa9e3f8 Fix compiler error with Xcode 12.4/Swift 5.3 2021-10-08 22:32:56 -05:00
Maurice Parker 6e54598547 Fix type that caused a compile error 2021-09-30 09:43:32 -05:00
Duncan Babbage f6552e110d Replace raw with repaired links. Fixes #3103 2021-09-30 16:52:00 +13:00
Duncan Babbage cc855f3832 link and URL vars for Article. Storage as rawLink
link and externalLink fall back to providing the raw stored value if URLs cannot be created even with repair.
2021-09-30 16:51:59 +13:00
Maurice Parker 37cb93ed1a
Merge pull request #3301 from stuartbreckenridge/theme-tweaks
Theme tweaks
2021-09-23 20:33:54 -05:00
Stuart Breckenridge 25f9896832 Localized strings for errors 2021-09-24 09:28:32 +08:00
Maurice Parker 4a3934fd28 Add ellipsis to Add context menu 2021-09-23 11:57:47 -05:00
Maurice Parker 859aa5127c Correct usage of ellipsis in main menu items. 2021-09-23 11:46:58 -05:00
Maurice Parker 812eed67c3 Rename button to "Open Themes Folder" 2021-09-23 10:02:34 -05:00
Stuart Breckenridge bd6095517b is missing instead of not found 2021-09-23 20:19:41 +08:00
Stuart Breckenridge e9b84d9219 Theme Import/Opening Changes
Mac:
- Better error messages
- The alert displayed contains an additional button to open the theme's folder (when clicked it will not dismiss the alert).
2021-09-23 20:12:35 +08:00
Stuart Breckenridge 82a62712ce
Better error messages for decoding issues 2021-09-21 10:43:12 +08:00
Stuart Breckenridge c29afd2677 try? changed to try with error handling 2021-09-21 09:22:45 +08:00
Stuart Breckenridge 78e0595708 Various ThemeDownloader Updates
- `try` added where applicable to ArticleTheme inits
- `ArticleThemePlist` has fixed spelling of theme identifier and conforms to Equatable
- `ArticleTheme` now uses `ArticleThemePlist`
-  `ArticleThemeDownloader` is now a class
- `ArticleThemeDownloader` will now download themes to Application Support/NetNewsWire/Downloads on macOS and iOS.
- `ArticleThemeDownloader` will remove downloaded themes from the Download folder when the application is closed.
- macOS app delegate now observes for theme download fails
- Error display code moved from SceneDelegate to SceneCoordinator so that it can use existing presentError on rootVC.
2021-09-21 09:10:56 +08:00
Stuart Breckenridge a1b01384d3 refactors downloader code for macOS & iOS
More consistent code across platforms.
2021-09-20 19:34:25 +08:00
Stuart Breckenridge afd952fbc2 refactors iOS theme downloads 2021-09-20 09:36:09 +08:00
Stuart Breckenridge 7994b34551 adds mac theme downloading 2021-09-19 21:18:23 +08:00
Maurice Parker b43d8b6b28 Change reload so that the text size style can be used in more places. 2021-09-17 15:59:43 -05:00
Maurice Parker de956f9473 Change to use JavaScript to detect scroll events as it will also capture scrollbar events 2021-09-13 21:03:27 -05:00
Maurice Parker 2c801a388c Restore the article scroll position when restarting NetNewsWire 2021-09-13 20:42:58 -05:00
Maurice Parker 87700325cf Changed to use preferredURL incase we run into any malformed links 2021-09-12 21:34:47 -05:00
Maurice Parker fa4b2531f8
Merge pull request #3102 from robmathers/copy-url-menu-options
Add Copy Article URL & Copy External URL Menu Items. Fixes #1285.
2021-09-12 21:17:50 -05:00
Maurice Parker 3a09ff2db7 Change so that we are using the ArticleTheme definition of the suffix 2021-09-12 13:30:15 -05:00
Maurice Parker abd66ea1bb Maintain scroll position when changing themes 2021-09-11 20:53:57 -05:00
Maurice Parker baad458138 Add Open Themes button 2021-09-11 20:32:15 -05:00
Maurice Parker b4d9423ff2 Add alert to verify overlaying an existing theme 2021-09-09 06:03:28 -05:00
Maurice C Parker c031aa5cbe Add popup button for selecting article themes on Catalina 2021-09-09 05:47:49 -05:00
Maurice Parker 6c09bf585c Use separate text widths for different OS versions 2021-09-09 02:08:47 -05:00
Maurice C Parker 35995fad39 Fix theme dialog formatting on Catalina 2021-09-09 01:53:40 -05:00
Maurice Parker ef44a9b6e6 Fix theme install button text 2021-09-09 01:37:55 -05:00
Maurice Parker 39c9cc440c Add optional article theme toolbar item 2021-09-08 19:58:40 -05:00
Maurice Parker e68e7420b8 Update the theme popup when the themes change 2021-09-08 17:36:52 -05:00
Maurice Parker 9db72e50e8 Add article theme pop up to General Prefs 2021-09-08 16:38:05 -05:00
Maurice Parker 596202fc33 Reload the article if the theme changes 2021-09-08 15:55:42 -05:00
Maurice Parker 281e41dd2d Add missing punctuation on alert 2021-09-08 05:49:02 -05:00
Maurice Parker e66344694e Copy the theme if the user requests it to be installed 2021-09-08 05:47:57 -05:00
Maurice Parker b568f03edc Unify the stylesheets into a single one to make building themes easier 2021-09-08 04:58:26 -05:00
Maurice Parker cf171394cf Change case on theme 2021-09-08 00:33:43 -05:00
Maurice Parker 86d63542de Change install text 2021-09-08 00:33:05 -05:00
Maurice Parker 98b9080b1f Implement initial alert dialog when importing a theme 2021-09-08 00:28:13 -05:00
Maurice Parker 491896e334 Change theme file extension from nnwstyle to nnwtheme 2021-09-07 17:06:41 -05:00
Maurice Parker 512e83d786 Refactor Styles to now be Themes 2021-09-07 16:58:06 -05:00
Maurice Parker cfd2db58c5 Remove references to nnwstyle.icns so that the system will generate a document icon for us. 2021-09-07 14:31:33 -05:00
Maurice Parker a06a10e661 Merge branch 'mac-release' 2021-09-06 20:42:13 -05:00
Maurice Parker 45c47f3752 Add nnwstyle as an imported type 2021-09-06 20:29:40 -05:00
Maurice Parker a6f5c67f9d Timeout the run loop to get a final return value after two seconds. Fixes #3276 2021-09-06 14:52:41 -05:00
Maurice Parker 530051386f Fix regression that prevented universal links from working 2021-09-01 20:38:50 -05:00
Maurice Parker 285e9a40fa
Merge pull request #3262 from stuartbreckenridge/ios-browser-behaviour
Adds option to open article links in NetNewsWire or in the default browser.
2021-08-26 17:48:30 -05:00
Stuart Breckenridge d451e3fa4a
Update Credits.rtf 2021-08-26 19:22:26 +08:00
Maurice Parker 0f0cf34ef8 Add nnwstyle bundle definitions 2021-08-25 20:22:58 -05:00
Maurice Parker ba279d2a6e Make the Styles folder configurable so that it can be in different places on macOS and iOS. 2021-08-24 20:20:20 -05:00
Daniel Jalkut 2e652351ec Implement the WKUIDelegate method that is reached when JavaScript in a web view invokes window.open(). This ensures that attempts to open links from code, such as from the YouTube embedded video player, work as expected. Fixes #3088. 2021-07-27 17:34:48 -04:00
Stuart Breckenridge 1bda0c3734 adds full width to extensions 2021-06-24 07:50:23 +08:00
Stuart Breckenridge 31af975174 applies fullWidth to accounts 2021-06-24 07:49:13 +08:00
Maurice Parker 2b9d3657e7
Merge pull request #3188 from stuartbreckenridge/3171
fullWidth added to extension table
2021-06-23 18:28:45 -05:00
Stuart Breckenridge 1971f1a5d8 fullWidth added to extension table 2021-06-24 07:27:14 +08:00
Maurice Parker e3f066aaf5
Merge pull request #3186 from danielpunkass/default-feed-handler
Hopefully finishing up the fixes for handling the "open in default browser" preference
2021-06-23 17:50:06 -05:00
Daniel Jalkut 258d7baa73 If we are reached by way of the new x-netnewswire-feed: scheme, replace that with standard feed: scheme before normalizing the URL. 2021-06-23 14:50:25 -04:00
Daniel Jalkut 8b447f6446 Adapt store of the openFeedsInDefaultBrowser preference to be stored/retrieved from app group shared defaults, so that the Safari App Extension can access it. 2021-06-23 14:39:02 -04:00
Stuart Breckenridge f86a327d8b Fixes #3171 2021-06-23 20:07:58 +08:00
Maurice Parker ba2d26dce9
Merge pull request #3180 from danielpunkass/default-feed-handler
Invert the semantics of the defaults key for whether to open Subscrib…
2021-06-22 21:20:12 -05:00
Daniel Jalkut d2157a7c08 Fix the x-netnewswire-feed: URL scheme replacement. 2021-06-22 22:16:10 -04:00
Daniel Jalkut 29af6dea1e Invert the semantics of the defaults key for whether to open Subscribe to Feed feeds in NNW or the user's configured default browser. This ensures the fallback behavior when no preference has been set will default as wanted to opening in NetNewsWire. 2021-06-22 22:14:11 -04:00
Maurice Parker f1dbc2de71 Merge branch 'ios-release' 2021-06-22 19:14:50 -05:00
Daniel Jalkut 8191f2476a Add x-netnewswire-feed to the list of scheme prefixes for adding a feed to NetNewsWire, and modify the behavior of the Safari App Extension plugin so that it consults the host app preference for opening in NetNewsWire or with the default feed handler, before choosing which scheme to prepend to the feed URL. 2021-06-22 12:35:09 -04:00
Daniel Jalkut 75fd9e1e13 Add new subscribeToFeedsInNetNewsWire boolean preference, to direct the behavior of the Subscribe to Feed app extension. 2021-06-21 17:51:04 -04:00
Maurice Parker d6aa5f23ba Don't allow the creation of iCloud accounts if iCloud and iCloud Drive aren't enabled. Fixes #3106 2021-06-17 19:05:39 -05:00
Maurice Parker 7fc29837a1
Merge pull request #3163 from stuartbreckenridge/main
Password Updates
2021-06-17 09:43:27 -05:00
Stuart Breckenridge 50327a97d3 Password Updates
• Removes LD_RUNPATH_SEARCH_PATHS which caused an issue when building for running on device
• Autofill enabled on macOS 11 +
• Adds sender for 1Password (for iPad)
2021-06-17 12:38:53 +08:00
Maurice Parker f26e0b8c81 Add hidden preference to suppress syncing on launch. Fixes #894 2021-06-16 20:21:44 -05:00
Brent Simmons 0d0f1e4908 Replace “don't” with “don’t” everywhere. 2021-05-31 16:01:01 -07:00
Brent Simmons ae63d0feb7 Add a warning about iCloud sync being slow sometimes. Also: in user-facing text, change “subscriptions” to “feeds.” We want to use the word “feed” — a “subscription” makes people think of IAP. 2021-05-31 15:52:56 -07:00
Maurice Parker 57815f0496 Merge branch 'mac-release' 2021-05-25 20:14:18 -05:00
Maurice Parker f9af3c786b Merge branch 'ios-candidate' 2021-05-25 20:12:50 -05:00
Brent Simmons 9d2c8f000f Create and use IconImageCache. It centralizes and de-dupes logic for getting feed/article images, and it caches the results, which helps performance. 2021-05-08 12:42:44 -07:00
Rob Mathers 8707a71313 Add Copy Article URL & Copy External URL Menu Items
The Mac items display in the edit and contextual menus, and in the iOS contextual menu for an article.
2021-05-01 16:47:39 -04:00
Chris Campbell 364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
Chris Campbell bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
Brent Simmons 790218501b
Merge pull request #3079 from babbage/bugfix/3069
Handle links with unencoded spaces. Fixes #3069
2021-04-28 21:55:46 -07:00
Duncan Babbage 9092d075a0 Handle links with unencoded spaces. Fixes #3069 2021-04-28 22:49:32 +12:00
Duncan Babbage 2ea86c1e14 Incorporate closure from mac-release
Enables ios-candidate branch to build macOS target.
2021-04-27 13:07:09 +12:00
Stuart Breckenridge 858672fdaf
fix on release branch 2021-04-25 13:31:15 +08:00
Stuart Breckenridge 5af2643479
standardised naming 2021-04-19 11:21:00 +08:00
Stuart Breckenridge d4130e7c65
Corrects naming convention
[iOS]
Twitter: Notify about new tweets
Reddit: Notify about new posts
Default: Notify about new articles
+ Fixes alignment issues in the inspector view

[macOS]
Twitter: Show notifications for new tweets
Reddit: Show notifications for new posts
Default: Show notifications for new articles
2021-04-19 11:10:57 +08:00
Maurice Parker 77dd2e5e22 Merge branch 'mac-release' into main 2021-04-15 14:31:52 -05:00
Maurice Parker 3955151daf Make sure mark as read completes before searching for the next unread. Fixes #2952 2021-04-15 14:29:49 -05:00
Maurice Parker f0ab588c0f Update to latest Account API. 2021-04-12 19:46:59 -05:00
Stuart Breckenridge 4e517a6db4
Disable Reader View
This commit:
- adds a `isFeedProvider: Bool` property to `WebFeed`
- if `isFeedProvider` is `true`, the article extractor is disabled on the inspector, hidden from the context menu, and the toolbar button is disabled. Additionally, if `isFeedProvider` is `true`, `isArticleExtractorAlwaysOn` returns `false` and cannot be set to `true`.
2021-04-09 07:47:14 +08:00
Maurice Parker b1a0b649a5
Merge pull request #2972 from j-f1/read-unread
Update swipe actions on macOS to match iOS
2021-04-07 03:47:27 -05:00
Jed Fox 76cf335af1
Use the star SF Symbols as well 2021-04-06 17:37:15 -04:00
Jed Fox 3609b6f977
Add labels to swipe actions to match iOS 2021-04-06 17:34:05 -04:00
Jed Fox 0c2f79f1b5
Update read/unread swipe images to be SF Symbols on Big Sur 2021-04-06 17:31:42 -04:00
Maurice Parker ea6cece955 Merge branch 'mac-release' into main 2021-04-03 09:30:42 -05:00
Maurice Parker 5663d8549e
Merge pull request #2958 from stuartbreckenridge/mac-candidate
Layout changes to reduce height of add account sheet
2021-04-01 18:00:09 -05:00
Stuart Breckenridge 8da7d2173f
Layout changes to reduce size of add account sheet 2021-04-02 06:53:20 +08:00
Maurice Parker 1ab727a128 Make symbol images images scale correctly. Fixes #2957 2021-04-01 11:12:48 -05:00
Jed Fox 4750e9b93a
Add dir=auto to page.html 2021-03-29 17:20:09 -04:00