Castopod
/
kasts
mirror of https://github.com/KDE/kasts.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Solve problem with entrypage not scrolling 

The issue was because of a Connection as final component.  That seems to
block the scrolling.
By putting the Connection at the top of the ScrollablePage, all problems
are solved.
Very strange ...
This commit is contained in:
Bart De Vries 2021-04-20 14:53:00 +02:00
parent 3a1c88038a
commit 1faf092d48
1 changed files with 18 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/qml/EntryPage.qml
View File

@ -1,5 +1,6 @@
/** /**
* SPDX-FileCopyrightText: 2020 Tobias Fella <fella@posteo.de> * SPDX-FileCopyrightText: 2020 Tobias Fella <fella@posteo.de>
* SPDX-FileCopyrightText: 2021 Bart De Vries <bart@mogwai.be>
* *
* SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL * SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
*/ */
@ -7,7 +8,6 @@
import QtQuick 2.14 import QtQuick 2.14
import QtQuick.Controls 2.14 as Controls import QtQuick.Controls 2.14 as Controls
import QtQuick.Layouts 1.14 import QtQuick.Layouts 1.14
import QtMultimedia 5.15 import QtMultimedia 5.15
import org.kde.kirigami 2.14 as Kirigami import org.kde.kirigami 2.14 as Kirigami
@ -23,6 +23,23 @@ Kirigami.ScrollablePage {
padding: 0 // needed to get the inline header to fill the page padding: 0 // needed to get the inline header to fill the page
Connections {
target: entry
function onQueueStatusChanged() {
if (entry.queueStatus === false) {
// this entry has just been removed from the queue
if (pageStack.depth > 1) {
if (pageStack.get(0).lastEntry) {
if (pageStack.get(0).lastEntry === entry.id) {
// if this EntryPage was open, then close it
pageStack.pop()
}
}
}
}
}
}
ColumnLayout { ColumnLayout {
GenericListHeader { GenericListHeader {
id: infoHeader id: infoHeader
@ -46,23 +63,6 @@ Kirigami.ScrollablePage {
} }
} }
Connections {
target: entry
function onQueueStatusChanged() {
if (entry.queueStatus === false) {
// this entry has just been removed from the queue
if (pageStack.depth > 1) {
if (pageStack.get(0).lastEntry) {
if (pageStack.get(0).lastEntry === entry.id) {
// if this EntryPage was open, then close it
pageStack.pop()
}
}
}
}
}
}
actions.main: Kirigami.Action { actions.main: Kirigami.Action {
text: !entry.enclosure ? i18n("Open in Browser") : text: !entry.enclosure ? i18n("Open in Browser") :
entry.enclosure.status === Enclosure.Downloadable ? i18n("Download") : entry.enclosure.status === Enclosure.Downloadable ? i18n("Download") :
@ -142,4 +142,3 @@ Kirigami.ScrollablePage {
} }
] ]
} }