From 1faf092d488dcada561d3b8b9799aa5876cbada5 Mon Sep 17 00:00:00 2001 From: Bart De Vries Date: Tue, 20 Apr 2021 14:53:00 +0200 Subject: [PATCH] Solve problem with entrypage not scrolling The issue was because of a Connection as final component. That seems to block the scrolling. By putting the Connection at the top of the ScrollablePage, all problems are solved. Very strange ... --- src/qml/EntryPage.qml | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/src/qml/EntryPage.qml b/src/qml/EntryPage.qml index 8bde9a54..bfbc6231 100644 --- a/src/qml/EntryPage.qml +++ b/src/qml/EntryPage.qml @@ -1,5 +1,6 @@ /** * SPDX-FileCopyrightText: 2020 Tobias Fella + * SPDX-FileCopyrightText: 2021 Bart De Vries * * SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL */ @@ -7,7 +8,6 @@ import QtQuick 2.14 import QtQuick.Controls 2.14 as Controls import QtQuick.Layouts 1.14 - import QtMultimedia 5.15 import org.kde.kirigami 2.14 as Kirigami @@ -23,6 +23,23 @@ Kirigami.ScrollablePage { padding: 0 // needed to get the inline header to fill the page + Connections { + target: entry + function onQueueStatusChanged() { + if (entry.queueStatus === false) { + // this entry has just been removed from the queue + if (pageStack.depth > 1) { + if (pageStack.get(0).lastEntry) { + if (pageStack.get(0).lastEntry === entry.id) { + // if this EntryPage was open, then close it + pageStack.pop() + } + } + } + } + } + } + ColumnLayout { GenericListHeader { id: infoHeader @@ -46,23 +63,6 @@ Kirigami.ScrollablePage { } } - Connections { - target: entry - function onQueueStatusChanged() { - if (entry.queueStatus === false) { - // this entry has just been removed from the queue - if (pageStack.depth > 1) { - if (pageStack.get(0).lastEntry) { - if (pageStack.get(0).lastEntry === entry.id) { - // if this EntryPage was open, then close it - pageStack.pop() - } - } - } - } - } - } - actions.main: Kirigami.Action { text: !entry.enclosure ? i18n("Open in Browser") : entry.enclosure.status === Enclosure.Downloadable ? i18n("Download") : @@ -142,4 +142,3 @@ Kirigami.ScrollablePage { } ] } -