Lincoln Ramsay
fcbbaa4060
Avoid stuck download notifications
...
Cancel the periodic updater before calling stopForeground so
that the notification can't come back after it has been closed.
Remove the workaround for API 30 slow notification closing because
it can cause a stuck notification. However, in order to avoid misleading
text being left on the notification if it closes slowly, ensure that
the "0 downloads" text is written to the notification when shutting down.
Fixes #4556
2021-02-28 09:34:25 +10:00
Herbert Reiter
1cd680a2af
Remove interface ImageResource ( #4911 )
2021-02-24 15:44:40 +01:00
ByteHamster
bbbf9cdf23
Moved pull request template
2021-02-23 10:33:49 +01:00
ByteHamster
388bc5b063
Tell contributors to only change English strings
2021-02-23 10:16:26 +01:00
ByteHamster
711ba97910
Merge pull request #4956 from ByteHamster/android12-exported
...
Explicitly specify exported attribute for Android 12 compatibility
2021-02-23 10:08:12 +01:00
ByteHamster
82dc41d813
Merge pull request #4950 from ByteHamster/fix-file-not-found
...
Fixed rare 'file not found' errors when starting playback
2021-02-23 10:07:38 +01:00
ByteHamster
353aeb5d8d
Merge pull request #4954 from damoasda/FeedItem-description
...
Improve FeedItem class documentation
2021-02-23 10:01:24 +01:00
ByteHamster
177081e4b7
Explicitly specify exported attribute for Android 12 compatibility
2021-02-23 09:28:34 +01:00
ByteHamster
69239e5e67
Merge pull request #4955 from ByteHamster/more-chapter-tests
...
Added auphonic files to chapter marks tests
2021-02-22 17:26:28 +01:00
ByteHamster
6add59819a
Added auphonic files to chapter marks tests
...
We currently don't have a parser for the m4a file but I just committed
the file for later.
2021-02-22 17:11:40 +01:00
Herbert Reiter
8bffe2beda
Improve FeedItem class documentation
2021-02-21 16:00:21 +01:00
ByteHamster
d6b6a0691d
Moved infrastructure documentation to wiki
2021-02-20 10:25:59 +01:00
ByteHamster
949260658b
Fixed rare 'file not found' errors when starting playback
...
The `getPlayLastPlayedMediaIntent` method was originally added in 2013
to avoid starting the service without a media file. The bind method
should actually never need to start the service in the first place,
though.
2021-02-19 21:22:19 +01:00
ByteHamster
822b6844f8
Merge pull request #4949 from ByteHamster/subscription-page-refresh
...
Don't flicker progress bar while refreshing
2021-02-19 20:57:28 +01:00
ByteHamster
59600eb6c5
Merge pull request #4947 from ByteHamster/real-world-parser-tests
...
Added a real file to test chapter parser with
2021-02-19 20:49:51 +01:00
ByteHamster
f0358eb344
Don't flicker progress bar while refreshing
2021-02-19 20:39:34 +01:00
ByteHamster
8fdd034e9e
Added a real file to test chapters with
...
Thanks to the Sendegate community
https://sendegate.de/t/gesucht-beispieldateien-mit-kapitelmarken/13228
2021-02-19 14:21:44 +01:00
ByteHamster
e5fc80e068
Merge pull request #4946 from yarons/patch-1
...
Fixed typo
2021-02-18 17:10:49 +01:00
Yaron Shahrabani
7b39ef8953
Fixed typo
...
Epsiodes->Episodes
2021-02-18 00:57:48 +02:00
ByteHamster
986a62de75
Merge pull request #4945 from ByteHamster/more-parser-tests
...
Added more id3 parser tests
2021-02-17 17:35:50 +01:00
ByteHamster
12e22849e6
Added more id3 parser tests
2021-02-17 14:48:31 +01:00
ByteHamster
1c9f017a7e
Pulled listing translations
2021-02-17 12:23:35 +01:00
ByteHamster
28d6551dbc
Removed plural form because Transifex only allows 2 forms in English
2021-02-17 11:39:30 +01:00
ByteHamster
64304cee8a
Merge pull request #4944 from ByteHamster/dont-restart-loading-indicator
...
Don't flicker with nav drawer loading indicator when refreshing
2021-02-17 09:28:54 +01:00
ByteHamster
32afda252e
Don't flicker with nav drawer loading indicator when refreshing
2021-02-16 22:20:11 +01:00
ByteHamster
cf2d1006df
Merge pull request #4942 from ByteHamster/rewrite-chapter
...
Rewrite chapter parser for testability
2021-02-16 22:14:06 +01:00
ByteHamster
9e68b8b0a3
Fixed NPE when loading ogg chapters
2021-02-16 16:09:18 +01:00
ByteHamster
e1277b1bb8
Merge pull request #4939 from ByteHamster/fix-toggle-disappearing
...
Fixed disappearing drawer toggle
2021-02-16 15:55:03 +01:00
ByteHamster
df4b013611
Fixed disappearing drawer toggle
...
When the activity is recreated after it was stopped in background,
the BackStackEntryCount is the same for all fragments. The one that
should display the toggle therefore thinks it shouldn't. This change
saves the button state now. This is only needed for top-level fragments.
2021-02-16 14:42:37 +01:00
ByteHamster
3f1c1c4bf5
Rewrite chapter parser for testability
2021-02-16 14:39:49 +01:00
ByteHamster
0f692be2d4
Merge pull request #4940 from ByteHamster/more-reliable-chapters
...
More reliable chapter loading
2021-02-16 09:39:23 +01:00
ByteHamster
fe0c710bc8
Merge pull request #4941 from ByteHamster/fix-chapters-multiple-nullbytes
...
Fix parsing chapters with multiple null bytes
2021-02-16 09:38:02 +01:00
ByteHamster
4f2dcc189c
Fix parsing chapters with multiple null bytes
...
Previously, we relied on the string to fill the complete frame.
Some podcasts terminate the string early and leave some garbage in
the frame data. Skip that garbage, so that the reader is at a valid
frame header position when starting the next iteration.
2021-02-15 23:13:29 +01:00
ByteHamster
57587c928e
Removed method that does the same as loadMediaInfo anyway
2021-02-15 22:02:55 +01:00
ByteHamster
339aa936bf
Removed return parameter of loadMediaInfo
...
We return true anyways. The call for actually loading is asynchronous,
so returning anything here does not make sense.
Reduces likelihood of loader being interrupted to just load the same
item again when the state changes.
2021-02-15 21:56:06 +01:00
ByteHamster
c0d3a6e3be
Don't filter chapters in the UI
2021-02-15 21:35:45 +01:00
Geist5000
aaeea78b37
changed the "Use Episode Cover" setting to only apply to list items. ( #4908 )
2021-02-15 16:04:03 +01:00
ByteHamster
394122dade
Updated broken beta testing link in readme
2021-02-15 15:39:31 +01:00
ByteHamster
42ce907aaf
Merge pull request #4936 from ByteHamster/chapter-reader
...
Simplified chapter reader
2021-02-15 15:21:49 +01:00
ByteHamster
5b7c2b7483
Merge pull request #4937 from ByteHamster/downloadservice-cleanup
...
Clean up DownloadService
2021-02-15 15:20:46 +01:00
ByteHamster
b1bf77d4e3
New workaround for hiding the notification directly
2021-02-15 11:44:02 +01:00
ByteHamster
c6b5d60a7c
Don't set progress to 0 and then back to a number
...
This triggers an animation
2021-02-15 11:44:02 +01:00
ByteHamster
4aa5443529
Refresh all feeds at once instead of sending tons of lists with 1 feed each
2021-02-15 11:43:57 +01:00
ByteHamster
52421d81f7
Removed some unnecessary calls to startForeground
2021-02-15 11:28:03 +01:00
ByteHamster
5a234a367d
Simplified chapter reader
...
No longer uses code duplication for opening local and remote streams.
Also, switched to OkHttp to handle redirects.
2021-02-15 11:08:00 +01:00
ByteHamster
66ae028719
Merge branch 'master' into develop
2021-02-14 22:44:08 +01:00
Tony Tam
f57cf0c317
New preference to show the remaining time in the 'queue' and podcast episode view ( #4880 )
2021-02-14 12:18:27 +01:00
ByteHamster
cca5a8a624
Merge pull request #4920 from ByteHamster/jcenter-deprecation
...
Migrate away from jcenter
2021-02-13 13:53:18 +01:00
ByteHamster
1a803fcbf8
Merge pull request #4926 from ByteHamster/move-basic-views
...
Move basic views to new module
2021-02-13 13:33:26 +01:00
ByteHamster
b0af98e644
Use speed dial view from jitpack
2021-02-13 13:31:40 +01:00