Commit Graph

4169 Commits

Author SHA1 Message Date
ByteHamster fcbadf1e9e Revert "Set background of playerFragment to same color as toolbar"
This reverts commit 2f6c9c49f8.
2018-02-20 22:47:18 +01:00
ByteHamster d376e462e7 Make feed title selectable 2018-02-14 11:15:15 +01:00
ByteHamster 2fed8ff104 Darken background of feed header
This change only applies to feed items using transparent backgrounds.
The item is darkened but the background keeps transparent, which looks
weird, especially in light theme (have a look at the 34C3 feed)
2018-02-13 00:53:31 +01:00
ByteHamster 2f6c9c49f8 Set background of playerFragment to same color as toolbar
Most noticeable in dark theme
2018-02-13 00:49:00 +01:00
ByteHamster 877ae45592 Removed useless nested layout 2018-02-13 00:22:52 +01:00
ByteHamster 301bf782a1 Do not flicker when pressing back arrow 2018-02-05 00:16:07 +01:00
ByteHamster 8feb6e087f Make player selectable 2018-02-05 00:14:39 +01:00
Martin Fietz 287bb5f7e1
Merge pull request #2550 from ByteHamster/download-range
Hotfix for servers not accepting the Range header
2018-01-24 08:04:12 +01:00
ByteHamster bc9d39dedf Hotfix for servers not accepting the Range header
Because of #2339, the file always exists when starting a download.
There is still an issue with the server parsing "Range: bytes=0-"
incorrectly, but this commit should make the error appear less often.

Related to #2539
2018-01-23 23:31:08 +01:00
Martin Fietz c79b003dff Prepare for 1.6.4.5 2018-01-22 21:51:43 +01:00
Martin Fietz 94e8c2d92b
Merge pull request #2549 from AntennaPod/bugfix/corrupt-database
Synchronize opening and closing of the database
2018-01-22 21:50:55 +01:00
Martin Fietz f7de8a0e44 Synchronize opening and closing of the database 2018-01-22 21:45:38 +01:00
H. Lehmann 77b199d005
Merge pull request #2547 from ByteHamster/improve-export-naming
Improved wording (Closes #2545)
2018-01-22 13:18:28 +01:00
Martin Fietz 961a68022b
Merge pull request #2546 from gaul/stringbuilder
Prefer StringBuilder over StringBuffer
2018-01-22 08:06:29 +01:00
ByteHamster 8b041be8aa Improved export success wording (Closes #2545) 2018-01-21 23:37:41 +01:00
Martin Fietz 82378f3647
Merge branch 'develop' into stringbuilder 2018-01-21 22:12:54 +01:00
Martin Fietz 34a5d7eb17
Merge pull request #2537 from AntennaPod/refactor
Fix inspection issues
2018-01-21 22:09:43 +01:00
Andrew Gaul 278e93880e Prefer StringBuilder over StringBuffer
The latter has unnecessary synchronization.  Found via error-prone.
2018-01-21 13:04:57 -08:00
Martin Fietz c64e47dcd6 Change back to old implementation 2018-01-21 19:59:09 +01:00
Martin Fietz dde04c5a01 Use temporary StringBuilder for string concatenation in loop 2018-01-21 13:15:43 +01:00
Martin Fietz b4d8868e9d Revert "Use StringBuilder for string concatenation in loop"
This reverts commit 919ee63c3c.
2018-01-21 13:13:23 +01:00
Martin Fietz 2a792c3c75 Remove useless comment 2018-01-21 13:08:36 +01:00
Martin Fietz db21463730 Add missing spaces 2018-01-21 13:07:28 +01:00
Martin Fietz 86f6c001c1 Inline variables 2018-01-21 13:05:10 +01:00
Martin Fietz 595674a872 Minor refactorings 2018-01-21 13:03:30 +01:00
Martin Fietz a6c33d3b2c Fix style 2018-01-21 13:03:00 +01:00
Martin Fietz d3491d1858 Merge branch 'develop' into refactor
# Conflicts:
#	app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java
#	core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java
2018-01-21 11:10:20 +01:00
Martin Fietz f7c048e5b4 Update translations 2018-01-21 11:00:15 +01:00
Martin Fietz e6498393a6
Merge pull request #2445 from ByteHamster/export
Database import/export
2018-01-21 10:51:16 +01:00
Martin Fietz 9adbf83182
Merge pull request #2543 from gaul/static-final
Make some static fields final
2018-01-21 10:03:52 +01:00
Martin Fietz 5abaa77551
Merge pull request #2542 from gaul/static-inner-class
Make some inner classes static
2018-01-21 10:03:12 +01:00
Andrew Gaul 404f241891 Make some static fields final
Adding final prohibits modification and allows initialization of
primitive and String fields at compile time instead of runtime in
clinit:

https://developer.android.com/training/articles/perf-tips.html#UseFinal

Found via error-prone.
2018-01-20 18:28:21 -08:00
Andrew Gaul 118d9103c1 Make some inner classes static
This avoids an implicit this field and can help GC.  Found via
error-prone.
2018-01-20 18:26:08 -08:00
Martin Fietz e4770e7edc PlayerStatus and playable fields cannot be final 2018-01-19 17:25:47 +01:00
Martin Fietz 99f01bdc90 Add throws to avoid interface clash 2018-01-14 18:42:50 +01:00
Martin Fietz e56e3868da Variable cannot be final 2018-01-14 18:42:26 +01:00
Martin Fietz b38d016ec3 Remove catch for exception that is never thrown 2018-01-14 18:41:26 +01:00
Martin Fietz c12fedf392 Merge folder configuration 2018-01-14 18:17:08 +01:00
Martin Fietz e9700b0627 Lookup service via application context to avoid memory leak 2018-01-14 18:14:15 +01:00
Martin Fietz 3cb8f27e49 Remove unnecessary interface modifiers 2018-01-14 18:09:15 +01:00
Martin Fietz 44f80a9831 static modifier is redundant for inner enums 2018-01-14 18:08:48 +01:00
Martin Fietz b80d6a7914 Remove redundant throws clauses 2018-01-14 18:06:24 +01:00
Martin Fietz a49048c7f6 Add final modifiers 2018-01-14 18:05:45 +01:00
Martin Fietz b86b6caec8 Weaken declaration access 2018-01-14 18:04:54 +01:00
Martin Fietz eaa9947869 Fix pointless arithmetic expression 2018-01-14 18:03:22 +01:00
Martin Fietz e02baebf02 Use bulk operation instead of iteration 2018-01-14 18:02:56 +01:00
Martin Fietz d7e1b0f977 Replace StringBuilder with String 2018-01-14 18:02:13 +01:00
Martin Fietz 919ee63c3c Use StringBuilder for string concatenation in loop 2018-01-14 18:01:31 +01:00
Martin Fietz e44a54c965 Remove redundant call to 'String.format()' 2018-01-14 18:00:57 +01:00
Martin Fietz 55e2ac4ebe Remove redundant calls to toString() 2018-01-14 18:00:21 +01:00