Commit Graph

2035 Commits

Author SHA1 Message Date
orionlee
2f82a5d464 refactor - rename FeedFileDownloadStatusRequesterInterface to a more generic DownloadStateProvider. 2019-11-05 12:34:11 -08:00
orionlee
cd3d20d613 refactor - move ItemEnqueuePositionCalculator to top-level per review. 2019-11-05 12:33:58 -08:00
orionlee
2d1ee52014 fix imports post androidX migration 2019-11-05 11:04:23 -08:00
orionlee
fb7fb05b5e test case tweak: preserve download order test, fix test case name
(remove the incomplete expected from test case name)
2019-11-05 11:04:23 -08:00
orionlee
820b0b0793 test case bug fix: Bulk download 2nd item position should be 1 2019-11-05 11:04:23 -08:00
orionlee
ce5aa26878 refactoring test - factor out common operations of calc position,
add to queue and verify result into common helper.
2019-11-05 11:04:23 -08:00
orionlee
fb824b541d Test cases readability: change expected format from position to the actual queue
(list of IDs), to make the test case more readable.
2019-11-05 11:04:23 -08:00
orionlee
97905e5ed4 #2448: make podcast episode enqueue position respect download start order 2019-11-05 11:04:17 -08:00
orionlee
0973efa943 refactor test - break ItemEnqueuePositionCalculatorTest to be more modular
to prepare for testing more complex enqueue options.
2019-11-05 10:54:21 -08:00
orionlee
17e61335db #2652 (part of): Expose keep in-progress at front as a preference
(in Playback > Queue section)
2019-11-05 10:54:21 -08:00
orionlee
30f104f40b #2652 (part of): The in-progress podcast at the front of the queue
should remain at the front.
2019-11-05 10:54:21 -08:00
orionlee
bfde3c7315 refactor - DBWriterTest: parametrize the set of tests 2019-11-05 10:54:21 -08:00
orionlee
ba27ec6b31 refactor - DBWriter.addQueueItem() : refactor enqueue position calculation
to be a unit-testable component (static inner class)
2019-11-05 10:54:21 -08:00
ByteHamster
8aff9709c3 Style OnlineFeedViewActivity like a dialog
User study showed that new users do not get the difference between the actual
feed list and the preview. If the preview is a dialog, this is a lot easier to see.
Additionally, the "dialog" now closes after the subscription succeeded.
2019-11-05 15:28:32 +01:00
sevenmaster
386395629b Clearer button text for feching podcast (#3575)
When subscribing to a podcast, the old text might be confusing to new users (it's not downloading an episode, just the feed. That is not considered downloading for most users)

Signed-off-by: sevenmaster <seven-master@hotmail.de>
2019-10-31 23:00:39 +01:00
H. Lehmann
2a2ced1631
Merge pull request #3572 from ByteHamster/downloadservice-refactoring
DownloadService refactoring
2019-10-31 09:23:47 +01:00
H. Lehmann
e7367e218d
Merge pull request #3571 from ByteHamster/hide-play-button-on-destroy
Updating notification play button in onDestroy
2019-10-30 19:30:20 +01:00
ByteHamster
69f3a1210f Do not refresh feeds more often than necessary 2019-10-30 19:27:38 +01:00
ByteHamster
6825cca32a Updating notification more often 2019-10-30 18:19:36 +01:00
ByteHamster
dd5ba4d38d Do not access context in constructor 2019-10-30 18:16:34 +01:00
ByteHamster
ea6b41116f Extracted DownloaderFactory to new class 2019-10-30 18:16:26 +01:00
ByteHamster
8f168948ad Reordered methods to have setup on top 2019-10-30 18:06:44 +01:00
ByteHamster
366e60990d Posting downloaders on executor 2019-10-30 18:05:26 +01:00
ByteHamster
fe17f1bcb5 Extracted handling completed downloads to method 2019-10-30 17:51:22 +01:00
ByteHamster
74621170fe Converted our own FeedSyncThread to a task+executor 2019-10-30 11:10:44 +01:00
ByteHamster
798868db9c Extracted notification from DownloadService 2019-10-29 23:58:44 +01:00
ByteHamster
056d7db16b Extracted feed sync from DownloadService 2019-10-29 23:39:29 +01:00
ByteHamster
7ae5424479 Updating notification play button in onDestroy 2019-10-29 22:37:58 +01:00
Ptilopsis Leucotis
917e60fbe2 Fix incorrect progress string on widget
If option "pref_followQueue_title" is disabled, when played episode #1 is ended and next episode #2 is loaded, progress string on widget show incorrect information about position and duration of episode, because it show (position / duration) of ended episode #1 instead of (position / duration) of loaded episode #2.
2019-10-29 11:16:06 +03:00
ByteHamster
20e025bd2e Prefer image that is specified in feed over embedded image 2019-10-27 22:52:41 +01:00
H. Lehmann
57818ade38
Merge branch 'develop' into more-eventbus-migration 2019-10-25 11:40:18 +02:00
H. Lehmann
a047e34f8e
Merge pull request #3528 from orionlee/podcast_screen_sort_2524
Sort Support in Podcast screen
2019-10-25 11:38:31 +02:00
ByteHamster
1de76f789f Removed EventDistributor 2019-10-25 11:25:21 +02:00
ByteHamster
728ed23077 Migrated feed list update event to EventBus 2019-10-25 11:19:52 +02:00
ByteHamster
d4b9d0fd59 Migrated unread items update to EventBus 2019-10-25 11:12:48 +02:00
ByteHamster
b5ab7d6d3c Migrated player status event to EventBus 2019-10-25 10:54:40 +02:00
fossterer
ca83c59537 Fixes #3444 - Strip off HTML from podcast descriptions 2019-10-24 23:20:31 -04:00
orionlee
baec984c0f Feed Sort Order DB column: changed from Integer to Text, to allow flexibility of multiple sorts without DB schema change 2019-10-24 15:32:51 -07:00
orionlee
7687ffb08e Misc code style fixes. 2019-10-24 13:49:32 -07:00
orionlee
007f1fbb87 Remove unused comparators after SortOrder refactoring 2019-10-24 13:39:28 -07:00
H. Lehmann
437f3f29c0
Merge pull request #3551 from ByteHamster/eventdistributor
Migrated some events from EventDistributor to EventBus
2019-10-24 22:28:33 +02:00
H. Lehmann
385bd3597b
Merge pull request #3550 from ByteHamster/remove-resume-intent
Removed resume intent
2019-10-24 22:27:48 +02:00
orionlee
9c895ef15a Test to ensure Feed only accepts INTRA_FEED sort order 2019-10-24 12:17:31 -07:00
orionlee
bcd4b49dda feeditem sort - handle boundary conditions 2019-10-24 12:03:22 -07:00
orionlee
306b6f30a4 rename + refactor QueueSorter to FeedItemPermutors, to support both queue and podcast screen. 2019-10-24 11:32:06 -07:00
orionlee
f56a02d513 sort in Podcast screen - implement all the sorts 2019-10-24 11:01:48 -07:00
orionlee
05dfccacc3 a new filter icon, to differentiate it from sort per review.
- Icon source: https://materialdesignicons.com/icon/filter-outline
2019-10-24 10:30:32 -07:00
H. Lehmann
f41bdcbaf2
Merge pull request #3544 from M-arcel/develop
Transparent widget
2019-10-23 23:11:51 +02:00
ByteHamster
ff44f97dd6 Showing a more interesting background image 2019-10-23 23:08:07 +02:00
ByteHamster
6642b79ac3 Code cleanup 2019-10-23 23:08:07 +02:00
ByteHamster
28cc00a016 Material design layout tweaks 2019-10-23 23:08:07 +02:00
Marcel Regeci
b513608032 Transparent widget 2019-10-23 23:07:49 +02:00
ByteHamster
7d3b78091f Removed event that is never sent 2019-10-23 22:51:28 +02:00
ByteHamster
d8ffa6c459 Migrated playback history events to EventBus 2019-10-23 22:51:21 +02:00
ByteHamster
68da2e022d Migrated download log events to EventBus 2019-10-23 22:41:20 +02:00
ByteHamster
a8c1b3c87c Removed resume intent 2019-10-23 22:25:33 +02:00
H. Lehmann
bc5f36336e
Merge pull request #3547 from ByteHamster/checkstyle-change
Checkstyle change
2019-10-22 22:59:42 +02:00
ByteHamster
cc52fa04fa Enforce MultipleVariableDeclarations checkstyle 2019-10-22 16:53:35 +02:00
orionlee
562ddee7d7 sort in podcast screen - db persistence 2019-10-20 15:21:46 -07:00
orionlee
be7db6cef1 sort in podcast screen - logic, no db persistence yet. 2019-10-20 15:21:46 -07:00
orionlee
1620d29549 Sort in Podcast screen - UI 2019-10-20 15:21:46 -07:00
ByteHamster
fea84424e3 Removed code duplication from playback tests, added test for ExoPlayer 2019-10-20 23:49:14 +02:00
H. Lehmann
f1f91478b6
Merge pull request #3520 from dsmith47/stream
Show stream button rather than download (in queue, podcast views)
2019-10-20 18:54:14 +02:00
H. Lehmann
38a670139f
Merge pull request #3505 from xgouchet/feature/3070_episode_image
Add an option to replace Episode cover with Podcast cover
2019-10-19 22:24:42 +02:00
H. Lehmann
4df98151a5
Merge pull request #3538 from ariedov/crash-on-equalizer-4.1
Fixes crash on equalizer open on Android 4.1
2019-10-19 01:53:08 +02:00
David Leibovych
5f3714a028 Fixes crash on equalizer open on Android 4.1 2019-10-19 00:20:53 +03:00
orionlee
250594827d unit test for get feeditem link with fallback 2019-10-18 11:31:46 -07:00
orionlee
5eaa4dbfb1 bugfix: Share Episode URL - handle empty link 2019-10-17 12:47:45 -07:00
Xavier Gouchet
fd5a5d71a2 Add an option to replace Episode cover with Podcast cover
The default is to use the episode cover (keep the previous behavior).

Fixes #3070
2019-10-17 16:00:27 +02:00
Doug Smith
0bc3294ca4 Implemented feature to show stream button (instead of Download/Play-Pause) in podcast episode views.
* Added user preference to specify that stream buttons are preferred
* Added StreamAction button to trigger streams on podcast options
2019-10-16 04:31:50 -04:00
H. Lehmann
54eeeb4355
Merge pull request #3516 from egsavage/reset-sleep-timer-on-play
Issue #2381 - restart sleep timer on play
2019-10-15 12:12:06 +02:00
Xavier Gouchet
504bbb0058 Remove duplicate string 2019-10-14 09:14:00 +02:00
Xavier Gouchet
c81fcba22d Fix formatting 2019-10-14 09:14:00 +02:00
Xavier Gouchet
4f65aa015a Add confirmation dialog before reseting statistics 2019-10-14 09:14:00 +02:00
Xavier Gouchet
4289933155 Optimize the deletion of statistics data 2019-10-14 09:14:00 +02:00
Xavier Gouchet
5989d6daf6 Remove the unnecessary StatisticsEvent 2019-10-14 09:14:00 +02:00
Xavier Gouchet
91463ba877 Remove icon from "Reset statistics" option menu item 2019-10-14 09:14:00 +02:00
Xavier Gouchet
f9b413332f Reset playback statistics
Fixes #1867
2019-10-14 09:14:00 +02:00
egsavage
a59fd67178 Issue #2381 - restart sleep timer on play 2019-10-13 20:58:28 -04:00
ByteHamster
c1d81408c1 Fixed notification reappearing if continuous playback is disabled 2019-10-09 12:26:11 +02:00
H. Lehmann
3980bcca6d
Merge pull request #3386 from orionlee/bugfix_skip_last_episode_in_queue_3383
Bugfix skip last episode in queue - episode status
2019-10-09 12:09:04 +02:00
H. Lehmann
0e614f96e9
Merge pull request #3497 from ByteHamster/position-in-notification
Showing progress in notification
2019-10-06 19:42:14 +02:00
H. Lehmann
f750e06a1b
Merge pull request #3498 from ByteHamster/fix-mono-switch
Fixed downmixing if service is not bound
2019-10-06 12:57:07 +02:00
H. Lehmann
935e2ceee0
Merge pull request #3499 from ByteHamster/local-playable-improvements
Local playable improvements
2019-10-06 12:54:14 +02:00
H. Lehmann
de10ca9548
Merge pull request #3415 from spacecowboy/per_feed_playbackspeed
Added per-feed playback speed setting
2019-10-06 12:52:55 +02:00
H. Lehmann
526c5744de
Merge pull request #3496 from ByteHamster/default-playback-speed
Added 0.75 to default playback speed list
2019-10-06 12:48:46 +02:00
ByteHamster
6f809b47e6 Speeding up notification update
startForeground() is significantly slower than just notify()
2019-10-06 12:45:22 +02:00
Jonas Kalderstam
138c29df0f Removed potentially misleading comment 2019-10-06 10:06:11 +02:00
ByteHamster
b2d9455d6c Caching icon manually to prevent long locks 2019-10-06 10:04:06 +02:00
Jonas Kalderstam
cab40dc466 Removed unnecessary comment 2019-10-06 10:04:05 +02:00
ByteHamster
69e51c148e Moved notification setup out of Thread
Fixes wrong thread for media player. Also, might fix race conditions.
2019-10-06 09:11:45 +02:00
ByteHamster
e6ae4c23f0 Showing file name if title extraction fails 2019-10-05 23:48:50 +02:00
ByteHamster
cf3e8107f3 Syntax cleanup
Mostly replaced tabs with spaces
2019-10-05 23:38:51 +02:00
ByteHamster
b081e320e3 Fixed downmixing if service is not bound 2019-10-05 23:04:18 +02:00
ByteHamster
53ea702772 Showing progress in notification 2019-10-05 21:58:25 +02:00
ByteHamster
cb942b646a Added 0.75 to default playback speed list
Users on Google Play seem to be confused that they can not select a
playback speed lower than 1x anymore. The reason is that they just
use the preference dialog and that dialog only displays the range
that is selected for the button.
2019-10-05 21:05:28 +02:00
Jonas Kalderstam
9539908f23 Removed unused imports and unnecessary whitespace changes 2019-10-05 02:24:47 +02:00
Jonas Kalderstam
6a37d33b97 Changed from db backed item speed to preferences backed global value 2019-10-05 02:15:26 +02:00
Jonas Kalderstam
97aa360611 Merge remote-tracking branch 'antennapod/develop' into per_feed_playbackspeed 2019-10-05 01:18:14 +02:00
ByteHamster
e37bd24364 Fixed free build 2019-10-04 23:20:51 +02:00