Commit Graph

5074 Commits

Author SHA1 Message Date
Anderson Mesquita
c38d7bad6b Reword "Mark as seen" to "Remove 'new' flag"
This avoids the confusion between "Mark as seen" and "Mark as played".

Closes: #3225
2019-07-14 11:16:52 -04:00
H. Lehmann
9fe4fed874
Merge pull request #3233 from jas14/pad-scrubber
Pad scrubber on large devices
2019-07-13 17:01:36 +02:00
H. Lehmann
ed338edea4
Merge pull request #3266 from ByteHamster/remove-flattr
Removed Flattr support
2019-07-13 15:04:05 +02:00
H. Lehmann
c8fc1f90e0
Merge pull request #3265 from ByteHamster/storage-label
Added total space to storage select dialog
2019-07-12 22:51:11 +02:00
ByteHamster
641ee60cbf Removed Flattr support 2019-07-12 19:28:22 +02:00
ByteHamster
b5b2bccda4 Added total space to storage select dialog 2019-07-12 18:59:43 +02:00
H. Lehmann
fdf10fdd87
Merge pull request #3263 from ByteHamster/search-crash
Updated SearchPreference
2019-07-12 18:50:44 +02:00
ByteHamster
eda23ca4bb Updated SearchPreference 2019-07-12 14:35:38 +02:00
H. Lehmann
14c9fd2fa2
Merge pull request #3194 from andersonvom/2747-completed-downloads-update
Reorganize fragment lifecycle
2019-07-11 13:06:23 +02:00
H. Lehmann
9f6529d4bc
Merge branch 'develop' into 2747-completed-downloads-update 2019-07-11 12:43:30 +02:00
H. Lehmann
e78e4d5656
Merge pull request #3261 from archibishop/fix-removing-wrong-favourite-message
Fix removing wrong favourite message
2019-07-11 12:42:14 +02:00
Wagubi Brian
782fce76d0 Fix removing wrong favoruite message 2019-07-10 12:29:48 +03:00
H. Lehmann
9e72780bc8
Merge pull request #3254 from jas14/feed-rotation-crash-3245
New ViewModel for loading feed preferences across lifecycle
2019-07-06 15:10:57 +02:00
H. Lehmann
ce649ec087
Merge pull request #3249 from archibishop/imagecover-playpause-fuctionality
Extend play/pause functionality to Image Cover
2019-07-06 15:00:30 +02:00
H. Lehmann
83c54e953a
Merge pull request #3256 from gaul/within-last-year
Fix within last year check in formatAbbrev
2019-07-06 14:57:00 +02:00
Andrew Gaul
24e4211da1 Fix within last year check in formatAbbrev
Previously this method considered a date within the last 365 days to
be in the same year as today.  Instead compare the actual years to
avoid confusion.  Fixes #3255.
2019-07-03 13:18:05 -07:00
Wagubi Brian
e887996053 Extend play/pause functionality to Image Cover 2019-07-02 21:58:30 +03:00
Joe Stein
3b6cfb711f New ViewModel for loading feed preferences across lifecycle 2019-07-02 18:33:32 +02:00
H. Lehmann
082a452156
Merge pull request #3252 from jas14/handle-bad-chapters
Gracefully handle bad ID3 chapter URLs
2019-07-02 09:18:37 +02:00
Joe Stein
f047c23c09 Gracefully handle bad ID3 chapter URLs 2019-07-01 13:40:46 +02:00
Joe Stein
4bc8821845 Increase scrubber padding for large devices 2019-07-01 12:31:14 +02:00
H. Lehmann
abcd6f772e
Merge pull request #3239 from archibishop/username-validation-gpodder-login
Validate username for characters not accepted.
2019-06-26 06:51:42 +02:00
Wagubi Brian
7f1f725bfe validate username for characters not accepted. 2019-06-26 04:50:18 +03:00
Anderson Mesquita
8e95ed75ab Fix recycler and empty view hide/show logic
The `emptyViewHandler` already handles hiding and showing both the empty
view and the recycler view on data changes, so this commit removes this
part of the logic from the episodes fragment.

It also hides the empty view right after creating the recycle adapter
for the first time (when the fragment is created) to prevent the
progress bar and the empty view from being displayed at the same time.

`createRecycleAdapter()` signature was changed to make it explicit that
it depends on both the `recyclerView` and `emptyViewHandler`. Similarly,
`onFragmentLoaded()`, since it also depends on the new data that gets
loaded.
2019-06-24 09:32:06 -04:00
Anderson Mesquita
bb8b1fc58f Reorganize subscription fragment lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita
fd07a10f03 Reorganize search fragment lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita
5e5dfa5584 Reorganize playback history lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita
90d5208402 Reorganize item fragments lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita
e22adbe451 Reorganize DownloadLogFragment lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita
bbcec5d0aa Reorganize Episode Fragments lifecycle
This uses the existing android lifecycle methods to avoid having to do
null checks and state saving in various places.
2019-06-24 08:38:04 -04:00
Anderson Mesquita
aabe370db3 Fix whitespace 2019-06-24 08:38:04 -04:00
Anderson Mesquita
486ceed0ef Reorganize downloads fragments lifecycle
Unregistering from the EventDistributor on stop will prevent downloads
from updating when an episode finishes playing while the screen was off
(#2747), so this registers/unregisters on view create/destroy.

Disposing of the request to load items on stop could potentially cause
the same issue. Since we're disposing of this request on destroy,
there's no need to keep checking and disposing of it in the several
lifecycle methods.

There's no need to call `onFragmentLoaded()` on attach, since this is
the first lifecycle method to be called [[1]], meaning the items will
always be null by the time this method is called.

Finally, since `loadItems` depends on the view being created, it is now
only called on view create to avoid having to store state in the class
about whether the view has been created, taking advantage of the native
fragment lifecycle.

[1]: https://developer.android.com/guide/components/fragments

Closes: #2747
2019-06-24 08:38:04 -04:00
Anderson Mesquita
a556183d60 Extract methods from onViewCreated 2019-06-24 08:38:04 -04:00
Anderson Mesquita
69f116904d Fix IDE warnings
Deprecated method, null pointer exceptions, and simpler switch with only
two cases.
2019-06-24 08:38:04 -04:00
Anderson Mesquita
56dc16802a Fix whitespace 2019-06-24 08:38:04 -04:00
H. Lehmann
1580e93b94
Merge pull request #3229 from ByteHamster/feed-settings-update
Updated feed settings screen
2019-06-14 18:47:53 +02:00
ByteHamster
f3cd43b972 Cleanup 2019-06-14 10:45:45 +02:00
ByteHamster
5a7cbdfaca Added authentication and episode filter dialogs 2019-06-14 10:34:55 +02:00
ByteHamster
8f11f8a271 Updated feed settings screen 2019-06-14 00:38:34 +02:00
H. Lehmann
8931d5b795
Merge pull request #3227 from ByteHamster/restructure-settings
Restructured preferences code
2019-06-13 23:38:18 +02:00
H. Lehmann
d21422a50f
Merge pull request #3228 from ByteHamster/removed-deleted-receiver
Removed deleted receiver from manifest
2019-06-13 23:22:18 +02:00
ByteHamster
85ef61f4ef Removed deleted receiver from manifest 2019-06-13 23:18:12 +02:00
ByteHamster
99acff3b8f Restructured preferences code 2019-06-13 23:12:41 +02:00
H. Lehmann
3331b663e1
Merge pull request #3213 from fabolhak/add_episode_cache_summary
add pref_episode_cache_summary
2019-06-13 21:55:33 +02:00
Unknown
d2b3d5f220 remove german translation 2019-06-07 09:47:55 +02:00
H. Lehmann
2949fe61b6
Merge pull request #3218 from ByteHamster/mobile-download
Clarified mobile updates setting
2019-06-06 00:18:51 +02:00
ByteHamster
6712711ab2 Clarified setting 2019-06-05 23:50:52 +02:00
Unknown
ee1809001d don't override summary value in PreferenceController 2019-06-04 23:58:17 +02:00
H. Lehmann
80ecfacb81
Merge pull request #3215 from ByteHamster/crashes
Fixed ArrayIndexOutOfBoundsException
2019-06-03 12:40:45 +02:00
H. Lehmann
83201d27df
Merge pull request #3214 from ByteHamster/work-manager-disabled-auto-update
Handle disabled auto update
2019-06-03 12:39:19 +02:00