5f75536ee5
Added best-practice checkstyle checks
...
This are the style guidelines I want to enforce throughout the project in the future.
Currently, huge parts of the app do not pass these checks but when developing something new,
we should add those checks to our IDEs.
They are basically the Google checks but with an increased line length from 100 to 120
characters and using 4 instead of 2 spaces for indentation.
2019-10-03 23:01:52 +02:00
1d12f414e4
Merge pull request #3372 from ByteHamster/notification-default-icon
...
Updated default notification icon
2019-10-02 16:10:05 +02:00
59d5c3cbf2
Changed color of default notification icon
2019-10-02 16:07:08 +02:00
71a5a00fd0
Merge branch 'develop' into notification-default-icon
2019-10-02 16:03:11 +02:00
2db5c00d66
Merge pull request #3482 from ByteHamster/exoplayer-log-source
...
Added logging to ExoPlayer
2019-10-02 15:58:04 +02:00
f9fd9c3282
Merge pull request #3426 from ByteHamster/feedinfo-fragment
...
Feedinfo page animation
2019-10-02 15:46:29 +02:00
cbdd3603aa
Added logging to ExoPlayer
2019-10-02 15:42:55 +02:00
6967e9c890
Added feed title to ActionBar
2019-10-02 15:39:10 +02:00
8f5ff42f6a
Merge pull request #3477 from orionlee/test_download_service_event_posting
...
Test download service event posting
2019-10-02 15:25:11 +02:00
8824b7568d
test refactor - move the common FeedItemEventListener test helper to the proper event/ package.
2019-09-30 20:34:12 -07:00
9459460ed4
test refactor - extract common FeedItemEventListener test helper.
2019-09-30 13:55:50 -07:00
d84fc95f0d
test for DownloadService, case media download successful.
2019-09-30 13:46:59 -07:00
f3b3d5c422
Merge pull request #3476 from ByteHamster/fix-feed-without-identifying-value
...
Fixed feed without any identifying value
2019-09-30 21:34:56 +02:00
f862d15753
Merge pull request #3471 from orionlee/bugfix2_player_not_using_downloaded_media_2947
...
New fix player stuck due to streaming rather than using downloaded media
2019-09-30 21:34:17 +02:00
c0befc9854
test tweak - ensure playback queue updated after download - use more concise assertTrue/False
2019-09-30 12:28:27 -07:00
4a0a825c08
test refactor - ensure playback queue updated after download - make test logic more readable by hiding EventBus setup in a helper.
2019-09-30 12:18:41 -07:00
cbf6103c00
test tweak - ensure playback queue updated after download - await for the event explicitly.
2019-09-30 12:07:53 -07:00
38e9cafee3
test tweak - ensure playback queue updated after download - follow de-facto convention for test feeds
2019-09-30 11:59:55 -07:00
f71b933c6b
Fixed feed without any identifying value
2019-09-30 20:39:02 +02:00
940e03bcc7
Fixed sharing ViewModel with multiple feeds
2019-09-30 19:28:51 +02:00
694d0f8d34
Merge pull request #3472 from ByteHamster/do-not-spam-logcat
...
Reduced logcat output
2019-09-30 19:07:56 +02:00
15b7ec6d06
Merge pull request #3473 from ByteHamster/statistics-fragment
...
Updated statistics ui
2019-09-30 19:07:35 +02:00
045e4bc419
Updated statistics layout
2019-09-29 23:52:42 +02:00
71949ab1b7
Converted statistics to fragment
...
Also set title of all preferences pages
2019-09-29 23:52:38 +02:00
31c746684b
Added ViewModel to FeedInfoFragment for even smoother animation
2019-09-29 22:27:46 +02:00
0187786047
Using FeedSettingsFragment without Activity
2019-09-29 22:19:17 +02:00
0ffa0e77d9
Reduced logcat output
2019-09-29 22:07:39 +02:00
71de4607a3
bugfix: Ensure when media download completes and item update event is posted, the feed media has been updated,
2019-09-29 12:55:02 -07:00
9469ebc6c3
bugfix: Ensure playback service use the updated feedItem after media download completes (rather than trying to stream)
2019-09-29 12:46:21 -07:00
1709877531
Merge pull request #3470 from ByteHamster/playbackservice-save-current-playable
...
Moved storing PlaybackPreferences to PlaybackPreferences.java
2019-09-29 17:10:34 +02:00
a3598daaa7
Moved storing PlaybackPreferences to PlaybackPreferences
2019-09-29 16:47:12 +02:00
338c68ff44
Merge pull request #3469 from ByteHamster/buffer-rewind
...
Keep buffer depending on rewind time
2019-09-29 14:57:13 +02:00
1c60a0134d
Keep buffer depending on rewind time
2019-09-29 14:05:48 +02:00
ea84dde76f
Merge pull request #3467 from ByteHamster/keep-back-buffer
...
Keep 30 seconds of back buffer
2019-09-29 12:56:04 +02:00
510f00e204
Making sure that we don't miss updates
2019-09-29 12:55:27 +02:00
2dfe08df2a
Merge pull request #3454 from ByteHamster/update-progress
...
Update episode progress during playback
2019-09-29 12:52:48 +02:00
c614e6e29c
Merge pull request #3466 from ByteHamster/no-reinit-on-pause
...
Do not reinit on pause
2019-09-29 12:50:47 +02:00
cf367c02af
Merge pull request #3465 from skitt/smart-spread-fix
...
Fix the smart shuffle spread calculation
2019-09-29 12:50:21 +02:00
fc317e3b68
Keep 30 seconds of back buffer
2019-09-29 12:49:06 +02:00
3beda73e3c
Do not reinit on pause
2019-09-29 12:39:13 +02:00
8d9c292ca1
Merge branch 'develop' into smart-spread-fix
2019-09-29 12:31:55 +02:00
373f31c53e
Merge pull request #3416 from orionlee/bugfix_autodownload_wifi_filter_on_android10_3387
...
Make Automatic Download WiFi filter UI work on Android 10+
2019-09-29 11:16:10 +02:00
e3ef12e413
Merge pull request #3440 from orionlee/avoid_cast_init_unless_enabled
...
Avoid Cast initialization unless it is enabled
2019-09-29 11:13:33 +02:00
fb377258f2
Merge pull request #3461 from ByteHamster/do-not-notify-cancelled-downloads
...
Do not notify cancelled downloads
2019-09-29 11:10:59 +02:00
43f8435aaf
Merge pull request #3464 from ByteHamster/checkstyle-more-rules
...
Enabled more checkstyle rules
2019-09-29 11:08:02 +02:00
78aecac3ca
Avoid Cast Initialization UI - prompt restart only when enabled. Make prompt more sticky by being not cancelable.
2019-09-28 13:28:12 -07:00
9373b61787
Avoid Cast Initialization - bugfix of accidental removal of cast-enabled codes
2019-09-28 13:26:30 -07:00
d6e2803beb
Wifi Filter UI - code style tweaks, mainly inlining.
2019-09-28 13:05:55 -07:00
7ae3934794
Fix the smart shuffle spread calculation
...
We want to ensure that the total spread is divisible by all feed
sizes, so the modulo calculation needs to divide spread by the feed
size, not the other way round as is done currently.
In addition, this ensures the per-feed spread is never 0 (so the
degenerate case is equivalent to the old smart shuffle).
Signed-off-by: Stephen Kitt <steve@sk2.org>
2019-09-28 18:11:08 +02:00
28a816b16c
Enabled more checkstyle rules
2019-09-28 17:23:36 +02:00
ByteHamster
H. Lehmann
orionlee
Stephen Kitt