3f1e6b5d50
Merge pull request #3106 from ByteHamster/subscriptions-columns
...
Set number of subscription columns
2019-04-12 10:56:26 +02:00
b4f04f6d6d
Merge pull request #3105 from ByteHamster/style-repetition
...
Reduced repetition in styles.xml
2019-04-12 10:36:06 +02:00
cfd0af55c4
Removed nb translation
2019-04-11 21:54:57 +02:00
777d92d4be
Set number of subscription columns
2019-04-11 21:24:51 +02:00
6595f49f22
Reduced repetition in styles.xml
2019-04-11 21:02:45 +02:00
97d08f3b00
Merge pull request #3097 from ByteHamster/exoplayer-main-thread
...
Executing all ExoPlayer methods on main thread
2019-04-11 20:50:56 +02:00
5745da75a6
Clarified that it is using caller thread. not main thread
2019-04-11 20:11:40 +02:00
0e3cabb86d
Do not hold state in fragments
2019-04-10 01:05:36 +02:00
156a20734a
Fix Sonic playback
2019-04-07 12:54:12 +02:00
2c9cb25eda
Merge branch 'develop' into exoplayer-main-thread
2019-04-07 11:52:24 +02:00
ebe32e795a
Executing all ExoPlayer methods on main thread
2019-04-07 00:19:02 +02:00
20f1445c06
fix rebase conflicts - remove the incorrect @NonNull from rxjava
2019-04-06 14:19:16 -07:00
1655d234af
#2966 RxJava2 null - case the underlying method may return null, but
...
should never happen in the code path, e.g.,
return the current FeedItem in ItemFragment UI.
Mark underlying method as @Nullable, and let observer's existing
onError() to handle null case
Rx observer : underlying sources marked as @Nullable
ItemFragment.load : .loadInBackground
MediaplayerActivity.checkFavorite : DBReader.getFeedItem
ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem
ItemlistFragment.loadItems : .loadData
2019-04-06 13:43:11 -07:00
0472bb9237
#2966 RxJava2 null - explicit mark underlying Rx sources as NonNull
...
to be on the safe side, for cases that the consuming observers checks null
unnecessarily.
Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.startFeedDownload : Downloader.getResult
AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData
PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory
QueueFragment.loadItems : DBReader.getQueue
SearchFragment.search : .performSearch
2019-04-06 13:43:11 -07:00
670fc124eb
#2966 RxJava2 null - explicit mark underlying Rx sources as NonNull
...
to be on the safe side, for cases that the consuming observers
already assumes the result is not null.
Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.listener member : DBReader.getFeedList
StatisticsActivity.loadStatistics : DBReader.getStatistics
CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt
CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems
DownloadLogFragment.loadItems : DBReader.getDownloadedItems
ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes
SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData
SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead
PreferenceController.export : ExportWorker.output member
2019-04-06 13:43:11 -07:00
5f86af88b1
Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145
...
Bulk remove from queue
2019-04-06 21:45:55 +02:00
cb14fd930f
refactor - rename string resource name `remove_episode_lable` , which was ambiguous with typos, to `delete_episode_label`
...
- non-default string resources to be handled by Transifex
2019-04-06 11:27:20 -07:00
cc43af110a
tweak - bulk edit UI - show a message after an action is applied.
2019-04-06 11:15:14 -07:00
b3fbf0b4aa
refactor - UI - remove the old (and now used) select all / none /intermediate icons
2019-04-04 14:05:51 -07:00
d186309066
bulk edit - UI - new select all / none icons, based on
...
standard Material icons.
2019-04-04 13:50:55 -07:00
dfe2241b4c
bulk remove episodes from queue - UI - icon for dark themes.
2019-04-04 13:12:09 -07:00
643173de14
Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716
...
Fix phantom service notification
2019-04-04 11:59:30 +02:00
b683d33bcb
bulk edit - refactor - reorder method parameter for DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API.
2019-04-03 14:21:35 -07:00
4322e8646f
bulk edit - UI tweak - rename "Remove Episode" to "Delete Episode", to be consistent with other UIs
2019-04-03 13:27:31 -07:00
46510c808a
Respect 'keep updated' for new items counter
2019-04-03 18:11:55 +02:00
7a98e3c231
Merge pull request #3082 from ByteHamster/mobile-updates
...
Mobile updates: Allow images
2019-04-03 17:43:53 +02:00
b6e50c61d6
Merge pull request #3060 from jatinkumarg/issue-3052
...
Added empty views to the PlayBack History, Queue,and Downloads
2019-04-03 17:42:09 +02:00
788e75515a
Review changes
2019-04-03 17:29:44 +02:00
3768dfb0ff
bulk edit - "N selected" UI logic
2019-04-02 17:34:05 -07:00
364c9a308d
bulk remove from queue - backend - implement the new API
2019-04-02 15:59:27 -07:00
70287a740e
bulk remove from queue - backend - refactor existing logic to support bulk remove
2019-04-02 14:59:12 -07:00
7d78b88a1c
bulk remove from queue - frontend logic, with a stub backend.
2019-04-02 14:11:22 -07:00
737f7571ab
UI Prototype for Batch Edit Episodes rework (from #1145 )
2019-04-02 11:47:57 -07:00
6fe171fac9
Use ApOkHttpUrlLoader for all images
...
Probably got broken during my Glide update.
When using append or prepend, Glide uses the next one in the chain if ApOkHttpUrlLoader blocks
2019-04-02 17:41:21 +02:00
0fda36b9b3
Add preference to allow mobile updates of images
2019-04-02 17:41:15 +02:00
c589bd2022
Validate that the *new* and *not played* are also exclusive
...
The FeedItem state is actually a tri-state, complement the test
coverage by checking that the state changes from *new* to
*not played*.
2019-03-31 21:26:53 +02:00
6ebf1defe7
Validate that the item state is only changed when needed
...
Follow-up to commit 8172d87477#3067 )
that adds test coverage for the resolved issue.
Also, fix that commit by making the update condition more explicit:
the FeedItem state is only changed when a state switch is necessary.
In other words, an item marked as *new* that gets downloaded should
lose the *new* mark and gain the *unplayed* mark instead.
2019-03-31 16:28:05 +02:00
cba4059063
Require the Mockito library for unit testing
2019-03-31 16:26:26 +02:00
3c7fd274de
Validate that the *new* and *played* states are exclusive
2019-03-31 16:26:26 +02:00
c6344f5bc0
Merge pull request #3073 from deandreamatias/fix-button-shadow-3040
...
Fix #3040 Video playback control button shadow
2019-03-31 00:44:50 +01:00
56456e0001
Delete unused drawable
2019-03-30 21:21:11 +01:00
f900046c66
Merge pull request #3068 from bibz/develop
...
Do not reset item "played" flag on media download
2019-03-30 11:12:46 +01:00
7f3f2180cc
Fixes #3040
...
- Delete unused icons
2019-03-29 22:27:26 +01:00
007f92c291
Change the icons in interface #3040
2019-03-29 22:23:52 +01:00
9e21695486
Add new vector icons #3040
2019-03-29 22:21:04 +01:00
209b0b3880
Fixed typos
2019-03-29 14:20:11 -04:00
09087b354d
Fix #3040
...
- Change the size of the button circle background
2019-03-29 12:57:52 +01:00
42cbdbd989
Merge pull request #3066 from orionlee/bugfix_statistics_played_duration_inflated_2162
...
bugfix - statistics - inflated actual played duration
2019-03-27 20:51:13 +01:00
bdf7bf6844
Fixes #3052 : Added empty views to the Playback History, Queue, Downloads and Episodes
2019-03-27 04:16:06 -04:00
8172d87477
Do not reset item "played" flag on media download
...
If an item has already been played, downloading its media will not
reset that "played" flag.
Fixes : #3067
2019-03-25 15:41:39 +01:00
H. Lehmann
ByteHamster
orionlee
Borjan Tchakaloff
Matias de Andrea
Martin Fietz
Jatin Kumar