5d459b5327
Merge pull request #3115 from ByteHamster/small-crash
...
Fixed NPE
2019-04-14 13:59:29 +02:00
f947b0a90d
Fixed NPE
2019-04-13 16:01:17 +02:00
7c4d4656f8
Merge pull request #3113 from ByteHamster/fix-crash-npe
...
Fixed NPE
2019-04-12 23:20:29 +02:00
8284251a91
Fixed NPE
2019-04-12 23:19:45 +02:00
48b2a67a72
Merge pull request #3110 from ByteHamster/fix-controller-release-crash
...
Fixed crash when re-using released controller
2019-04-12 23:11:12 +02:00
8ebc98af13
Fixed crash when re-using released controller
2019-04-12 11:55:41 +02:00
3f1e6b5d50
Merge pull request #3106 from ByteHamster/subscriptions-columns
...
Set number of subscription columns
2019-04-12 10:56:26 +02:00
b4f04f6d6d
Merge pull request #3105 from ByteHamster/style-repetition
...
Reduced repetition in styles.xml
2019-04-12 10:36:06 +02:00
8810248a5c
Merge pull request #3107 from ByteHamster/nb-translation
...
Removed nb translation
2019-04-12 10:35:09 +02:00
244aeeedcd
Merge pull request #3104 from ByteHamster/queue-loading
...
Fix displaying progress indicator in multi window
2019-04-12 10:34:47 +02:00
cfd0af55c4
Removed nb translation
2019-04-11 21:54:57 +02:00
777d92d4be
Set number of subscription columns
2019-04-11 21:24:51 +02:00
6595f49f22
Reduced repetition in styles.xml
2019-04-11 21:02:45 +02:00
d4c87facaf
Fix displaying progress indicator in multi window
2019-04-11 20:54:48 +02:00
97d08f3b00
Merge pull request #3097 from ByteHamster/exoplayer-main-thread
...
Executing all ExoPlayer methods on main thread
2019-04-11 20:50:56 +02:00
be6eb1c738
Merge pull request #3102 from ByteHamster/no-state-in-fragments
...
Do not hold state in fragments
2019-04-11 20:50:34 +02:00
1d0e22135e
Making sure that ExternalPlayerFragment is updated when starting first media
2019-04-11 20:41:39 +02:00
5745da75a6
Clarified that it is using caller thread. not main thread
2019-04-11 20:11:40 +02:00
0e3cabb86d
Do not hold state in fragments
2019-04-10 01:05:36 +02:00
d8a010ad48
Merge pull request #3100 from orionlee/bugfix_bulk_action_ui_survive_split_screen_3088
...
bugfix - bulk actions - make UI survive upon split screen
2019-04-08 18:54:01 +02:00
f5956bcd56
Merge pull request #3101 from orionlee/bugfix_add_podcast_by_url_case_no_feed_in_html_3099
...
bugfix - add podcast by URL - show error dialog when URL points to no feed
2019-04-08 18:53:32 +02:00
345e6863c3
bugfix #3099 - add podcast by URL - show error dialog when URL points to no feed.
2019-04-07 14:56:15 -07:00
1928411694
bugfix #3088 - bulk edit - make UI survive upon split screen
2019-04-07 14:27:29 -07:00
156a20734a
Fix Sonic playback
2019-04-07 12:54:12 +02:00
2c9cb25eda
Merge branch 'develop' into exoplayer-main-thread
2019-04-07 11:52:24 +02:00
3fdf6af1a3
Merge pull request #2974 from orionlee/bugfix_rxjava2_null_returns_2966
...
Fix rxjava2 null returns
2019-04-07 11:35:13 +02:00
ebe32e795a
Executing all ExoPlayer methods on main thread
2019-04-07 00:19:02 +02:00
e16f44ad5d
bugfix - rxjava2 null return - wrap nullable return with Optional
2019-04-06 14:22:53 -07:00
20f1445c06
fix rebase conflicts - remove the incorrect @NonNull from rxjava
2019-04-06 14:19:16 -07:00
c04f340ae2
#2966 RxJava2 null - case underlying method has needs to return null.
...
Need to wrap return result with Optional<>
Mark code path with TODO. Actual fix is pending #2954 merge.
Rx observer: underlying sources that need to return Optional<>
OnlineFeedViewActivity.parseFeed : <anonymous subscriber>
PlaybackController.bindToService : fixed in #2954
2019-04-06 13:43:12 -07:00
1655d234af
#2966 RxJava2 null - case the underlying method may return null, but
...
should never happen in the code path, e.g.,
return the current FeedItem in ItemFragment UI.
Mark underlying method as @Nullable, and let observer's existing
onError() to handle null case
Rx observer : underlying sources marked as @Nullable
ItemFragment.load : .loadInBackground
MediaplayerActivity.checkFavorite : DBReader.getFeedItem
ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem
ItemlistFragment.loadItems : .loadData
2019-04-06 13:43:11 -07:00
0472bb9237
#2966 RxJava2 null - explicit mark underlying Rx sources as NonNull
...
to be on the safe side, for cases that the consuming observers checks null
unnecessarily.
Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.startFeedDownload : Downloader.getResult
AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData
PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory
QueueFragment.loadItems : DBReader.getQueue
SearchFragment.search : .performSearch
2019-04-06 13:43:11 -07:00
670fc124eb
#2966 RxJava2 null - explicit mark underlying Rx sources as NonNull
...
to be on the safe side, for cases that the consuming observers
already assumes the result is not null.
Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.listener member : DBReader.getFeedList
StatisticsActivity.loadStatistics : DBReader.getStatistics
CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt
CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems
DownloadLogFragment.loadItems : DBReader.getDownloadedItems
ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes
SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData
SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead
PreferenceController.export : ExportWorker.output member
2019-04-06 13:43:11 -07:00
5f86af88b1
Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145
...
Bulk remove from queue
2019-04-06 21:45:55 +02:00
31194e02a5
Merge pull request #3093 from AntennaPod/bugfix/3084-queue-undo-single
...
Create new adapter to show single item after undo
2019-04-06 21:32:36 +02:00
74fdabba69
Show single item after undo in EpisodesFragment
2019-04-06 21:32:03 +02:00
cb14fd930f
refactor - rename string resource name `remove_episode_lable` , which was ambiguous with typos, to `delete_episode_label`
...
- non-default string resources to be handled by Transifex
2019-04-06 11:27:20 -07:00
075547947e
tweak - batch edit UI - support longer action label
2019-04-06 11:15:35 -07:00
3bf880e34a
remove comment to reduce mental work per review feedback
2019-04-06 11:15:35 -07:00
86bf3ef3e0
remove outdated comment - support for vector drawables for pre Android 5 devices is here to stay.
2019-04-06 11:15:34 -07:00
0204c1cebd
tweak - bulk edit UI - remove hiding FAB during scroll per review feedback
2019-04-06 11:15:34 -07:00
3311b4371e
tweak - bulk edit UI - use Snackbar for selection message
...
- to be consistent with the action message in previous commit.
2019-04-06 11:15:34 -07:00
cc43af110a
tweak - bulk edit UI - show a message after an action is applied.
2019-04-06 11:15:14 -07:00
46f7805a96
refactor - bulk edit UI - make fab clickable on Pre-Lollipop devices without custom codes.
2019-04-06 11:12:34 -07:00
6c3033409d
Create new adapter to show single item after undo
2019-04-06 16:28:07 +02:00
b3fbf0b4aa
refactor - UI - remove the old (and now used) select all / none /intermediate icons
2019-04-04 14:05:51 -07:00
836334798d
refactor - UI - make OPML import screen use the new select all / none icons as well (so that only single set of icons are needed)
2019-04-04 13:58:50 -07:00
d186309066
bulk edit - UI - new select all / none icons, based on
...
standard Material icons.
2019-04-04 13:50:55 -07:00
dfe2241b4c
bulk remove episodes from queue - UI - icon for dark themes.
2019-04-04 13:12:09 -07:00
4797d3ae56
Merge pull request #3086 from ByteHamster/fix-double-slash-url
...
Specifying base url
2019-04-04 19:06:34 +02:00
H. Lehmann
ByteHamster
Martin Fietz
orionlee