Commit Graph

5860 Commits

Author SHA1 Message Date
orionlee 69c0022472 code style fixes - naming, indentation, etc. 2019-11-05 12:34:11 -08:00
orionlee 418d4fa4d4 bugfix respect download order - obey user settings "Enqueue Downloaded" 2019-11-05 12:34:11 -08:00
orionlee fb6fa010f8 Enqueue tweaks - replace custom stub DownloadStateProvider with mockito mocks in test 2019-11-05 12:34:11 -08:00
orionlee 2f82a5d464 refactor - rename FeedFileDownloadStatusRequesterInterface to a more generic DownloadStateProvider. 2019-11-05 12:34:11 -08:00
orionlee cd3d20d613 refactor - move ItemEnqueuePositionCalculator to top-level per review. 2019-11-05 12:33:58 -08:00
orionlee 2d1ee52014 fix imports post androidX migration 2019-11-05 11:04:23 -08:00
orionlee fb7fb05b5e test case tweak: preserve download order test, fix test case name
(remove the incomplete expected from test case name)
2019-11-05 11:04:23 -08:00
orionlee 820b0b0793 test case bug fix: Bulk download 2nd item position should be 1 2019-11-05 11:04:23 -08:00
orionlee ce5aa26878 refactoring test - factor out common operations of calc position,
add to queue and verify result into common helper.
2019-11-05 11:04:23 -08:00
orionlee fb824b541d Test cases readability: change expected format from position to the actual queue
(list of IDs), to make the test case more readable.
2019-11-05 11:04:23 -08:00
orionlee 97905e5ed4 #2448: make podcast episode enqueue position respect download start order 2019-11-05 11:04:17 -08:00
orionlee 0973efa943 refactor test - break ItemEnqueuePositionCalculatorTest to be more modular
to prepare for testing more complex enqueue options.
2019-11-05 10:54:21 -08:00
orionlee 17e61335db #2652 (part of): Expose keep in-progress at front as a preference
(in Playback > Queue section)
2019-11-05 10:54:21 -08:00
orionlee 30f104f40b #2652 (part of): The in-progress podcast at the front of the queue
should remain at the front.
2019-11-05 10:54:21 -08:00
orionlee bfde3c7315 refactor - DBWriterTest: parametrize the set of tests 2019-11-05 10:54:21 -08:00
orionlee ba27ec6b31 refactor - DBWriter.addQueueItem() : refactor enqueue position calculation
to be a unit-testable component (static inner class)
2019-11-05 10:54:21 -08:00
ByteHamster 8aff9709c3 Style OnlineFeedViewActivity like a dialog
User study showed that new users do not get the difference between the actual
feed list and the preview. If the preview is a dialog, this is a lot easier to see.
Additionally, the "dialog" now closes after the subscription succeeded.
2019-11-05 15:28:32 +01:00
ByteHamster 9d5abba312 Modified episode swipe directions
- Allow queue swiping in both directions
- Do not allow swiping on tabbed screens where it interferes with tab switching
2019-11-03 23:47:15 +01:00
sevenmaster 363c3614f8 episodes should not look like a link (#3576) 2019-11-01 14:26:04 +01:00
sevenmaster 59b3e4bf11 Make search button clickable (#3577) 2019-11-01 08:05:01 +01:00
sevenmaster 386395629b Clearer button text for feching podcast (#3575)
When subscribing to a podcast, the old text might be confusing to new users (it's not downloading an episode, just the feed. That is not considered downloading for most users)

Signed-off-by: sevenmaster <seven-master@hotmail.de>
2019-10-31 23:00:39 +01:00
H. Lehmann 2a2ced1631
Merge pull request #3572 from ByteHamster/downloadservice-refactoring
DownloadService refactoring
2019-10-31 09:23:47 +01:00
H. Lehmann e7367e218d
Merge pull request #3571 from ByteHamster/hide-play-button-on-destroy
Updating notification play button in onDestroy
2019-10-30 19:30:20 +01:00
ByteHamster 69f3a1210f Do not refresh feeds more often than necessary 2019-10-30 19:27:38 +01:00
ByteHamster 6825cca32a Updating notification more often 2019-10-30 18:19:36 +01:00
ByteHamster dd5ba4d38d Do not access context in constructor 2019-10-30 18:16:34 +01:00
ByteHamster ea6b41116f Extracted DownloaderFactory to new class 2019-10-30 18:16:26 +01:00
ByteHamster 8f168948ad Reordered methods to have setup on top 2019-10-30 18:06:44 +01:00
ByteHamster 366e60990d Posting downloaders on executor 2019-10-30 18:05:26 +01:00
ByteHamster fe17f1bcb5 Extracted handling completed downloads to method 2019-10-30 17:51:22 +01:00
ByteHamster 74621170fe Converted our own FeedSyncThread to a task+executor 2019-10-30 11:10:44 +01:00
ByteHamster 798868db9c Extracted notification from DownloadService 2019-10-29 23:58:44 +01:00
ByteHamster 056d7db16b Extracted feed sync from DownloadService 2019-10-29 23:39:29 +01:00
ByteHamster 7ae5424479 Updating notification play button in onDestroy 2019-10-29 22:37:58 +01:00
H. Lehmann 091d2bb438
Merge pull request #3569 from PtilopsisLeucotis/fix-progress-string-on-widget
Fix incorrect progress string on widget
2019-10-29 09:51:34 +01:00
Ptilopsis Leucotis 917e60fbe2 Fix incorrect progress string on widget
If option "pref_followQueue_title" is disabled, when played episode #1 is ended and next episode #2 is loaded, progress string on widget show incorrect information about position and duration of episode, because it show (position / duration) of ended episode #1 instead of (position / duration) of loaded episode #2.
2019-10-29 11:16:06 +03:00
H. Lehmann 3b51af00e3
Merge pull request #3567 from ByteHamster/prefer-image-from-feed
Prefer image that is specified in feed over embedded image
2019-10-28 13:30:35 +01:00
ByteHamster 20e025bd2e Prefer image that is specified in feed over embedded image 2019-10-27 22:52:41 +01:00
H. Lehmann eb5514c764
Merge pull request #3566 from sevenmaster/newGradleVersion
new gradle version
2019-10-27 16:16:41 +01:00
H. Lehmann 3c052d01bc
Merge pull request #3565 from mdeveloper20/fix-talkback-support
Add support for talkback on subscription and discovery list, Fixes #3563
2019-10-27 16:06:52 +01:00
sevenmaster 7b6ec1f73e new gradle version, this should fix #3562 2019-10-27 15:53:44 +01:00
Masoud Pezeshkzade 360446a445 Add support for talkback on subscription and discovery list, Fixes #3563 2019-10-27 18:14:39 +03:30
H. Lehmann c6fd6d0e53
Merge pull request #3561 from orionlee/refactor_batch_edit_sort
Refactor batch edit - use the common FeedItem sorting logic
2019-10-27 09:01:12 +01:00
orionlee 197a7b1f1a Refactor batch edit - use the common FeedItem sorting logic 2019-10-25 14:41:51 -07:00
H. Lehmann 49c9e19c0d
Merge pull request #3559 from ByteHamster/test-more-stable
Making sure that tests click on preference, not preferenceCategory
2019-10-25 16:05:43 +02:00
ByteHamster 369b89f1db Making sure that tests click on preference, not preferenceCategory 2019-10-25 15:29:54 +02:00
ByteHamster 92c3287651 Fixed about screen logo getting removed by proguard 2019-10-25 12:17:05 +02:00
ByteHamster 0407d27e99 Fixed EventBus getting removed by proguard 2019-10-25 11:54:06 +02:00
H. Lehmann 76b913b154
Merge pull request #3558 from ByteHamster/more-eventbus-migration
Removed EventDistributor, replaced with EventBus
2019-10-25 11:43:02 +02:00
H. Lehmann 57818ade38
Merge branch 'develop' into more-eventbus-migration 2019-10-25 11:40:18 +02:00