Commit Graph

2895 Commits

Author SHA1 Message Date
ByteHamster d6e0799a21 Updated translations 2021-04-02 17:49:08 +02:00
ByteHamster 2df3cf9fe7 Rename audio player tabs 2021-04-02 17:14:01 +02:00
Tony Tam 843892e34f
Safer remain time - default to zero when the media duration is wrong (#5043) 2021-04-02 14:30:21 +02:00
ByteHamster ea4488c181 Fixed new SpotBugs violations after merging to develop 2021-03-28 22:57:48 +02:00
ByteHamster 7465b747f3
Merge pull request #5055 from ByteHamster/spotbugs
Add SpotBugs CI check
2021-03-28 22:46:37 +02:00
ByteHamster 998535515b Make AntennaPod pass the medium SpotBugs findings 2021-03-28 22:32:40 +02:00
ByteHamster b1e15e8704 Removed unused methods that caused SpotBugs violations 2021-03-27 21:52:11 +01:00
ByteHamster 71184ee5d4 Fixed SpotBugs violations, so that at least the most severe checks pass 2021-03-27 20:44:35 +01:00
ByteHamster 6b9821a1f9
Merge pull request #5052 from ByteHamster/stop-service-properly
Stop service properly when playback ends
2021-03-27 12:20:31 +01:00
ByteHamster 4f5d076cb9 Stop service properly when playback ends 2021-03-26 18:59:14 +01:00
ByteHamster 68e70d1b6b Show cover and shownotes for previewed episodes 2021-03-26 18:56:38 +01:00
Joschua Gandert 241935c601
Fixed certain file types not being recognized in local feeds (Closes #4802) (#5039) 2021-03-22 10:16:51 +01:00
datavizard b276c34942
Adds a visual cue to the podcast header view whenever updates are disabled (#5014) 2021-03-10 13:30:45 +01:00
ByteHamster 2cbcdb97d1 Fixed getting next page of feed 2021-03-10 12:18:01 +01:00
ByteHamster b05d877954 Fixed animation when hiding drawer items 2021-03-09 17:55:57 +01:00
ByteHamster 962edc6778 Updated translations 2021-03-08 10:36:13 +01:00
ByteHamster a49b4477a9
Merge pull request #5010 from ByteHamster/crash-fix
Various crash fixes reported in the beta
2021-03-08 10:15:20 +01:00
ByteHamster 0172a5db13 Nullability checks in ExoPlayerWrapper 2021-03-07 20:00:09 +01:00
ByteHamster 7a3bb825ed Fixed calling bindService if service is not running 2021-03-07 19:57:35 +01:00
ByteHamster 14c81265dc
Merge pull request #5006 from ByteHamster/podcast-specific-speed
Clear temporary playback speed when switching to another episode
2021-03-07 12:18:31 +01:00
ByteHamster 1646ba4088 Clear temporary playback speed when switching to another episode 2021-03-07 11:35:50 +01:00
ByteHamster db70129537 Stop playback of deleted podcast even if it is just streaming 2021-03-07 11:11:31 +01:00
ByteHamster d3bf107363 Fixed download service notification not being updated to 'Stopping service' 2021-03-06 21:00:26 +01:00
ByteHamster ef24f6d1f4 Fixed local folders ending up in DownloadService 2021-03-06 20:59:16 +01:00
peakvalleytech f90656d213
Show podcast-specific settings in preferences search (#4990) 2021-03-06 20:44:15 +01:00
ByteHamster bc073ff38f Removed metadata loader from model 2021-03-05 17:44:33 +01:00
ByteHamster d54ce2f8b1 Code cleanup 2021-03-05 16:55:55 +01:00
ByteHamster 3f21ef50d3 Added basic tag editor UI 2021-03-05 14:12:07 +01:00
ByteHamster e86905e4c8 Sort folders to the end 2021-03-05 12:56:23 +01:00
ByteHamster 627bd35500 Fixed folder ID generation 2021-03-05 10:56:54 +01:00
ByteHamster f76d3ad09e Merge branch 'develop' into folders 2021-03-05 10:12:35 +01:00
ByteHamster cfa873af6d Removed ShownotesProvider interface 2021-03-04 22:58:13 +01:00
ByteHamster f62a6b808e Only store content_encoded or description 2021-03-04 19:47:48 +01:00
ByteHamster 9dbe5f6de5 Merge branch 'master' into develop 2021-03-04 19:23:03 +01:00
ByteHamster 8426971161 Updated translations to avoid Lint error 2021-03-04 12:37:29 +01:00
ByteHamster 2e750effa1 Make errors on 'add feed' page more pretty 2021-03-04 12:10:01 +01:00
ByteHamster 6020f481c5 Mention ad blockers in certificate error message 2021-03-04 11:49:36 +01:00
ByteHamster 4872ea76f4 Show the name of failing downloads in the notification 2021-03-04 11:23:08 +01:00
ByteHamster d4141d19a0 Described download errors in more detail 2021-03-04 11:15:44 +01:00
ByteHamster 352df348cb Show dedicated error message when an app messes with the network 2021-03-04 10:45:19 +01:00
ByteHamster 878da84666 Formatted with spaces 2021-03-04 10:23:05 +01:00
ByteHamster dd8341a858 Replace Java-based feed filtering with SQL-based 2021-03-03 18:23:29 +01:00
ByteHamster bb12f6b04c Removed unused helper class 2021-03-03 14:33:20 +01:00
ByteHamster 8f1b91c733 Merge branch 'master' into develop 2021-03-03 14:32:28 +01:00
ByteHamster 931941f4a3 Updated translations 2021-03-03 11:37:23 +01:00
ByteHamster 213099fec6
Merge pull request #4981 from ByteHamster/remove-optional
Removed our re-implementation of 'Optimal' and used the RxJava equivalent instead
2021-03-03 11:23:50 +01:00
ByteHamster 3dadbbf249
Merge pull request #4983 from ByteHamster/fix-error-message-wrong-size
Fixed wrong error message
2021-03-01 23:03:20 +01:00
ByteHamster 3bfe69219f Fixed wrong error message 2021-03-01 20:54:24 +01:00
ByteHamster e59767890e Removed our re-implementation of 'Optimal' and used the RxJava equivalent instead 2021-03-01 20:47:05 +01:00
ByteHamster 3ebbacdf60 Removed ExternalMedia
It was used for "open with" actions, which are no longer supported.
We have the local folders feature for that now.
2021-03-01 20:21:25 +01:00
ByteHamster d444e8d23e
Merge pull request #4978 from ByteHamster/remove-chapter-loader-from-model
Removed chapter loader from model
2021-03-01 20:13:39 +01:00
ByteHamster 3f6cb57ffe
Merge pull request #4976 from ByteHamster/net-ssl
Moved SSL providers to new module
2021-03-01 20:07:36 +01:00
ByteHamster 91f613b4de Fixed crash when notification updater is null 2021-03-01 19:53:41 +01:00
ByteHamster b7d34e0514 Removed chapter loader from model 2021-03-01 16:54:39 +01:00
ByteHamster 0e94aa5d9d Moved SSL providers to new module 2021-03-01 16:21:39 +01:00
ByteHamster a6702bbcb5
Merge pull request #4972 from ByteHamster/chapter-demo-file
Added chapter parser test files from Hindenburg Journalist Pro
2021-03-01 11:26:05 +01:00
ByteHamster ddd6a12354 Merge branch 'master' into develop 2021-03-01 11:24:39 +01:00
ByteHamster c4f036c06c
Merge pull request #4963 from a1291762/develop
Avoid the stuck download notification
2021-03-01 10:09:28 +01:00
Lincoln Ramsay 8755a54e99 Change the message that appears when downloads are finished
In the event that the notification hangs around, this is a more
accurate description of what is happening.
2021-03-01 07:13:33 +10:00
ByteHamster 5431026adf Added chapter parser test files from Hindenburg Journalist Pro
Thanks to the Sendegate community!
https://sendegate.de/t/gesucht-beispieldateien-mit-kapitelmarken/13228
2021-02-28 21:49:13 +01:00
Herbert Reiter 47a0336c3e
Refactoring: Remove Cursor related code from Feed class (#4968) 2021-02-28 14:16:07 +01:00
Lincoln Ramsay fcbbaa4060 Avoid stuck download notifications
Cancel the periodic updater before calling stopForeground so
that the notification can't come back after it has been closed.

Remove the workaround for API 30 slow notification closing because
it can cause a stuck notification. However, in order to avoid misleading
text being left on the notification if it closes slowly, ensure that
the "0 downloads" text is written to the notification when shutting down.

Fixes #4556
2021-02-28 09:34:25 +10:00
ByteHamster cc3e0c38d2 Removed DbWriter dependency from model 2021-02-26 11:10:00 +01:00
Herbert Reiter 39f9796656
Refactoring: Move inner classes PlayableUtils and PlayableException out of Playable (#4962) 2021-02-25 23:17:34 +01:00
MStrecke 519d6ce9d6
use full URL for custom gpodder server (#4932) 2021-02-25 23:08:00 +01:00
Herbert Reiter 1cd680a2af
Remove interface ImageResource (#4911) 2021-02-24 15:44:40 +01:00
ByteHamster 2c70db7074 Remove free build hack 2021-02-23 17:11:32 +01:00
ByteHamster 82dc41d813
Merge pull request #4950 from ByteHamster/fix-file-not-found
Fixed rare 'file not found' errors when starting playback
2021-02-23 10:07:38 +01:00
ByteHamster 353aeb5d8d
Merge pull request #4954 from damoasda/FeedItem-description
Improve FeedItem class documentation
2021-02-23 10:01:24 +01:00
ByteHamster 6add59819a Added auphonic files to chapter marks tests
We currently don't have a parser for the m4a file but I just committed
the file for later.
2021-02-22 17:11:40 +01:00
Herbert Reiter 8bffe2beda Improve FeedItem class documentation 2021-02-21 16:00:21 +01:00
ByteHamster 949260658b Fixed rare 'file not found' errors when starting playback
The `getPlayLastPlayedMediaIntent` method was originally added in 2013
to avoid starting the service without a media file. The bind method
should actually never need to start the service in the first place,
though.
2021-02-19 21:22:19 +01:00
ByteHamster 8fdd034e9e Added a real file to test chapters with
Thanks to the Sendegate community
https://sendegate.de/t/gesucht-beispieldateien-mit-kapitelmarken/13228
2021-02-19 14:21:44 +01:00
Yaron Shahrabani 7b39ef8953
Fixed typo
Epsiodes->Episodes
2021-02-18 00:57:48 +02:00
ByteHamster 12e22849e6 Added more id3 parser tests 2021-02-17 14:48:31 +01:00
ByteHamster 28d6551dbc Removed plural form because Transifex only allows 2 forms in English 2021-02-17 11:39:30 +01:00
ByteHamster 9e68b8b0a3 Fixed NPE when loading ogg chapters 2021-02-16 16:09:18 +01:00
ByteHamster 3f1c1c4bf5 Rewrite chapter parser for testability 2021-02-16 14:39:49 +01:00
ByteHamster 0f692be2d4
Merge pull request #4940 from ByteHamster/more-reliable-chapters
More reliable chapter loading
2021-02-16 09:39:23 +01:00
ByteHamster 4f2dcc189c Fix parsing chapters with multiple null bytes
Previously, we relied on the string to fill the complete frame.
Some podcasts terminate the string early and leave some garbage in
the frame data. Skip that garbage, so that the reader is at a valid
frame header position when starting the next iteration.
2021-02-15 23:13:29 +01:00
ByteHamster 57587c928e Removed method that does the same as loadMediaInfo anyway 2021-02-15 22:02:55 +01:00
ByteHamster 339aa936bf Removed return parameter of loadMediaInfo
We return true anyways. The call for actually loading is asynchronous,
so returning anything here does not make sense.

Reduces likelihood of loader being interrupted to just load the same
item again when the state changes.
2021-02-15 21:56:06 +01:00
Geist5000 aaeea78b37
changed the "Use Episode Cover" setting to only apply to list items. (#4908) 2021-02-15 16:04:03 +01:00
ByteHamster 42ce907aaf
Merge pull request #4936 from ByteHamster/chapter-reader
Simplified chapter reader
2021-02-15 15:21:49 +01:00
ByteHamster b1bf77d4e3 New workaround for hiding the notification directly 2021-02-15 11:44:02 +01:00
ByteHamster 4aa5443529 Refresh all feeds at once instead of sending tons of lists with 1 feed each 2021-02-15 11:43:57 +01:00
ByteHamster 52421d81f7 Removed some unnecessary calls to startForeground 2021-02-15 11:28:03 +01:00
ByteHamster 5a234a367d Simplified chapter reader
No longer uses code duplication for opening local and remote streams.
Also, switched to OkHttp to handle redirects.
2021-02-15 11:08:00 +01:00
ByteHamster 66ae028719 Merge branch 'master' into develop 2021-02-14 22:44:08 +01:00
Tony Tam f57cf0c317
New preference to show the remaining time in the 'queue' and podcast episode view (#4880) 2021-02-14 12:18:27 +01:00
ByteHamster 010ed376cd Move basic views to new module 2021-02-12 21:00:39 +01:00
ByteHamster 24ea4708ea Remove PlaybackServiceCallbacks 2021-02-12 18:08:58 +01:00
Herbert Reiter 60968089ae
Refactoring: Remove ClientConfig.automaticDownloadAlgorithm (#4924) 2021-02-07 17:57:09 +01:00
Jonas Kalderstam ae8759869d Fixed default number of items to clean up
Not sure why this worked before TBH - but default value should
naturally be to reduce to desired cache size.

Probably makes no difference in actual use - but it is how the tests
are constructed.
2021-02-06 21:43:34 +01:00
Jonas Kalderstam 3a9e1fc2dd
Applied code review suggestions
Co-authored-by: ByteHamster <ByteHamster@users.noreply.github.com>
2021-02-06 15:54:25 +01:00
Jonas Kalderstam 08edd151f9 Added new cleanup option: when not favorited
This is another way of solving #2077.

The root issue is that queued episodes are never auto-deleted
currently which means that if you automatically add episodes to the
queue you will eventually end up with AntennaPod refusing to auto
download more episodes because the cache is full and it can't make
space.

This option will only refuse to delete favorited items. Otherwise it
will simply delete the oldest episodes.
2021-02-05 11:15:22 +01:00
ByteHamster aa64ae132f Updated translations 2021-02-04 13:05:40 +01:00
ByteHamster 9924952e2f
Merge pull request #4900 from ByteHamster/decouple-widget
Reduce coupling between widget and playback service
2021-02-03 23:56:33 +01:00
ByteHamster b6f72f8847 Reduce coupling between widget and playback service
Instead of binding to the service, pass the required data. This also
ensures that the widget is updated instantly when calling from
PlaybackService. JobService had the problem that the OS sometimes
took some seconds before actually executing the job.
2021-02-03 23:37:51 +01:00
Tim Schumacher 1297a16850
Allow remapping hardware buttons (#4881) 2021-02-03 12:50:01 +01:00