Commit Graph

4095 Commits

Author SHA1 Message Date
Andrew Gaul 278e93880e Prefer StringBuilder over StringBuffer
The latter has unnecessary synchronization.  Found via error-prone.
2018-01-21 13:04:57 -08:00
Martin Fietz f7c048e5b4 Update translations 2018-01-21 11:00:15 +01:00
Martin Fietz e6498393a6
Merge pull request #2445 from ByteHamster/export
Database import/export
2018-01-21 10:51:16 +01:00
Martin Fietz 9adbf83182
Merge pull request #2543 from gaul/static-final
Make some static fields final
2018-01-21 10:03:52 +01:00
Martin Fietz 5abaa77551
Merge pull request #2542 from gaul/static-inner-class
Make some inner classes static
2018-01-21 10:03:12 +01:00
Andrew Gaul 404f241891 Make some static fields final
Adding final prohibits modification and allows initialization of
primitive and String fields at compile time instead of runtime in
clinit:

https://developer.android.com/training/articles/perf-tips.html#UseFinal

Found via error-prone.
2018-01-20 18:28:21 -08:00
Andrew Gaul 118d9103c1 Make some inner classes static
This avoids an implicit this field and can help GC.  Found via
error-prone.
2018-01-20 18:26:08 -08:00
Martin Fietz b98571ede8 Update gradle wrapper 2018-01-13 15:46:23 +01:00
H. Lehmann 2c9582c947
Merge pull request #2534 from AntennaPod/sdk_int_lt_14
Replace code for SDK version lower than 14
2018-01-10 18:26:54 +01:00
H. Lehmann 0614b53400
Merge pull request #2533 from AntennaPod/remove_preference_activity_gingerbread
Remove PreferenceActivityGingerbread
2018-01-10 18:17:54 +01:00
H. Lehmann be569bfb14
Merge pull request #2531 from AntennaPod/remove_nineoldandroids
Replace ViewHelper
2018-01-10 15:24:34 +01:00
H. Lehmann 8969e1cbb6
Merge pull request #2532 from AntennaPod/execute_on_executor
Cleanup executeAsync
2018-01-10 15:16:51 +01:00
Martin Fietz f756cd84d1 Remove unnecessary annotations 2018-01-09 21:06:13 +01:00
Martin Fietz 89366d97d1 Replace code for SDK version lower than 14 2018-01-09 21:03:30 +01:00
Martin Fietz fe8993803d Replace lambda with method reference 2018-01-09 20:21:57 +01:00
Martin Fietz df131cdd0d Replace with lambda 2018-01-09 20:20:32 +01:00
Martin Fietz 7e0a958f8a Use guard clause 2018-01-09 20:20:18 +01:00
Martin Fietz 1694432560 Delete PreferenceActivityGingerbread 2018-01-09 20:19:38 +01:00
Martin Fietz 59a1b4a2bb Cleanup executeAsync 2018-01-09 20:13:14 +01:00
Martin Fietz eaf007ecac Replace ViewHelper 2018-01-09 19:59:51 +01:00
Martin Fietz b1c212c2fc
Merge pull request #2525 from dirkmueller/video_aspect
Set video aspect on initial creation
2018-01-08 22:59:01 +01:00
Martin Fietz 0c662530b9
Merge pull request #2526 from dirkmueller/min_sdk_14
set minSdkVersion to 14
2018-01-08 22:57:03 +01:00
Dirk Mueller dfa8766754 set minSdkVersion to 14
According to https://developer.android.com/about/dashboards/index.html
API levels of 14 and lower are only on less than 0.5% of the devices.
IMHO it is time to move on, and allow for some compat code cleanup.
2018-01-08 22:12:15 +01:00
Dirk Mueller 32215ffc28 Set video aspect on initial creation
Previously on first start of a video the aspect ratio
was not correct (annoying on a 18:9 phone as
it doesn't match the usual 16:9 aspect ratio). So extract
the code into a setupVideoAspectRatio() helper
and call it from surfaceCreated as well.
2018-01-08 11:20:14 +01:00
ByteHamster dc316074e8 Simplified onActivityResult 2018-01-07 20:19:29 +01:00
ByteHamster 12456b52de Using FileUtils.copyInputStreamToFile 2018-01-07 20:17:18 +01:00
ByteHamster 4c00f76494 Closing correctly 2018-01-07 20:14:49 +01:00
Martin Fietz fc4057d2c6
Merge pull request #2521 from dirkmueller/jsoup_bump
Update jsoup to 1.11.2
2018-01-07 20:11:08 +01:00
Martin Fietz 4d156118cc
Merge pull request #2520 from dirkmueller/include_cleanup
Cleanup order/remove unused includes
2018-01-07 20:11:01 +01:00
ByteHamster bc9bd0bfcf Style changes and logging 2018-01-07 20:09:28 +01:00
Martin Fietz 358f33553e
Merge pull request #2522 from dirkmueller/layout_cleanup
remove reference to nonexisting onClick callback
2018-01-07 19:38:12 +01:00
Martin Fietz 84e2748874
Merge pull request #2519 from dirkmueller/develop
Return START_STICKY from onStartCommand()
2018-01-07 19:36:54 +01:00
Dirk Mueller 602754104e remove reference to nonexisting onClick callback
This defined onClick callback does not exist, so we
don't need to specify it.
2018-01-07 19:32:10 +01:00
Dirk Mueller ad09587298 Update jsoup to 1.11.2
jsoup 1.11.1 features a 30% lower DOM memory footprint, streaming
network HTML parsing, faster HTML generation, and a bunch of other
improvements and bug fixes.

See https://jsoup.org/news/release-1.11.1 and
https://jsoup.org/news/release-1.11.2 (with the followup bugfixes)
for details.
2018-01-07 19:27:50 +01:00
Dirk Mueller bbbff0bc73 Cleanup order/remove unused includes
This is the result of Android Studio's include cleanup
Macro. This removes some no longer used includes, simplifying
the code a bit. The rest is grouping and resorting alphabetically.
2018-01-07 19:26:23 +01:00
Dirk Mueller 234e3ddbc2 Fix small whitespace error
This causes Android Lint to barf as it can not detect
the VIBRATE permission being requested.
2018-01-07 15:51:04 +01:00
Dirk Mueller 9de74f1dff Return START_STICKY from onStartCommand()
The _FLAG_ variant is the input enum, replace it
with the value-equivalent properly typed enum.
2018-01-07 15:46:34 +01:00
Martin Fietz dc5be358af
Merge pull request #2515 from ByteHamster/fix-shared
Fixed video view
2018-01-06 13:57:18 +01:00
ByteHamster 2e98119d47 Fixed video view
Bug was introduced in #2457, shared element does not exist in video view
2018-01-06 12:33:38 +01:00
Martin Fietz 8b84b70032
Merge pull request #2333 from ByteHamster/item-height
Improved list items when using a large font size
2018-01-04 22:10:49 +01:00
Martin Fietz 204c97b8de
Merge pull request #2339 from ByteHamster/save-file-url
Setting File_url when starting download
2018-01-04 20:05:59 +01:00
Martin Fietz dc970d52d8 Update translations 2018-01-03 19:06:11 +01:00
Martin Fietz f8343773db To not redeliver intents to fix issues on Oreo 2018-01-03 19:04:10 +01:00
Martin Fietz 68754684b7
Merge pull request #2457 from ByteHamster/sharedElement
Shared element transition
2018-01-03 18:52:11 +01:00
Martin Fietz 79d2b068ac
Merge pull request #2504 from kroegerama/develop
Resolves #2475 (Headset button press not correctly handled)
2018-01-03 18:50:25 +01:00
H. Lehmann d3d47726ff
Merge pull request #2512 from sevenmaster/develop
Adjust text color in widget
2018-01-02 21:00:26 +01:00
seven-master@hotmail.de 80309b42ca Adjust text color; Closes #2466 2018-01-02 20:25:15 +01:00
ByteHamster 3fd3db6c57 Review changes 2017-12-25 22:42:41 +01:00
ByteHamster d36f4b6a87 Updated phrasing 2017-12-24 13:18:05 +01:00
ByteHamster b665792d29 Cleanup import/export 2017-12-24 13:11:57 +01:00