Commit Graph

6679 Commits

Author SHA1 Message Date
Mats Wahlberg 06d212b911 Use freeImplementation for including conscrypt in Free builds.
This removes the need for the -PfreeBuild flag to gradle, and makes
assemblePlay and assembleDebug build all flavours without errors again.
Changed circleci config back accordingly and removed comment about
-PfreeBuild. Based on #4457.
2020-10-02 14:39:02 +02:00
Mats Wahlberg 468acab8f4 Removed comment about automatically choosing Conscrypt version
There are drawbacks to using conscryptVersion = "latest.release",
hopefully the version will be kept up to date manually instead.
2020-09-30 13:52:31 +02:00
Mats Wahlberg 30268d73d1 Cleaned up string to println in core/build.gradle
Variable can be used and gets replaced directly in the string without
using '+' to concatenate strings.
2020-09-30 13:52:31 +02:00
Mats Wahlberg 3271d7628f Fixed circle static-analysis error
No code changes, but formatting with comments around else statements
needed to be clearer, also some whitespaces should have been avoided...
2020-09-30 13:52:31 +02:00
Mats Wahlberg 4f86047a24 Enable TLSv1.3 and harden protocols and cipher suites for Free builds
The Free build bundles a modern Conscrypt which means TLSv1.3 is always
guaranteed no matter android version. So it can always be enabled. Since
it also provides modern cipher suites, there is no need to enable older
protocols than TLSv1.2 (that is: SSLv3, TLSv1.0 and TLSv1.1 which are
all now deprecated).

And the support for modern cipher suites also means there is no need to
explicitly enable the following (obsolete+unsafe) ciphers suites:
 * TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA
 * TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
on Android API < 21 (Android < 5.0).

No changes are made to the Play builds (since the available security
provider can't be guaranteed to support modern protocols and cipher
suites).
2020-09-30 13:52:31 +02:00
Mats Wahlberg 3f0420544a Updated circleci debug and release jobs to explicitly build Play flavors
Changed the gradlew build targets assembleRelease to assemblePlayRelease
and assembleDebug to assemblePlayDebug, because the old targets causes
files for the free builds to get compiled when not needed. It's
unnecessary and also done without -PfreeBuild which gives build errors.

These are also the targets used in makeRelease.sh, so the workflow
should better match the expected.
2020-09-30 13:52:31 +02:00
Mats Wahlberg 4c24d1c29a Bundle Conscrypt security provider for Free builds
This fixes protocol and cipher errors on older versions of android
without requiring Google API/Services (which are non-free) to replace
the security provider from the OS. No changes are made to Play builds.

The value of conscryptVersion in build.gradle should be updated
regularly to keep the bundled version of conscrypt up to date (or
changed to "latest.release", which will cause issues with verifying
reproducible builds).

Fixes: #2814 (for users of free builds)
2020-09-30 13:52:31 +02:00
H. Lehmann 746190106f
Merge pull request #4439 from ByteHamster/item-without-feed-hotfix
Fixed crash when item has no feed
2020-09-20 12:32:39 +02:00
H. Lehmann 490ae5ec1f
Merge pull request #4438 from ByteHamster/description-crash-hotfix
Fixed crash (fromCallable rethrows instead of calling onError)
2020-09-20 11:56:50 +02:00
ByteHamster 43d36c7560 Fixed crash when item has no feed
Apparently, there are ways to end up with items that have no feed.
This hotfix prevents the app from crashing but it does not solve the
reason for items without feeds.
2020-09-20 11:52:11 +02:00
H. Lehmann 4a339ff532
Merge pull request #4386 from ByteHamster/special-thanks
Added 'special thanks' screen
2020-09-20 08:57:05 +02:00
ByteHamster 3671188b0f Fixed crash (fromCallable rethrows instead of calling onError) 2020-09-20 08:52:25 +02:00
ByteHamster d38c7a442a Added 'special thanks' screen 2020-09-20 08:35:20 +02:00
H. Lehmann 694ba65dd0
Merge pull request #4437 from ByteHamster/providerinstaller-synchronous
Make ProviderInstaller synchronous again
2020-09-20 08:27:37 +02:00
H. Lehmann ae04b1d88f
Merge pull request #4436 from ByteHamster/remove-artwork
Removed artwork folder
2020-09-20 08:22:16 +02:00
ByteHamster 806b1f48ec Make ProviderInstaller synchronous again
See #4077 for details: It is fast and the old method sometimes does not install the provider early enough

Reverts #3946 and #4285
2020-09-19 21:27:01 +02:00
ByteHamster fdae07347b Removed artwork folder 2020-09-19 21:10:16 +02:00
H. Lehmann 689bdb69db
Merge pull request #4431 from ByteHamster/fix-scroll-position-reset
Fixed pages forgetting scroll position when switching tabs
2020-09-19 11:24:29 +02:00
H. Lehmann 571ebea12e
Merge pull request #4432 from ByteHamster/upgrade-appcompat
Upgraded AppCompat to fix WebView crashes
2020-09-19 11:22:58 +02:00
ByteHamster b75c05cca1 Upgraded AppCompat to fix WebView crashes 2020-09-18 23:11:38 +02:00
ByteHamster f3e3f9c4d1 Fixed pages forgetting scroll position when switching tabs 2020-09-18 23:07:10 +02:00
H. Lehmann dc454b9373
Merge pull request #4423 from tonytamsf/landscape-2
fix layout for 16:9 phone screens, squashed for #4334
2020-09-15 10:20:37 +02:00
Tony Tam da14ae58dc - better resizing for multiple screen ratios 2020-09-14 11:14:52 -07:00
H. Lehmann 25d2290643
Merge pull request #4412 from asdoi/playback_upates
Update skip/forward TextViews of AudioPlayerFragment
2020-09-09 22:20:09 +02:00
asdoi c4673662b2 update skip/forward value 2020-09-08 16:44:53 +02:00
H. Lehmann 06315821d5
Merge pull request #4344 from ByteHamster/parser-error-more-details
Be more verbose about invalid type errors
2020-08-04 09:25:16 +02:00
H. Lehmann 5a56fb6f0d
Merge pull request #4340 from damoasda/FeedItemlistFragment-NPE-fix
Fix NullPointerException in FeedItemlistFragment when deleting a podcast
2020-08-03 22:02:39 +02:00
Herbert Reiter 46b886baa3 Fix NullPointerException in FeedItemlistFragment when deleting a podcast 2020-08-03 21:43:19 +02:00
ByteHamster dd5b3cac0e Be more verbose about invalid type errors 2020-08-03 13:10:08 +02:00
H. Lehmann de70873e96
Merge pull request #4325 from ByteHamster/dispose-loader-before-null
Dispose loaders before setting controller to null
2020-07-31 23:01:18 +02:00
H. Lehmann 7603ab3403
Merge pull request #4326 from ByteHamster/remove-icon-poll
Remove icon poll from production version
2020-07-31 21:45:24 +02:00
ByteHamster 7e0dc71265 Revert "Added new icon poll"
This reverts commit cc04e08e74.
2020-07-29 00:31:23 +02:00
H. Lehmann 8fa1a9c03c
Merge pull request #4324 from ByteHamster/streaming-confirmation-dialog
Make mobile streaming dialog easier to understand
2020-07-27 14:27:56 +02:00
ByteHamster 426be4d226 Dispose loaders before setting controller to null 2020-07-27 13:16:23 +02:00
ByteHamster d86121746a Make mobile streaming dialog easier to understand 2020-07-27 11:33:53 +02:00
ByteHamster 4ddee03214 Bumped version to 2.0.0-RC7 2020-07-25 10:33:18 +02:00
ByteHamster fe67b6501b Updated translations 2020-07-25 10:32:54 +02:00
H. Lehmann 25dd5a3426
Merge pull request #4288 from ByteHamster/icon-poll
Added new icon poll
2020-07-25 10:28:49 +02:00
ByteHamster cc04e08e74 Added new icon poll 2020-07-25 10:15:00 +02:00
H. Lehmann 03190dfa20
Merge pull request #4306 from ByteHamster/mime-type-media-content
Fixed mime type in media:content
2020-07-22 17:55:04 +02:00
ByteHamster 51bbf1a5f9 Fixed mime type of media:content tags 2020-07-21 11:56:42 +02:00
ByteHamster ecbcafd209 Reformatted NSMedia 2020-07-21 11:56:30 +02:00
H. Lehmann a3a5a58ae6
Merge pull request #4285 from ByteHamster/install-provider
Install provider in any case
2020-07-21 10:45:34 +02:00
H. Lehmann 2339b2b8d4
Merge pull request #4301 from ByteHamster/double-scheme
Accept more malformed subscribtion URIs
2020-07-21 10:22:53 +02:00
ByteHamster 9d23279f47 Accept more malformed subscribtion URIs 2020-07-21 09:45:12 +02:00
H. Lehmann 84a8eaaee0
Merge pull request #4292 from tonytamsf/landscape-1
FIX:  In landscape mode, the album art overwhelms the playback screen #4009
2020-07-19 16:53:47 +02:00
Tony Tam e53db91ee3 fix checkstyle 2020-07-17 17:53:28 -07:00
Tony Tam 98edefea08 a bit more margin 2020-07-16 22:56:19 -07:00
Tony Tam ac8f6f9a3e layout params 2020-07-16 22:45:59 -07:00
H. Lehmann abece8a340
Merge pull request #4294 from ByteHamster/close-player
Close player when selecting sidebar entry
2020-07-16 23:19:13 +02:00