From dc0739a4f884ad3d47649d89fc8eff2c41f63e6f Mon Sep 17 00:00:00 2001
From: Alessandro Ferro <49845537+xfarrow@users.noreply.github.com>
Date: Fri, 23 Apr 2021 21:44:06 +0200
Subject: [PATCH] Library 1

fixed issue #2 and cleaned code
---
 .gitignore                                 |   2 +
 librerie/exercise1/container/container.hpp |   7 -
 librerie/exercise1/list/list.cpp           | 316 ++++++++++-----------
 librerie/exercise1/vector/vector.cpp       | 249 ++++++++--------
 librerie/exercise1/vector/vector.hpp       |  53 +---
 5 files changed, 273 insertions(+), 354 deletions(-)
 create mode 100644 .gitignore

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..da21387
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,2 @@
+
+**/main
diff --git a/librerie/exercise1/container/container.hpp b/librerie/exercise1/container/container.hpp
index c28cc43..7b7e4e5 100644
--- a/librerie/exercise1/container/container.hpp
+++ b/librerie/exercise1/container/container.hpp
@@ -31,7 +31,6 @@ public:
    bool operator!=(const Container&&) const noexcept = delete; // Comparison of abstract types might not be possible.
 
   // Specific member functions
-
    virtual bool Empty() const noexcept {
      return (size == 0);
    } // (concrete function should not throw exceptions)
@@ -43,10 +42,6 @@ public:
    virtual void Clear() = 0;
 };
 
-/* ************************************************************************** */
-
-
-
 template <typename Data>
 class LinearContainer : virtual public Container{ // Must extend Container
 
@@ -72,7 +67,6 @@ public:
   /* ************************************************************************ */
 
   // Specific member functions
-
   virtual Data& Front() const = 0; // (concrete function must throw std::length_error when empty)
   virtual Data& Back() const = 0; // (concrete function must throw std::length_error when empty)
 
@@ -105,7 +99,6 @@ public:
   /* ************************************************************************ */
 
   // Specific member functions
-
   virtual bool Exists(const Data&) const noexcept = 0; // (concrete function should not throw exceptions)
 
 };
diff --git a/librerie/exercise1/list/list.cpp b/librerie/exercise1/list/list.cpp
index 371af2d..3396301 100644
--- a/librerie/exercise1/list/list.cpp
+++ b/librerie/exercise1/list/list.cpp
@@ -29,21 +29,16 @@ List<Data>::Node::Node(Data&& moveFrom){
   std::swap(value, moveFrom);
 }
 
-
-// Comparison operator
 template <typename Data>
 bool List<Data>::Node::operator==(const Node& node)const noexcept{
   return (node.value == value);
 }
 
-
 template <typename Data>
 bool List<Data>::Node::operator!=(const Node& node)const noexcept{
   return !(*this == node);
 }
 
-
-// Specific constructor
 template <typename Data>
 List<Data>::List(const LinearContainer<Data>& con){
   for(ulong i = 0; i<con.Size(); ++i){
@@ -51,7 +46,6 @@ List<Data>::List(const LinearContainer<Data>& con){
     }
 }
 
-// Copy constructor
 template <typename Data>
 List<Data>::List(const List<Data>& copyFrom){
   for(ulong i = 0; i<copyFrom.Size(); ++i){
@@ -59,7 +53,6 @@ List<Data>::List(const List<Data>& copyFrom){
     }
 }
 
-// Move constructor
 template <typename Data>
 List<Data>::List(List<Data>&& moveFrom){
   std::swap(size, moveFrom.size);
@@ -72,19 +65,17 @@ List<Data>::~List(){
   Clear();
 }
 
-// Copy assignment
 template <typename Data>
  List<Data>& List<Data>::operator=(const List<Data>& copyFrom){
  if(*this != copyFrom){
    Clear();
-   for(ulong i = 0; i<copyFrom.Size(); ++i){
+   for(ulong i = 0 ; i<copyFrom.Size() ; ++i){
      InsertAtBack(copyFrom[i]);
      }
    }
    return *this;
  }
 
- //Move assignment
  template <typename Data>
  List<Data>& List<Data>::operator=(List<Data>&& moveFrom)noexcept{
    if(*this != moveFrom){
@@ -95,11 +86,10 @@ template <typename Data>
   return *this;
  }
 
- //Comparison operators
  template <typename Data>
  bool List<Data>::operator==(const List<Data>& list) const noexcept{
-   if(this->size != list.Size()) return false;
-   for(ulong i = 0; i < (this->size); ++i){
+   if(size != list.Size()) return false;
+   for(ulong i = 0 ; i < size ; ++i){
      if((*this)[i] != list[i]) return false;
    }
    return true;
@@ -110,34 +100,29 @@ bool List<Data>::operator!=(const List<Data>& list) const noexcept{
   return !(*this==list);
 }
 
-// Specific member functions
-
- template <typename Data>
- void List<Data>::InsertAtFront(const Data& data){
-   struct Node* tmp = new Node(data);
-   tmp->next = head;
-   head =tmp;
-   size++;
-
-   if(size == 1){
-      tail = head;
-    }
+template <typename Data>
+void List<Data>::InsertAtFront(const Data& data){
+  struct Node* tmp = new Node(data);
+  tmp->next = head;
+  head = tmp;
+  size++;
+  if(size == 1){
+    tail = head;
+  }
  }
 
-
-  template <typename Data>
-  void List<Data>::InsertAtFront(Data&& data){
-    struct Node* tmp = new Node(data);
-    tmp->next = head;
-    head =tmp;
-    size++;
-
-    if(size == 1){
-       tail = head;
-     }
+template <typename Data>
+void List<Data>::InsertAtFront(Data&& data){
+  struct Node* tmp = new Node(std::move(data));
+  tmp->next = head;
+  head = tmp;
+  size++;
+  if(size == 1){
+    tail = head;
   }
+}
 
-  template <typename Data>
+template <typename Data>
   void List<Data>::RemoveFromFront(){
     if(head == nullptr){
       throw std::length_error("List is empty!");
@@ -148,148 +133,133 @@ bool List<Data>::operator!=(const List<Data>& list) const noexcept{
       tmp->next = nullptr;
       delete tmp;
       size--;
-
       if(head==nullptr){
         tail=nullptr;
       }
     }
   }
 
-  template <typename Data>
-  Data List<Data>::FrontNRemove(){
-    if(head == nullptr){
-      throw std::length_error("List is empty!");
-    }
-    else{
-      Data value = head->value;
-      RemoveFromFront();
-      return value;
-    }
+template <typename Data>
+Data List<Data>::FrontNRemove(){
+  if(head == nullptr){
+    throw std::length_error("List is empty!");
   }
-
-  template <typename Data>
-  void List<Data>::InsertAtBack(const Data& data){
-    if(size == 0){
-      InsertAtFront(data);
-    }
-    else{
-      struct Node* last = new Node(data);
-      tail->next = last;
-      tail = last;
-      size++;
-    }
+  else{
+    Data value = head->value;
+    RemoveFromFront();
+    return value;
   }
-
-  template <typename Data>
-  void List<Data>::InsertAtBack(Data&& data){
-    if(size == 0){
-      InsertAtFront(data);
-    }
-    else{
-      struct Node* last = new Node(data);
-      tail->next = last;
-      tail = last;
-      size++;
-    }
-  }
-
-  template <typename Data>
-  void List<Data>::Clear(){
-    while(head != nullptr){
-      RemoveFromFront();
-    }
-  }
-
-  template <typename Data>
-  Data& List<Data>::Front() const{
-    if(size == 0){
-      throw std::length_error("List is empty!");
-    }else{
-      return head->value;
-    }
-  }
-
-  template <typename Data>
-  Data& List<Data>::Back() const{
-    if(size == 0){
-      throw std::length_error("List is empty!");
-    }else{
-      return tail->value;
-    }
-  }
-
-  template <typename Data>
-  Data& List<Data>::operator[](const ulong idx) const{
-    if(idx >= size || idx < 0){
-      throw std::out_of_range("Out of Range!");
-    }else
-    {
-      struct Node* tmp = head;
-      for(ulong i=0; i<idx; ++i){
-        tmp = tmp->next;
-      }
-      return tmp->value;
-    }
-  }
-
-
-  template <typename Data>
-     void List<Data>::MapPreOrder(MapFunctor function, void* par){
-       MapPreOrder(function, par, head);
-     }
-
-     template <typename Data>
-     void List<Data>::MapPostOrder(MapFunctor function, void* par){
-       MapPostOrder(function, par, head);
-     }
-
-     template <typename Data>
-     void List<Data>::FoldPreOrder(FoldFunctor function, const void* constPar, void* par) const{
-       FoldPreOrder(function, constPar, par, head);
-     }
-
-     template <typename Data>
-     void List<Data>::FoldPostOrder(FoldFunctor function, const void* constPar, void* par) const{
-       FoldPostOrder(function, constPar, par, head);
-     }
-
-     //OVERLOAD Accessory Function
-
-     template <typename Data>
-     void List<Data>::MapPreOrder(MapFunctor function, void* par, struct Node* node){
-       if(node == nullptr)
-         return;
-
-       function(node->value, par);
-       MapPreOrder(function, par, node->next);
-     }
-
-     template <typename Data>
-     void List<Data>::MapPostOrder(MapFunctor function, void* par, struct Node* node){
-       if(node == nullptr)
-         return;
-
-       MapPostOrder(function, par, node->next);
-       function(node->value, par);
-     }
-
-     template <typename Data>
-     void List<Data>::FoldPreOrder(FoldFunctor function, const void* constPar, void* par, struct Node* node) const{
-
-       if(node == nullptr)
-         return;
-
-       function(node->value, constPar, par);
-       FoldPreOrder(function, constPar, par, node->next);
-     }
-
-     template <typename Data>
-     void List<Data>::FoldPostOrder(FoldFunctor function, const void* constPar, void* par, struct Node* node) const{
-       if(node == nullptr)
-         return;
-
-       FoldPostOrder(function, constPar, par, node->next);
-       function(node->value, constPar, par);
-     }
-/* ************************************************************************** */
+}
+
+template <typename Data>
+void List<Data>::InsertAtBack(const Data& data){
+  if(size == 0){
+    InsertAtFront(data);
+  }
+  else{
+    struct Node* last = new Node(data);
+    tail->next = last;
+    tail = last;
+    size++;
+  }
+}
+
+template <typename Data>
+void List<Data>::InsertAtBack(Data&& data){
+  if(size == 0){
+    InsertAtFront(data);
+  }
+  else{
+    struct Node* last = new Node(std::move(data));
+    tail->next = last;
+    tail = last;
+    size++;
+  }
+}
+
+template <typename Data>
+void List<Data>::Clear(){
+  while(head != nullptr){
+    RemoveFromFront();
+  }
+}
+
+template <typename Data>
+Data& List<Data>::Front() const{
+  if(size == 0){
+    throw std::length_error("List is empty!");
+  }else{
+    return head->value;
+  }
+}
+
+template <typename Data>
+Data& List<Data>::Back() const{
+  if(size == 0){
+    throw std::length_error("List is empty!");
+  }else{
+    return tail->value;
+  }
+}
+
+template <typename Data>
+Data& List<Data>::operator[](const ulong index) const{
+  if(index >= size || index < 0){
+    throw std::out_of_range("Out of Range!");
+  }else{
+    struct Node* tmp = head;
+    for(ulong i=0; i<index; ++i){
+      tmp = tmp->next;
+    }
+    return tmp->value;
+  }
+}
+
+template <typename Data>
+void List<Data>::MapPreOrder(MapFunctor function, void* par){
+  MapPreOrder(function, par, head);
+}
+
+template <typename Data>
+void List<Data>::MapPostOrder(MapFunctor function, void* par){
+  MapPostOrder(function, par, head);
+}
+
+template <typename Data>
+void List<Data>::FoldPreOrder(FoldFunctor function, const void* constPar, void* par) const{
+  FoldPreOrder(function, constPar, par, head);
+}
+
+template <typename Data>
+void List<Data>::FoldPostOrder(FoldFunctor function, const void* constPar, void* par) const{
+  FoldPostOrder(function, constPar, par, head);
+}
+
+template <typename Data>
+void List<Data>::MapPreOrder(MapFunctor function, void* par, struct Node* node){
+  if(node == nullptr) return;
+  function(node->value, par);
+  MapPreOrder(function, par, node->next);
+}
+
+template <typename Data>
+void List<Data>::MapPostOrder(MapFunctor function, void* par, struct Node* node){
+  if(node == nullptr) return;
+  MapPostOrder(function, par, node->next);
+  function(node->value, par);
+}
+
+template <typename Data>
+void List<Data>::FoldPreOrder(FoldFunctor function, const void* constPar, void* par, struct Node* node) const{
+  if(node == nullptr) return;
+  function(node->value, constPar, par);
+  FoldPreOrder(function, constPar, par, node->next);
+}
+
+template <typename Data>
+void List<Data>::FoldPostOrder(FoldFunctor function, const void* constPar, void* par, struct Node* node) const{
+  if(node == nullptr) return;
+  FoldPostOrder(function, constPar, par, node->next);
+  function(node->value, constPar, par);
+}
 }
diff --git a/librerie/exercise1/vector/vector.cpp b/librerie/exercise1/vector/vector.cpp
index 2ebef36..a7b3d5e 100644
--- a/librerie/exercise1/vector/vector.cpp
+++ b/librerie/exercise1/vector/vector.cpp
@@ -34,136 +34,127 @@ template <typename Data>
  }
 
  // Destructor
- template <typename Data>
-  Vector<Data>::~Vector(){
+template <typename Data>
+Vector<Data>::~Vector(){
+  Clear();
+}
+
+// Copy assignment
+template <typename Data>
+Vector<Data>& Vector<Data>::operator=(const Vector<Data>& vec){
+  Vector<Data>* tmpvec = new Vector<Data>(vec);
+  std::swap(*tmpvec, *this);
+  delete tmpvec;
+  return *this;
+}
+
+// Move assignment
+template <typename Data>
+Vector<Data>& Vector<Data>::operator=(Vector<Data>&& vec)noexcept{
+  std::swap(Elements,vec.Elements);
+  std::swap(size, vec.size);
+  return *this;
+}
+
+template <typename Data>
+bool Vector<Data>::operator==(const Vector<Data>& vec) const noexcept{
+  if(size == vec.size){
+    for(ulong i=0; i<size; ++i){
+      if(Elements[i] != vec.Elements[i])
+        return false;
+      }
+      return true;
+  }else{
+      return false;
+   }
+}
+
+template <typename Data>
+bool Vector<Data>::operator!=(const Vector<Data>& vec)const noexcept{
+  return !(*this == vec);
+}
+
+template <typename Data>
+void Vector<Data>::Resize(const ulong newsize){
+  if(newsize == 0){
     Clear();
   }
-
-  // Copy assignment
-  template <typename Data>
-   Vector<Data>& Vector<Data>::operator=(const Vector<Data>& vec){
-     Vector<Data>* tmpvec = new Vector<Data>(vec);
-     std::swap(*tmpvec, *this);
-     delete tmpvec;
-     return *this;
-   }
-
-   // Move assignment
-   template <typename Data>
-   Vector<Data>& Vector<Data>::operator=(Vector<Data>&& vec)noexcept{
-     std::swap(Elements,vec.Elements);
-     std::swap(size, vec.size);
-     return *this;
-   }
-
-   // Comparison operators
-   template <typename Data>
-   bool Vector<Data>::operator==(const Vector<Data>& vec) const noexcept{
-     if(size == vec.size){
-       for(ulong i=0; i<size; ++i){
-         if(Elements[i] != vec.Elements[i])
-            return false;
-       }
-       return true;
-     }else{
-     return false;
-   }
-   }
-
-
-   template <typename Data>
-   bool Vector<Data>::operator!=(const Vector<Data>& vec)const noexcept{
-     return !(*this == vec);
-   }
-
-   template <typename Data>
-   void Vector<Data>::Resize(const ulong newsize){
-     if(newsize == 0){
-       Clear();
-     }else if(size != newsize)
-     {
-       ulong limit = (size < newsize) ? size : newsize;
-       Data* TmpElements = new Data[newsize]{};
-       for(ulong i=0; i<limit; ++i){
-         std::swap(Elements[i], TmpElements[i]);
-       }
-       std::swap(Elements, TmpElements);
-       size = newsize;
-       delete[] TmpElements;
-     }
-   }
-
-
-   template <typename Data>
-   void Vector<Data>::Clear(){
-      delete[] Elements;
-      Elements = nullptr;
-      size = 0;
-   }
-
-   template <typename Data>
-     Data& Vector<Data>::Front() const {
-       if(size != 0)
-       {
-         return Elements[0];
-       }else{
-         throw std::length_error("Access to an empty vector!");
-       }
-     }
-
-    template <typename Data>
-     Data& Vector<Data>::Back() const {
-       if(size != 0)
-        {
-          return Elements[size - 1];
-        }else{
-          throw std::length_error("Access to an empty vector!");
-        }
-      }
-
-
-    template <typename Data>
-    Data& Vector<Data>::operator[](const ulong idx) const{
-      if(idx < size)
-      {
-        return Elements[idx];
-      }
-      else
-      {
-        throw std::out_of_range("Tried to access index " + std::to_string(idx) + " but the dimension of the vector is " + std::to_string(size));
-      }
-    }
-
-
-    template <typename Data>
-    void Vector<Data>::MapPreOrder(const MapFunctor fun, void* par){
-      for(ulong i=0; i<size; ++i){
-        fun(Elements[i], par);
-      }
-    }
-
-    template <typename Data>
-    void Vector<Data>::MapPostOrder(const MapFunctor fun, void* par){
-      ulong idx = size;
-      while(idx > 0)
-      {
-        fun(Elements[--idx], par);
-      }
-    }
-
-
-    template <typename Data>
-    void Vector<Data>::FoldPreOrder(const FoldFunctor fun, const void* par, void* acc) const{
-      for(ulong i=0; i<size; ++i){
-        fun(Elements[i], par, acc);
-      }
-    }
-
-    template <typename Data>
-    void Vector<Data>::FoldPostOrder(const FoldFunctor fun, const void* par, void* acc) const{
-        ulong idx = size;
-        while(idx > 0){
-          fun(Elements[--idx], par, acc);
-        }
+  else if(size != newsize){
+    ulong limit = (size < newsize) ? size : newsize;
+    Data* TmpElements = new Data[newsize]{};
+    for(ulong i=0; i<limit; ++i){
+      std::swap(Elements[i], TmpElements[i]);
     }
+    std::swap(Elements, TmpElements);
+    size = newsize;
+    delete[] TmpElements;
+  }
+}
+
+template <typename Data>
+void Vector<Data>::Clear(){
+  delete[] Elements;
+  Elements = nullptr;
+  size = 0;
+}
+
+template <typename Data>
+Data& Vector<Data>::Front() const {
+  if(size != 0){
+    return Elements[0];
+  }
+  else{
+    throw std::length_error("Access to an empty vector!");
+  }
+}
+
+template <typename Data>
+Data& Vector<Data>::Back() const {
+  if(size != 0){
+    return Elements[size - 1];
+  }
+  else{
+    throw std::length_error("Access to an empty vector!");
+  }
+}
+
+template <typename Data>
+Data& Vector<Data>::operator[](const ulong index) const{
+  if(index < size){
+    return Elements[index];
+  }
+  else{
+    throw std::out_of_range("Tried to access index " + std::to_string(index) + " but the dimension of the vector is " + std::to_string(size));
+  }
+}
+
+template <typename Data>
+void Vector<Data>::MapPreOrder(const MapFunctor fun, void* par){
+  for(ulong i=0; i<size; ++i){
+    fun(Elements[i], par);
+  }
+}
+
+template <typename Data>
+void Vector<Data>::MapPostOrder(const MapFunctor fun, void* par){
+  ulong index = size;
+  while(index > 0){
+    fun(Elements[--index], par);
+  }
+}
+
+template <typename Data>
+void Vector<Data>::FoldPreOrder(const FoldFunctor fun, const void* par, void* acc) const{
+  for(ulong i=0; i<size; ++i){
+    fun(Elements[i], par, acc);
+  }
+}
+
+template <typename Data>
+void Vector<Data>::FoldPostOrder(const FoldFunctor fun, const void* par, void* acc) const{
+  ulong idx = size;
+  while(idx > 0){
+    fun(Elements[--idx], par, acc);
+  }
+}
 }
diff --git a/librerie/exercise1/vector/vector.hpp b/librerie/exercise1/vector/vector.hpp
index b5fcbe5..2ae8fed 100644
--- a/librerie/exercise1/vector/vector.hpp
+++ b/librerie/exercise1/vector/vector.hpp
@@ -25,35 +25,22 @@ protected:
    using LinearContainer<Data>::size;
    Data* Elements = nullptr;
 
-  // ...
-
 public:
 
-  // Default constructor
-  // Vector() specifiers;
-    Vector() = default;
-
-
-  /* ************************************************************************ */
+  Vector() = default;
 
   // Specific constructors
   Vector(const ulong); // A vector with a given initial dimension
   Vector(const LinearContainer<Data>&); // A vector obtained from a LinearContainer
 
-  /* ************************************************************************ */
-
   // Copy constructor
-   Vector(const Vector&);
+  Vector(const Vector&);
 
   // Move constructor
-   Vector(Vector&&)noexcept;
-
-  /* ************************************************************************ */
+  Vector(Vector&&)noexcept;
 
   // Destructor
-   ~Vector();
-
-  /* ************************************************************************ */
+  ~Vector();
 
   // Copy assignment
    Vector& operator=(const Vector&);
@@ -61,54 +48,30 @@ public:
   // Move assignment
   Vector& operator=(Vector&&) noexcept;
 
-  /* ************************************************************************ */
-
   // Comparison operators
   bool operator==(const Vector&) const noexcept;
   bool operator!=(const Vector&) const noexcept;
 
-  /* ************************************************************************ */
-
-  // Specific member functions
-
   void Resize(const ulong); // Resize the vector to a given size
 
-  /* ************************************************************************ */
-
-  // Specific member functions (inherited from Container)
-
   void Clear() override; // Override Container member
 
-  /* ************************************************************************ */
-
-  // Specific member functions (inherited from LinearContainer)
-
   Data& Front() const override; // Override LinearContainer member (must throw std::length_error when empty)
   Data& Back() const override; // Override LinearContainer member (must throw std::length_error when empty)
 
   Data& operator[](const ulong) const override; // Override LinearContainer member (must throw std::out_of_range when out of range)
 
-  /* ************************************************************************ */
+  using typename MappableContainer<Data>::MapFunctor;
 
-  // Specific member functions (inherited from MappableContainer)
+  void MapPreOrder(const MapFunctor, void*) override; // Override MappableContainer member
+  void MapPostOrder(const MapFunctor, void*) override; // Override MappableContainer member
 
-   using typename MappableContainer<Data>::MapFunctor;
-
-   void MapPreOrder(const MapFunctor, void*) override; // Override MappableContainer member
-   void MapPostOrder(const MapFunctor, void*) override; // Override MappableContainer member
-
-  /* ************************************************************************ */
-
-  // Specific member functions (inherited from FoldableContainer)
-
-   using typename FoldableContainer<Data>::FoldFunctor;
+  using typename FoldableContainer<Data>::FoldFunctor;
 
   void FoldPreOrder(const FoldFunctor, const void*, void*) const override; // Override FoldableContainer member
   void FoldPostOrder(const FoldFunctor, const void*, void*) const override; // Override FoldableContainer member
 };
 
-/* ************************************************************************** */
-
 }
 
 #include "vector.cpp"